4 Dec
2009
4 Dec
'09
2:27 p.m.
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
4 Dec
4 Dec
2:34 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
Since attachments modifications create document versions is sounds logical.
+1,
JV.
On Fri, Dec 4, 2009 at 2:27 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5:11 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
+1
Jean-Vincent Drean wrote:
Since attachments modifications create document
versions is sounds logical.
+1,
JV.
On Fri, Dec 4, 2009 at 2:27 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
2:43 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
+1
Thomas Mortagne wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
3:06 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
+1
On 12/4/2009 3:27 PM, Thomas Mortagne wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
3:33 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
+1
I think that right now we consider the Document as: content + objects
+ class + attachments
Maybe we should have both Document events but also content events +
object events + class events + attachment events.
We can do that later. The reason would be for listeners who want more
specific events since otherwise it's hard to know what's changed if
you only receive a Doc event.
Thanks
-Vincent
3:38 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On Fri, Dec 4, 2009 at 15:33, Vincent Massol <vincent(a)massol.net> wrote:
On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:
Sure we need theses but it's more work.
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
+1
I think that right now we consider the Document as: content + objects
+ class + attachments
Maybe we should have both Document events but also content events +
object events + class events + attachment events.
We can do that later. The reason would be for listeners who want more
specific events since otherwise it's hard to know what's changed if
you only receive a Doc event.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
3:39 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On 12/4/09 3:33 PM, Vincent Massol wrote:
On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:
+ metadata ?
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
+1
I think that right now we consider the Document as: content + objects
+ class + attachments
Maybe we should have both Document events but also
content events +
object events + class events + attachment events.
We can do that later. The reason would be for listeners who want more
specific events since otherwise it's hard to know what's changed if
you only receive a Doc event.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
3:40 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On 12/4/09 3:33 PM, Vincent Massol wrote:
On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:
+1
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
+1
I think that right now we consider the Document as:
content + objects
+ class + attachments
+ metadata ?
Maybe we should have both Document events but also
content events +
object events + class events + attachment events.
We can do that later. The reason would be for listeners who want more
specific events since otherwise it's hard to know what's changed if
you only receive a Doc event.
+1 for the future
Jerome.
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
4:29 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On Fri, Dec 4, 2009 at 14:27, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
For the details i propose to make UploadAction call
context.getWiki().saveDocument
instead of
context.getWiki().getStore().saveXWikiDoc (which make document save
bypass even generation)
(same for DeleteAttachmentAction)
say if you think it could be an issue.
--
Thomas Mortagne
4:55 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
+1
I agree on what Thomas Mortagne said on bypass and on Attachment events log
(upload/delete/edit).
Regards,
Flavius
On Fri, Dec 4, 2009 at 5:29 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
On Fri, Dec 4, 2009 at 14:27, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>
wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
For the details i propose to make UploadAction call
context.getWiki().saveDocument
instead of
context.getWiki().getStore().saveXWikiDoc (which make document save
bypass even generation)
(same for DeleteAttachmentAction)
say if you think it could be an issue.
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
6 Dec
6 Dec
11:09 a.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
On 12/04/2009 04:29 PM, Thomas Mortagne wrote:
Also see http://jira.xwiki.org/jira/browse/XWIKI-1982
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
On Fri, Dec 4, 2009 at 14:27, Thomas
Mortagne<thomas.mortagne(a)xwiki.com> wrote:
> Hi devs,
>
> Currently when you attach or delete a new file on a document it does
> not produce any document related event. Thing is it does modify the
> document but since it bypass XWiki#saveDocument it does not produce
> any event.Whic mean currently to know that an attachment as been added
> you can only listen to upload action event (and it works only if it
> has been done with the UI).
>
> I propose to make attachment modification also produce document
> modification events.
>
> WDYT ?
+1
Here is my +1
--
Thomas Mortagne
For the details i propose to make UploadAction call
context.getWiki().saveDocument
instead of
context.getWiki().getStore().saveXWikiDoc (which make document save
bypass even generation)
(same for DeleteAttachmentAction)
say if you think it could be an issue.
4 Dec
4 Dec
6:05 p.m.
New subject: [xwiki-devs] [VOTE] Make attachments produce document modification events
+1
- Asiri
On Fri, Dec 4, 2009 at 6:57 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com>wrote;wrote:
Hi devs,
Currently when you attach or delete a new file on a document it does
not produce any document related event. Thing is it does modify the
document but since it bypass XWiki#saveDocument it does not produce
any event.Whic mean currently to know that an attachment as been added
you can only listen to upload action event (and it works only if it
has been done with the UI).
I propose to make attachment modification also produce document
modification events.
WDYT ?
Here is my +1
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
5809
days inactive
5811
days old
12 comments
10 participants
participants (10)
-
Asiri Rathnayake -
Caleb James DeLisle -
Flavius Olaru -
Florin Ciubotaru -
Jean-Vincent Drean -
Jerome Velociter -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol