Re: [xwiki-devs] [xwiki-notifications] r28239 - platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups - xwiki-devs@xwiki.org

12 Apr 2010

On Apr 12, 2010, at 12:05 PM, jvelociter (SVN) wrote:

...
  Author: jvelociter
 Date: 2010-04-12 12:05:45 +0200 (Mon, 12 Apr 2010)
 New Revision: 28239

 Modified:

platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.js
 Log:
 XWIKI-5094 Administration rights editor cannot be used in portlet mode

 Merged from branch 2.2

 Modified:
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.js
 ===================================================================
 ---
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.js	2010-04-12
10:04:39 UTC (rev 28238)
 +++
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/usersandgroups/usersandgroups.js	2010-04-12
10:05:45 UTC (rev 28239)
 @@ -367,8 +367,9 @@
   var uorg = table.json.uorg;
   var allows = row.allows;
   var denys = row.denys;
 -  var saveUrl = "?xpage=saverights&clsname=" + table.json.clsname +
"&fullname=" + row.fullname + "&uorg=" + uorg;

 +  var saveUrl = window.docviewurl + "?xpage=saverights&clsname=" +
table.json.clsname + "&fullname=" + row.fullname + "&uorg=" +
uorg;
 + 
BTW can we guarantee that table.json.clsname, row.fullname and uorg don't contain any
character that would need to be URL-encoded?

Thanks
-Vincent

PS: We need a URL factory on the JS side to create valid URLs with proper encoding.

[snip]