November 2008 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Postpone 1.7 branches creation after XE 1.7 release
by Jean-Vincent Drean 26 Nov '08

26 Nov '08

Hi, XE 1.7 RC1 is to be released this afternoon and we had planned to create 1.7 branches after it. While most (all?) of us will be working on stabilizing XE 1.7 in the coming week I suggest to postpone the 1.7 branches creation after XE 1.7 release (dec 3rd). Here's my +1. I plan to start the release at 13:30 UTC. Release plan : xwiki-configuration-resources 1.19 xwiki-core 1.7-rc-1 xwiki-plugin-skinx 1.4 xwiki-platform-web 1.7-rc-1 xwiki-product-enterprise 1.7-rc-1 Thanks, JV.

7 6

[xwiki-devs] [ANN] XWiki Enterprise 1.7 Release Candidate 1 Released
by Jean-Vincent Drean 26 Nov '08

26 Nov '08

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.7 RC 1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is the first release candidate for the 1.7 version. Changes from 1.7M3: * Link feature implemented in the new WYSIWYG editor (link to wiki page, web page, email). * Work in progress on the new experimental WYSIWYG editor. * Work in progress on the new XWiki Syntax v2.0 * Reorganized, documented and enhanced xwiki.cfg configuration file Important bug fixes: * XWIKI-2873 : Wrong user name is inserted in group during LDAP membership synchronisation Note that general goals for XWiki Enterprise 1.7 are: * Working and usable (i.e. users can use them for their day to day work instead of the old Syntax and old WYSIWYG editor) versions of new rendering and new WYSIWYG editor. * Working JCR (can be used for day to day work instead of Hibernate). * Blog revamping * Webdav integration For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17RC1 Thanks -The XWiki dev team

3 2

Re: [xwiki-devs] [xwiki-users] Office-Importer Test Server.
by Asiri Rathnayake 26 Nov '08

26 Nov '08

Hi Vincent, On Wed, Nov 26, 2008 at 1:49 PM, Vincent Massol <vincent(a)massol.net> wrote: > > On Nov 26, 2008, at 4:13 AM, Asiri Rathnayake wrote: > > > Hi Vincent, > > > > On Tue, Nov 25, 2008 at 9:07 PM, Vincent Massol <vincent(a)massol.net> > > wrote: > > > >> Guillaume, > >> > >> I can see some other problems: > >> * title is not correct > > > > > > Did you mean the title content (spellings?) or the font size of the > > title? > > If it's the latter, it's because openoffice server in this case has > > used > > for sizing, and this is filtered in the strict > > filtering mode. > > A title should be converted to a title (i.e. using the == syntax in > wiki). > > Wasn't this a real title in the original word doc? It seems not. If the user editing the document was using headings instead of font sizes, this would result in a title. > > > > I'm pretty sure you didn't mean the latter one, if so please explain > > what's > > exactly wrong :) > > > > * lots of empty lines > > > > > > Good point. > > > > If any of you have some free time (which excludes vincent ;)) please > > try > > this : > > > > Open a new text document in openoffice and: > > > > 1. Type one line of text. > > > > 2. Press enter twice and type another line of text. > > > > So you'd have something like : > > > > " Hi, This is the first line > > > > And this is the second line" > > > > 3. Save the document as *html*. > > > > 4. Open the document in firefox and see the result. > > > > The same thing happens when converting documents via openoffice > > server. The > > problem is, for each empty line in a word document, open office uses : > > > > > > What is the effect of "margin-bottom: 0in"? If it removes the new line > then we should check for this and remove the paragraph altogether (for > all filterings IMO). Well it is supposed to, but it doesn't work in either FireFox or IE. But anyway, since it is supposed to mean there is no newline in between, we could remove such paragraphs. But consider the following case : Paragraph-1 Paragraph-2 In this case if we blindly remove the first paragraph, it will loose other styles along with it. So we should only filter such paragraphs in strict/moderate filtering scenarios. In non-restricted mode, we can't do the same. Again, I'm thinking whether this filtering belongs to office-importer or xhtml parser ? WDYT ? > > > > For spacing. And this is obviously not correct. May be I should take > > this to > > openoffice guys ? > > Yes you should but in the meantime we can filter this (only when > margin-bottom is 0). > > > Vincent, if you remember, I tried to replace these empty paragraphs > > with > > elements. But I didn't mention this to you at that time. > > Yes you didn't mention that there was a CSS with margin-bottom: 0in > which changes everything... Well I saved the best for the end ;) Thanks. - Asiri > > > -Vincent > > > I simply > > didn't like these empty paragraphs ;) > > > > Thanks. > > > > - Asiri > > > > > > > > > >> > >> > >> Thanks > >> -Vincent > >> > >> On Nov 25, 2008, at 4:30 PM, Guillaume Lerouge wrote: > >> > >>> Hi Asiri, > >>> > >>> I tested strict filtering with my usual test document and apparently > >>> something went wrong with links (see the bottom of the page): > >>> http://91.121.237.216/xwiki/bin/view/Main/GuillaumeTestProgrammez > >>> > >>> Apart from this, it looks pretty good. > >>> > >>> Guillaume > >>> > >>> On Tue, Nov 25, 2008 at 4:14 PM, Asiri Rathnayake < > >>> asiri.rathnayake(a)gmail.com> wrote: > >>> > >>>> Hi Devs, Users, > >>>> > >>>> I have uploaded yet another new version of office-importer @ > >>>> http://91.121.237.216/xwiki/bin/view/Import/. > >>>> > >>>> This version utilizes the latest rendering module which has > >>>> improved a lot > >>>> since the last upload. > >>>> > >>>> Also a moderate style filtering option is introduced. > >>>> > >>>> Please try it out and let us know what you think. > >>>> > >>>> Thanks. > >>>> > >>>> - Asiri > _______________________________________________ > users mailing list > users(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/users >

1 0

[xwiki-devs] Valid XWiki Page Names
by Jonas von Malottki 26 Nov '08

26 Nov '08

Hello Devs, is there some Documentation (or a Regex) which Characters are practically allowed in page and space names? I am unable to find this. From the syntax page it is kind of clear that the following ones are not really usable: "." Because of Space Prefix "[]" Link itself "()%" new formatting characters ">" alias of links I was playing around and if you enter some page name like "hello.hello.hello" you'll get a page named "hello" in the Space "hello.hello". If you enter "hello\.hello" it'll just display nothing. (on XWiki 1.7 M2) Maybe XWiki should check if the given page or space name is actually valid, before creating the page? Nice greetings Jonas

3 3

[xwiki-devs] [VOTE] Change default table syntax
by Thomas Mortagne 25 Nov '08

25 Nov '08

Hi devs, Currently in xwiki syntax 2.0 we are using || title cell 1 || title cell2 | cell 1 | cell 2 for table syntax. The problem is that with this grammar it's impossible to have empty cells because you can't use || as it mean title cell. Creole is using (see http://www.wikicreole.org/wiki/Creole1.0#section-Creole1.0-Tables) |= title cell 1 |= title cell2 | | cell 1 | cell 2 | I propose to change our current || by |= meaning the difference with the Creole syntax will be just that we don't need the ending |: |= title cell 1 |= title cell2 | cell 1 | cell 2 - we generally agreed to use Creole as much as possible - this syntax support space - this cell header syntax is more consistent with our header syntax (which is the Creole one ok ;)) - I think it's more readable than the current one because it's easier to differentiate header cell and cell especially when there is lot's of them So here is my +1 -- Thomas Mortagne

8 10

[xwiki-devs] Location, release cycle and distribution of non core macros 2.0
by Jerome Velociter 25 Nov '08

25 Nov '08

Hello devs, This week we created a new "xwiki-macros" module under platform/core/ for macros of the XWiki Syntax 2.0. Another question now is what do we do for macros that are not "core macros" (i.e. not indispensable for what we consider being the basic working wiki, unlike the TOC macro, or the velocity macro). Development of such macros already started, for example the instant messenger status macro, and the map macro. Possibilities I see : 1. having them at the same level we have applications/ plugins/ under platform : adding a macros/ directory. 2. having them in the xwiki-macros core submodule, despite the fact they are not core I am for solution 1 right now, but maybe there are better alternatives to this, too. We also have to decide how we do release and distribute them, for example do we pack them with XE, or do we release them separately, and let users install them themselves as it is the case for most of the applications already. (For me the answer to this latest question seems obvious : we _should_ send them together with XE) Let me know what you think, I'd like if still possible having the map macro in 1.7 RC1. Jerome.

4 11

[xwiki-devs] Office-Importer Test Server.
by Asiri Rathnayake 25 Nov '08

25 Nov '08

Hi All, I have setup a test server for testing the new xwiki-office-importer feature @ http://91.121.237.216/xwiki/bin/view/Main/ Please note that this is the same server used for testing xwiki-webdav interface. Known issues for office-importer : * Table support is limited due to : http://jira.xwiki.org/jira/browse/XWIKI-2804 & http://jira.xwiki.org/jira/browse/XWIKI-2834 * List support is limited due to : http://jira.xwiki.org/jira/browse/XWIKI-2812 * Image links (links with images as labels) are not supported yet : http://jira.xwiki.org/jira/browse/XWIKI-2832 Please help us improve office importer by testing it out and reporting as many bugs as you can ;) Thanks. - Asiri

4 24

Re: [xwiki-devs] [xwiki-notifications] r14425 - sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/officeimporter/filter
by Vincent Massol 24 Nov '08

24 Nov '08

Hi Asiri, On Nov 24, 2008, at 6:08 PM, asiri (SVN) wrote: > Author: asiri > Date: 2008-11-24 18:08:51 +0100 (Mon, 24 Nov 2008) > New Revision: 14425 > > Modified: > sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java > Log: > XAOFFICE-1 : Develop the initial feature set for office-importer > plugin. > > * Added support for filtering empty / redundant paragraphs. > > Modified: sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/ > xwiki/plugin/officeimporter/filter/RedundantTagFilter.java > =================================================================== > --- sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java 2008-11-24 > 15:17:17 UTC (rev 14424) > +++ sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java 2008-11-24 > 17:08:51 UTC (rev 14425) > @@ -31,12 +31,13 @@ > > public void filter(Document document, ImporterContext context) > { > - for(String key : attributeWiseFilteredTags) { > + for (String key : attributeWiseFilteredTags) { > > filterNodesWithZeroAttributes(document.getElementsByTagName(key)); > } > - for(String key : contentWiseFilteredTags) { > + for (String key : contentWiseFilteredTags) { > > filterNodesWithEmptyTextContent(document.getElementsByTagName(key)); > - } > + } > + filterEmptyParagraphs(document); > } > > /** > @@ -70,10 +71,35 @@ > { > for (int i = 0; i < elements.getLength(); i++) { > Element element = (Element) elements.item(i); > - if (element.getTextContent().trim().equals("")) { > + if (element.getTextContent().trim().equals("")) { > element.getParentNode().removeChild(element); > i--; > } > } > } > + > + /** > + * OpenOffice server generates redundant paragraphs (with empty > content) to achieve spacing. > + * These paragraphs should be stripped off / replaced with > {@code } elements appropriately > + * because otherwise they result in spurious {@code (%%)} > elements in generated xwiki content. > + * > + * @param document The html document. > + */ > + private void filterEmptyParagraphs(Document document) > + { > + NodeList paragraphs = document.getElementsByTagName("p"); > + for (int i = 0; i < paragraphs.getLength(); i++) { > + Element paragraph = (Element) paragraphs.item(i); > + if (paragraph.getTextContent().trim().equals("")) { > + // We suspect this is an empty paragraph but it is > possible that it contains other > + // non-textual tags like images. For the moment > we'll only search for internal image > + // tags, we might have to refine this criterion > later. > + NodeList internalImages = > paragraph.getElementsByTagName("img"); > + if (internalImages.getLength() == 0) { > + paragraph.getParentNode().removeChild(paragraph); > + i--; I don't understand this algorithm. There can be a lot of other valid XHTML elements inside a P element (see the XHTML spec). Why are you searching for IMG tags at all? What about all the other tags? Again I'm not sure this code is in the right place. For example what will happen if the user provides an empty P as input for a wiki page (using XHTML syntax)? Your code will never run in this case. To be honest I haven't looked at the office importer code for some time but we really need to be careful to move all generic code outside of it and into the HTML cleaner or into the XHTML parser. Could you please check that there are only office-related code in there? Thanks -Vincent

2 3

[xwiki-devs] problem installing xwiki
by antoine seilles 24 Nov '08

24 Nov '08

Hi i'm trying to install xwiki on ubuntu 8.10 with Tomcat5.5, JVM 1.6 and mysql 5.0 I have followed instructions of http://platform.xwiki.org/xwiki/bin/view/AdminGuide/Installation I ve tried to google this error but i didn't find a solution. When trying to access my xwiki app, i have the following message : javax.servlet.ServletException: L'exécution de la servlet a lancé une exception com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:94) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) *cause mère* java.lang.NoClassDefFoundError: org/jgroups/blocks/RpcDispatcher$Marshaller java.lang.ClassLoader.defineClass1(Native Method) java.lang.ClassLoader.defineClass(ClassLoader.java:621) java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1853) org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:875) org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1330) org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1209) java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320) java.lang.Class.getDeclaredMethods0(Native Method) java.lang.Class.privateGetDeclaredMethods(Class.java:2427) java.lang.Class.getDeclaredMethods(Class.java:1791) org.jboss.cache.util.reflect.ReflectionUtil.inspectRecursively(ReflectionUtil.java:53) org.jboss.cache.util.reflect.ReflectionUtil.getAllMethods(ReflectionUtil.java:36) org.jboss.cache.factories.ComponentRegistry.addComponentDependencies(ComponentRegistry.java:232) org.jboss.cache.factories.ComponentRegistry.registerComponent(ComponentRegistry.java:219) org.jboss.cache.factories.ComponentRegistry.<init>(ComponentRegistry.java:98) org.jboss.cache.DefaultCacheFactory.bootstrap(DefaultCacheFactory.java:125) org.jboss.cache.DefaultCacheFactory.createAndWire(DefaultCacheFactory.java:115) org.jboss.cache.DefaultCacheFactory.createCache(DefaultCacheFactory.java:94) org.jboss.cache.DefaultCacheFactory.createCache(DefaultCacheFactory.java:79) org.xwiki.cache.jbosscache.internal.JBossCacheCache.initialize(JBossCacheCache.java:101) org.xwiki.cache.jbosscache.internal.JBossCacheCacheFactory.newCache(JBossCacheCacheFactory.java:78) com.xpn.xwiki.store.XWikiCacheStore.initCache(XWikiCacheStore.java:99) com.xpn.xwiki.store.XWikiCacheStore.initCache(XWikiCacheStore.java:84) com.xpn.xwiki.store.XWikiCacheStore.<init>(XWikiCacheStore.java:64) com.xpn.xwiki.XWiki.initXWiki(XWiki.java:679) com.xpn.xwiki.XWiki.<init>(XWiki.java:655) com.xpn.xwiki.XWiki.getMainXWiki(XWiki.java:315) com.xpn.xwiki.XWiki.getXWiki(XWiki.java:386) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:135) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:689) javax.servlet.http.HttpServlet.service(HttpServlet.java:802) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:94) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) *cause mère* java.lang.ClassNotFoundException: org.jgroups.blocks.RpcDispatcher$Marshaller org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1363) org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1209) java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320) java.lang.ClassLoader.defineClass1(Native Method) java.lang.ClassLoader.defineClass(ClassLoader.java:621) java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1853) org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:875) org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1330) org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1209) java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320) java.lang.Class.getDeclaredMethods0(Native Method) java.lang.Class.privateGetDeclaredMethods(Class.java:2427) java.lang.Class.getDeclaredMethods(Class.java:1791) org.jboss.cache.util.reflect.ReflectionUtil.inspectRecursively(ReflectionUtil.java:53) org.jboss.cache.util.reflect.ReflectionUtil.getAllMethods(ReflectionUtil.java:36) org.jboss.cache.factories.ComponentRegistry.addComponentDependencies(ComponentRegistry.java:232) org.jboss.cache.factories.ComponentRegistry.registerComponent(ComponentRegistry.java:219) org.jboss.cache.factories.ComponentRegistry.<init>(ComponentRegistry.java:98) org.jboss.cache.DefaultCacheFactory.bootstrap(DefaultCacheFactory.java:125) org.jboss.cache.DefaultCacheFactory.createAndWire(DefaultCacheFactory.java:115) org.jboss.cache.DefaultCacheFactory.createCache(DefaultCacheFactory.java:94) org.jboss.cache.DefaultCacheFactory.createCache(DefaultCacheFactory.java:79) org.xwiki.cache.jbosscache.internal.JBossCacheCache.initialize(JBossCacheCache.java:101) org.xwiki.cache.jbosscache.internal.JBossCacheCacheFactory.newCache(JBossCacheCacheFactory.java:78) com.xpn.xwiki.store.XWikiCacheStore.initCache(XWikiCacheStore.java:99) com.xpn.xwiki.store.XWikiCacheStore.initCache(XWikiCacheStore.java:84) com.xpn.xwiki.store.XWikiCacheStore.<init>(XWikiCacheStore.java:64) com.xpn.xwiki.XWiki.initXWiki(XWiki.java:679) com.xpn.xwiki.XWiki.<init>(XWiki.java:655) com.xpn.xwiki.XWiki.getMainXWiki(XWiki.java:315) com.xpn.xwiki.XWiki.getXWiki(XWiki.java:386) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:135) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:689) javax.servlet.http.HttpServlet.service(HttpServlet.java:802) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:94) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) Thanks for your time.

3 7

Re: [xwiki-devs] [xwiki-notifications] r14425 - sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/plugin/officeimporter/filter
by Vincent Massol 24 Nov '08

24 Nov '08

Hi Asiri, Are you sure this should go in the office importer and not in the HTML cleaner or in the XHMTL parser? Thanks -Vincent On Nov 24, 2008, at 6:08 PM, asiri (SVN) wrote: > Author: asiri > Date: 2008-11-24 18:08:51 +0100 (Mon, 24 Nov 2008) > New Revision: 14425 > > Modified: > sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java > Log: > XAOFFICE-1 : Develop the initial feature set for office-importer > plugin. > > * Added support for filtering empty / redundant paragraphs. > > Modified: sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/ > xwiki/plugin/officeimporter/filter/RedundantTagFilter.java > =================================================================== > --- sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java 2008-11-24 > 15:17:17 UTC (rev 14424) > +++ sandbox/xwiki-plugin-officeimporter/src/main/java/com/xpn/xwiki/ > plugin/officeimporter/filter/RedundantTagFilter.java 2008-11-24 > 17:08:51 UTC (rev 14425) > @@ -31,12 +31,13 @@ > > public void filter(Document document, ImporterContext context) > { > - for(String key : attributeWiseFilteredTags) { > + for (String key : attributeWiseFilteredTags) { > > filterNodesWithZeroAttributes(document.getElementsByTagName(key)); > } > - for(String key : contentWiseFilteredTags) { > + for (String key : contentWiseFilteredTags) { > > filterNodesWithEmptyTextContent(document.getElementsByTagName(key)); > - } > + } > + filterEmptyParagraphs(document); > } > > /** > @@ -70,10 +71,35 @@ > { > for (int i = 0; i < elements.getLength(); i++) { > Element element = (Element) elements.item(i); > - if (element.getTextContent().trim().equals("")) { > + if (element.getTextContent().trim().equals("")) { > element.getParentNode().removeChild(element); > i--; > } > } > } > + > + /** > + * OpenOffice server generates redundant paragraphs (with empty > content) to achieve spacing. > + * These paragraphs should be stripped off / replaced with > {@code } elements appropriately > + * because otherwise they result in spurious {@code (%%)} > elements in generated xwiki content. > + * > + * @param document The html document. > + */ > + private void filterEmptyParagraphs(Document document) > + { > + NodeList paragraphs = document.getElementsByTagName("p"); > + for (int i = 0; i < paragraphs.getLength(); i++) { > + Element paragraph = (Element) paragraphs.item(i); > + if (paragraph.getTextContent().trim().equals("")) { > + // We suspect this is an empty paragraph but it is > possible that it contains other > + // non-textual tags like images. For the moment > we'll only search for internal image > + // tags, we might have to refine this criterion > later. > + NodeList internalImages = > paragraph.getElementsByTagName("img"); > + if (internalImages.getLength() == 0) { > + paragraph.getParentNode().removeChild(paragraph); > + i--; > + } > + } > + } > + } > }

1 0