March 2017 - xwiki-devs@xwiki.org

[xwiki-devs] [proposal] Process to handle Pull Requests
by Ludovic Dubost 10 May '19

10 May '19

Hi devs, I don't think there is currently a process that is in place to handle pull requests and I have the feeling that the way there are handled today is a bit random. There are usually comments sent out on each pull request but sometimes it seems that some pull requests are going in sleep mode and it's not clear who is in charge. I would like to suggest that a process is put in place where it's clear who is responsible for a pull request and a status is given to the contributors that propose that pull request. Something like: Assigned developer: XXXX Status: New -> new pull request, not yet assigned Assigned -> assigned to a developer, he is in charge of reviewing the pull request and ask for modifications or accept it. The developer can auto assign it to himself. If nobody does, we need to decide how they will be taken into account. ModificationsRequired -> for now rejected with comments. Contributor needs to apply comments and then change back to Assigned for further evaluation VoteRequired -> there are no more comments, but a vote is required as the changes to XWiki core are important WaitingFinalAuthorization -> optional step for complex patches where a additional authorization would be required (need to define who would be the persons that give the authorization) WaitingApplication -> there are no more comments and no changes or vote required. The pull request can be applied and is waiting for a developer to apply it Abandoned -> contributors is abandoning the pull request (cannot do the changes, no more time, etc..) Rejected -> pull request is rejected (quality not enough, etc..) Applied -> pull request is applied What do you think ? Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

7 12

[xwiki-devs] Velocity 2.0 and DeprecatedCheckUberspector
by Claude Brisson 20 Jun '18

20 Jun '18

Hi. I'm currently working on Velocity 2.0 packaging. If that's OK with you, I would like to incorporate DeprecatedCheckUberspector.java into Velocity, but I need a statement from your part to be able to change its licence to Apache 2.0 (LGPL and Apache 2.0 licences aren't compatible). By the way, I take this opportunity to tell you that if there is another specific part of xwiki-commons-velocity that you think should be integrated on our side, or an important missing feature you'd like to insist on, don't hesitate. I already integrated VELOCITY-825, for instance, so String->Enum constant conversions are now handled by Velocity. There may be other important conversion cases you'd like to see handled. Regards, Claude

4 8

[xwiki-devs] [Vote] Assignee for PR: Contributor or Committer?
by Ecaterina Moraru (Valica) 07 May '18

07 May '18

Hi, We have discussed this subject multiple times, but we don't have an official vote and conclusion on the topic. Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request? 1: Contributor - he provided the solution - giving the attributions, the contributor might feel encouraged to contribute more - we could do some JIRA statistics on external contributions, but this use case can be covered by GitHub statistics 2: Committer - he does the merging on his account and he becomes responsible for the committed code. - in case there are problems, the committer needs to find solution, since we can't rely on contributors availability - in doing the PR review, the committer spends a lot of time analyzing and testing the provided solution We are talking here about complete solutions provided by the PR, since in case of partial solutions, the committer can assign himself on the issue (depends on the quantity of modification he does). Let me know what you think, Caty

9 11

[xwiki-devs] [Proposal] Entry point for Extensions
by Vincent Massol 18 Aug '17

18 Aug '17

Hi devs, Problem ======= We have 2 issues right now when installing an extension in XWiki: 1) It’s not clear where is the entry point of that extension. - Example1: an app that is only for admins and only has a ConfigurableClass - Example2: an app that provides a macro and doesn’t have a UI 2) Even when an extension registers itself in the Applications Panel, the user still need to refresh the page or navigate away to see it. Proposal ======== * Introduce the concept of Entry point (a.k.a home page) in Extension metadata * Have the EM UI display the extension’s entry point (when there’s one) after having installed the extension so that the user can click on it and be taken to the home page of the extension. This would make extensions more discoverable IMO. Implementation Details ================== * Some maven extension metadata properties in pom.xml * A format to represent an entry point. It shouldn’t be a full URL since that needs to be computed at runtime. Basically it should contain: ** The document reference ** The action to use (view, admin, etc) - optional, should default to “view" ** The query string to use - optional, should default to an empty query string This corresponds to the notion of ResourceReference (EntityResourceReference to be precise). However we don’t have any textual representation of it ATM. WDYT? Good idea? Bad idea? Thanks -Vincent

8 16

[xwiki-devs] [VOTE] Move from our mailing lists and use Discourse instead
by Vincent Massol 15 May '17

15 May '17

Hi devs, I’m proposing to vote for moving away from our users and devs mailing list and instead to use the Discourse open source tool: * Home page: http://www.discourse.org/ * License: GPL v2 * FAQ: http://www.discourse.org/faq/ * Awesome feature list: http://www.discourse.org/about/ What is especially interesting for us: * It works with mailing lists (you can receive mails and send mails to the forum). * Works as a forum. BTW if you want to see a real life instance, check the gradle instance at https://discuss.gradle.org/ Nice things: * Works on mobile * Comprehensive API (would allow us to integrate it with xwiki.org) * Badges/user metrics So here’s my +1 to try it out and ask XWiki SAS if they could host an instance. WDYT? Do you see any negative point (I don’t ATM)? :) Please cast your votes! Thanks -Vincent

10 30

[xwiki-devs] [GSoC] More extension repositories
by Krzysiek Płachno 02 Apr '17

02 Apr '17

Hi, I'm about to prepare a plan and timeline with milestones for the task "More extension repositories ". The page with design details ( http://design.xwiki.org/xwiki/bin/view/Design/ExtensionManagerRepositories) gives 10 examples of repositories to set an integration with, whilst the description of task on XWiki GSoC information sub page refers only to 3: Nexus , Bintray , Pypi ( http://dev.xwiki.org/xwiki/bin/view/GoogleSummerOfCode/Moreextensionreposit…) . So the task for GSoC work includes integration with all those 10, or just those 3? I need to know it to plan well the milestones. Best, Krzysztof

3 7

[xwiki-devs] Glossary Application
by Sarthak Gupta 01 Apr '17

01 Apr '17

Hi, On the IRC, I asked about the meaning of the term "Rendering transformation". I went through the Rendering Framework doc and found that 'Rendering' is just a way to convert the DOM (Data Object Model: it connects different programming languages) into a valid output which is shown to the user. Now in the project "Glossary Application" , the idea is to present a list of definitions in the glossary app. I wanted to inquire if the definitions of the 'technical terms'(words which a user while going through the x-wiki page will find difficult to understand) of the x-wiki page is to be listed in the glossary app? And when user clicks on that word then a new page opens listing the definition of that term, feature etc? Thanks :)

2 18

Re: [xwiki-devs] Error while building
by Sarthak Gupta 31 Mar '17

31 Mar '17

Hi Vincent, Still Getting the same error on ubuntu :/ CKBuilder - Builds a release version of ckeditor-dev. Downloading CKBuilder... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 7423k 100 7423k 0 0 306k 0 0:00:24 0:00:24 --:--:-- 485k Starting CKBuilder... /home/sarthak/application-ckeditor-master/base/target/ckeditor-dev-4.6.2/dev/builder/build.sh: line 61: git: command not found [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] CKEditor Integration Parent POM .................... SUCCESS [ 0.842 s] [INFO] CKEditor Integration Base .......................... FAILURE [ 29.140 s] [INFO] CKEditor Integration Plugins ....................... SKIPPED [INFO] CKEditor Integration Test Modules .................. SKIPPED [INFO] CKEditor Integration Test Page Objects ............. SKIPPED [INFO] CKEditor Integration WebJar ........................ SKIPPED [INFO] CKEditor Integration UI ............................ SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 30.790 s [INFO] Finished at: 2017-03-31T22:56:08+05:30 [INFO] Final Memory: 26M/158M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (build-ckeditor) on project application-ckeditor-base: Command execution failed. Process exited with an error: 127 (Exit value: 127) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException On Fri, Mar 31, 2017 at 11:19 PM, Sarthak Gupta <sarthakgupta072(a)gmail.com> wrote: > Hi Vincent, > Still getting the same error on ubuntu :/ > Attached image: > > > On Thu, Mar 30, 2017 at 4:59 PM, Vincent Massol <vincent(a)massol.net> > wrote: > >> This build requires linux. >> >> Maybe it would work with cygwin, I don’t know. It’s not very nice to be >> OS-agnostic I agree but I think we’re stuck by CKEditor which requires a >> special custom build tool that probably only works on unix. >> >> Thanks >> -Vincent >> >> > On 30 Mar 2017, at 12:47, Sarthak Gupta <sarthakgupta072(a)gmail.com> >> wrote: >> > >> > Hi, >> > I am getting this error while building application-ckeditor. What to do? >> > >> > [INFO] >> > ------------------------------------------------------------ >> ------------ >> > [INFO] Reactor Summary: >> > [INFO] >> > [INFO] CKEditor Integration Parent POM .................... SUCCESS >> [02:07 >> > min] >> > [INFO] CKEditor Integration Base .......................... FAILURE >> [15:46 >> > min] >> > [INFO] CKEditor Integration Plugins ....................... SKIPPED >> > [INFO] CKEditor Integration Test Modules .................. SKIPPED >> > [INFO] CKEditor Integration Test Page Objects ............. SKIPPED >> > [INFO] CKEditor Integration WebJar ........................ SKIPPED >> > [INFO] CKEditor Integration UI ............................ SKIPPED >> > [INFO] >> > ------------------------------------------------------------ >> ------------ >> > [INFO] BUILD FAILURE >> > [INFO] >> > ------------------------------------------------------------ >> ------------ >> > [INFO] Total time: 19:54 min >> > [INFO] Finished at: 2017-03-30T15:39:01+05:30 >> > [INFO] Final Memory: 20M/121M >> > [INFO] >> > ------------------------------------------------------------ >> ------------ >> > [ERROR] Failed to execute goal >> > org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (build-ckeditor) on >> project >> > application-ckeditor-base: Command execution failed. Cannot run program >> > "C:\Users\SARTHAK >> > GUPTA\.m2\XWiki\application-ckeditor-master\base\target\cked >> itor-dev-4.6.2\dev\builder\build.sh" >> > (in directory "C:\Users\SARTHAK >> > GUPTA\.m2\XWiki\application-ckeditor-master\base"): CreateProcess >> > error=193, %1 is not a valid Win32 application -> [Help 1] >> > [ERROR] >> > [ERROR] To see the full stack trace of the errors, re-run Maven with >> the -e >> > switch. >> > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> > [ERROR] >> > [ERROR] For more information about the errors and possible solutions, >> > please read the following articles: >> > [ERROR] [Help 1] >> > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException >> > [ERROR] >> > [ERROR] After correcting the problems, you can resume the build with the >> > command >> > [ERROR] mvn <goals> -rf :application-ckeditor-base >> >> >

2 1

[xwiki-devs] [XWiki Day] BFD#139
by Alexandru Cotiuga 31 Mar '17

31 Mar '17

Hello devs, Today is BFD#139: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingdays Our current status for the 500 days period is 61 bugs behind. See: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=103 52#Created-vs-Resolved-Chart/16742 Here's the BFD#139 dashboard to follow the progress during the day: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=13813 Happy BugFixing Day, Alex

1 1

[xwiki-devs] Repositories for some custom code
by Ludovic Dubost 30 Mar '17

30 Mar '17

Hi, I'd like 2 repositories on xwiki contrib for small improvements to XWikis: extension-appwithinminutes-filefields -> provides image, file and pdf fields for AppWithinMinutes and extension-pdftemplate-modern -> an alternate pdf template for exporting PDF with a logo and nicer fonts Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic(a)xwiki.com skype: ldubost Blog: http://blog.ludovic.org <https://r.clb.pt/r/38b73d342d9beb124c111af0c8332fb6?d=http%3A%2F%2Fblog.lud…>Try XWiki on the cloud <https://r.clb.pt/r/38b73d342d9beb124c111af0c8332fb6?d=http%3A%2F%2Fwww.xwik…> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://r.clb.pt/r/38b73d342d9beb124c111af0c8332fb6?d=https%3A%2F%2Fcryptpa…>

2 4