October 2009 - xwiki-devs@xwiki.org

[xwiki-devs] [Proposal] Rename platform/web/wysiwyg module to platform/web/xwiki-gwt-wysiwyg
by Marius Dumitru Florea 19 Oct '09

19 Oct '09

In addition I'd like to changed the package from: com.xpn.xwiki.wysiwyg.* to org.xwiki.gwt.wysiwyg.* Here's my +1. WDYT? Thanks, Marius

2 2

[xwiki-devs] BoldTest.testTimeComplexity() generates StackOverflow error
by Vincent Massol 19 Oct '09

19 Oct '09

Hi Sergiu, Could you have a look at BoldTest.testTimeComplexity(). It generates a stackoverflow error in the console: java.lang.StackOverflowError at java.util.regex.ASCII.isType(ASCII.java:185) at java.util.regex.Pattern$Ctype.isSatisfiedBy(Pattern.java:3444) at java.util.regex.Pattern$CharProperty$1.isSatisfiedBy(Pattern.java: 3337) at java.util.regex.Pattern$CharProperty.match(Pattern.java:3345) at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168) at java.util.regex.Pattern$Behind.match(Pattern.java:4648) at java.util.regex.Pattern$LazyLoop.match(Pattern.java:4353) at java.util.regex.Pattern$GroupTail.match(Pattern.java:4227) at java.util.regex.Pattern$BranchConn.match(Pattern.java:4078) at java.util.regex.Pattern$Curly.match2(Pattern.java:3821) at java.util.regex.Pattern$Curly.match(Pattern.java:3748) at java.util.regex.Pattern$Branch.match(Pattern.java:4114) at java.util.regex.Pattern$GroupHead.match(Pattern.java:4168) Thanks -Vincent

1 0

Re: [xwiki-devs] GWT tree Interact with WYSIWYG editor
by Leon Wang 19 Oct '09

19 Oct '09

Hi Marius, Since the first approach which is "1) edit the wysiwyg_createEditor velocity macro from macros.vm" is simpler, I will modify macros.vm. You said "new WysiwygEditor($jsVarName); with something like window["${fieldId}_editor"] = new WysiwygEditor($jsVarName);" Could you please explain briefly what does "window["${fieldId}_editor"]" mean? What is it for? Is it a function of javascript? In the macros.vm I found "Wysiwyg.onModuleLoad(function() {new WysiwygEditor($jsVarName); $jsVarName = undefined;});", I did not find any "window" stuff. So after the first step, I got the reference, is the reference stored in window["${fieldId}_editor"] variable? Since don't depend at all on WYSIWYG Java code is not possible and do not bring you more work, I think should go with "i) access the editor in Java (GWT) code by writing a simple native getter". For the code you provided "editorJSReference.@com.xpn.xwiki.wysiwyg.client.editor.WysiwygEditorApi::editor;" I never saw code like this, is the @ for Java annotation or Component? Is there any document I can read to learn about the related rationale/knowledge? 'cause I have no clue what it means. So this line will return the WYSIWYG editor's reference restored/declared in the macros.vm file? I tried to add a new page in the draft document for Loading GWT in Xwiki page, It seems I can't add new page, only editing existing document. Should I add something behind your "Writing GWT applications in XWiki", so you could create a new one or something else. If there are work I can do to save your time or to make Xwiki better, feel free to assign me the work. I am more than happy to help. Thank you for taking your time to help me! -Leon

2 1

[xwiki-devs] Duplications & debt - REST/XMLRPC and WebDAV
by Vincent Massol 19 Oct '09

19 Oct '09

Hi Asiri, I see there's 10% of code duplication in the webdav module: http://nemo.sonarsource.org/project/index/181898 This is the highest of all modules. Do you think you could have a look? Second worst is REST with 5% http://nemo.sonarsource.org/components/index/178319 In term of technical debt, WebDAV module is also high with 9.5% and the highest is the XMLRPC module with 12.2%. Thanks -Vincent

4 5

[xwiki-devs] Meeting Manager Annoucement
by Ludovic Dubost 18 Oct '09

18 Oct '09

Hi, We have published the Meeting Manager application which has been sponsored by "Groupe Glon". The meeting manager is an XWiki 2.0 application which allows to plan and manage meetings and meeting cycles. It's a very nice and complete application. You can plan your meeting by setting an agenda, adding participants and propose a vote for meeting dates (a little like Doodle). You can then write your meeting notes. You can download the Meeting manager application here: http://code.xwiki.org/xwiki/bin/view/Applications/MeetingManagerApplication For developers, the source code is available here: http://svn.xwiki.org/svnroot/xwiki/sandbox/applications/xwiki-application-m… Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

1 0

[xwiki-devs] More memory needed for build?
by Vincent Massol 18 Oct '09

18 Oct '09

Hi, Today I just got my first OOM when building xwiki. It happened in the xwiki-core tests: Running com.xpn.xwiki.notify.PropertyChangedRuleTest org.apache.maven.surefire.booter.SurefireExecutionException: Java heap space; nested exception is java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space The bad part is that I'm building with: MAVEN_OPTS=-Xmx1024m Anyone else has noticed a memory req increase in the build? Thanks -Vincent

2 4

Re: [xwiki-devs] Background button of WYSIWYG toolbar and GWT
by Leon Wang 17 Oct '09

17 Oct '09

Thank you Guillaume! It works now! Hello Marius, I have improved the document http://platform.xwiki.org/xwiki/bin/view/AdminGuide/WysiwygEditor by giving an example how to add a new button to the toolbar of WYSIWYG editor. At first, I thought only Xwiki people who created Xwiki can edit the document. Today I tried to register and I know I can edit it too! That's great! I also can write a document about how to Load GWT application to Xwiki page, do you know where should I place this new document? Should I place it in a existing page or should place create a new page? Marius, I will digest what your replied last time. Thank you! :-D PS: I will be in China during Dec 26 ~ Jan 11, 2011, if anyone xwiki people have a chance to come to Beijing let me know I will should you around. Have a nice week everyone!

2 1

[xwiki-devs] XWiki at the Enterprise 2.0 Conference in California
by Ludovic Dubost 17 Oct '09

17 Oct '09

We did it !!!! http://enterprise2blog.com/2009/10/drum-roll-please-our-launch-pad-finalist… I want to all thank you for helping making this happen. This is just great for XWiki. With this conference where we get 5 minutes on stage in the keynote room + a mini-pod in the exposition room, we will get a huge exposure for XWiki. If there are some Californian's that want to meet while I'm there in San Francisco, please tell me. It Nov 2nd, 3rd at the Moscone. I'll probably stay a few days after. Do come see us at the exposition. If you have a great usage of XWiki come even more to show it to other potential users of XWiki. The best way to help XWiki is to spread it's usage. Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

3 2

[xwiki-devs] [Colibri] CSS Cleanup
by Ecaterina Valica 17 Oct '09

17 Oct '09

Hi devs, One of the items for the 2.1 XE is: "Clean the colibri skin so that it's no longer a pile of code added on top of Toucan" I would ask you to help me test the cleanup for the Colibri skin. The cleanup was made on the XE 2.0 release. You can find colibri.css, ie-6.css and ie-all.css at: http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/colibri.… http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/ie-6.css http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/ie-all.c… >From the original colibri.css size of 73,9 Ko and 4408 lines of code, now we have 29,7 Ko and 1526 lines of code. My problem is that I didn't delete too much. You can find the leftovers at: http://incubator.myxwiki.org/xwiki/bin/download/Skins/ColibriClean/colibriL… The code could be even more compressed if there weren't so many inconsistencies in the markup for doing the same thing (ex. button usage, panel input elements, etc). I didn't use anything from the colibri/ie.css - so this can be deleted if the cleanup is accepted and committed. There are some standards in the cleanup, like: - alphabetical order for the css proprieties; - 2 spaces indentation for the proprieties; - comment headers for separation and grouping of different parts of the code; - "Overwrites" and "Should be in" comments for dependencies overwriting. It would be nice if the code can be tested in a more "advanced" manner to cover for the unusual parts that I might not cover in my testing. There are some minor differences from the XE2.0 Colibri in the display. My request is: if you find one of those be sure it doesn't have another style associated or the problem is not in the CSS, but in the markup. You can report bugs replying to this mail or on the incubator page http://incubator.myxwiki.org/xwiki/bin/view/Skins/ColibriClean Thank you, Caty

2 3

[xwiki-devs] [Proposal] Automatically inherit the "View" right from the "Edit" right
by Guillaume Lerouge 16 Oct '09

16 Oct '09

Hi Devs, right now an user can have edit rights on a page even though he does not have the view right on that page. This sounds weird to me since that user can still access the page's content by going to the right URL. Thus I think it would be better to have the view right inherited from the edit right (if an user can edit a page he should also be able to view it). Is there any drawback to this? Here's the matching JIRA issue: http://jira.xwiki.org/jira/browse/XWIKI-4491 Thanks for your feedback, Guillaume -- Guillaume Lerouge Product Manager - XWiki SAS Skype: wikibc Twitter: glerouge http://guillaumelerouge.com/

3 3