March 2009 - xwiki-devs@xwiki.org

[xwiki-devs] customize xwiki
by walido 27 Mar '09

27 Mar '09

hi, my request is about customizing xwiki from its war file i.e make the forum plugin that i have(BulletinBoardApplication2.xar) an original component of the application, by the way i don't know if there's a better forum plugin :) and that's including also changing the skins and the backgroud of the "first generated application",threre's another question how add a link to forum component in the quick links panel (* [Forum>Main.BulletinBoard]?? ) help me with this one please thank you -- View this message in context: http://n2.nabble.com/customize-xwiki-tp2543791p2543791.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

1 0

[xwiki-devs] Anti Vandalism Filter For GSoc 09
by Harshana Martin 27 Mar '09

27 Mar '09

Hi xWiki Devs, I'm a computer engineering undergrad from university of moratuwa and i'm really interested computer security, network security, cryptography. Hence i'm curious about this xWiki project idea for Gsoc 09 called anit vandalism filter which seems to be very interesting. So i'm very keen to know more about this project, specially scope, dependencies and requirements before submitting my project proposal. I appreciate some more details and feed back about this. Thanks & Regards, Harashna Martin -- View this message in context: http://n2.nabble.com/Anti-Vandalism-Filter-For-GSoc-09-tp2543640p2543640.ht… Sent from the XWiki- Dev mailing list archive at Nabble.com.

1 0

Re: [xwiki-devs] [xwiki-notifications] r18051 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation xwiki-rendering-api/src/test/java/org/xwiki/rendering/internal/transformation xwiki-
by Thomas Mortagne 27 Mar '09

27 Mar '09

fixed On Fri, Mar 27, 2009 at 09:50, Vincent Massol <vincent(a)massol.net> wrote: > > On Mar 26, 2009, at 9:48 PM, tmortagne (SVN) wrote: > >> Author: tmortagne >> Date: 2009-03-26 21:48:42 +0100 (Thu, 26 Mar 2009) >> New Revision: 18051 >> >> Added: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ >> java/org/xwiki/rendering/internal/transformation/ >> TestSimpleInlineMacro.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- >> rendering-macro-box/src/test/resources/macrobox6.test >> platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/ >> resources/macros/macro14.test >> Modified: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/ >> java/org/xwiki/rendering/internal/transformation/ >> MacroTransformation.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ >> java/org/xwiki/rendering/internal/transformation/TestSimpleMacro.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ >> resources/META-INF/plexus/components.xml >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- >> rendering-macro-box/src/test/java/org/xwiki/rendering/ >> RenderingTests.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/ >> java/org/xwiki/rendering/RenderingTests.java >> Log: >> XWIKI-3461: A non-inline {{box}} after an inline one is rendered as >> inline >> > > [snip] > >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/ >> xwiki-rendering-macro-box/src/test/java/org/xwiki/rendering/ >> RenderingTests.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- >> rendering-macro-box/src/test/java/org/xwiki/rendering/ >> RenderingTests.java 2009-03-26 19:50:15 UTC (rev 18050) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- >> rendering-macro-box/src/test/java/org/xwiki/rendering/ >> RenderingTests.java 2009-03-26 20:48:42 UTC (rev 18051) >> @@ -37,11 +37,12 @@ >> { >> RenderingTestSuite suite = new RenderingTestSuite("Test Box >> Macro"); >> >> - suite.addTestsFromResource("macrobox1", true); >> + /*suite.addTestsFromResource("macrobox1", true); >> suite.addTestsFromResource("macrobox2", true); >> suite.addTestsFromResource("macrobox3", true); >> suite.addTestsFromResource("macrobox4", true); >> - suite.addTestsFromResource("macrobox5", true); >> + suite.addTestsFromResource("macrobox5", true);*/ > > Seems you have forgotten to remove comments. > > [snip] > > Thanks > -Vincent > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r18051 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation xwiki-rendering-api/src/test/java/org/xwiki/rendering/internal/transformation xwiki-rendering-api/src/test/resources/META-INF/plexus xwiki-rendering-macros/xwiki-rendering-macro-box/src/test/java/org/xwiki/rendering xwiki-rendering-macros/xwiki-rendering-macro-box/src/test/resources xwiki-rendering-tests/src/test/java/org/xwiki/rendering xwiki-
by Vincent Massol 27 Mar '09

27 Mar '09

On Mar 26, 2009, at 9:48 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-03-26 21:48:42 +0100 (Thu, 26 Mar 2009) > New Revision: 18051 > > Added: > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ > java/org/xwiki/rendering/internal/transformation/ > TestSimpleInlineMacro.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-box/src/test/resources/macrobox6.test > platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/ > resources/macros/macro14.test > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/ > java/org/xwiki/rendering/internal/transformation/ > MacroTransformation.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ > java/org/xwiki/rendering/internal/transformation/TestSimpleMacro.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/test/ > resources/META-INF/plexus/components.xml > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-box/src/test/java/org/xwiki/rendering/ > RenderingTests.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/ > java/org/xwiki/rendering/RenderingTests.java > Log: > XWIKI-3461: A non-inline {{box}} after an inline one is rendered as > inline > [snip] > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/ > xwiki-rendering-macro-box/src/test/java/org/xwiki/rendering/ > RenderingTests.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-box/src/test/java/org/xwiki/rendering/ > RenderingTests.java 2009-03-26 19:50:15 UTC (rev 18050) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-box/src/test/java/org/xwiki/rendering/ > RenderingTests.java 2009-03-26 20:48:42 UTC (rev 18051) > @@ -37,11 +37,12 @@ > { > RenderingTestSuite suite = new RenderingTestSuite("Test Box > Macro"); > > - suite.addTestsFromResource("macrobox1", true); > + /*suite.addTestsFromResource("macrobox1", true); > suite.addTestsFromResource("macrobox2", true); > suite.addTestsFromResource("macrobox3", true); > suite.addTestsFromResource("macrobox4", true); > - suite.addTestsFromResource("macrobox5", true); > + suite.addTestsFromResource("macrobox5", true);*/ Seems you have forgotten to remove comments. [snip] Thanks -Vincent

1 0

Re: [xwiki-devs] [xwiki-notifications] r18050 - in platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src: main/java/org/xwiki/rendering/internal/macro/toc test/java/org/xwiki/rendering test/resources
by Vincent Massol 26 Mar '09

26 Mar '09

On Mar 26, 2009, at 8:50 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-03-26 20:50:15 +0100 (Thu, 26 Mar 2009) > New Revision: 18050 > > Added: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/test/resources/macrotoc9.test > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/main/java/org/xwiki/rendering/internal/macro/ > toc/TocMacro.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/test/java/org/xwiki/rendering/ > RenderingTests.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/test/resources/macrotoc3.test > Log: > XWIKI-3462: TOC not displaying properly > [snip] > Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/ > xwiki-rendering-macro-toc/src/test/resources/macrotoc9.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/test/resources/ > macrotoc9.test (rev 0) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-toc/src/test/resources/macrotoc9.test 2009-03-26 > 19:50:15 UTC (rev 18050) > @@ -0,0 +1,129 @@ > +.#----------------------------------------------------- > +.input|xwiki/2.0 Maybe a little description here to explain what this test is testing since it's not immediately obvious. > > +.#----------------------------------------------------- > += Level 1 > + > +{{toc start=1 depth=3 numbered=false scope=page /}} > + > +== Level 2a > + > +=== Level 3a > + > +=== Level 3b > + > += Level 2b > + > +=== Level 3c [snip] Thanks -Vincent

2 1

[xwiki-devs] [PROPOSAL] wiki=false by default in html macro
by Thomas Mortagne 26 Mar '09

26 Mar '09

Hi devs, Currently in the html macro the wiki parser is applied. That means that if you expected the html you put inside the macro you could have unpleasant surprises. I think putting just html in the html (eventually some velocity) is the most common use case and it's easier for a user to understand that the wiki content inside the html macro is not applied because it's not enabled that "this does not looks like the html I put". Another way to say it is that we will get a lot more mail on the list with wiki=true than wiki=false ;) I propose to change wiki=true by wiki=false by default. Here is my +1 -- Thomas Mortagne

4 4

[xwiki-devs] Annotations for our components
by Vincent Massol 26 Mar '09

26 Mar '09

Hi devs, I'm continuing on this topic since I really believe we need annotations now. However I think it's best to have our own annotations for injection. One reason we need annotation (amongst other needs) is in order to be able to create a xwiki uberjar for rendering modules for example. With components.xml you cannot easily merge jars since you'd need to merge components.xml so you'd need to write some xslt code for that. Another reason is that we have to comment in the code things such as "this field is injected automatically by the component manager". Of course this comment is forgotten most of the time. It's much nicer to have a @Inject annotation. Last we need annotations if we want to be able to more easily support different IOC frameworks since otherwise it means that for each fwk we need to do again all components mappings in a static way. Of course one basic need is evidently to reduce the number of config lines we have to write and the errors associated with them. I'm going to look into plexus annotations for a starter (+ guice) to see how they do it and then I'll make a proposal for annotations. Let me know what you think. Thanks -Vincent

3 4

[xwiki-devs] [Proposal] Components Annotations
by Vincent Massol 26 Mar '09

26 Mar '09

Hi, To start with I propose to model against the plexus annotations but more simple: * Component * Requirement * Configuration /** * Marks a class as a XWiki component. */ @Documented @Retention(RUNTIME) @Target(TYPE) @Inherited public @interface Component { Class<?> role(); String hint() default ""; String instantiationStrategy() default ""; } /** * Configures a requirement. */ @Documented @Retention(RUNTIME) @Target({ FIELD, METHOD }) @Inherited public @interface Requirement { Class<?> role() default Object.class; String hint() default ""; // // HACK: This is here to support component requirement lists, which can take a list of hints // String[] hints() default {}; } Note: not sure yet why plexus says it's a hack. /** * Marks a field as a configuration element with a default value. */ @Documented @Retention(RUNTIME) @Target(FIELD) @Inherited public @interface Configuration { String name() default ""; String value(); } So for example in the code you'd have: @Component(role=Parser.class) public class WikiModelXWikiParser implements Parser... { @Requirement private LinkParser linkParser; .... wdyt? I'm still researching. Thanks -Vincent

2 2

[xwiki-devs] [VOTE] Release date and roadmap for 1.8.1
by Vincent Massol 26 Mar '09

26 Mar '09

Hi, I'm proposing that we release XE 1.8.1 on the 6th of April. It would have been 3 weeks since the release of 1.8 and we'll have plenty of important fixes and improvements for our users. Note that 1.8.1 is mainly for rendering/wysiwyg improvements. The roadmap is currently defined in jira: - For wysiwyg http://tinyurl.com/d75olg - For rendering http://tinyurl.com/cwpchk Note that more issues will be put for rendering and other domain. The idea is to time box this for the 6th of April. Here's my +1 Thanks -Vincent

5 4

Re: [xwiki-devs] [xwiki-notifications] r18027 - in platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg: client/plugin/macro/exec client/widget/rta/internal server server/cleaner/internal server/converter/internal
by Vincent Massol 26 Mar '09

26 Mar '09

Hi Marius, On Mar 26, 2009, at 12:26 AM, mflorea (SVN) wrote: > Author: mflorea > Date: 2009-03-26 00:26:55 +0100 (Thu, 26 Mar 2009) > New Revision: 18027 > > Modified: > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > client/plugin/macro/exec/RefreshExecutable.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > client/widget/rta/internal/IEBehaviorAdjuster.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > server/DefaultWysiwygService.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > server/cleaner/internal/DefaultHTMLCleaner.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > server/cleaner/internal/WysiwygCleaningFilter.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > server/converter/internal/EventsHTMLConverter.java > platform/web/trunk/wysiwyg/src/main/java/com/xpn/xwiki/wysiwyg/ > server/converter/internal/XWikiHTMLConverter.java > Log: > Updated the WYSIWYG code due to: > * XWIKI-3456: Provide way to control the HTML cleaning filters > executed by the HTML Cleaner > * XWIKI-3457: XHTML parser shouldn't run the HTML Cleaner > Also some minor IE fixes. [snip] > import com.xpn.xwiki.web.Utils; > import com.xpn.xwiki.wysiwyg.server.cleaner.HTMLCleaner; > @@ -49,8 +53,12 @@ > { > org.xwiki.xml.html.HTMLCleaner cleaner = > (org.xwiki.xml.html.HTMLCleaner) > Utils.getComponent(org.xwiki.xml.html.HTMLCleaner.ROLE); > - Document document = cleaner.clean(new > StringReader(dirtyHTML)); > - filter.filter(document); > + HTMLCleanerConfiguration config = > cleaner.getDefaultConfiguration(); > + List<HTMLFilter> filters = new ArrayList<HTMLFilter>(); > + filters.add(filter); I think it would be good to add a good comment here explaining why you have to run your filter first. > > + filters.addAll(config.getFilters()); > + config.setFilters(filters); > + Document document = cleaner.clean(new > StringReader(dirtyHTML), config); > return XMLUtils.toString(document); > } > } [snip] Thanks -Vincent

2 1