May 2009 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Generify ComponentManager
by Asiri Rathnayake 07 May '09

07 May '09

Hi Devs, ComponentManager interface at the moment doesn't use generics and we have to manually cast the results into corresponding types. But with new notion of using Class objects for roles (for lookup) I think it would be very easier to generify this interface. Here is my +1. Thanks. - Asiri

5 4

Re: [xwiki-devs] [xwiki-notifications] r19431 - in platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html: . src/main/java/org/xwiki/rendering/internal/macro/html src/test/java/org/xwiki/rendering
by Thomas Mortagne 06 May '09

06 May '09

On Wed, May 6, 2009 at 16:24, vmassol <platform-notifications(a)xwiki.org> wrote: > Author: vmassol > Date: 2009-05-06 16:24:58 +0200 (Wed, 06 May 2009) > New Revision: 19431 > > Added: > platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/HTMLMacroTest.java > platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentAccessBridge.java > platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentNameSerializer.java > Modified: > platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/pom.xml > platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacro.java > Log: > XWIKI-3764: Modify behavior of HTML macro when it's set to contain wiki syntax > > * Fixed regression where non inline content in inline context was allowed to go through > > Merged from trunk (rev 19430) > > > Modified: platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/pom.xml > =================================================================== > --- platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/pom.xml 2009-05-06 14:23:02 UTC (rev 19430) > +++ platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/pom.xml 2009-05-06 14:24:58 UTC (rev 19431) > @@ -42,6 +42,19 @@ > <groupId>org.wikimodel</groupId> > <artifactId>org.wikimodel.wem</artifactId> > </dependency> > +  > + <dependency> > + <groupId>org.xwiki.platform</groupId> > + <artifactId>xwiki-core-shared-tests</artifactId> > + <version>${pom.version}</version> > + <scope>test</scope> > + </dependency> This dependency is already in xwiki-core-rendering-macros-parent > + <dependency> > + <groupId>jmock</groupId> > + <artifactId>jmock</artifactId> > + <version>1.1.0</version> > + <scope>test</scope> > + </dependency> > </dependencies> > <build> > <plugins> > @@ -49,9 +62,9 @@ > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-surefire-plugin</artifactId> > <configuration> > - <includes> > - <include>**/RenderingTests.java</include> > - </includes> > + <excludes> > + <exclude>**/Mock*.java</exclude> > + </excludes> > </configuration> > </plugin> > <plugin> > > Modified: platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacro.java > =================================================================== > --- platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacro.java 2009-05-06 14:23:02 UTC (rev 19430) > +++ platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/main/java/org/xwiki/rendering/internal/macro/html/HTMLMacro.java 2009-05-06 14:24:58 UTC (rev 19431) > @@ -26,6 +26,8 @@ > > import org.apache.commons.lang.StringUtils; > import org.w3c.dom.Document; > +import org.w3c.dom.Element; > +import org.w3c.dom.Node; > import org.xwiki.bridge.DocumentAccessBridge; > import org.xwiki.bridge.DocumentNameSerializer; > import org.xwiki.component.annotation.Component; > @@ -193,8 +195,9 @@ > * @param isInline true if the content is inline and thus if we need to remove the top level paragraph > * element created by the cleaner > * @return the cleaned HTML as a string representing valid XHTML > + * @throws MacroExecutionException if the macro is inline and the content is not inline HTML > */ > - private String cleanHTML(String content, boolean isInline) > + private String cleanHTML(String content, boolean isInline) throws MacroExecutionException > { > String cleanedContent = content; > > @@ -216,9 +219,20 @@ > // HTML envelope when rendered. We remove it so that the HTML <head> tag isn't output. > HTMLUtils.stripHTMLEnvelope(document); > > - // If in inline mode remove the top level paragraph if there's one. > + // If in inline mode verify we have inline HTML content and remove the top level paragraph if there's one > if (isInline) { > - HTMLUtils.stripFirstElementInside(document, HTMLConstants.TAG_HTML, HTMLConstants.TAG_P); > + // TODO: Improve this since when're inside a table cell or a list item we can allow non inline items too > + Element root = document.getDocumentElement(); > + if (root.getChildNodes().getLength() == 1 && root.getFirstChild().getNodeType() == Node.ELEMENT_NODE > + && root.getFirstChild().getNodeName().equalsIgnoreCase("p")) > + { > + HTMLUtils.stripFirstElementInside(document, HTMLConstants.TAG_HTML, HTMLConstants.TAG_P); > + } else { > + throw new MacroExecutionException( > + "When using the HTML macro inline, you can only use inline HTML content." > + + " Block HTML content (such as tables) cannot be displayed." > + + " Try leaving an empty line before and after the HTML macro."); > + } > } > > // Don't print the XML declaration nor the XHTML DocType. > > Added: platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/HTMLMacroTest.java > =================================================================== > --- platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/HTMLMacroTest.java (rev 0) > +++ platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/HTMLMacroTest.java 2009-05-06 14:24:58 UTC (rev 19431) > @@ -0,0 +1,69 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.rendering; > + > +import org.xwiki.rendering.internal.macro.html.HTMLMacro; > +import org.xwiki.rendering.macro.Macro; > +import org.xwiki.rendering.macro.MacroExecutionException; > +import org.xwiki.rendering.macro.html.HTMLMacroParameters; > +import org.xwiki.rendering.scaffolding.MockDocumentNameSerializer; > +import org.xwiki.rendering.transformation.MacroTransformationContext; > +import org.xwiki.test.AbstractXWikiComponentTestCase; > + > +/** > + * Unit tests for {@link HTMLMacro} that cannot be performed using the Rendering Test framework. > + * > + * @version $Id: $ > + * @since 1.8.3 > + */ > +public class HTMLMacroTest extends AbstractXWikiComponentTestCase > +{ > + /** > + * {@inheritDoc} > + * > + * @see com.xpn.xwiki.test.AbstractXWikiComponentTestCase#setUp() > + */ > + @Override > + protected void setUp() throws Exception > + { > + super.setUp(); > + getComponentManager().registerComponent(MockDocumentAccessBridge.getComponentDescriptor()); > + getComponentManager().registerComponent(MockDocumentNameSerializer.getComponentDescriptor()); > + } > + > + /** > + * Verify that inline HTML macros with non inline content generate an exception. > + */ > + public void testHTMLMacroWhenNonInlineContentInInlineContext() throws Exception > + { > + HTMLMacro macro = (HTMLMacro) getComponentManager().lookup(Macro.class.getName(), "html"); > + HTMLMacroParameters parameters = new HTMLMacroParameters(); > + MacroTransformationContext context = new MacroTransformationContext(); > + context.setInline(true); > + try { > + macro.execute(parameters, "<ul><li>item</li></ul>", context); > + fail("Should have thrown an exception here"); > + } catch (MacroExecutionException expected) { > + assertEquals("When using the HTML macro inline, you can only use inline HTML content. Block HTML " > + + "content (such as tables) cannot be displayed. Try leaving an empty line before and after the " > + + "HTML macro.", expected.getMessage()); > + } > + } > +} > > Added: platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentAccessBridge.java > =================================================================== > --- platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentAccessBridge.java (rev 0) > +++ platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentAccessBridge.java 2009-05-06 14:24:58 UTC (rev 19431) > @@ -0,0 +1,271 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.rendering; > + > +import java.util.Map; > + > +import org.xwiki.bridge.DocumentAccessBridge; > +import org.xwiki.bridge.DocumentModelBridge; > +import org.xwiki.bridge.DocumentName; > +import org.xwiki.component.descriptor.ComponentDescriptor; > +import org.xwiki.component.descriptor.DefaultComponentDescriptor; > + > +/** > + * Mock {@link DocumentAccessBridge} implementation used for testing, since we don't want to pull any dependency on the > + * Model/Skin/etc for the Rendering module's unit tests. > + * > + * @version $Id: $ > + * @since 1.8.3 > + */ > +public class MockDocumentAccessBridge implements DocumentAccessBridge > +{ > + /** > + * Create and return a descriptor for this component. > + * > + * @return the descriptor of the component. > + */ > + public static ComponentDescriptor getComponentDescriptor() > + { > + DefaultComponentDescriptor componentDescriptor = new DefaultComponentDescriptor(); > + > + componentDescriptor.setRole(DocumentAccessBridge.class); > + componentDescriptor.setImplementation(MockDocumentAccessBridge.class.getName()); > + > + return componentDescriptor; > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getDocumentContent(String documentName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getDocumentContent(String documentName, String language) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public boolean exists(String documentName) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getURL(String documentName, String action, String queryString, String anchor) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getAttachmentURL(String documentName, String attachmentName) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getProperty(String documentName, String className, int objectNumber, String propertyName) > + throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getProperty(String documentName, String className, String propertyName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getProperty(String documentName, String propertyName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getPropertyType(String className, String propertyName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public boolean isPropertyCustomMapped(String className, String propertyName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void setProperty(String documentName, String className, String propertyName, Object propertyValue) > + throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public byte[] getAttachmentContent(String documentName, String attachmentName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public boolean hasProgrammingRights() > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getDocumentContentForDefaultLanguage(String arg0) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public boolean isDocumentViewable(String arg0) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getCurrentUser() > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getDefaultEncoding() > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public String getDocumentSyntaxId(String arg0) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public boolean isDocumentEditable(String arg0) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void setAttachmentContent(String arg0, String arg1, byte[] arg2) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void setDocumentContent(String arg0, String arg1, String arg2, boolean arg3) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void setDocumentSyntaxId(String arg0, String arg1) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public DocumentModelBridge getDocument(String documentName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public DocumentName getDocumentName(String documentName) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public DocumentName getCurrentDocumentName() > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void popDocumentFromContext(Map<String, Object> backupObjects) > + { > + throw new RuntimeException("Not implemented"); > + } > + > + /** > + * {@inheritDoc} > + */ > + public void pushDocumentInContext(Map<String, Object> backupObjects, String documentName) throws Exception > + { > + throw new RuntimeException("Not implemented"); > + } > +} > > Added: platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentNameSerializer.java > =================================================================== > --- platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentNameSerializer.java (rev 0) > +++ platform/core/branches/xwiki-core-1.8/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-html/src/test/java/org/xwiki/rendering/MockDocumentNameSerializer.java 2009-05-06 14:24:58 UTC (rev 19431) > @@ -0,0 +1,61 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.rendering; > + > +import org.xwiki.bridge.DocumentAccessBridge; > +import org.xwiki.bridge.DocumentName; > +import org.xwiki.bridge.DocumentNameSerializer; > +import org.xwiki.component.descriptor.ComponentDescriptor; > +import org.xwiki.component.descriptor.DefaultComponentDescriptor; > + > +/** > + * Mock {@link DocumentAccessBridge} implementation used for testing, since we don't want to pull any dependency on the > + * Model/Skin/etc for the Rendering module's unit tests. > + * > + * @version $Id: MockDocumentNameSerializer.java 19152 2009-04-27 21:02:41Z tmortagne $ > + * @since 1.9M2 > + */ > +public class MockDocumentNameSerializer implements DocumentNameSerializer > +{ > + /** > + * Create and return a descriptor for this component. > + * > + * @return the descriptor of the component. > + */ > + public static ComponentDescriptor getComponentDescriptor() > + { > + DefaultComponentDescriptor componentDescriptor = new DefaultComponentDescriptor(); > + > + componentDescriptor.setRole(DocumentNameSerializer.class); > + componentDescriptor.setImplementation(MockDocumentNameSerializer.class.getName()); > + > + return componentDescriptor; > + } > + > + /** > + * {@inheritDoc} > + * > + * @see org.xwiki.bridge.DocumentNameSerializer#serialize(org.xwiki.bridge.DocumentName) > + */ > + public String serialize(DocumentName documentName) > + { > + throw new RuntimeException("Not implemented"); > + } > +} > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 1

[xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true
by Vincent Massol 06 May '09

06 May '09

Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when wiki=true. For ex take the following input: {{velocity}} ... {{html wiki="true"}} <form> $xwiki.includeForm("XWiki.MyClassSheet") <br /> <p> <input type="submit" name="submit" value="Create this new Workpackage" /> </p> </form> {{/html}} ... {{/velocity}} And assume that MyClassSheet has some $doc.display() velocity code which thus generate {{html}} macros. Current Result ============ Right now here's what happens: 1) velocity macro is executed and $xwiki.includeForm executes 2) MyClassSheet generate {{html}} macro content thus yielding: {{html wiki="true"}} <form> {{html}}...<someTag>...</someTag>{{/html}} </form> {{/html}} 3) After velocity has finished executing the velocity macro calls the wiki parser on the result and thus the top level HTML macro executes 4) since wiki=true the content is given to a SAX parser and each XML tag content is given to the wiki parser. Thus "{{html}}...", "..." and "{{/html}}" will be parser by the wiki parser separately (because <someTag> is valid XML), thus generating non expected content as a result. Proposed change ============== Modify the HTML behavior so that the wiki parser executes first (instead of the SAX parser) and render the result using a special renderer that prints the special symbols and text as is. When run on our example this would give (same steps 1) and 2)): 3) wiki parser executes and generate XDOM. Render it using the special renderer Note that this means that if in HTML your write content that has a meaning in some wiki syntax you'll need to escape it. For example if you have: {{html wiki=true}}  {{/html}} you'll get some strikethrough. So you'll need to write instead: {{html wiki=true}} <!~-~-hello~-~-> {{/html}} WDYT? Here's my +1 Thanks -Vincent

5 14

[xwiki-devs] [VOTE/IDEA] Introduce ApplicationContextInitializer
by Asiri Rathnayake 06 May '09

06 May '09

Hi Devs, I was working on openoffice server auto-start feature and faced a few problems with it. To start the openoffice server when XE is started, I need to send a notification to openoffice server manager when XE is started. The first attempt was to use our ObservationManager component to send startup / shutdown events and let OpenOfficeServerManager listen to them. But this approach requires that OpenOfficeServerManager component is loaded on XE startup so that it can recieve the startup notification. As a solution I tried to use <load-on-startup> components list in plexus.xml file but since OpenOfficeServerManager has a dependancy on ConfigurationSourceCollection component, it fails to load on startup. This is because ConfigurationSourceCollection requires a valid ApplicationContext to be present for it's operation but at the time plexus is loading <load-on-startup> components, no ApplicationContext is present. The core issue is, plexus is initialized before we initialize ApplicationContext; and we can't change this order either. Since the above approach is not going to work, I propose to introduce an ApplicationContextInitializer component pretty much alike RequestInitializer and ExecutionContextInitializer. The idea is to allow any component to do further initializations on ApplicationContext if they need to do so. When XE is started up and an ApplicationContext is created, ApplicationContextInitializerManager will lookup for all the components that implement ApplicationContextInitializer and let them a chance to execute their own initializations. But this doesn't solve the problem of shutdown notifications. For shutdown notifications we can either use the plain old ObservationManager component or we can do the following; rather than having ApplicationContextInitializer and ApplicationContextInitializerManager, we will have ApplicationContextListener and ApplicationContextListenerManager. ApplicationContextListener will have two methods like contextCreated() and contextDestroyed() that will allow any component to perform startup / shutdown tasks. But still, I don't see where we can invoke contextDestroyed() method from, I looked at both servlet container API and portlet container API and couldn't find a consistent way of invoking the contextDestroyed() method. Please let me know what you think about this idea. Thanks. - Asiri

2 1

[xwiki-devs] [VOTE] switching to UTF8 by default in 1.9M2
by Sergiu Dumitriu 06 May '09

06 May '09

Hi devs, We've been tackling this proposal for some time, but we never took a final decision on it. So, I propose that we do this switch as soon as possible. Changes: - default encoding UTF-8 in the start_xwiki* scripts, xwiki.cfg and web.xml - remove the LANG= environment variable from the start script, since it's not needed - add the encoding configuration for the mysql jdbc connection URL (http://dev.mysql.com/doc/refman/5.0/en/connector-j-reference-charsets.html) Implications: - hsqldb instances will continue to work fine - for mysql and other DB instances, either the DB will need to be changed to work with the new encoding, or the wiki will have to be changed back to 8859-1. If we append characterEncoding=UTF-8 to the connection URL, then the storage will throw exceptions when trying to store an incompatible character, thus admins will quickly notice the problem and solve the issue, before users report loosing characters after a while (since without this setting the characters are silently transformed to '?' and this won't be noticed until the cache expires). We need to highlight this change in the release notes and upgrade instructions. -- Sergiu Dumitriu http://purl.org/net/sergiu/

5 7

[xwiki-devs] [VOTE] XE 1.8.3
by Vincent Massol 05 May '09

05 May '09

I'm proposing to have another point release for XE 1.8.x called 1.8.3. XE 1.8.2 is planned for the 20th of April and I propose to plan 1.8.3 for two weeks after, i.e. 4th of May. As usual the goal is to include important bug fixes. The reason I think we need a 1.8.3 is because we're starting to get feedback from our new wysiwyg/new rendering and we need to bring bug fixes as fast as possible to our users without forcing them to wait for 1.9 final. Here's my +1 Thanks -Vincent

10 15

[xwiki-devs] swf in xwiki
by walido 05 May '09

05 May '09

i would like to display the swf files that i have on my disk in xwiki so copied the source code of http://enterprise.xwiki.org/xwiki/bin/view/UserGuide/EditVideo just the fragment with :<OBJECT ... <EMBED... and i changed the url of the source so i can play my swf file that i putted in the attachment but it does'nt work what should i do thank you very much -- View this message in context: http://n2.nabble.com/swf-in-xwiki-tp2795695p2795695.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

3 3

Re: [xwiki-devs] [xwiki-notifications] r19378 - in platform/core/branches/xwiki-core-1.8: xwiki-bridge/src xwiki-bridge/src/main/java/org/xwiki/bridge xwiki-bridge/src/test xwiki-bridge/src/test/java xwiki-bridge/src/test/java/org xwiki-bridge/src/te
by Thomas Mortagne 05 May '09

05 May '09

On Tue, May 5, 2009 at 12:49, Vincent Massol <vincent(a)massol.net> wrote: > > On May 5, 2009, at 12:40 PM, tmortagne (SVN) wrote: > >> Author: tmortagne >> Date: 2009-05-05 12:40:47 +0200 (Tue, 05 May 2009) >> New Revision: 19378 >> >> Added: >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/ >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ >> org/ >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ >> org/xwiki/ >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ >> org/xwiki/bridge/ >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ >> org/xwiki/bridge/DocumentNameTest.java >> Modified: >> platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/main/java/ >> org/xwiki/bridge/DocumentName.java >> platform/core/branches/xwiki-core-1.8/xwiki-core/src/main/java/com/ >> xpn/xwiki/doc/XWikiDocument.java >> platform/core/branches/xwiki-core-1.8/xwiki-core/src/test/java/com/ >> xpn/xwiki/doc/XWikiDocumentTest.java >> Log: >> XWIKI-3754: XWikiDocument.getLinkedPages loose multiwiki information > > [snip] >> >> + >> + /** >> + * {@inheritDoc} >> + * >> + * @see java.lang.Object#equals(java.lang.Object) >> + */ >> + @Override >> + public boolean equals(Object obj) >> + { >> + boolean equals = false; >> + >> + if (obj == this) { >> + equals = true; >> + } else if (obj instanceof DocumentName) { >> + DocumentName documentName = (DocumentName) obj; >> + >> + equals = >> + documentName.getWiki().equals(this.getWiki()) && >> documentName.getSpace().equals(this.getSpace()) >> + && documentName.getPage().equals(this.getPage()); >> + } >> + >> + return equals; >> + } > > You're not handling null I think. Yes but I assume DocumentName is supposed to be valid > > [snip] > > -Vincent > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

2 2

Re: [xwiki-devs] [xwiki-notifications] r19378 - in platform/core/branches/xwiki-core-1.8: xwiki-bridge/src xwiki-bridge/src/main/java/org/xwiki/bridge xwiki-bridge/src/test xwiki-bridge/src/test/java xwiki-bridge/src/test/java/org xwiki-bridge/src/test/java/org/xwiki xwiki-bridge/src/test/java/org/xwiki/bridge xwiki-core/src/main/java/com/xpn/xwiki/doc xwiki-core/src/test/java/com/xpn/xwiki/doc
by Vincent Massol 05 May '09

05 May '09

On May 5, 2009, at 12:40 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-05-05 12:40:47 +0200 (Tue, 05 May 2009) > New Revision: 19378 > > Added: > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/ > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ > org/ > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ > org/xwiki/ > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ > org/xwiki/bridge/ > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/test/java/ > org/xwiki/bridge/DocumentNameTest.java > Modified: > platform/core/branches/xwiki-core-1.8/xwiki-bridge/src/main/java/ > org/xwiki/bridge/DocumentName.java > platform/core/branches/xwiki-core-1.8/xwiki-core/src/main/java/com/ > xpn/xwiki/doc/XWikiDocument.java > platform/core/branches/xwiki-core-1.8/xwiki-core/src/test/java/com/ > xpn/xwiki/doc/XWikiDocumentTest.java > Log: > XWIKI-3754: XWikiDocument.getLinkedPages loose multiwiki information [snip] > > + > + /** > + * {@inheritDoc} > + * > + * @see java.lang.Object#equals(java.lang.Object) > + */ > + @Override > + public boolean equals(Object obj) > + { > + boolean equals = false; > + > + if (obj == this) { > + equals = true; > + } else if (obj instanceof DocumentName) { > + DocumentName documentName = (DocumentName) obj; > + > + equals = > + documentName.getWiki().equals(this.getWiki()) && > documentName.getSpace().equals(this.getSpace()) > + && documentName.getPage().equals(this.getPage()); > + } > + > + return equals; > + } You're not handling null I think. [snip] -Vincent

1 0

[xwiki-devs] Buh bye XWiki
by Ancuta Maria Gheorghe 05 May '09

05 May '09

Hello, Because of personal reasons i decided not to continue contributing to XWiki development. Thanks a lot for all your guidance and a wish you good luck in everything, it was really nice being part of this community ! With great respect, Ancuta

1 0