January 2010 - xwiki-devs@xwiki.org

[xwiki-devs] XWiki Application Merger Maven Plugin
by Andreas Schaefer 25 Jan '10

25 Jan '10

Hi Guys I updated my Maven Plugin that takes Code / Content of Pages and Objects and places it into the XML files which then can be packed up into a XAR. The plugin uses the same File Name Pattern as the IntelliJ Plugin for the Content Files: - Page: <Page Name>.<Extension> - Object: <Page Name>.<Class Space>.<Class Name>.<Object Number>.<Property Name>.<Extension> The Content Files can contain anything like Velocity, Groovy, JavaScript, CSS etc. There can be multiple Content Files per target XML file but the XML file must be present in the source directory. If there is not Content File the XML file will be written to the target file w/o transformation otherwise any Page Content or Object Property will be replaced with the content of the Content File. The XML files can be taken straight from an export or from the source application w/o any adjustments. Let me know if that would be of some help for XWiki. -Andy

3 8

[xwiki-devs] [Proposal] Add LiveValidate Javascript library for validating form fields.
by Caleb James DeLisle 24 Jan '10

24 Jan '10

My registration template provides the option of client side validation using the LiveValidate library. In order to turn this functionality on by default we would have to bundle the library with XWiki. The library is licensed under the MIT license: http://livevalidation.com/license and weighs in at 12.5KB when minified. I would like to add: resources/js/yui/livevalidation/livevalidation_prototype.compressed.js and a stylesheet which was posted to the incubator by Jerome Velociter resources/js/yui/livevalidation/livevalidation_style.css Caleb James DeLisle

5 13

[xwiki-devs] [VOTE] Remove the xwiki-core captcha plugin and add $captchaservice VelocityContextInitializer
by Caleb James DeLisle 24 Jan '10

24 Jan '10

I am adding a new captcha component, it uses jcaptcha-2.0-alpha1 and supports image captchas and sound captchas (freetts jars must be added for sound captcha support) There is a captcha plugin in xwiki-core which makes the core depend on jcaptcha-all-1.0-RC3. jcaptcha-all-1.0-RC3 causes conflicts when getting classes from jcaptcha-2.0. The plugin in querstion: http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/… Here's my +1 for removing it entirely, breaking backward compatibility, lightening xwiki-core, and making the core no longer depend on jcaptcha. You may review a patch for removing the plugin here: http://jira.xwiki.org/jira/secure/attachment/16508/XWIKI-4779-removeJcaptch… To provide velocity access to the captcha component for checking the results of the captcha, I would like to add a VelocityContextInitializer which will add a binding called $captchaservice which will provide 3 methods: /** * If this is false, the captcha system will still work. * It is for velocity scripts to determine whether captchas are needed. * * @return Is the captcha service enabled in the configuration. */ boolean isEnabled() /** @return a List of the names of all registered classes implementing {@link org.xwiki.captcha.CaptchaVerifier}. */ public List<String> listCaptchaNames() /** * Get a {@link org.xwiki.captcha.CaptchaVerifier} from the service. * * @param captchaName The name of the type of captcha, use {@link #listCaptchaNames()} for a list * @return A captcha object which can be used to check a specific answer for a given challange * @throws Exception If the named captcha doesn't exist. */ public CaptchaVerifier getCaptchaVerifier(String captchaName) throws Exception I realize throwing an Exception to velocity always results in a stack trace but I see it as the lesser evil to returning a non-functional CaptchaVerifier which always returns false. Also I see no use case where the name of the captcha is not given in hardcoded velocity so this Exception is only for the velocity developers. Here's my +1 for adding this as well. Caleb James DeLisle

4 7

[xwiki-devs] To remove old captcha plugin, must remove line from xwiki.cfg for workspaces, any problem?
by Caleb James DeLisle 24 Jan '10

24 Jan '10

I just wanted to double check, I know Jerome is on vacation but I wanted to see if anyone had a problem with me removing the reference to the old jcaptcha plugin from workspaces xwiki.cfg. It is used in RegistrationService but is turned off by default. I can get to implementing the new captcha system there later. For the moment does anyone have any problem with me removing the plugin line from the configuration file? Caleb

2 2

Re: [xwiki-devs] [xwiki-notifications] r26317 - in platform/core/trunk/xwiki-core/src/main: aspect/compatibility/com/xpn/xwiki/doc java/com/xpn/xwiki/doc
by Vincent Massol 23 Jan '10

23 Jan '10

On Jan 23, 2010, at 7:27 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-01-23 19:27:50 +0100 (Sat, 23 Jan 2010) > New Revision: 26317 > > Modified: > platform/core/trunk/xwiki-core/src/main/aspect/compatibility/com/xpn/xwiki/doc/XWikiDocumentCompatibilityAspect.aj > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java > Log: > XWIKI-4784: Make xwiki-core works without aspectJ [snip] > > - //ÊIf the parent is not set in the current document set the template parent as the parent. > + //ï¿∏If the parent is not set in the current document set the template parent as the parent. Problem here. Thanks -Vincent > if (getParentReference() == null) { > setParentReference(templatedoc.getParentReference()); > }

2 1

[xwiki-devs] text formatting
by alyssaloren 23 Jan '10

23 Jan '10

Hi! Can someone please help me? I'm looking for the package or part of the XWiki code where I can apply the XWiki Syntax v2.0. I would like to format the text that would appear on the screen and I can't seem to find the code that does that. Please help. example: i'll get the contents of a page through getPage() and getContents() then in another class, i'll enclosed the contents with the xwiki syntax for highlighting the text then save it back so when a user views the page, he will see the highlighted text. Thank you in advance! -- View this message in context: http://n2.nabble.com/text-formatting-tp4438830p4438830.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

2 3

[xwiki-devs] [Proposal] Make the rewritten registration page an application rather than a template.
by Caleb James DeLisle 23 Jan '10

23 Jan '10

I would like to make the new registration page an application because it will make it much easier for the wiki administrator to add fields because the code has to have the right to save information which is passed to it. It is also very big, about 300 lines of code and 300 lines of configuration and comments. Something this size doesn't seem suited for the templates directory. Finally it is highly extendable. It contains a large configuration which defines all of it's fields because it is meant to be edited and have more fields added. I think placing it in the templates section would put it where wiki administrators would not have such easy access to it. Available here are the current velocity template and the (slightly older) syntax2.0 code snippet http://jira.xwiki.org/jira/browse/XWIKI-4778 Caleb

3 3

Re: [xwiki-devs] [xwiki-notifications] r26312 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store
by Sergiu Dumitriu 23 Jan '10

23 Jan '10

On 01/22/2010 07:38 PM, cjdelisle (SVN) wrote: > Author: cjdelisle > Date: 2010-01-22 19:38:30 +0100 (Fri, 22 Jan 2010) > New Revision: 26312 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > Log: > XWIKI-4754 parameterize query in getTranslationList > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-22 17:49:40 UTC (rev 26311) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-22 18:38:30 UTC (rev 26312) > @@ -3024,11 +3024,12 @@ > > public List<String> getTranslationList(XWikiDocument doc, XWikiContext context) throws XWikiException > { > - String hql = > - "select doc.language from XWikiDocument as doc where doc.space = '" + Utils.SQLFilter(doc.getSpace()) > - + "' and doc.name = '" + Utils.SQLFilter(doc.getName()) > - + "' and (doc.language<> '' or (doc.language is not null and '' is null))"; > - List<String> list = context.getWiki().search(hql, context); > + String hql = "select doc.language from XWikiDocument as doc where doc.space = ? and doc.name = ? " > + + "and (doc.language<> '' or (doc.language is not null and '' is null))"; doc.space and doc.name are explicitly used for historical reasons (in the beginning doc.fullName was not stored in the database). For better performance we could just use doc.fullName = ?. > + ArrayList<String> params = new ArrayList<String>(); > + params.add(doc.getSpace()); > + params.add(doc.getName()); > + List<String> list = search(hql, 0, 0, params, context); > return (list == null) ? new ArrayList<String>() : list; > } -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 3

Re: [xwiki-devs] [xwiki-notifications] r26311 - in platform/core/trunk/xwiki-core/src/main: java/com/xpn/xwiki/plugin/packaging resources
by Vincent Massol 22 Jan '10

22 Jan '10

On Jan 22, 2010, at 7:08 PM, Jerome Velociter wrote: > vmassol (SVN) wrote: >> Author: vmassol >> Date: 2010-01-22 18:49:40 +0100 (Fri, 22 Jan 2010) >> New Revision: 26311 >> >> Modified: >> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java >> platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> Log: >> XWIKI-4774: Importer should add a version comment when saving documents when importing >> >> Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java >> =================================================================== >> --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java 2010-01-22 17:15:11 UTC (rev 26310) >> +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java 2010-01-22 17:49:40 UTC (rev 26311) >> @@ -30,6 +30,7 @@ >> import java.io.OutputStream; >> import java.io.StringWriter; >> import java.util.ArrayList; >> +import java.util.Arrays; >> import java.util.Date; >> import java.util.HashMap; >> import java.util.List; >> @@ -645,7 +646,8 @@ >> xa.getAttachment_content().setContentDirty(false); >> } >> >> - context.getWiki().saveDocument(doc.getDoc(), context); >> + String saveMessage = context.getMessageTool().get("core.importer.saveDocumentComment"); >> + context.getWiki().saveDocument(doc.getDoc(), saveMessage, context); >> doc.getDoc().saveAllAttachments(false, true, context); >> addToInstalled(doc.getFullName() + ":" + doc.getLanguage(), context); >> >> >> Modified: platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties >> =================================================================== >> --- platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2010-01-22 17:15:11 UTC (rev 26310) >> +++ platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties 2010-01-22 17:49:40 UTC (rev 26311) >> @@ -510,6 +510,7 @@ >> core.importer.select=select >> core.importer.selectAll=all >> core.importer.selectNone=none >> +core.importer.saveDocumentComment=Imported from XAR > > Maybe we could add package name & version, WDYT ? I thought about it but for now I wanted to do the simplest thing that would work. I'm ok to add package name + version. Thanks -Vincent > Jerome. > >> >> registerwelcome=Welcome to the registration form. This will allow you to edit pages, once the admin gives you appropriate rights >> email=e-Mail address >> @@ -669,7 +670,10 @@ >> >> tempdirnotset=Temporary directory not set. Please follow the instructions on <a href="http://www.xwiki.org/xwiki/bin/view/FAQ/WhyAmIGettingANullPointerExceptionW…">xwiki.org</a> on how to fix this. >> >> -# comments for history >> +# Comments for history >> +# Note: These keys should be moved to their domains. >> +# For example the comment messages for the XAR importer are in core.importer.* keys. >> +# TODO: Do the same for the other keys >> core.comment=Comment >> core.comment.prompt=Enter a comment describing your changes >> core.comment.addComment=Added comment

1 0

[xwiki-devs] [VOTE] Add Ecaterina Valica as a committer
by Sergiu Dumitriu 21 Jan '10

21 Jan '10

Hi devs, I'd like to propose Ecaterina Valica as a committer on XE, skins and applications. Ecaterina has been doing a good job moving XWiki towards better and more consistent UIs. I've been applying her patches for the last months, and lately I believe that the quality is good, and they do not need major changes anymore. This would really speed up resolving skin issues and improvements. Here's my +1. Disclaimer: Ecaterina is working for XWiki SAS. For more details on the XWiki project and XWiki SAS see http://massol.myxwiki.org/xwiki/bin/view/Blog/XWikiSASAndOpenSource -- Sergiu Dumitriu http://purl.org/net/sergiu/

9 12