xwiki-devs January 2010

xwiki-devs@xwiki.org

38 participants
107 discussions

[xwiki-devs] Configuration for velocity applications

by Caleb James DeLisle

Hello all, I have been working on a registration application which is written entirely in velocity and I want to specify some configurations for it such as should captchas be required or should LiveValidation be enabled. This is just an example and I'm sure there are and will be more velocity applications which need to be configured. The problem is that ConfigurationSource is unavailable to velocity applications and a few possible solutions include: Put the configuration in the XWiki.XWikiPreferences object and get it using XWiki.Param This is nice because preferences for applications which are in the database should also be in the database IMO. However it negates the ConfigurationSource, making configuration less portable and it also introduces the need for programming rights to save the document. Add a configuration class to get the parameters from ConfigurationSource and pass them to the velocity application. Vincent has -1'd the idea of having a generic configuration getter like XWiki.Param and writing a java class for each application defeats the purpose of writing code as an XAR application. Another idea is to put the configuration inside the (registration) application and load the registration document in the relevant section of the administration application. The best way to do this would be to define a class and the administration app includes any document containing an object of that class. This way any application which needed configuration could be configured from one place and it wouldn't require a reference for each one. I'd like to hear any other ideas anyone has, Caleb

14 years, 10 months

[xwiki-devs] [ANN] XWiki Enterprise 2.2 Milestone 2 Released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise 2.2 Milestone 2. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download Changes from 2.2 Milestone 1: * New improved registration page * New UI for edit mode * Support for color theme in HTML export * Improved speed and responsiveness of the WYSIWYG editor * Comments UI improvements * Upgraded to GWT 2.0.0 * Lots of bugs fixes For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise22M1 Thanks -The XWiki dev team

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26514 - platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal

by Sergiu Dumitriu

On 01/28/2010 12:59 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-01-28 12:59:59 +0100 (Thu, 28 Jan 2010) > New Revision: 26514 > > Modified: > platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java > Log: > XWIKI-4800: Fix warnings appearing in the logs when importing a XAR > > Modified: platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java > =================================================================== > --- platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java 2010-01-28 11:18:19 UTC (rev 26513) > +++ platform/core/trunk/xwiki-cache/xwiki-cache-jbosscache/src/main/java/org/xwiki/cache/jbosscache/internal/JBossCacheCache.java 2010-01-28 11:59:59 UTC (rev 26514) > @@ -195,8 +195,12 @@ You used LOG.warn in nodeEvicted and LOG.info in nodeRemoved. Shouldn't they use the same log level? > public void nodeEvicted(NodeEvictedEvent event) > { > if (!event.getFqn().isChildOf(ROOT_FQN)) { > - if (LOG.isInfoEnabled()) { > - LOG.info(MessageFormat.format("The node {0} should not has been evicted", event.getFqn())); > + if (!event.getFqn().equals(ROOT_FQN)) { > + LOG.warn(MessageFormat.format( > + "The [{0}] node has been evicted but it should not even have been part of the cache", > + event.getFqn())); > + } else { > + LOG.debug("The entire cache has been evicted"); > } > > return; > @@ -216,8 +220,12 @@ > public void nodeRemoved(NodeRemovedEvent event) > { > if (!event.getFqn().isChildOf(ROOT_FQN)) { > - if (LOG.isInfoEnabled()) { > - LOG.info(MessageFormat.format("The node {0} should not has been removed", event.getFqn())); > + if (!event.getFqn().equals(ROOT_FQN)) { > + LOG.info(MessageFormat.format( > + "The [{0}] node has been removed but it should not even have been part of the cache", > + event.getFqn())); > + } else { > + LOG.debug("The entire cache has been removed"); > } > > return; -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 10 months

Re: [xwiki-devs] [VOTE] Edit UI improvements and panelless edit

by Raluca Stavro

On Mon, Jan 25, 2010 at 10:37 PM, Sergiu Dumitriu <sergiu(a)xwiki.com> wrote: > Hi devs, > > We've been working on improving the editors (content, class, object), > and now I have some pretty important UI changes to commit, but not > everybody seems to agree with them, so I bring up a vote. > > The whole improvements can be seen on > http://incubator.myxwiki.org/xwiki/bin/Improvements/ImprovedEdit > > Here are the individual voted points: > > 0 Remove all panels in edit mode +1 > > 1a Parent and title above the content in wiki/wysiwyg mode > > 1b The same style in edit mode as in view mode for the parent/title fields > > 1c AJAX Suggest for the parent field +1 for all > > 2a New label for the content textarea ("Content") > > 2b List of included documents after the Content label > > 3a Syntax switcher in the top right corner of the content > > 3b Syntax help in the top right corner of the content > > 3c Syntax help and switcher only in the wiki editor +1 for all > > 4 Better label for the version comment > big +1 > 5a Right float the Minor edit field > > 5b Put the Minor edit label after the checkbox > +1 for both > 6 Move autosave in line with the submit buttons > +1, but aligned on the right side > 7 Introduce new AJAX-powered Add Object > i) above the objects > ii) bellow the objects +1 for i) > > 8 Introduce new AJAX-powered Add Object from this class > i) at the top of the list of existing objects > ii) at the end of the list +1 for i) > > 9 Move the class switcher in the top right corner > > 9b Remove the class switcher > +1 (I never needed it - and I do work with class editors quite often) > 10 Introduce new AJAX-powered Add Property > i) at the top of the list of properties > ii) at the end of the list > +1 for i) Note: I voted for 7 i), 8 i) and 10 i) to keep consistency. Nice job! Raluca. > > I vote +1 for all of the above, except 9b (-0), and with options 7i), > 8ii), and 10ii) > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

14 years, 10 months

[xwiki-devs] [UX] Delete space menu action

by Vincent Massol

Hi, WDYT about a delete space action in the space action menu? Seems like it' a basic need from the questions we get about how to do this. We would display all docs in the space on the delete page and ask extra confirmation. Thanks -Vincent

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26429 - enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium

by Vincent Massol

On Jan 27, 2010, at 11:38 AM, cjdelisle (SVN) wrote: > Author: cjdelisle > Date: 2010-01-27 11:38:03 +0100 (Wed, 27 Jan 2010) > New Revision: 26429 > > Modified: > enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java > Log: > XAWATCHLIST-97: Selenium test failing after upgrade from old XWiki.WatchListManager - Removed all references to XWiki.WatchListManager. > > Modified: enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java > =================================================================== > --- enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java 2010-01-27 09:18:49 UTC (rev 26428) > +++ enterprise/trunk/distribution-test/selenium-tests/src/test/it/com/xpn/xwiki/it/selenium/WatchListTest.java 2010-01-27 10:38:03 UTC (rev 26429) > @@ -56,13 +56,6 @@ > { > // Stop GreenMail test server > this.greenMail.stop(); > - > - // Restore XWiki.WatchListManager from the trash since it's been deleted by the tests below. > - open("XWiki", "WatchListManager"); > - if (isElementPresent("link=Restore")) { > - clickLinkWithLocator("link=Restore"); > - assertTextPresent("Watchlist for Administrator"); > - } > } > > public void testWatchThisPageAndWholeSpace() throws Exception > @@ -93,9 +86,6 @@ > open("XWiki", "WatchListMessage", "edit", "editor=object"); > assertTextPresent("Mail 0:"); > > - // Test if the watchlist manager document exists > - assertTrue("Page XWiki.WatchListManager doesn't exist", isExistingPage("XWiki", "WatchListManager")); > - > // Watch Test.TestWatchThisPage > createPage("Test", "TestWatchThisPage", "TestWatchThisPage selenium"); > clickLinkWithText("Watch", false); > @@ -109,9 +99,15 @@ > assertTextPresent("TestWatchThisPage"); > assertTextPresent("TestWatchWholeSpace"); > > + // Click on the inline edit button > + clickLinkWithLocator("xpath=//a[@id='tmEditInline']"); > + > + // Click the watchlist button because it forgets that we are at the watchlist, no new page loads so we don't wait. > + clickLinkWithLocator("xpath=//li[@id='watchlistTab']/a", false); > + > // Ensure the frequency set is every hour so that Hourly job we've modified is used > - getSelenium().select("XWiki.WatchListClass_0_interval", "label=Scheduler.WatchListDailyNotifier"); > - clickLinkWithXPath("//input[@value='Save']", true); > + getSelenium().select("XWiki.WatchListClass_0_interval", "value=Scheduler.WatchListDailyNotifier"); > + clickEditSaveAndView(); > > // Trigger the notification > open("Scheduler", "WebHome"); > @@ -130,10 +126,5 @@ > clickLinkWithXPath("//div[@id='xobject_XWiki.XWikiPreferences_0_title']", false); > setFieldValue("XWiki.XWikiPreferences_0_smtp_port", "25"); > clickEditSaveAndView(); > - > - // XWIKI-2125 > - // Verify that the Watchlist menu entry is not present if XWiki.WatchListManager does not exists > - deletePage("XWiki", "WatchListManager"); > - assertTextNotPresent("Manage your watchlist"); Not very urgent right now but we may want to not have a watchlist tab in the user profile if the watchlist sheet page doesn't exist. In the future I think this will be an Interface Extension in the user profile so that apps can contribute new tabs and the watchlist will be a separate app. Thanks -Vincent

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26408 - in platform/core/trunk/xwiki-core/src/main: java/com/xpn/xwiki/user/impl/LDAP java/com/xpn/xwiki/user/impl/xwiki resources

by Sergiu Dumitriu

On 01/26/2010 03:20 PM, vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-26 15:20:55 +0100 (Tue, 26 Jan 2010) > New Revision: 26408 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/AbstractXWikiAuthService.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > Log: > XWIKI-2261: Don't give password hints Actually I would leave the nousername/nopassword messages, since this is a known fact that doesn't give any hints about the existence of the user. > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-01-26 14:14:24 UTC (rev 26407) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/LDAP/XWikiLDAPAuthServiceImpl.java 2010-01-26 14:20:55 UTC (rev 26408) > @@ -115,7 +115,7 @@ > > // Check for empty usernames > if (login.equals("")) { > - context.put("message", "nousername"); > + context.put("message", "invalidcredentials"); > > if (LOG.isDebugEnabled()) { > LOG.debug("LDAP authentication failed: login empty"); > @@ -126,7 +126,7 @@ > > // Check for empty passwords > if ((password == null) || (password.trim().equals(""))) { > - context.put("message", "nopassword"); > + context.put("message", "invalidcredentials"); > > if (LOG.isDebugEnabled()) { > LOG.debug("LDAP authentication failed: password null or empty"); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java 2010-01-26 14:14:24 UTC (rev 26407) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java 2010-01-26 14:20:55 UTC (rev 26408) > @@ -423,13 +423,13 @@ > > // Check for empty usernames > if (cannonicalUsername.equals("")) { > - context.put("message", "nousername"); > + context.put("message", "invalidcredentials"); > return null; > } > > // Check for empty passwords > if ((password == null) || (password.trim().equals(""))) { > - context.put("message", "nopassword"); > + context.put("message", "invalidcredentials"); > return null; > } > -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26271 - in platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki: . objects objects/classes store

by Caleb James DeLisle

When users are added to the XWikiAllGroup, the class which is created is called Main.WebHome instead of XWiki.XWikiGroupClass testwiki=> select baseobject0_.XWO_CLASSNAME, stringprop1_.XWS_VALUE as col_0_0_ from xwikiobjects baseobject0_, xwikistrings stringprop1_ inner join xwikiproperties stringprop1_1_ on stringprop1_.XWS_ID=stringprop1_1_.XWP_ID and stringprop1_.XWS_NAME=stringprop1_1_.XWP_NAME where baseobject0_.XWO_NAME='XWiki.XWikiAllGroup' and baseobject0_.XWO_ID=stringprop1_.XWS_ID and (trim(both from stringprop1_.XWS_VALUE)<>'' or (trim(both from stringprop1_.XWS_VALUE) is not null) and ('' is null)); xwo_classname | col_0_0_ -------------------+----------------- XWiki.XWikiGroups | XWiki.Admin Main.WebHome | XWiki.JohnSmith Main.WebHome | XWiki.meme (3 rows) That is why the createAndDeleteUser test is failing http://hudson.xwiki.org/job/xwiki-product-enterprise-tests/com.xpn.xwiki.pr… Caleb vmassol (SVN) wrote: > Author: vmassol > Date: 2010-01-21 09:25:54 +0100 (Thu, 21 Jan 2010) > New Revision: 26271 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > Log: > XWIKI-4753: Refactor old model to use the new Entity Reference classes > > * More deprecation removal + added @deprecated annotations for BaseClass/BaseObject's get/SetName() to find places where they shouldn't be used > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -3796,10 +3796,10 @@ > XWikiDocument groupDoc = getDocument(groupName, context); > > BaseObject memberObject = (BaseObject) groupClass.newObject(context); > - memberObject.setClassName(groupClass.getName()); > - memberObject.setName(groupDoc.getFullName()); > + memberObject.setXClassReference(groupClass.getXClassReference()); > + memberObject.setDocumentReference(groupDoc.getDocumentReference()); > memberObject.setStringValue("member", userName); > - groupDoc.addObject(groupClass.getName(), memberObject); > + groupDoc.addXObject(groupClass.getDocumentReference(), memberObject); > if (groupDoc.isNew()) { > saveDocument(groupDoc, context.getMessageTool().get("core.comment.addedUserToGroup"), context); > } else { > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseObject.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -42,6 +42,26 @@ > private String guid = UUID.randomUUID().toString(); > > /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #getDocumentReference()} > + */ > + @Deprecated > + @Override public String getName() > + { > + return super.getName(); > + } > + > + /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #setDocumentReference(org.xwiki.model.reference.DocumentReference)} > + */ > + @Deprecated > + @Override public void setName(String name) > + { > + super.setName(name); > + } > + > + /** > * {@inheritDoc} > * > * @see com.xpn.xwiki.objects.BaseCollection#hashCode() > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -76,6 +76,26 @@ > private String nameField; > > /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #getDocumentReference()} > + */ > + @Deprecated > + @Override public String getName() > + { > + return super.getName(); > + } > + > + /** > + * Note: This method is overridden to add the deprecation warning so that code using is can see it's deprecated. > + * @deprecated since 2.2M2 use {@link #setDocumentReference(org.xwiki.model.reference.DocumentReference)} > + */ > + @Deprecated > + @Override public void setName(String name) > + { > + super.setName(name); > + } > + > + /** > * {@inheritDoc} > * <p> > * This insures natural ordering between properties. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-21 08:20:26 UTC (rev 26270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java 2010-01-21 08:25:54 UTC (rev 26271) > @@ -491,8 +491,8 @@ > } > > // Verify if the document already exists > - Query query = > - session.createQuery("select xwikidoc.id from XWikiDocument as xwikidoc where xwikidoc.id = :id"); > + Query query = session.createQuery( > + "select xwikidoc.id from XWikiDocument as xwikidoc where xwikidoc.id = :id"); > query.setLong("id", doc.getId()); > if (query.uniqueResult() == null) { > session.save(doc); > @@ -503,16 +503,16 @@ > } > > // Remove objects planned for removal > - if (doc.getObjectsToRemove().size() > 0) { > - for (BaseObject removedObject : doc.getObjectsToRemove()) { > + if (doc.getXObjectsToRemove().size() > 0) { > + for (BaseObject removedObject : doc.getXObjectsToRemove()) { > deleteXWikiObject(removedObject, context, false); > } > - doc.setObjectsToRemove(new ArrayList<BaseObject>()); > + doc.setXObjectsToRemove(new ArrayList<BaseObject>()); > } > > // We should only save the class if we are using the class table mode > if (bclass != null) { > - bclass.setName(doc.getFullName()); > + bclass.setDocumentReference(doc.getDocumentReference()); > if ((bclass.getFieldList().size() > 0) && (useClassesTable(true, context))) { > saveXWikiClass(bclass, context, false); > } > @@ -525,18 +525,14 @@ > // migrate values of list properties > if (prop instanceof StaticListClass || prop instanceof DBListClass) { > ListClass lc = (ListClass) prop; > - String[] classes = > - {DBStringListProperty.class.getName(), StringListProperty.class.getName(), > - StringProperty.class.getName()}; // @see > - // ListClass#newProperty() > + String[] classes = { DBStringListProperty.class.getName(), StringListProperty.class.getName(), > + StringProperty.class.getName()}; // @see ListClass#newProperty() > for (int i = 0; i < classes.length; i++) { > String oldclass = classes[i]; > if (!oldclass.equals(lc.newProperty().getClass().getName())) { > - Query q = > - session.createQuery( > - "select p from " + oldclass + " as p, BaseObject as o" + " where o.className=?" > - + " and p.id=o.id and p.name=?").setString(0, bclass.getName()).setString( > - 1, lc.getName()); > + Query q = session.createQuery("select p from " + oldclass + " as p, BaseObject as o" > + + " where o.className=? and p.id=o.id and p.name=?").setString(0, > + bclass.getName()).setString(1, lc.getName()); > for (Iterator it = q.list().iterator(); it.hasNext();) { > BaseProperty lp = (BaseProperty) it.next(); > BaseProperty lp1 = lc.newProperty(); > @@ -609,7 +605,7 @@ > for (List<BaseObject> objects : doc.getXObjects().values()) { > for (BaseObject obj : objects) { > if (obj != null) { > - obj.setName(doc.getFullName()); > + obj.setDocumentReference(doc.getDocumentReference()); > /* If the object doesn't have a GUID, create it before saving */ > if (StringUtils.isEmpty(obj.getGuid())) { > obj.setGuid(UUID.randomUUID().toString()); > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

14 years, 10 months

[xwiki-devs] [VOTE] Upgrade to GWT 2.0 before 2.2M2 release

by Marius Dumitru Florea

Hi devs, I'd like to upgrade platform/web to GWT 2.0 before the 2.2M2 release. Even if the WYSIWYG users won't notice any difference (maybe a small decrease in loading time and a small increase in responsiveness dues to compiler optimizations) this upgrade will help ease the development. You can find the detailed release notes at http://code.google.com/webtoolkit/doc/latest/ReleaseNotes.html . I'm most interested in: * ability to run the unit tests on the build server (a 32-bit JVM isn't needed anymore, finally, since the tests are run by default with HtmlUnit) * ability to run and debug the Java code directly in the browser (new development mode using a FF plugin) * ability to split the code and load it on demand In order to upgrade I need http://google-web-toolkit-incubator.googlecode.com/files/gwt-incubator-2009… in our maven repo: mvn install:install-file -Dfile=gwt-incubator-20091216-r1739.jar -DgroupId=com.google.gwt -DartifactId=gwt-incubator -Dversion=20091216-r1739 -Dpackaging=jar Who can help me with that? All unit and integration tests pass locally so here's my +1. Thanks, Marius

14 years, 10 months

Re: [xwiki-devs] [xwiki-notifications] r26407 - in platform: core/trunk/xwiki-core/src/main/resources web/trunk/standard/src/main/webapp/templates

by Sergiu Dumitriu

On 01/26/2010 03:14 PM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2010-01-26 15:14:24 +0100 (Tue, 26 Jan 2010) > New Revision: 26407 > > Modified: > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > platform/web/trunk/standard/src/main/webapp/templates/imported.vm > Log: > XWIKI-4796 When importing XE XAR from an empty database, the import result is not properly displayed > Modified: platform/web/trunk/standard/src/main/webapp/templates/imported.vm > =================================================================== > +#else > + ## If the current user does not have admin and this template is being displayed > + ## it means security settings have been changed with the import (probably a defaut XE XAR import) > + ## We display a warning and invite the user to log in to further administrate the wiki What if the user was logged in, but now has fewer rights? Minor: you don't need the "" around the message, since it's a single string result which can be passed to the macro. > + #warning("$msg.get('core.importer.securitySettingsChanged', [$xwiki.getURL('XWiki.XWikiLogin', 'login')])") > +#end > \ No newline at end of file -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 10 months

← Newer
1
2
3
4
5
6
7
...
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs January 2010