April 2010 - xwiki-devs@xwiki.org

[xwiki-devs] [Proposal] Define our security requirements.
by Caleb James DeLisle 06 May '10

06 May '10

It might sound silly but if there are no security requirements then there are no security holes. We all know when we see something which shouldn't happen but I don't think there is any page defining exactly what the security requirements are. 1. Users should not be able to spawn additional processes on the server. 2. Users should not be able to commit changes to the database except through the saveDocument function. 3. Users should not be able to save documents without their name as the author or contentAuthor as applicable. 4. Guests should not be able to execute server side script except that which was written and saved by a user. This list is doesn't cover much yet, I hope to see some additions and discussion of may code may violate some the rules as well as how we can have 'untrusted' code which is unable to violate the rules. I propose we put up a design page for maintenance of this list. WDYT? Caleb

4 5

[xwiki-devs] SVN Application for XWiki
by Ludovic Dubost 03 May '10

03 May '10

Hi, If you are following the xwiki comments, you might have seen that I've been working on an SVN application for XWiki. I've published this application here: http://code.xwiki.org/xwiki/bin/view/Applications/SVNApplication The objective of this application is to bring to XWiki Applications more professional development practices. One of them is the ability to do version management of XWiki applications. Of course XWiki contains versioning but this versioning does not apply accross wikis and makes it difficult to contribute code back to the community. With the SVN application you can now directly contribute code and code updates to the XWiki SVN contrib repository or to any other SVN repository. You can even commit in multiple SVN repositories in the same Wiki. The SVN Application supports: 1/ Compare the Wiki (limited to a list of spaces) with the SVN repository listing - added pages in the wiki - modified pages in the wiki - new pages in SVN - modified pages in SVN - conflicting pages modified in both SVN and the Wiki 2/ Commit in the SVN Repository 3/ Update from the SVN Repostory 4/ Show differences between SVN and the Wiki (in XML) The SVN Application does not provide merging and conflict resolution. The SVN Application normalizes XWiki XML allowing the cleanup the XML to not have the user, the dates, comments. This is necessary to provide concurrent development on multiple XWiki server without telling you that the pages have changed all the time. The source code is of course in SVN at http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-svn/ Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

4 5

Re: [xwiki-devs] [xwiki-notifications] r28664 - platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/table
by Sergiu Dumitriu 29 Apr '10

29 Apr '10

On 04/29/2010 05:21 PM, dgervalle (SVN) wrote: > Author: dgervalle > Date: 2010-04-29 17:21:25 +0200 (Thu, 29 Apr 2010) > New Revision: 28664 > > Modified: > platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/table/livetable.js > Log: > XWIKI-5135 - Highlight applied filters in livetable > Fix tag names comparison to uppercase string. > > Modified: platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/table/livetable.js > =================================================================== > --- platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/table/livetable.js 2010-04-29 13:13:38 UTC (rev 28663) > +++ platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/table/livetable.js 2010-04-29 15:21:25 UTC (rev 28664) > @@ -698,7 +698,7 @@ > * Apply style to livetable filters that are applied > */ > applyActiveFilterStyle: function(element) { > - if(element&& ((element.tagName == "input"&& element.type == "text") || element.tagName == "select")) { > + if(element&& ((element.tagName == "INPUT"&& element.type == "text") || element.tagName == "SELECT")) { That's not quite correct. Depending on the browser, doctype and mimetype, it could be lowercase. Better use some case insensitive comparison, for example: element.tagName.toLowerCase() == "input" > if ($F(element) != '') { > element.addClassName('xwiki-livetable-filter-active'); > } else { -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 2

[xwiki-devs] [Security Advisory] SQL injection issue.
by Caleb James DeLisle 29 Apr '10

29 Apr '10

In the 2.3 timeframe, a serious security bug was fixed. Hibernate treats backslashes differently from some database management systems and as a result native SQL can be injected through the searchDocuments function. This means members of a wiki can finish an SQL query, also this means that badly written searchDocuments or search queries go from small security issues to larger ones. NOTE: Passwords are hashed (encrypted) so they cannot easily be read from the database. Who's at risk? Database systems which treat backslash as an escape character and allow stacked queries are susceptible to arbitrary SELECT, INSERT, UPDATE, DELETE, and DROP statements. These include: MS-SQL Postgres Database systems which treat backslash as an escape character but disallow stacked queries are susceptible only to arbitrary SELECT statements. These include: MySql Oracle Database systems which do not treat backslash as an escape character are not vulnerable these include: HSQLDB (default XWiki zip/exe installation) You can get a small groovy snippet to test your database and see if it supports stacked queries here: http://dev.xwiki.org/xwiki/bin/view/Drafts/SecuringXWiki#HMitigationMethods… What can be done: #1: XWiki-2.3 and XWiki-2.2.6 Are patched to convert \ to \\ in search queries so upgrading to them will negate the threat. You can download them here: http://www.xwiki.org/xwiki/bin/Main/Download #2: If you compile your own branch of XWiki and are unable to upgrade, you can integrate the patch which was used to fix the problem The patch is here: http://dev.xwiki.org/xwiki/bin/download/Drafts/SecuringXWiki/XWIKI%2D4755%2… Since the database controller has changed, you will likely have to port this patch to your version, what's important is that api.XWiki.searchDocuments and api.XWiki.search have their input filtered. #3: You can and should make sure to log unexpected SQL at the database level. XWiki doesn't usually use the backslash character and queries containing backslashes should be logged specially. Also it is a good idea to log (or block if possible) any SQL comment syntax. Hibernate does not support comments and comment syntax is central to almost all SQL injection. Caleb

1 0

[xwiki-devs] [ANN] XWiki Enterprise and XWiki Enterprise Manager 2.2.6 Released
by Denis Gervalle 28 Apr '10

28 Apr '10

The XWiki development team is pleased to announce the release of XWiki Enterprise and XWiki Enterprise Manager 2.2.6. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is a bug fix release for the 2.2 branches. Fixes since 2.2.5: * [XWIKI-4378] - Should never deny resources access through skin URL * [XWIKI-5004] - Inactive user should be able to access the same UI than XWikiGuest * [XWIKI-5005] - Form displayed to inactive user after login for account activation does not submit to correct URL * [XWIKI-5064] - Issue escaping " [ " when located in front of an URL * [XWIKI-5113] - Id block inside header is badly rendered * [XWIKI-5114] - Allow controlling the depth of headers to look for when generating titles from document's content (configuration in xwiki.cfg) * [XWIKI-5126] - Link to force editing a locked user is wrong in new UI * [XWIKI-5127] - #googlecalcustom macro mixup front and background colors, and also use a "Test" title * [XWIKI-5128] - XWiki doesn't check groups permissions correctly in multiwiki environment * [XWIKI-5131] - PropUpdateAction use wrong XWiki#flushCache method * [XAADMINISTRATION-134] - Users->add new user not using XWiki.Registration with field validation. * [XAADMINISTRATION-131] - Hide color theme setting from space administration (currently unsupported at the level) For more information see the Releases notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise226 and http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXEM226 Thanks -The XWiki dev team

4 3

[xwiki-devs] Authentification
by Doktor Insano 28 Apr '10

28 Apr '10

Hi, I am currently trying to implement a custom authentication as suggested here: http://platform.xwiki.org/xwiki/bin/view/AdminGuide/Authentication#HCustomA… The custom authentication implementation works fine, its Single Sign-On (user name is set in each request header) and I would additionally like to fallback to login form in case no header value is set. This works fine, but what I would like to change as well is to have the entered credentials in the form to be checked to a specific custom table in the database. Idea is to take the username and password and see if they match the ones stored in the database. I would appreciate if somebody could help with suggestions on this. Thank you -- View this message in context: http://xwiki.475771.n2.nabble.com/Authentification-tp4973445p4973445.html Sent from the XWiki- Dev mailing list archive at Nabble.com.

1 0

[xwiki-devs] [proposal] Send out a security advisory over XWIKI-4755
by Caleb James DeLisle 28 Apr '10

28 Apr '10

As many already know, a serious security issue was fixed in the 2.3 timeframe. It does not affect all installations specifically installations with databases such as MySql which disallow multiple queries to be executed at once. Still for those who are affected this is quite serious and I believe in taking a proactive stance on security. I would like to send a security advisory email to the users list which says the following: 1. Explain the problem clearly but without any sample exploit. 2. Provide a groovy snippet to test if a database allows multiple queries. 3. Provide a link to the patch which was used to plug the hole in 2.3 so security concerned users who are unable to upgrade may include it in custom builds. This patch is simplistic and likely to apply cleanly or with little work on all versions. WDYT? Caleb

1 0

[xwiki-devs] Uncaught exception escaped Problem
by Leon Wang 27 Apr '10

27 Apr '10

Hi Marius, "I've seen this exception before but I don't remember how to avoid it. What version of the WYSIWYG editor do you use? Is your Wysiwyg.html file similar to this http://svn.xwiki.org/svnroot/xwiki/platform/web/tags/xwiki-web-2.1.1/wysiwy… ?" It is similar, here is what I got: <?xml version="1.0" encoding="ISO-8859-1" ?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en"> <head> <title>XWiki WYSIWYG Editor - Hosted Mode Demo</title> <meta name="gwt:property" content="locale=en" /> <script type="text/javascript" src="/xwiki/resources/js/prototype/prototype.js"></script> <script type="text/javascript" src="/xwiki/bin/skin/resources/js/xwiki/xwiki.js"></script> <script type='text/javascript' src='/xwiki/bin/skin/resources/js/smartclient/initsc.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_Core.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_Foundation.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_Containers.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_Grids.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_Forms.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/modules/ISC_DataBinding.js'></script> <script type='text/javascript' src='/xwiki/resources/js/smartclient/skins/Enterprise/load_skin.js'></script> <script type='text/javascript' src='/xwiki/bin/skin/resources/js/xwiki/xwikiexplorer/xwikiexplorer.js'></script> <script type="text/javascript" src="xwe.nocache.js"></script> </head> <body> <button onclick="load(this)">Load</button> <script type="text/javascript"> function load(hook) { // Create a plain text area. var textArea = document.createElement('textarea'); textArea.id = 'demo'; textArea.rows = 25; textArea.cols = 80; hook.parentNode.replaceChild(textArea, hook); // Create a new editor instance. new WysiwygEditor({ hookId: 'demo', syntax: 'xwiki/2.0', displayTabs: true, defaultEditor: 'wysiwyg', plugins: 'submit line separator text valign list indent history format symbol link image table macro import', menu: 'link image table macro import', debug: true }); } </script> </body> </html> What should I do? Thank you for your help! Jue Wang

1 0

[xwiki-devs] Fwd: [xwiki-notifications] r28628 - in enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui: . elements framework
by Jerome Velociter 27 Apr '10

27 Apr '10

----- "cjdelisle (SVN)" <enterprise-notifications(a)xwiki.org> wrote: > Author: cjdelisle > Date: 2010-04-27 08:45:23 +0200 (Tue, 27 Apr 2010) > New Revision: 28628 > > Added: > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTest.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestAdminAddUser.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestNoLiveValidation.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdminSectionPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/FormPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/LightBoxRegisterPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/UsersPage.java > Modified: > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdministrationPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/BasePage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/RegisterPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/ViewPage.java > > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/framework/AbstractTest.java > Log: > XAADMINISTRATION-134: Users->add new user not using XWiki.Registration > with field validation.Added testing. Also duplicated selenium1.0 tests > for registeration. Maybe we should delete original selenium 1.0 test when they are replaced. This way we know how much migration remains to do. WDYT ? Jerome. >Also added some testing infrastructure. > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTest.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTest.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTest.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,175 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui; > + > +import org.junit.Assert; > +import org.junit.Before; > +import org.junit.Test; > + > +import org.openqa.selenium.By; > +import org.openqa.selenium.WebDriverException; > + > +import org.xwiki.it.ui.elements.RegisterPage; > +import org.xwiki.it.ui.elements.ViewPage; > +import org.xwiki.it.ui.elements.HomePage; > +import org.xwiki.it.ui.elements.LoginPage; > +import org.xwiki.it.ui.elements.AdministrationPage; > +import org.xwiki.it.ui.elements.AdminSectionPage; > +import org.xwiki.it.ui.framework.AbstractTest; > +import org.xwiki.it.ui.framework.TestUtils; > + > +/** > + * Test the user registration feature. > + * > + * @version $Id$ > + * @since 2.3M1 > + */ > +public class RegisterTest extends AbstractTest > +{ > + protected RegisterPage registerPage; > + > + @Before > + public void setUp() > + { > + registerPage = getRegisterPage(); > + > + deleteUser("JohnSmith"); > + registerPage.gotoRegisterPage(); > + > + // Switch LiveValidation on or off as needed. > + int x = 0; > + while (registerPage.liveValidationEnabled() != > useLiveValidation()) { > + HomePage homePage = new HomePage(getDriver()); > + homePage.gotoHomePage(); > + homePage.loginAsAdmin(); > + AdministrationPage adminPage = > homePage.administorWiki(); > + AdminSectionPage registrationAdminSection = > adminPage.clickRegistrationSection(); > + > registrationAdminSection.getForm().setFieldValue(By.name("XWiki.Registration_1_liveValidation_enabled"), > + > Boolean.valueOf(useLiveValidation()).toString()); > + registrationAdminSection.clickSave(); > + if (x > 2) { > + throw new WebDriverException("Unable to set > useLiveValidation to " + useLiveValidation()); > + } > + x++; > + registerPage.gotoRegisterPage(); > + } > + registerPage.fillInJohnSmithValues(); > + } > + > + /** To put the registration page someplace else, subclass this > class and change this method. */ > + protected RegisterPage getRegisterPage() > + { > + return new RegisterPage(getDriver()); > + } > + > + /** To test without javascript validation, subclass this class > and change this method. */ > + protected boolean useLiveValidation() > + { > + return true; > + } > + > + @Test > + public void testRegisterJohnSmith() > + { > + Assert.assertTrue(validateAndRegister()); > + tryToLogin("JohnSmith", "WeakPassword"); > + } > + > + @Test > + public void testRegisterExistingUser() > + { > + registerPage.fillRegisterForm(null, null, "Admin", null, > null, null); > + // Can't use validateAndRegister here because user existance > is not checked by LiveValidation. > + Assert.assertFalse(registerPage.register()); > + > Assert.assertTrue(registerPage.validationFailureMessagesInclude("User > already exists.")); > + } > + > + @Test > + public void testRegisterPasswordTooShort() > + { > + registerPage.fillRegisterForm(null, null, null, "short", > "short", null); > + Assert.assertFalse(validateAndRegister()); > + > Assert.assertTrue(registerPage.validationFailureMessagesInclude("Please > use a longer password.")); > + } > + > + @Test > + public void testRegisterDifferentPasswords() > + { > + registerPage.fillRegisterForm(null, null, null, null, > "DifferentPassword", null); > + Assert.assertFalse(validateAndRegister()); > + > Assert.assertTrue(registerPage.validationFailureMessagesInclude("Your > passwords aren't the same.")); > + } > + > + @Test > + public void testRegisterEmptyPassword() > + { > + registerPage.fillRegisterForm(null, null, null, "", "", > null); > + Assert.assertFalse(validateAndRegister()); > + > Assert.assertTrue(registerPage.validationFailureMessagesInclude("This > field is mandatory.")); > + } > + > + @Test > + public void testRegisterInvalidEmail() > + { > + registerPage.fillRegisterForm(null, null, null, null, null, > "not an email address"); > + Assert.assertFalse(validateAndRegister()); > + > Assert.assertTrue(registerPage.validationFailureMessagesInclude("Please > give a valid email address.")); > + } > + > + /** > + * If LiveValidation is enabled then it will check that there are > no failures with that. > + * If no failures then hits register button, it then asserts that > hitting thr register > + * button did not reveal any failures not caught by > LiveValidation. > + * > + * If LiveValidation is disabled then just hits the register > button. > + */ > + protected boolean validateAndRegister() > + { > + if (useLiveValidation()) { > + registerPage.triggerLiveValidation(); > + if > (!registerPage.getValidationFailureMessages().isEmpty()) { > + return false; > + } > + boolean result = registerPage.register(); > + > Assert.assertTrue(registerPage.getValidationFailureMessages().isEmpty()); > + return result; > + } > + return registerPage.register(); > + } > + > + /** Deletes specified user if it exists, leaves the driver on > undefined page. */ > + private void deleteUser(String userName) > + { > + ViewPage vp = new ViewPage(getDriver()); > + TestUtils.gotoPage("XWiki", userName, getDriver()); > + if (vp.exists()) { > + vp.loginAsAdmin(); > + TestUtils.deletePage("XWiki", userName, getDriver()); > + vp.clickLogout(); > + } > + } > + > + protected void tryToLogin(String username, String password) > + { > + LoginPage loginPage = registerPage.clickLogin(); > + loginPage.loginAs(username, password); > + Assert.assertTrue(registerPage.isAuthenticated()); > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTest.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestAdminAddUser.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestAdminAddUser.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestAdminAddUser.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,54 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui; > + > +import org.junit.Assert; > +import org.junit.Test; > + > +import org.xwiki.it.ui.elements.RegisterPage; > +import org.xwiki.it.ui.elements.HomePage; > +import org.xwiki.it.ui.elements.LoginPage; > +import org.xwiki.it.ui.elements.AdministrationPage; > +import org.xwiki.it.ui.elements.UsersPage; > +import org.xwiki.it.ui.elements.LightBoxRegisterPage; > + > +/** > + * Test the Admin->Users->AddNewUser feature. > + * > + * @version $Id$ > + * @since 2.4M1 > + */ > +public class RegisterTestAdminAddUser extends RegisterTest > +{ > + protected RegisterPage getRegisterPage() > + { > + return new LightBoxRegisterPage(getDriver()); > + } > + > + protected void tryToLogin(String username, String password) > + { > + HomePage homePage = new HomePage(getDriver()); > + homePage.gotoHomePage(); > + homePage.clickLogout(); > + LoginPage loginPage = homePage.clickLogin(); > + loginPage.loginAs(username, password); > + Assert.assertTrue(registerPage.isAuthenticated()); > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestAdminAddUser.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestNoLiveValidation.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestNoLiveValidation.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestNoLiveValidation.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,34 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui; > + > +/** > + * Test the user registration feature without javascript field > validation. > + * > + * @version $Id$ > + * @since 2.4M1 > + */ > +public class RegisterTestNoLiveValidation extends RegisterTest > +{ > + protected boolean useLiveValidation() > + { > + return false; > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/RegisterTestNoLiveValidation.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdminSectionPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdminSectionPage.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdminSectionPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,65 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui.elements; > + > +import org.openqa.selenium.WebDriver; > +import org.openqa.selenium.WebElement; > +import org.openqa.selenium.support.FindBy; > +import org.xwiki.it.ui.framework.TestUtils; > + > +/** > + * Represents the actions possible on the main Administration Page. > + * > + * @version $Id$ > + * @since 2.3M1 > + */ > +public class AdminSectionPage extends AdministrationPage > +{ > + @FindBy(xpath = > "//div[@id='admin-page-content']/div/p/span/input[@type='submit']") > + private WebElement saveButton; > + > + // The admin-page-content div is being treated as a form since it > may contain multiple forms and we want to be able > + // to access elements in them all. > + @FindBy(xpath = "//div[@id='admin-page-content']") > + private WebElement formElement; > + > + private FormPage form; > + > + public AdminSectionPage(WebDriver driver) > + { > + super(driver); > + this.form = new FormPage(formElement, driver); > + } > + > + public void gotoAdministrationPage() > + { > + TestUtils.gotoPage("XWiki", "XWikiPreferences", "admin", > getDriver()); > + } > + > + public void clickSave() > + { > + saveButton.click(); > + } > + > + public FormPage getForm() > + { > + return form; > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdminSectionPage.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdministrationPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdministrationPage.java > 2010-04-26 15:17:30 UTC (rev 28627) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/AdministrationPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -35,6 +35,12 @@ > @FindBy(xpath = "//li[@class='Import']/a/span/img") > WebElement importLink; > > + @FindBy(xpath = "//li[@class='Registration']/a/span/img") > + WebElement registrationLink; > + > + @FindBy(xpath = "//li[@class='Users']/a/span/img") > + WebElement usersLink; > + > public AdministrationPage(WebDriver driver) > { > super(driver); > @@ -51,4 +57,15 @@ > return new ImportPage(getDriver()); > } > > + public AdminSectionPage clickRegistrationSection() > + { > + this.registrationLink.click(); > + return new AdminSectionPage(getDriver()); > + } > + > + public UsersPage clickUsersSection() > + { > + this.usersLink.click(); > + return new UsersPage(getDriver()); > + } > } > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/BasePage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/BasePage.java > 2010-04-26 15:17:30 UTC (rev 28627) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/BasePage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -70,21 +70,74 @@ > { > return getDriver().findElement(By.xpath("//meta[@name='" + > metaName + "']")).getAttribute("content"); > } > - > + > + /** > + * Wait until the element given by the locator is displayed. Give > up after 10 seconds. > + * > + * @param locator the locator for the element to look for. > + */ > public void waitUntilElementIsVisible(final By locator) > { > this.waitUntilElementIsVisible(locator, 10); > } > > + /** > + * Wait until the element given by the locator is displayed. > + * > + * @param locator the locator for the element to look for. > + * @param timeout how long to wait in seconds before giving up. > + */ > public void waitUntilElementIsVisible(final By locator, int > timeout) > { > + waitUntilElementsAreVisible(new By[] {locator}, timeout, > true); > + } > + > + /** > + * Wait until one or all of a array of element locators are > displayed. > + * > + * @param locators the array of element locators to look for. > + * @param all if true then don't return until all elements are > found. Otherwise return after finding one. > + */ > + public void waitUntilElementsAreVisible(final By[] locators, > final boolean all) > + { > + waitUntilElementsAreVisible(locators, 10, all); > + } > + > + /** > + * Wait until one or all of a array of element locators are > displayed. > + * > + * @param locators the array of element locators to look for. > + * @param timeout how long to wait in seconds before giving up. > + * @param all if true then don't return until all elements are > found. Otherwise return after finding one. > + */ > + public void waitUntilElementsAreVisible(final By[] locators, int > timeout, final boolean all) > + { > Wait<WebDriver> wait = new WebDriverWait(driver, timeout); > wait.until(new ExpectedCondition<WebElement>() > { > public WebElement apply(WebDriver driver) > { > - RenderedWebElement element = (RenderedWebElement) > driver.findElement(locator); > - return element.isDisplayed() ? element : null; > + RenderedWebElement element = null; > + for (int i = 0; i < locators.length; i++) { > + try { > + element = (RenderedWebElement) > driver.findElement(locators[i]); > + } catch (NotFoundException e) { > + // This exception is caught by WebDriverWait > + // but it returns null which is not > necessarily what we want. > + if (all) { > + return null; > + } > + continue; > + } > + if (element.isDisplayed()) { > + if (!all) { > + return element; > + } > + } else if (all) { > + return null; > + } > + } > + return element; > } > }); > } > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/FormPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/FormPage.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/FormPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,96 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui.elements; > + > +import java.util.Map; > +import java.util.HashMap; > + > +import org.openqa.selenium.WebDriver; > +import org.openqa.selenium.WebElement; > +import org.openqa.selenium.NoSuchElementException; > +import org.openqa.selenium.WebDriverException; > +import org.openqa.selenium.By; > + > +/** > + * Represents a Form. > + * > + * @version $Id:$ > + * @since 2.4M1 > + */ > +public class FormPage extends BasePage > +{ > + private final WebElement form; > + > + public FormPage(WebElement form, WebDriver driver) > + { > + super(driver); > + this.form = form; > + } > + > + public void fillFieldsByName(Map<String, String> valuesByNames) > + { > + Map valuesByElements = new HashMap<WebElement, String>((int) > (valuesByNames.size() / 0.75)); > + > + for (String name : valuesByNames.keySet()) { > + > valuesByElements.put(this.form.findElement(By.name(name)), > valuesByNames.get(name)); > + } > + fillFieldsByElements(valuesByElements); > + } > + > + > + public void fillFieldsByElements(Map<WebElement, String> > valuesByElements) > + { > + for (WebElement el : valuesByElements.keySet()) { > + setFieldValue(el, valuesByElements.get(el)); > + } > + } > + > + public void setFieldValue(By findElementBy, String value) > + { > + setFieldValue(this.form.findElement(findElementBy), value); > + } > + > + public void setFieldValue(WebElement fieldElement, String value) > + { > + if (!fieldElement.getTagName().equals("input") && > !fieldElement.getTagName().equals("textbox")) { > + throw new WebDriverException("You can only fill in input > and textbox elements."); > + } > + if (fieldElement.getAttribute("type").equals("checkbox")) { > + setCheckBox(fieldElement, value.equals("true")); > + } else { > + fieldElement.clear(); > + fieldElement.sendKeys(value); > + } > + } > + > + public void setCheckBox(WebElement checkBoxElement, boolean > checked) > + { > + int x = 0; > + while (checkBoxElement.isSelected() != checked) { > + checkBoxElement.toggle(); > + if (x == 100) { > + throw new WebDriverException("Unable to set checkbox > at " > + + > checkBoxElement.getAttribute("name") + " to " + checked); > + } > + x++; > + } > + > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/FormPage.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/LightBoxRegisterPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/LightBoxRegisterPage.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/LightBoxRegisterPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,81 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui.elements; > + > +import java.util.List; > +import java.util.ArrayList; > + > +import org.openqa.selenium.support.FindBy; > +import org.openqa.selenium.By; > +import org.openqa.selenium.WebElement; > +import org.openqa.selenium.WebDriver; > + > +/** > + * Represents a registertion page in a lightbox > + * > + * @version $Id$ > + * @since 2.3M1 > + */ > +public class LightBoxRegisterPage extends RegisterPage > +{ > + @FindBy(xpath = > "//div/form[@id='register']/div/span[1]/input[@value='Save']") > + private WebElement submitButton; > + > + public LightBoxRegisterPage(WebDriver driver) > + { > + super(driver); > + } > + > + public void gotoRegisterPage() > + { > + HomePage homePage = new HomePage(getDriver()); > + homePage.gotoHomePage(); > + > + homePage.loginAsAdmin(); > + AdministrationPage adminPage = homePage.administorWiki(); > + UsersPage usersPage = adminPage.clickUsersSection(); > + > + usersPage.clickAddNewUser(); > + waitUntilElementIsVisible(By.id("register_first_name")); > + } > + > + /** @return true if registration is successful, false if user > couldn't be registered. */ > + public boolean register() > + { > + submitButton.click(); > + > + waitUntilElementsAreVisible( > + new By[] > {By.xpath("//td[@class='username']/a[@href='/xwiki/bin/view/XWiki/JohnSmith']"), > + > By.xpath("//dd/span[@class='LV_validation_message LV_invalid']") > + }, > + false > + ); > + > + return !getDriver() > + .findElements( > + > By.xpath("//td[@class='username']/a[@href='/xwiki/bin/view/XWiki/JohnSmith']")) > + .isEmpty(); > + } > + > + public boolean liveValidationEnabled() > + { > + return > !getDriver().findElements(By.xpath("//div[@id='lb']/div[@id='lb-content']/script[3]")).isEmpty(); > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/LightBoxRegisterPage.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/RegisterPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/RegisterPage.java > 2010-04-26 15:17:30 UTC (rev 28627) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/RegisterPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -19,8 +19,18 @@ > */ > package org.xwiki.it.ui.elements; > > +import java.util.List; > +import java.util.Map; > +import java.util.HashMap; > + > +import org.openqa.selenium.support.FindBy; > +import org.openqa.selenium.By; > +import org.openqa.selenium.WebElement; > import org.openqa.selenium.WebDriver; > +import org.openqa.selenium.WebDriverException; > > +import org.xwiki.it.ui.framework.TestUtils; > + > /** > * Represents the actions possible on the Registration Page > * > @@ -29,8 +39,133 @@ > */ > public class RegisterPage extends ViewPage > { > + @FindBy(id = "register") > + private WebElement registerFormElement; > + > + @FindBy(xpath = > "//form[@id='register']/div/span/input[@type='submit']") > + private WebElement submitButton; > + > + private FormPage form; > + > public RegisterPage(WebDriver driver) > { > super(driver); > } > + > + /** To put the registration page someplace else, subclass this > class and change this method. */ > + public boolean isOnRegisterPage() > + { > + if (registerFormElement != null && > !getDriver().findElements(By.name("register_password")).isEmpty()) { > + if (form == null) { > + form = new FormPage(registerFormElement, > getDriver()); > + } > + return true; > + } > + return false; > + } > + > + /** To put the registration page someplace else, subclass this > class and change this method. */ > + public void gotoRegisterPage() > + { > + HomePage homePage = new HomePage(getDriver()); > + homePage.gotoHomePage(); > + > + if (homePage.isAuthenticated()) { > + homePage.clickLogout(); > + } > + > + homePage.clickRegister(); > + form = new FormPage(registerFormElement, getDriver()); > + } > + > + public void fillInJohnSmithValues() > + { > + fillRegisterForm("John", "Smith", "JohnSmith", > "WeakPassword", "WeakPassword", "johnsmith(a)xwiki.org"); > + } > + > + public void fillRegisterForm(final String firstName, > + final String lastName, > + final String username, > + final String password, > + final String confirmPassword, > + final String email) > + { > + checkAtRegisterPage(); > + Map map = new HashMap(); > + if (firstName != null) { > + map.put("register_first_name", firstName); > + } > + if (lastName != null) { > + map.put("register_last_name", lastName); > + } > + if (username != null) { > + map.put("xwikiname", username); > + } > + if (password != null) { > + map.put("register_password", password); > + } > + if (confirmPassword != null) { > + map.put("register2_password", confirmPassword); > + } > + if (email != null) { > + map.put("register_email", email); > + } > + form.fillFieldsByName(map); > + } > + > + /** @return true if registration is successful, false if user > couldn't be registered. */ > + public boolean register() > + { > + checkAtRegisterPage(); > + submitButton.click(); > + > + List<WebElement> infos = > getDriver().findElements(By.className("infomessage")); > + for (WebElement info : infos) { > + if (info.getText().indexOf("Registration successful.") != > -1) { > + return true; > + } > + } > + return false; > + } > + > + /** @return a list of WebElements representing validation failure > messages. Use after calling register() */ > + public List<WebElement> getValidationFailureMessages() > + { > + return > getDriver().findElements(By.xpath("//dd/span[@class='LV_validation_message > LV_invalid']")); > + } > + > + /** @return Is the specified message included in the list of > validation failure messages. */ > + public boolean validationFailureMessagesInclude(String message) > + { > + for (WebElement messageElement : > getValidationFailureMessages()) { > + if (messageElement.getText().equals(message)) { > + return true; > + } > + } > + return false; > + } > + > + public boolean liveValidationEnabled() > + { > + return > !getDriver().findElements(By.xpath("/html/body/div/div/div[3]/div/div/div/div/div/script")).isEmpty(); > + } > + > + /** Try to make LiveValidation validate the forms. Focus on an > unvalidated field (register_first_name)*/ > + public void triggerLiveValidation() > + { > + // Click on all of the validated fields to prevent "Passwords > don't match" sticking -> flickering test. > + // The right solution is to have a better way to fire > LiveValidation without excessive js. > + > registerFormElement.findElement(By.name("register2_password")).click(); > + > registerFormElement.findElement(By.name("register_password")).click(); > + > registerFormElement.findElement(By.name("xwikiname")).click(); > + > + > registerFormElement.findElement(By.name("register_first_name")).click(); > + } > + > + private void checkAtRegisterPage() > + { > + if (!isOnRegisterPage()) { > + throw new WebDriverException("Must go to the registration > page before using it's functions."); > + } > + } > } > > Added: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/UsersPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/UsersPage.java > (rev 0) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/UsersPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -0,0 +1,56 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + */ > +package org.xwiki.it.ui.elements; > + > +import org.junit.Assert; > +import org.junit.Test; > + > +import org.openqa.selenium.WebDriver; > +import org.openqa.selenium.WebElement; > +import org.openqa.selenium.support.FindBy; > + > + > +import org.xwiki.it.ui.elements.RegisterPage; > +import org.xwiki.it.ui.elements.BasePage; > +import org.xwiki.it.ui.elements.AdministrationPage; > + > +/** > + * Test the Admin->Users->AddNewUser feature. > + * > + * @version $Id$ > + * @since 2.4M1 > + */ > +public class UsersPage extends BasePage > +{ > + @FindBy(id = "addNewUser") > + private WebElement addNewUserButton; > + > + public UsersPage(WebDriver driver) > + { > + super(driver); > + } > + > + public RegisterPage clickAddNewUser() > + { > + this.addNewUserButton.click(); > + RegisterPage rp = new LightBoxRegisterPage(getDriver()); > + return rp; > + } > +} > > > Property changes on: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/UsersPage.java > ___________________________________________________________________ > Name: svn:keywords > + Author Id Revision HeadURL > Name: svn:eol-style > + native > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/ViewPage.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/ViewPage.java > 2010-04-26 15:17:30 UTC (rev 28627) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/elements/ViewPage.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -19,6 +19,8 @@ > */ > package org.xwiki.it.ui.elements; > > +import java.util.List; > + > import org.openqa.selenium.By; > import org.openqa.selenium.JavascriptExecutor; > import org.openqa.selenium.WebDriver; > @@ -52,6 +54,9 @@ > @FindBy(id = "tmCreateSpace") > private WebElement createSpaceMenuLink; > > + @FindBy(id= "tmAdminWiki") > + private WebElement administorWikiMenuLink; > + > public ViewPage(WebDriver driver) > { > super(driver); > @@ -63,12 +68,16 @@ > public void loginAsAdmin() > { > if (!isAuthenticated()) { > - // If there's no login link then go to the home page > + // If there's no login link then go to the home page. > if (!hasLoginLink()) { > + String thisPage = getPageURL(); > HomePage homePage = new HomePage(getDriver()); > homePage.gotoHomePage(); > + clickLogin().loginAsAdmin(); > + getDriver().get(thisPage); > + } else { > + clickLogin().loginAsAdmin(); > } > - clickLogin().loginAsAdmin(); > } > } > > @@ -122,6 +131,13 @@ > return new CreateSpacePage(getDriver()); > } > > + public AdministrationPage administorWiki() > + { > + hoverOverMenu("tmWiki"); > + this.administorWikiMenuLink.click(); > + return new AdministrationPage(getDriver()); > + } > + > // TODO: I don't think we should go through the menus, it's > probably faster to to as deletePage() does > public void deleteCurrentPage() > { > @@ -142,6 +158,19 @@ > > return new HistoryPane(getDriver()); > } > + > + /** @return does this page exist. */ > + public boolean exists() > + { > + List<WebElement> messages = > getDriver().findElements(By.className("xwikimessage")); > + for (WebElement message : messages) { > + if (message.getText().equals("The requested document > could not be found.") > + || message.getText().equals("The document has been > deleted.")) { > + return false; > + } > + } > + return true; > + } > > private void hoverOverMenu(String menuId) > { > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/framework/AbstractTest.java > =================================================================== > --- > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/framework/AbstractTest.java > 2010-04-26 15:17:30 UTC (rev 28627) > +++ > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/framework/AbstractTest.java > 2010-04-27 06:45:23 UTC (rev 28628) > @@ -22,6 +22,7 @@ > import org.junit.AfterClass; > import org.junit.BeforeClass; > import org.openqa.selenium.WebDriver; > +import org.xwiki.test.XWikiExecutor; > > /** > * To be extended by all Test Classes. Allows to start/stop the Web > Driver and get access to it. > @@ -31,20 +32,30 @@ > */ > public class AbstractTest > { > + private static XWikiExecutor executor; > + > @BeforeClass > - public static void init() > + public static void init() throws Exception > { > + if > (!Boolean.parseBoolean(System.getProperty("xwiki.alltests"))) { > + // Start XE > + executor = new XWikiExecutor(0); > + executor.start(); > + } > + > if (TestUtils.getDriver() == null) { > TestUtils.initDriver(); > } > } > > @AfterClass > - public static void shutdown() > + public static void shutdown() throws Exception > { > // Only close if we're not part of the AllTests test suite > if > (!Boolean.parseBoolean(System.getProperty("xwiki.alltests"))) { > TestUtils.closeDriver(); > + // Stop XE > + executor.stop(); > } > } > > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications

1 0

[xwiki-devs] Uncaught exception escaped Problem
by Leon Wang 26 Apr '10

26 Apr '10

Hi Marius, I compiled my code, but all the buttons are invisible and uncaught exception came up: [ERROR] Uncaught exception escaped java.lang.RuntimeException: Failed to invoke native method: @org.xwiki.gwt.dom.client.Event::isCancelled() with 0 arguments. at com.google.gwt.dev.shell.moz.LowLevelMoz.invoke(LowLevelMoz.java:134) at com.google.gwt.dev.shell.moz.ModuleSpaceMoz.doInvoke(ModuleSpaceMoz.java:99) at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:453) at com.google.gwt.dev.shell.ModuleSpace.invokeNativeBoolean(ModuleSpace.java:146) at com.google.gwt.dev.shell.JavaScriptHost.invokeNativeBoolean(JavaScriptHost.java:35) at org.xwiki.gwt.dom.client.Event$.isCancelled$(Event.java) at org.xwiki.gwt.user.client.ui.rta.internal.BehaviorAdjuster.onBrowserEvent(BehaviorAdjuster.java:123) at org.xwiki.gwt.user.client.ui.rta.RichTextArea.onBrowserEvent(RichTextArea.java:154) at com.google.gwt.user.client.DOM.dispatchEventImpl(DOM.java:1320) at com.google.gwt.user.client.DOM.dispatchEventAndCatch(DOM.java:1299) at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1262) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103) at com.google.gwt.dev.shell.moz.MethodDispatch.invoke(MethodDispatch.java:80) at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method) at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:1428) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2840) at com.google.gwt.dev.SwtHostedModeBase.processEvents(SwtHostedModeBase.java:235) at com.google.gwt.dev.HostedModeBase.pumpEventLoop(HostedModeBase.java:558) at com.google.gwt.dev.HostedModeBase.run(HostedModeBase.java:405) at com.google.gwt.dev.HostedMode.main(HostedMode.java:232) Here is the visual: https://docs.google.com/Doc?docid=0AUvGk3CNC6BPZGhwZGQ1M3dfNDNnNDQ5emZmNw&h… Could you please help me take a look at it. Thank you, Marius! Jue Wang

2 1