May 2014 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Support 3 XWiki versions instead of 2
by vincent＠massol.net 27 May '14

27 May '14

Hi devs, I’d like to propose that we change our rule of supporting the last 2 versions of XWiki (ie the latest stable and the version in development) which is documented here: http://www.xwiki.org/xwiki/bin/view/Main/Support The new support rule would be that we support: * The latest release from the previous development cycle (right now that’s 5.4.5) * The latest stable release from the current cycle (right now that’s 6.0.1) * The latest development release from the current cycle (right now that’s 6.1M1) The rationale is that we need to offer a super stable release (that’s the latest from the previous dev cycle) for users in production. Here’s my +1. Thanks -Vincent PS: Note that if we really wanted to support only 2 versions, then I’d propose to drop the “latest stable from the current cycle” (ie 6.0.1 right now), thus offering only 5.4.5 and 6.1M1 ATM.

6 6

[xwiki-devs] Unwanted revision increments
by walid yaich 26 May '14

26 May '14

Hi, I added $doc.save() in contentview.vm to save the object added to my doc, this save increment the revision. is it possible to tell the save to not increment the version ? Thanks in advance :)

4 4

[xwiki-devs] Approved Revision Installable with the Extension Manager
by walid yaich 26 May '14

26 May '14

Hi, When i finish this work i want to make an extension "*Installable with the Extension Manager*". Main modifications i have made : - Changes on *historyinline.vm* to add a button Approve in order to approve a revision and make it public. - Modification on *contentview.vm* to get the revision value passed in parameter from historyinline.vm and set the approved revision in the object attached to the document. - I added a *groovy listener*<http://extensions.xwiki.org/xwiki/bin/view/Extension/Create+an+XObject+By+d…>to add an object to new pages - Adding a new *class*<http://www.rendering.xwiki.org/xwiki/bin/viewrev/FAQ/How+to+implement+%22Ap…>to contains the value of the approved revision It's not finished yet, i have to make a clean and tested version of this extension and make some documentations, but i want to know if i'm on the right way to build an extension. An extension can override files like historyinline.vm ? if yes it won't work for futur version if XWIKI, right ? otherwise what's the best way to do so ? I can't find documentation about creating an installable Extension Manager. What about licenses? i asked my boss and he told me that we can make this public for free but i should mention the name of our company, and make copyright (the name of our company) in new source files, is it possible ? Thanks in advance :)

2 3

[xwiki-devs] [ANN] XWiki 5.4.5 released
by Guillaume "Louis-Marie" Delhumeau 26 May '14

26 May '14

The XWiki development team is proud to announce the availability of XWiki 5.4.5. This release is a stabilization version that fix important bugs discovered in the 5.4.4 version. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki545 Thanks -The XWiki dev team

1 0

Re: [xwiki-devs] [Contrib] Create a repository for the Hierarchy Macro
by Lyes Bandou 26 May '14

26 May '14

Hi Vincent Thank you , and no we don't need a JIRA project yet On Mon, May 26, 2014 at 11:15 AM, vincent(a)massol.net <vincent(a)massol.net>wrote: > Hi Lyes, > > Done: https://github.com/xwiki-contrib/macro-dynamic-tree > > Do you also need a JIRA project? > > Thanks > -Vincent > > On 21 May 2014 at 19:07:24, Anca Luca (lucaa(a)xwiki.com(mailto: > lucaa(a)xwiki.com)) wrote: > > > Hello Devs, > > > > As far as I know it's not a refactoring of the old macro because some > > parameters / parameters behaviour was not kept 100%. It's missing some > > features, basically. Adding some with the cost of removing others. > > > > So if we consider it a new version of the old one, installing an > "upgrade" > > will break the behaviour. You'd tell me we could wait to release the new > > version it only when ready, but then people could not take advantage of > its > > features (which are cool). > > > > We could have it as a new extension until we implement all the features > of > > the old one, and then we mark it as implementing the same feature so that > > the old one could be upgraded to the new one. > > > > Anca > > > > > > On Wed, May 21, 2014 at 7:11 PM, vincent(a)massol.net wrote: > > > > > > > > > > > > > > > > > On 21 May 2014 at 18:08:33, Lyes Bandou (lyes.bandou(a)xwiki.com(mailto: > > > lyes.bandou(a)xwiki.com)) wrote: > > > > > > > Code of the two macros is not the same, > > > > > > This doesn’t matter much if the new code is considered a refactoring of > > > the old code. > > > > > > > The new macro has the same name and > > > > keeps most paramettres, but the behavior is not the same it uses > Ajax to > > > > load the data (using JSON) and the older macro display the documents > > > > hierarchy in a space , the new macro can uses documents list as > documents > > > > roots of the tree (plus another paramettres) > > > > > > > > > > > > I suggest "Dynamic Tree Macro" as the new name. > > > > > > The real question is: do we need the 2 macros at once? > > > > > > I guess we need to ask the question to the author of the first macro: > > > Anca, Paul, Mircea. > > > > > > Because from a user point of view, it’s a nightmare to have several > > > extensions doing the same thing, the user never knows which one to use. > > > > > > Anca/Paul/Mircea, do you have an opinion? > > > > > > Thanks > > > -Vincent > > > > > > > On Wed, May 21, 2014 at 4:40 PM, Thomas Mortagne > > > > wrote: > > > > > > > > > Same question, why is a new repository needed exactly ? If it's THE > > > > > new version then it's the same extension and it should be the same > > > > > repository, even if you rewrite half of it in a 2.0 version. > > > > > > > > > > On Wed, May 21, 2014 at 5:37 PM, vincent(a)massol.net > > > > > wrote: > > > > > > Do you really need a new extension? Couldn’t you improve the > existing > > > > > one then? > > > > > > > > > > > > Thanks > > > > > > -Vincent > > > > > > > > > > > > On 21 May 2014 at 17:35:52, Lyes Bandou (lyes.bandou(a)xwiki.com > > > (mailto: > > > > > lyes.bandou(a)xwiki.com)) wrote: > > > > > > > > > > > >> This is the new version of Hierarchy Macro ( > > > > > >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro > > > ) > > > > > with > > > > > >> the addition of to many parameters > > > > > >> > > > > > >> > > > > > >> On Wed, May 21, 2014 at 4:26 PM, Thomas Mortagne > > > > > >> wrote: > > > > > >> > > > > > >> > Are you talking about > > > > > >> > > > > http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro ? > > > > > >> > > > > > > >> > If not you might want to find another name since this one > already > > > have > > > > > >> > https://github.com/xwiki-contrib/macro-hierarchy. > > > > > >> > > > > > > >> > On Wed, May 21, 2014 at 5:23 PM, Lyes Bandou > > > > > >> > wrote: > > > > > >> > > Hello devs, > > > > > >> > > > > > > > >> > > I would like a repository for the Hierarchy Macro on > > > > > >> > > https://github.com/xwiki-contrib. > > > > > >> > > > > > > > >> > > Hierarchy Macro use jQuery and jsTree ( > http://www.jstree.com) > > > to > > > > > display > > > > > >> > > dynamique tree view of wiki documents based on parent/child > > > > > relationships > > > > > >> > > > > > > > >> > > Thank you in advance. > > > > > >> > > > > > > > >> > > > > > > > >> > > Lyes Bandou > > > > > > > > > > > > _______________________________________________ > > > > > > devs mailing list > > > > > > devs(a)xwiki.org > > > > > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > > > > > > > > > > > > > > > -- > > > > > Thomas Mortagne > > > > > _______________________________________________ > > > > > devs mailing list > > > > > devs(a)xwiki.org > > > > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > > > > _______________________________________________ > > > > devs mailing list > > > > devs(a)xwiki.org > > > > http://lists.xwiki.org/mailman/listinfo/devs > > > _______________________________________________ > > > devs mailing list > > > devs(a)xwiki.org > > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > _______________________________________________ > > devs mailing list > > devs(a)xwiki.org > > http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

1 0

Re: [xwiki-devs] [Contrib] Create a repository for the Hierarchy Macro
by Lyes Bandou 26 May '14

26 May '14

Code of the two macros is not the same, The new macro has the same name and keeps most paramettres, but the behavior is not the same it uses Ajax to load the data (using JSON) and the older macro display the documents hierarchy in a space , the new macro can uses documents list as documents roots of the tree (plus another paramettres) I suggest "Dynamic Tree Macro" as the new name. On Wed, May 21, 2014 at 4:40 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com>wrote: > Same question, why is a new repository needed exactly ? If it's THE > new version then it's the same extension and it should be the same > repository, even if you rewrite half of it in a 2.0 version. > > On Wed, May 21, 2014 at 5:37 PM, vincent(a)massol.net <vincent(a)massol.net> > wrote: > > Do you really need a new extension? Couldn’t you improve the existing > one then? > > > > Thanks > > -Vincent > > > > On 21 May 2014 at 17:35:52, Lyes Bandou (lyes.bandou(a)xwiki.com(mailto: > lyes.bandou(a)xwiki.com)) wrote: > > > >> This is the new version of Hierarchy Macro ( > >> http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro) > with > >> the addition of to many parameters > >> > >> > >> On Wed, May 21, 2014 at 4:26 PM, Thomas Mortagne > >> wrote: > >> > >> > Are you talking about > >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro ? > >> > > >> > If not you might want to find another name since this one already have > >> > https://github.com/xwiki-contrib/macro-hierarchy. > >> > > >> > On Wed, May 21, 2014 at 5:23 PM, Lyes Bandou > >> > wrote: > >> > > Hello devs, > >> > > > >> > > I would like a repository for the Hierarchy Macro on > >> > > https://github.com/xwiki-contrib. > >> > > > >> > > Hierarchy Macro use jQuery and jsTree (http://www.jstree.com) to > display > >> > > dynamique tree view of wiki documents based on parent/child > relationships > >> > > > >> > > Thank you in advance. > >> > > > >> > > > >> > > Lyes Bandou > > > > _______________________________________________ > > devs mailing list > > devs(a)xwiki.org > > http://lists.xwiki.org/mailman/listinfo/devs > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

3 3

[xwiki-devs] Infinite loop in documentation
by walid yaich 26 May '14

26 May '14

Hi, I think there is a loop when trying to read about DocumentSheetBinding<http://enterprise.xwiki.org/xwiki/bin/view/XWiki/DocumentSheetBinding>, here is the link: http://enterprise.xwiki.org/xwiki/bin/view/XWiki/SheetDescriptorClass Have a nice day :)

2 2

[xwiki-devs] Display Revision Application
by walid yaich 26 May '14

26 May '14

Hi, I have problem to get this application works properly, In this article<http://www.xwiki.org/xwiki/bin/view/FAQ/How+to+implement+%22Approved+Revisi…>, i'm supposed to do this to test it : 1. Create a page, say Main.Test with the content "Original Content" 2. Edit the page again to change the content to "New Content" 3. Add an XObject of type Revision.RevisionClass and set the revisionfield to 1.1 (this is the version we want to display) 4. Save This works But when we change the order : 1. Add an XObject of type Revision.RevisionClass and set the revisionfield to 1.1 (this is the version we want to display) 2. Create a page, say Main.Test with the content "Original Content" 3. Edit the page again to change the content to "New Content" 4. Save it doesn't work anymore, you save the Revision object with the right revision but it won't display it. But this works for all revisions before adding the object. Once you added the object, no matter how much changes you made, you won't be able to display last revisions(created after adding the object) BTW, when i give a wrong revision, the page display just "$revDoc.getRenderedContent()" One strange usecase : 1) i create a new page, make modifications and save 3 times 2) i add the object and give 1.1 for revision and save 3) when i edit the file, in the editor, i can find the last version, i modify something and save ==> it's like, it'll save the revision 1.1 (setted to the added object) When i make "compare selected version" between the last and the first, it gives me the last change i made, but when i click on the last revision i can't find the last change i made. Any explanation please ? Thanks in advance :)

2 2

[xwiki-devs] Display revision
by walid yaich 24 May '14

24 May '14

Hi, Please, did you remember on which XWIKI version did you test this application<http://www.xwiki.org/xwiki/bin/view/FAQ/How+to+implement+%22Approved+Revisi…>? i tried it on 5.4.4 and 6.0 but i can't get it work properly, Thanks in advance

2 1

[xwiki-devs] historyinline.vm
by walid yaich 23 May '14

23 May '14

Hi, I'm changing historyinline.vm to add a link "Approve", in order to set the approved revision in the object added to the document. I added this tag in the foreach : do this make sens ? is it supposed to work ? <a href="" onclick="$doc.set("revision", $version)">Approve</a></td> In my html source i find : <a href="" onclick="">Approve</a> the display is fine but no action, nothing happen Thanks in advance :)

1 1