April 2017 - xwiki-devs@xwiki.org

[xwiki-devs] [proposal] Process to handle Pull Requests
by Ludovic Dubost 10 May '19

10 May '19

Hi devs, I don't think there is currently a process that is in place to handle pull requests and I have the feeling that the way there are handled today is a bit random. There are usually comments sent out on each pull request but sometimes it seems that some pull requests are going in sleep mode and it's not clear who is in charge. I would like to suggest that a process is put in place where it's clear who is responsible for a pull request and a status is given to the contributors that propose that pull request. Something like: Assigned developer: XXXX Status: New -> new pull request, not yet assigned Assigned -> assigned to a developer, he is in charge of reviewing the pull request and ask for modifications or accept it. The developer can auto assign it to himself. If nobody does, we need to decide how they will be taken into account. ModificationsRequired -> for now rejected with comments. Contributor needs to apply comments and then change back to Assigned for further evaluation VoteRequired -> there are no more comments, but a vote is required as the changes to XWiki core are important WaitingFinalAuthorization -> optional step for complex patches where a additional authorization would be required (need to define who would be the persons that give the authorization) WaitingApplication -> there are no more comments and no changes or vote required. The pull request can be applied and is waiting for a developer to apply it Abandoned -> contributors is abandoning the pull request (cannot do the changes, no more time, etc..) Rejected -> pull request is rejected (quality not enough, etc..) Applied -> pull request is applied What do you think ? Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

7 12

[xwiki-devs] Velocity 2.0 and DeprecatedCheckUberspector
by Claude Brisson 20 Jun '18

20 Jun '18

Hi. I'm currently working on Velocity 2.0 packaging. If that's OK with you, I would like to incorporate DeprecatedCheckUberspector.java into Velocity, but I need a statement from your part to be able to change its licence to Apache 2.0 (LGPL and Apache 2.0 licences aren't compatible). By the way, I take this opportunity to tell you that if there is another specific part of xwiki-commons-velocity that you think should be integrated on our side, or an important missing feature you'd like to insist on, don't hesitate. I already integrated VELOCITY-825, for instance, so String->Enum constant conversions are now handled by Velocity. There may be other important conversion cases you'd like to see handled. Regards, Claude

4 8

[xwiki-devs] [Vote] Assignee for PR: Contributor or Committer?
by Ecaterina Moraru (Valica) 07 May '18

07 May '18

Hi, We have discussed this subject multiple times, but we don't have an official vote and conclusion on the topic. Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request? 1: Contributor - he provided the solution - giving the attributions, the contributor might feel encouraged to contribute more - we could do some JIRA statistics on external contributions, but this use case can be covered by GitHub statistics 2: Committer - he does the merging on his account and he becomes responsible for the committed code. - in case there are problems, the committer needs to find solution, since we can't rely on contributors availability - in doing the PR review, the committer spends a lot of time analyzing and testing the provided solution We are talking here about complete solutions provided by the PR, since in case of partial solutions, the committer can assign himself on the issue (depends on the quantity of modification he does). Let me know what you think, Caty

9 11

[xwiki-devs] [Proposal] Entry point for Extensions
by Vincent Massol 18 Aug '17

18 Aug '17

Hi devs, Problem ======= We have 2 issues right now when installing an extension in XWiki: 1) It’s not clear where is the entry point of that extension. - Example1: an app that is only for admins and only has a ConfigurableClass - Example2: an app that provides a macro and doesn’t have a UI 2) Even when an extension registers itself in the Applications Panel, the user still need to refresh the page or navigate away to see it. Proposal ======== * Introduce the concept of Entry point (a.k.a home page) in Extension metadata * Have the EM UI display the extension’s entry point (when there’s one) after having installed the extension so that the user can click on it and be taken to the home page of the extension. This would make extensions more discoverable IMO. Implementation Details ================== * Some maven extension metadata properties in pom.xml * A format to represent an entry point. It shouldn’t be a full URL since that needs to be computed at runtime. Basically it should contain: ** The document reference ** The action to use (view, admin, etc) - optional, should default to “view" ** The query string to use - optional, should default to an empty query string This corresponds to the notion of ResourceReference (EntityResourceReference to be precise). However we don’t have any textual representation of it ATM. WDYT? Good idea? Bad idea? Thanks -Vincent

8 16

[xwiki-devs] [VOTE] Move from our mailing lists and use Discourse instead
by Vincent Massol 15 May '17

15 May '17

Hi devs, I’m proposing to vote for moving away from our users and devs mailing list and instead to use the Discourse open source tool: * Home page: http://www.discourse.org/ * License: GPL v2 * FAQ: http://www.discourse.org/faq/ * Awesome feature list: http://www.discourse.org/about/ What is especially interesting for us: * It works with mailing lists (you can receive mails and send mails to the forum). * Works as a forum. BTW if you want to see a real life instance, check the gradle instance at https://discuss.gradle.org/ Nice things: * Works on mobile * Comprehensive API (would allow us to integrate it with xwiki.org) * Badges/user metrics So here’s my +1 to try it out and ask XWiki SAS if they could host an instance. WDYT? Do you see any negative point (I don’t ATM)? :) Please cast your votes! Thanks -Vincent

10 30

[xwiki-devs] [Proposal] Create a separate IRC channel for notifications
by Vincent Massol 12 May '17

12 May '17

Hi devs, I think we’ve reached the point when we need 2 IRC channels: * one for users and devs discussions (“xwiki”) * one for notifications (“xwiki-notifications”) There are too many notifications right now to be able to have unobstructed conversations on IRC. Note that ideally this will require modifying the IRCBot application so that some Botlets are on the main “xwiki” channel (like the the jira botlet that gives the full URL of a jira issue) and the others on the “xwiki-notifications” channel. However, FTM I’m proposing to configure the IRCBot to use the xwiki-notifications channel exclusively. WDYT? Thanks -Vincent

5 8

[xwiki-devs] [XWiki Day] BFD#141
by Alexandru Cotiuga 28 Apr '17

28 Apr '17

Hello devs, Today is BFD#141: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingdays Our current status for the 500 days period is 60 bugs behind. See: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=103 52#Created-vs-Resolved-Chart/16742 Here's the BFD#141 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=13891 Happy BugFixing Day, Alex

1 1

[xwiki-devs] [ANN] XWiki 9.3.1 released
by Thomas Mortagne 26 Apr '17

26 Apr '17

The XWiki development team is proud to announce the availability of XWiki 9.3.1. This version fix a bug that makes impossible to migrate subwikis and a regression related to escaping in requests LIKE values. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/9.3.1 Thanks for your support -The XWiki dev team

2 1

[xwiki-devs] [Proposal][UX] Explicit content actions
by Ecaterina Moraru (Valica) 25 Apr '17

25 Apr '17

Hi devs, Some users have complained that the content actions are too abstract / ambiguous and they don't see/understand them so they don't know how to Edit or Create content in the first minutes of interaction. More details about this problem can be found at http://design.xwiki.org/xwiki/bin/view/Proposal/IdeaLabeledActions There I've suggested 2 possible proposals: Proposal 1: JS Tooltips Proposal 2: Labeled actions Which one do you prefer? Thanks, Caty P.S: This was a recurrent topic and we change several things over the years. I guess we will continue iterating until we reach the sweet spot :)

7 17

[xwiki-devs] [Proposal][UX] Visible Save buttons
by Ecaterina Moraru (Valica) 25 Apr '17

25 Apr '17

Hi devs, Some users have complained that when editing they don't know that they need to scroll in order to see the Save buttons. This is a proposal that tackles: - Displaying the save buttons in a bottom area, when they are out of the viewport, see http://design.xwiki.org/xwiki/bin/download/Proposal/IdeaVisibleSave/bottomB… - Reorganizing the bottom zone in order to compact all the save functions into a single bar - When the user scrolls, the buttons go into their position, see http://design.xwiki.org/xwiki/bin/download/Proposal/IdeaVisibleSave/after.p… For the whole proposal and more screenshots, see http://design.xwiki.org/xwiki/bin/view/Proposal/IdeaVisibleSave WDYT? Thanks, Caty

6 16

[xwiki-devs] [Proposal][UX] Bundle Menu app in XWiki
by Ecaterina Moraru (Valica) 25 Apr '17

25 Apr '17

Hi devs, Another idea for this roadmap is if we want to bundle the Menu App inside XWiki. I've tried to list the current issues at: http://design.xwiki.org/xwiki/bin/view/Proposal/IdeaDefaultMenu with a proposal for a default menu instance. WDYT? Thanks, Caty

3 4

[xwiki-devs] [Proposal][UX] Bundle Help app in XWiki
by Ecaterina Moraru (Valica) 25 Apr '17

25 Apr '17

Hi devs, In the 9.2 roadmap we developed a Help Center in http://jira.xwiki.org/browse/HELPCENTER-1 that showcases the major XWiki concepts (templates, macros, apps, etc.) to newcomers. Currently the idea is to bundle the Help in XWiki, in order to be accessible from the start, without the need of a manual install. I've describe the major issues with the bundling here: http://design.xwiki.org/xwiki/bin/view/Proposal/IdeaDefaultHelp WDYT? - Should we bundle it even if we have "Issue 1: Uninstallable"? Should we fix it first? - What about the other issues? Do you see any other problems? Thanks, Caty

3 4

[xwiki-devs] [ANN] XWiki 9.3 released
by Ecaterina Moraru (Valica) 24 Apr '17

24 Apr '17

The XWiki development team is proud to announce the availability of XWiki 9.3. This release brings a couple of small, but very useful improvements like: * the ability to filter the sections in Administration, * reset changes done to extension pages and * alternative configuration locations. Developers also get: * some helpful API in writing clean queries when escaping and filtering, * a new API to find documents belonging to extensions and * more control through a new extension point for the content menu You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/9.3 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] [xwik-devs] Local maven repository in Extension Manager
by Krzysiek Płachno 24 Apr '17

24 Apr '17

Hi, I want to connect local maven repository Extension Manager (and so Extension Repository) according to http://platform.xwiki.org/ xwiki/bin/view/DevGuide/CreatingExtensions/#HUsingtheExtensionManager In 'xwiki.properties' I put following line: *extension.repositories=maven-local:maven:file:///C:/Users/Krzysztof/.m2/repository/* It was discovered by XWiki since in Repository Application it's visible: http://i.imgur.com/ep9yazr.png When I try to import extension from local repository (that is present there) I get exception: http://i.imgur.com/PucSgOL.png Full stack trace: https://pastebin.com/iUnJ29wm What may be the problem? Url to local repository ( *file:///C:/Users/Krzysztof/.m2/repository/)* is ok since when I paste it in browser I can access this directory flawlessly. I'm working on Windows. (url with backslashes, escaped or not, is not recognized by xwiki) Thanks in advance! Krzysztof

3 6

[xwiki-devs] [ANN] XWiki 8.4.5 released
by Vincent Massol 24 Apr '17

24 Apr '17

The XWiki development team is proud to announce the availability of XWiki 8.4.5 (latest LTS). This is a bugfix release. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/8.4.5 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] PR
by Sarthak Gupta 20 Apr '17

20 Apr '17

Hi, I have created a pull request for this issue: https://jira.xwiki.org/browse/BLOG-32 on https://github.com/xwiki-contrib/application-blog/ P.S : Is this the correct way of notifying about the pull request that I will create in future. :P Thanks

2 5

[xwiki-devs] [XWiki Day] Test Day #4
by Thomas Mortagne 20 Apr '17

20 Apr '17

Hi devs, The idea today is to do a Test Day with priority to fixing long standing flickering (integration mostly) tests. You can find known flickering tests on http://jira.xwiki.org/issues/?filter=14240. The goal is to really fix them, not just add some random wait here and there ;) If you are not confident with the area around those specific flickering tests here are some other ideas for this kind of Day: * obviously add more tests and increase the code coverage * move tests from enterprise to platform. Needed for the platform flavor and removal of XE * update jacoco covering setup (we often forget to increase it when adding more tests) * move more tests from JMock to Mockito * work on new test setups and tools: ** improve docker containers for packaging XWiki (possibly several for multiple DBs and Servlet containers). ** work on spreading Jenkins platform job into one job per maven module so that build can be spread on various agents (groovy scripting) ** Research/Use Jenkins 2 Pipeline plugin with the new DSL and commit the jenkinsfile in SCM ** Test platform to run contrib extension tests on various versions of XWiki automatically * Speedup existing tests (research xwiki startup time, remove unnecessary modules, etc) When what you fix can be linked to an issue, tag it with "testday" (same idea as "bugfixingday" when doing BFD). If not then answer to this mail to explain what you did. Good Test Day !

2 1

[xwiki-devs] [ANN] XWiki 9.3 Release Candidate 1 released
by Eduard Moraru 19 Apr '17

19 Apr '17

The XWiki development team is proud to announce the availability of XWiki 9.3 Release Candidate 1. This release brings a couple of small, but very useful improvements like the ability to filter the sections in Administration, reset changes done to extension pages and alternative configuration locations. Developers get some helpful API in writing clean queries when escaping and filtering, a new API to find documents belonging to extensions and more control through a new extension point for the content menu. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/9.3RC1 Thanks for your support -The XWiki dev team

1 0

[xwiki-devs] Not able to make changes on localhost.
by Sarthak Gupta 19 Apr '17

19 Apr '17

Hi, Two days before I downloaded the application-blog repository from github on my pc. In order to check whether the changes I make in the repository(on my pc) are visible while running the localhost on browser, I made some changes in the ui of the application blog. (I tried to change the color of the 'date' text on top of blog page, I tried to increased the font size of title, I tried to shift the position of blog-button-toolbox ). But I think these changes are not visible to me on localhost after building the whole repository again. The process that I follow is: - Going to the application-blog directory. - going to application-blog-ui - making changes in BlogStyle.xml and saving them. - going back to application-blog directory. - mvn clean install.(100% success) - refreshing the localhost on my web browser. No changes seen! :/ Could there be any reason for this? Or am I doing it in a wrong way? Thank You Sarthak Gupta

2 2

[xwiki-devs] [Usability] Feedback from session with new user
by Vincent Massol 19 Apr '17

19 Apr '17

Hi devs, Over the weekend I had some friends at my house and I asked one of them to try a few simple tasks in XWiki. 1) I asked him to modify the home page to put his own content. He couldn’t find how to edit the home page... * I ran the Tour wizard and he read everything and finished it and still could’t find how to edit * He even read the content of the home page and noticed the line that says to use the pencil icon above to edit the page. He tried to click the pencil icon but couldn’t find or realize that there was a button to click above. * In the end I had to explain to him that page action bar. Idea/suggestion: At the end of the tour or outside the tour, when the first user views the home page, have a flashing arrow with a text “click here to edit this page” to direct the user to edit the page. Note that he mentioned having some text before the icons to say that this was a Menu… I found it a bit strange. When he saw the XWiki admin UI, he said that the vertical menu was much simpler to understand and that it would be nicer to use that for the page actions. I explained that it would take too much space and he understood that. 2) I asked him to create a new page. It took him some time to understand he had to enter a title but he did it. He clicked the “empty page” template, thinking that it would create the page. He even double-clicked it. After some hints from my side, he was able to locate the “create” button. Idea/suggestion: the create button is not easy to locate, it’s quite more down from the rest. Note that we’re also missing a cancel button if want to go back and not create a page. 3) I asked him to delete the page after he edited it and even created a new page but he didn’t realize the action would in the same action bar. The reason is that the icon for the actions is a “settings”/“cog” icon and he thought that there would be admin stuff under it. Idea/Suggestion: Change the icon to something else. 4) I asked him to create pages under other pages and he was able to do that fine. 5) He wanted the wiki in French and we noticed quite a few places that were missing translations: - the new step in the AWM wizard - the create page validation message - color theme admin UI (there were a few others but I forgot them) Note: When adding an image in CKEditor and when in French, the tab for uploading is translated as “Téléverser” which is quite awkward in French IMO… ;) 6) He was able to use the navigation panel to navigate Food for thoughts and actions… Thanks -Vincent

3 2

[xwiki-devs] [PROPOSAL] Yet another new platform flavor proposal or how to get rid of XWiki Enterprise
by Thomas Mortagne 18 Apr '17

18 Apr '17

Here is a new proposal on this subject. This supersets the following threads: * http://markmail.org/message/mhhurc7lbyfanph7 * http://markmail.org/message/nav5a77hzmhq4gq6 * http://markmail.org/message/fd5ijxdquzdhtykw We discussed with other committers (Vincent and Ludovic) and came to the conclusion that it was not core dev team job to provide a specific flavor like Knowledge Base and that we should focus only on a very generic one (pretty much XE without the Blog). Here are the details: = One flavor We develop only 1 flavor located in xwiki-platform repository. It's a generic flavor not targeting any specific use case (the first version with be XE without the Blog). We will discuss the name in another thread later, let's call it "Wiki Flavor" for now. Of course everyone is free and welcomed to build lots of contrib flavors which will be proposed when you install XWiki ("Development Flavor", "Demo Flavor", "Blog Flavor", etc.). = No "Base flavor" But platform will provide an extension that can be used as dependency by various flavors to get "core" UI extensions that we think make sense in any kind of flavor. = Demo package We currently have a jetty/hsqldb based package in platform which let you choose which flavor you want. We will show it in the download page. We will add another one with the Wiki Flavor already installed in it (pretty much like the XE jetty/hsqldb package). Listed on the download page too. We don't maintain exe/jar installers anymore in platform, they die with XWiki Enterprise. They are a real pain to maintain and we are actually failing since they don't really work properly everywhere they are supposed to work. It does not worth the trouble for what is not a production ready package and it's better anyway to make more clear XWiki is a server thing. WDYT ? Thanks, -- Thomas Mortagne

6 13

[xwiki-devs] [Proposal] Improve the Notifications Module to replace the Watchlist
by Guillaume Delhumeau 18 Apr '17

18 Apr '17

Hello developers! The new roadmap has been voted and I continue my work on the notifications module. You might have played with it since the 9.2 release and I hope you like it. Now I need to implement the email part of the notifications module. It means that users could decide either the notifications are displayed on the top menu or sent by emails periodically. Having this in mind, it is clear that it conflicts with the Watchlist. The plan is to move to contrib the Watchlist application (when possible) and to implement the same features inside the notifications module. Any objection before I start the work? Thanks, -- Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

2 2

[xwiki-devs] [Proposal] Start exploring JUnit5
by Vincent Massol 17 Apr '17

17 Apr '17

Hi devs, JUnit5 is getting closer to a final release (planned for July 2017) and it would be nice to be able to start familiarizing ourselves with JUnit5 and start migrating some tests and prepare the conversion of our custom JUnit4 Rules to JUnit5 Extensions. A nice video about using JUnit5: https://www.youtube.com/watch?v=0qI6_NKFQsY&feature=youtu.be User guide: http://junit.org/junit5/docs/current/user-guide/#overview` I’ve created and implemented https://jira.xwiki.org/browse/XCOMMONS-1189. Please let me know if this causes any issue. Thanks -Vincent

1 0

[xwiki-devs] [error] Building XWiki
by Sarthak Gupta 15 Apr '17

15 Apr '17

After sorting out the previous error with some effort, I am getting another error. Could someone please tell me how to resolve this? After giving "mvn clean install" command. . . . . T/application-ckeditor-test-1.14-SNAPSHOT.pom [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building CKEditor Integration Test Page Objects 1.14-SNAPSHOT [INFO] ------------------------------------------------------------------------ Downloading: https://repo.maven.apache.org/maven2/org/xwiki/platform/xwiki-platform-test… [WARNING] The POM for org.xwiki.platform:xwiki-platform-test-ui:jar:9.1.2 is missing, no dependency information available Downloading: https://repo.maven.apache.org/maven2/org/xwiki/platform/xwiki-platform-test… [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] CKEditor Integration Parent POM .................... SUCCESS [ 10.360 s] [INFO] CKEditor Integration Base .......................... SUCCESS [05:06 min] [INFO] CKEditor Integration Plugins ....................... SUCCESS [01:02 min] [INFO] CKEditor Integration Test Modules .................. SUCCESS [ 0.249 s] [INFO] CKEditor Integration Test Page Objects ............. FAILURE [ 9.993 s] [INFO] CKEditor Integration WebJar ........................ SKIPPED [INFO] CKEditor Integration UI ............................ SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 06:56 min [INFO] Finished at: 2017-04-14T22:40:32+05:30 [INFO] Final Memory: 37M/126M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal on project application-ckeditor-test-pageobjects: Could not resolve dependencies for project org.xwiki.contrib:application-ckeditor-test-pageobjects:jar:1.14-SNAPSHOT: Could not find artifact org.xwiki.platform:xwiki-platform-test-ui:jar:9.1.2 in central (https://repo.maven.apache.org/maven2) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionExcept… [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :application-ckeditor-test-pageobjects

2 2

[xwiki-devs] [Contrib] request for 2 project repositories
by Ludovic Dubost 14 Apr '17

14 Apr '17

Hi, I would like to request two projects repositories for: 1/ Search Extension Spellchecker application-search-spellcheck This extension uses jazzy (https://github.com/tupilabs/jazzy) to provide spell checking of search queries (in english for now) 2/ Office365 integration application-office365 This extension provides a macro allowing to display office365 documents inside XWiki, as well as display search results on office365 as a widget in the solr search screen (it needs a UI extension for this which I will propose in a jira issue) Thanks Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic(a)xwiki.com skype: ldubost Blog: http://blog.ludovic.org <https://r.clb.pt/r/9948f250f66b8701fa3e61729c63b99e?d=http%3A%2F%2Fblog.lud…>Try XWiki on the cloud <https://r.clb.pt/r/9948f250f66b8701fa3e61729c63b99e?d=http%3A%2F%2Fwww.xwik…> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://r.clb.pt/r/9948f250f66b8701fa3e61729c63b99e?d=https%3A%2F%2Fcryptpa…>

2 3