November 2018 - xwiki-devs@xwiki.org

[xwiki-devs] [Proposal] Get rid of sonar.xwiki.org?
by Vincent Massol 07 Jan '19

07 Jan '19

Hi devs, Context: * I lost the config on ci.xwiki.org to push maven results to sonar.xwiki.org. I can find them back for sure but will take me a bit of time. * We don’t use sonar.xwiki.org that much * We now have https://sonarcloud.io/organizations/xwiki/projects to which we can push results from our builds * https://sonarcloud.io/organizations/xwiki/projects is always up to date in term of sonar version and we don’t need to maintain it So my proposal is to decommission sonar.xwiki.org and to configure https://sonarcloud.io/organizations/xwiki/projects the way we want (I already did that a bit but we can tune it more) and modify our maven build to push to it. WDYT? Thanks -Vincent

6 9

[xwiki-devs] [Discussion] Coding practice for location of internal package name
by Vincent Massol 31 Dec '18

31 Dec '18

Hi devs, On Matrix/IRC, I’ve posted the following: " * Guillaume Delhumeau: BTW your naming is strange for the internal package * for ex: package org.xwiki.notifications.preferences.internal.email; * normally we put internal just after the main package part * ie. * org.xwiki.notifications.internal.* * and org.xwiki.notifications.* for public classes * see http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HPac… * General rule is org.xwiki.(module name).internal. * I see thomas has done the same “error" for org.xwiki.job.handler.internal and org.xwiki.job.handler.internal.question . So maybe there's something to discuss/change * I guess we have a mix of both now so we should discuss it and adjust our rules if need be “ So I think we don’t have all the same rules/understanding of the definition at http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HPac… I’d like to discuss with you to see what you prefer and adjust our rules so that it matches what we do in practice. Any take in this? Thanks -Vincent

7 8

[xwiki-devs] [Brainstorming] Finish refactoring for xwiki configuration directories
by Vincent Massol 25 Dec '18

25 Dec '18

Hi devs, Context ====== Clemens fixed a bug at https://jira.xwiki.org/browse/XWIKI-15163 and while doing so inroduced a new system property to override the location of the xwiki.properties file. I commented at https://jira.xwiki.org/browse/XWIKI-15163?focusedCommentId=98075&page=com.a… Even though it’s not necessary to introduce a new system property just for the need of this test (it’s easy to refactor the code to not need this IMO), it raises the question of what we want to do to make the configuration simpler in XWiki (simpler config, simpler upgrades, etc). History ====== We discussed this a few times in the past: * March 2010: http://markmail.org/message/6cvm5hocvtbqtgp6 * June 2012: https://markmail.org/message/3aq2bjrb6a2ip2ri Note that the June 2012 proposal was agreed. Globally this is what we implemented since the June 2012 proposal: * XCOMMONS-187: The Permanent Data directory resolver should support System Property "xwiki.data.dir". More specifically the code is here: https://github.com/xwiki/xwiki-commons/blob/55569d3466dc0ea36f6964474973f7a… * XWIKI-13867: Search xwiki.cfg in /etc/xwiki/ first. Code is here: https://github.com/xwiki/xwiki-platform/blob/973d4e9c6ad02dbb31d94fe96df9c1… * XWIKI-13868: Search xwiki.properties in /etc/xwiki/ first. Code is here: https://github.com/xwiki/xwiki-platform/blob/93f02215783ac0f4030fe3062cac4d… I’d like to note that I don’t remember discussions/proposals for XWIKI-13867/XWIKI-13868 and I commented on http://jira.xwiki.org/browse/XWIKI-13867 and didn’t get any response from my various comments. Current behavior ============= So right now the behavior is the following on config files (I’m excluding the recent change of Clements, see below in actions): * If xwiki.cfg exists under the. "java:comp/env” JNDI key, then it’s used * If not found, then search for it in /etc/xwiki/xwiki.cfg * If not found, then default to WEB-INF/xwiki.cfg * If /etc/xwiki.xwiki.properties exist then it’s used * if not found, search in WEB-INF/xwiki.properties (as a ServletContext resource) * If not found, then default to an empty configuration Discussion/Proposal ================ * I think we should ask Clemens to rollback the introduction of the xwiki.properties.default.dir system property and to just make the test work without introducing any system property. I can help Clemens do that. * I propose that instead we continue implementing the June 2012 proposal defined at https://markmail.org/message/3aq2bjrb6a2ip2ri and introduce the xwiki.config.dir system property. * Right now I don’t like the solution introduced by /etc/xwiki/* because they don’t allow supporting several instances of XWiki on the same machine. However, the introduction of xwiki.config.dir system property would fix it. * We could also introduce the user home dir location as a location where xwiki config files would be looked for. * We also need to generalize the config files to hibernate.cfg.xml and clustering config files (jgroup files), and logback. See https://www.xwiki.org/xwiki/bin/view/Documentation/AdminGuide/Backup#HConfi… WDYT? Thanks -Vincent PS: Sorry for the long mail, I had to do a lot of archeology to research this… Took me a while ;)

2 2

[xwiki-devs] [ANN] XWiki 10.8.2 Released
by Clément Aubin 30 Nov '18

30 Nov '18

Hi everyone, The XWiki development team is proud to announce the availability of XWiki 10.8.2. This is a bugfix release that covers important issues that we have discovered since 10.8.1 [1] has been released. See the release notes [2] for more information. Thanks, and have a great end of week, Clément [1] https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/10.8.1/ [2] https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/10.8.2/

1 0

[xwiki-devs] [XWiki Day] BFD#199
by Oana-Lavinia Florean 30 Nov '18

30 Nov '18

Hello devs, This Thursday is BFD#199: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -40 bugs over 120 days (4 months), i.e. we need to close 40 bugs to have created bugs == closed bugs * -140 bugs over 365 days (1 year) * -155 bugs over 500 days (between 1 and 2 years) * -362 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#199 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14345 Good luck at fixing bugs, Lavinia

1 1

[xwiki-devs] [Proposal] New xwiki-clover-maven repository
by Vincent Massol 30 Nov '18

30 Nov '18

Hi devs, I’d like to refactor the groovy code that I’ve currently put at https://github.com/xwiki/xwiki-jenkins-pipeline/blob/59051fd8f61bd5a65db790… and to move it into an XWiki Maven plugin for Clover. The goal of this plugin is to take as input two clover.xml Clover data files and to generate a diff report (example: http://maven.xwiki.org/site/clover/20181120/XWikiReport-20171222-1835-20181…) Rationale for move this outside of Jenkins: * Less dependency on Jenkins * Much easier to test * Better versioning and release * Increased reuse (any project in the world will be able to use it whereas the pipeline is specific to xwiki and not reusable easily) It’s not linked to releases of XWiki. But it should be maintained by the xwiki dev team since we use it in our pipeline to compute the global coverage and generate reports/emails when global TPC is lowered. WDYT? Thanks -Vincent

3 2

[xwiki-devs] [ANN] XWiki 10.10 released
by Alex Cotiugă 29 Nov '18

29 Nov '18

Hello all, The XWiki development team is proud to announce the availability of XWiki 10.10. In this version, a new protection helper was introduced to prevent users from breaking the wiki when an XClass page is being refactored, PDF export looks better now and the new auto-suggestion feature starts to be enabled in some places. It's now possible to easily enable asynchronous execution and caching for panels, wiki UI extensions and wiki macros, this making the rendering of the page faster. Among other things, Wiki Macros can now have typed parameters and it is now possible to make the content of a macro editable inline with the WYSIWYG editor. You can download it here: https://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the release notes: https://www.xwiki.org/xwiki/bin/view/ReleaseNotes/Data/XWiki/10.10/ Thanks for your support -The XWiki dev team

2 1

[xwiki-devs] Postpone of XWiki 10.10
by Alex Cotiugă 26 Nov '18

26 Nov '18

Hello devs, There are some issues in progress for 10.10 release + some testing for them so I propose to postpone the release for tomorrow. Thanks, Alex

1 0

[xwiki-devs] [Proposal] WCAG exception: consecutive line breaks
by Simon Urli 26 Nov '18

26 Nov '18

Hi everyone, one of the most validation error we have with WCAG is about consecutive line breaks: basically a presents in a page. This happens mostly in our translation pages since the linebreaks in plain syntax are translated in tags. Caty provided a lot of details about this error on the related issue: https://jira.xwiki.org/browse/XWIKI-15666. Currently we have around 140 validations failure because of this. Different proposal have been made in order to fix it, that I will try to sum-up here: A. Remove completely this validation check B. Add an exception for the translation pages C. Triggers the error only if more than 2 consecutive breaks is encountered D. Create a rendering syntax dedicated to translation pages A. Remove completely the validation check pros: * the easiest one * apparently the rule is not checked in other accessibility test, so its real purpose for accessibility is unclear cons: * IMO this rule is useful for checking the good practice of not using B. Add an exception for the translation pages pros: * same as for A cons: * ? C. Triggers the error only if more than 2 consecutive breaks is encountered pros: * ? cons: * we would miss some consecutive that are used only for style and we would catch some others in translations if we do 3 linebreaks instead of 2. IMO it's only moving the problem D. Create a rendering syntax dedicated to translation pages pros: * remove completely the problem of consecutive in translations * can maybe be used to present them in another way? cons: * need to develop/test/maintain a new rendering syntax I'd personnaly vote like this: A: +0 B: +1 C: -1 D: +0 WDYT? Simon -- Simon Urli Software Engineer at XWiki SAS simon.urli(a)xwiki.com More about us at http://www.xwiki.com

6 7

[xwiki-devs] [XWiki Day] BFD#198
by Oana-Lavinia Florean 23 Nov '18

23 Nov '18

Hello devs, This Thursday is BFD#198: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -44 bugs over 120 days (4 months), i.e. we need to close 44 bugs to have created bugs == closed bugs * -139 bugs over 365 days (1 year) * -155 bugs over 500 days (between 1 and 2 years) * -367 bugs over 1600 days (4.3 years) See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#198 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14342 Good luck at fixing bugs, Lavinia

1 1