- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] xwiki-sandbox/org.xwiki.model vs xwiki-sandbox/components/xwiki-model

by Asiri Rathnayake

---------- Forwarded message ---------- From: Asiri Rathnayake <asiri.rathnayake(a)gmail.com> Date: Mon, Mar 10, 2008 at 4:55 AM Subject: Re: [xwiki-devs] xwiki-sandbox/org.xwiki.model vs xwiki-sandbox/components/xwiki-model To: Vincent Massol <vincent(a)massol.net> Cc: XWiki Developers <devs(a)xwiki.org> Hi Vincent, Following is a simple discussion of the two implementations of the new data-model of ArchitectureV2. Both of these implementations are not complete yet and my knowledge of xwiki is still limited. There for, there may be short-commings in the following discussion, please bare with me and try to correct me where i'm wrong (this will help me a lot). xwiki-sandbox/components/xwiki-model (Vincent) ----------------------------------------------------------------------- -> Represents a clear hierarchical view of domain objects (Server->Wiki->Space->Page) [ A simple graphical representation of the model is attached. ] -> Does not include any administrative / security / rights related code (simple model definitions). -> Currently upward navigation (given a page find it's parent space) is not possible. (but i believe this can be implemented at a higher layer) -> PropertyDefinition class is currently isolated, and no mention about Users. -> No mention about persistence related issues (DAOs). -> All are concrete classes Q.) Shouldn't we have interfaces (with a default impl) rather than classes here ? xwiki-sandbox/org.xwiki.model (Mikhail, Stéphane) ------------------------------------------------------------------------- -> The business layer (org.xwiki.model) contains model classes (Farm, Wiki, Space, Document, User) Along with (Session and XWikiException) Q.) Strictly speaking, Session and XWikiException are not domain classes. Shouldn't we try to keep things more simple in the model ? -> Here the notion of a hierarchy seems to be little blured, Farm doesn't have any method like getWikis() but it seems to contain some administrative / authentication related methods like createUser() and checkPassword() (This looks quite odd for me). And with this model it is possible to navigate upwards the hierarchy (Page->Space->Wiki). -> Some domain classes have code related to session handling / user rights. (is this ok?) -> In a sense, domain classes seems to be active rather than being passive (getters / setters). Example : space.addPage(Page page) <- passive, space.newPage(, , ,) <- active Example (imaginary) : space.getPages(SomeFilter) <- passive, space.getPages(...) {/* perform validations, access rights and return */} <- active -> There is a persistance layer (org.xwiki.model.dao). If we are to have two seperate plexus components for storage and data-model (or in other words, to decouple the model from storage), DAO classes should actually go inside the storage component. Having DAO classes inside the model will automatically bind the model to a particular storage implementation. -> org.xwiki.model.dao seems to have a single DAO interface (IWikiDAO) to access the storage rather than having separate DAO classes for each domain class. Q.) Why not have separate DAO classes for each model class ? Q.) org.xwiki.model.dao has *Value classes for each domain class. Why not use domain classes directly ? -> There is a default in-memory implementation of IWikiDAO inside org.xwiki.model.dao.memory I think that's all for the moment. Thanks. - Asiri On Sun, Mar 9, 2008 at 7:48 PM, Vincent Massol <vincent(a)massol.net> wrote: > Hi Asiri, > > On Mar 9, 2008, at 2:25 PM, Asiri Rathnayake wrote: > > > Hi Stéphane, > > > > I think the new data model is commited at xwiki-sandbox/ > > org.xwiki.model. But i'm bit confused with xwiki-sandbox/components/ > > xwiki-model. What does the latter stand for ? > > The one in org.xwiki.model was done by Stephane and the other one by > me ;) > > I guess they are two proposals for the same thing so we'll need to > decide which one to use. Note that the one I have isn't finished > either. We need to continue working on it, make proposals, etc. > Maybe you could review both and send an email with the differences. > This is an area I'd like to work on actively too. I've just been busy > with the 1.3 release but now it's done I'll try to spend more time on > the v2 components. However for this to happen we need someone to work > actively on fixing the important 1.3 bugs, releasing a 1.3.1 (for > example to fix the login issue with tomcat/IE7) and taking the lead on > 1.4. > > Anyone interested in doing this or simply helping out? > > Thanks > -Vincent > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

17 years, 6 months

1
0
0 0

[xwiki-devs] xwiki-sandbox/org.xwiki.model vs xwiki-sandbox/components/xwiki-model

by Asiri Rathnayake

Hi Stéphane, I think the new data model is commited at xwiki-sandbox/org.xwiki.model. But i'm bit confused with xwiki-sandbox/components/xwiki-model. What does the latter stand for ? Thanks. - Asiri

17 years, 6 months

2
2
0 0

[xwiki-devs] i did a bad thing on xwiki.org --> authentication/access control issue in xwiki 1.3

by Niels Mayer

I thought I was "playing" with my xwiki install (same skin) but it turns out was actually playing with xwiki.org. Unfortunately, I "hit" some buttons on xwiki.org and the actions I did should have been prevented by access-control, but they weren't. The actions assoc'd with these button should probably be available only to 'Admin' (or someone w/ programming rights) and not available to me logged in as 'NielsMayer' ( http://www.xwiki.org/xwiki/bin/view/XWiki/NielsMayer ) Given that I just recently registered and I'm not a "committer" (yet) I assume I should not have programming Access rights. Unfortunately, it let me perform the actions anyways as if I did have these rights. Specifically, http://www.xwiki.org/xwiki/bin/view/Scheduler/ has the following list: WatchList hourly notificationsNormalSun Mar 09 07:00:00 CET 2008*Infos* : view <http://www.xwiki.org/xwiki/bin/view/Scheduler/WatchListJob1> *Job* : pause<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=pause&which=Scheduler.Wat…> delete<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=delete&which=Scheduler.Wa…> unschedule<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=unschedule&which=Schedule…> WatchList daily notificationsNoneN/A*Infos* : view<http://www.xwiki.org/xwiki/bin/view/Scheduler/WatchListJob2> *Job* : schedule<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=schedule&which=Scheduler.…> delete<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=delete&which=Scheduler.Wa…> WatchList weekly notificationsNormalSun Mar 16 00:00:00 CET 2008*Infos* : view<http://www.xwiki.org/xwiki/bin/view/Scheduler/WatchListJob3> *Job* : pause<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=pause&which=Scheduler.Wat…> delete<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=delete&which=Scheduler.Wa…> unschedule<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=unschedule&which=Schedule…> WatchList monthly notificationsNormalSat Mar 15 00:00:00 CET 2008*Infos* : view<http://www.xwiki.org/xwiki/bin/view/Scheduler/WatchListJob4> *Job* : pause<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=pause&which=Scheduler.Wat…> delete<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=delete&which=Scheduler.Wa…> unschedule<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=unschedule&which=Schedule…> IRC BotNormal *Infos* : view<http://www.xwiki.org/xwiki/bin/view/Scheduler/IRCBot> *Job* : pause<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=pause&which=Scheduler.IRC…> delete<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=delete&which=Scheduler.IR…> unschedule<http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=unschedule&which=Schedule…> When I click on "pause" it paused the job, and when I clicked resume, it resumed it with the following message: "Job *WatchList monthly notifications* *resumed*. Next fire time : *Sat Mar 15 00:00:00 CET 2008" *This is despite the printed warning at the bottom of the page:* *"Job creation is reserved for programmers. It seems you do not have programming access right allowed on the Scheduler space." Xwiki.org <http://xwiki.org/> says it's running "1.3-rc-1.8082" --------------------------- This leads me to wonder how such administrative functions are secured. It makes sense to condition presentation of pause/delete/unschedule/schedule on whether Administrative/programming-access is available to the logged-in user. (i.e. don't present UI capabilities which aren't accessible to the given login/role). However, if someone were to just enter the URL http://www.xwiki.org/xwiki/bin/view/Scheduler/?do=pause&which=Scheduler.Wat… action should be access-controlled and prevented anyways. In my case, it wasn't. Anyways, sorry about doing this by accident. Hopefully no damage was done (I did resume the job i paused). I assume this is a "bug" I've discovered, and not a "feature." I guess further explorations in this area should be done on my own instance rather than xwiki.org .... ( no, i didn't test "unschedule" or "delete" given the potential that they'd actuallty work). If this is a bug, it would probably make good sense to review other instances where this might happen (aka "security walkthrough" of code). Is there any automated functional testing of the entire system (as opposed to unit testing) to ensure such access control issues aren't lurking in other areas? -- Niels. http://nielsmayer.com PS: Is there a document describing the security architecture of Xwiki?

17 years, 6 months

4
4
0 0

[xwiki-devs] SPAWN and external services

by Paul Libbrecht

Hello, Sergiu criticized that a MathTran (a TeX-daeomon over the web) solution for formulae is bad because it relies on an external service or a complex installation... probably correct and the rest of his argument (in particular the wish for MathML) is more than valid! But, I realize that scientific documents, the goal of spawn, right?, are often made of external services. Consider the success of TeXmacs, one of the great features is its ability to connect to external systems, precisely. Typically, the following artifacts are sensible products of external services: - plots of functions - plots of data-sets - presentation of data-sets - advanced visualizations (e.g. chemical diagrams, construction plans, interactive geometry constructions...). I don't think we want all that to be solved internally in spawn, using external services is a must and, on a web-system, those should be web-services. In many cases, the XWiki source may contain info to regenerate fully the artifact (this is the case of many TeXmacs session I think), in other cases external interactions are needed. The service has to be running when authoring, for sure, but it should not need to when running. Or at least breakage of it should not impact viewers. That leads me to think that a good approach would be to store the products in a more managed way, e.g., as attachments, than in a cache where it can go away for size reasons. Comments welcome. paul

17 years, 6 months

2
1
0 0

[xwiki-devs] XWiki build nows works with Maven 2.0.9-SNAPSHOT too

by Vincent Massol

All is in the title... So now, I think xwiki should build on most maven versions... barring the potential maven bugs... ;) -Vincent

17 years, 6 months

1
0
0 0

[xwiki-devs] Do you like our new T-Shirt?

by Vincent Massol

Hi, Here's the new T-shirt that we're planning to print: http://www.xwiki.com/xwiki/bin/download/Blog/NoTShirtYetCeBIT2008/TSHIRTCEB… WDYT? Do you like it? Would you wear it? :) (Full story at CEBIT here: http://www.xwiki.com/xwiki/bin/view/Blog/NoTShirtYetCeBIT2008) Thanks -Vincent

17 years, 6 months

2
3
0 0

[xwiki-devs] Is templates directory required any more?

by Sachin Mittal

Hi, I see that under xwiki webapp there is a template directory, that contains vm files. Same filenames are included in respective skins directory also. So based on my understanding of how velocity files are called and invoked upon user action, the vm files under templates directory play no role. Also in some previous discussion it was mentioned that they were redundant and there was a plan to separate common set of vm files into single directory. So I have two questions: 1. Can I delete the templates directory from my deployment. 2. If these files under this are no more required then what about deleting them from svn istelf. If have I have missed something and these files are required then please let me know in what case would these be required. Thanks Sachin ----- http://www.assembla.com/wiki/show/sachin_mittal about me: -- View this message in context: http://www.nabble.com/Is-templates-directory-required-any-more--tp15397359p… Sent from the XWiki- Dev mailing list archive at Nabble.com.

17 years, 6 months

4
9
0 0

[xwiki-devs] [VOTE] Anca as core committer

by Vincent Massol

Hi XWiki Committers, I'd like to vote Anca Paula Luca as XWiki core committer. She's been a committer on XWiki Watch for a long time, she understand the xwiki dev process and she wants to work on our core GWT support to move it to use GWT 1.4. You can see her work here: http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/web/branches/xwiki-web-gw… I feel she would be a great committer and she's interested in maintaing and improving this GWT code on the long run. Note that I have little idea how good the code on that branch is since I have not touched GWT yet but I trust Anca to do a good job and improve it if the quality is not to the par. Here's my +1 Thanks -Vincent

17 years, 6 months

6
5
0 0

[xwiki-devs] About GSoC 2008

by Asiri Rathnayake

Hi All, Sorry if this is the wrong place / time to ask this question. I wanted to know whether XWiki will participate in GSoC 2008<http://code.google.com/soc/2008/>. ( care to hint some project ideas ? ) Thank you. - Asiri

17 years, 6 months

4
15
0 0

[xwiki-devs] [ANN] XWiki Enterprise 1.3 Released

by Vincent Massol

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.3 final. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This release spanned 2 full months starting on the 10th of January 2008 and ending on the 7th of March 2008. During that period we implemented over 200 issues, fixing close to 100 bugs and adding new features such as: * Ability to export pages as HTML in a zip file * Ability to export the current page in a XAR * Better Oracle support * New Toucan skin * Complete rewrite of the LDAP authentication support including the support for LDAP groups * Diff emails sent by the Watchlist feature + ability to customize the email sent * Improved translation (German, French, Spanish) + new transaltions (Slovak) Main changes from 1.3RC1: * Core changes: o Bugs + XWIKI-1850 - No security against recursive includes + XWIKI-2047 - DB2 Hibernate Mapping for 1.2 + XWIKI-2163 - XWiki.parseGroovyFromPage() doesn't work when passing the a page containing JARs to be put in the Groovy classloader + XWIKI-2164 - Cannot log out + XWIKI-2171 - When user is not in the bind_DN/ bind_pass search for DN from user uid fail o Improvements + XWIKI-2157 - Add Slovak translation + XWIKI-2170 - Allow inactive users to see specific pages * Albatross Skin: o Bugs + XSALBATROSS-18 - Parse error when serving skin.js through SkinAction * Toucan Skin: o Bugs + XSTOUCAN-11 - RSS macro isn't styled correctly in Toucan + XSTOUCAN-12 - In inline edit mode all the input fields are stretched to the full content width + XSTOUCAN-13 - Numbered lists do not appear as numbered + XSTOUCAN-17 - Bulletted lists do not show bullets in the WYSIWYG editor o Improvements + XSTOUCAN-14 - In admin mode allow clicking anywhere on a tab to select it + XSTOUCAN-15 - Increase size of info box displayed by the #xwikimessageboxstart macro + XSTOUCAN-16 - Remove borders for tables using the memberstable class id * Watchlist plugin o Bugs + XPWATCHLIST-20 - Exception on Scheduler.WebHome about "isDocumentWatched" For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise13 Thanks -The XWiki dev team

17 years, 6 months

1
0
0 0

[xwiki-devs] [VOTE] Create a criteriaService

by Jean-Vincent Drean

Hi, I'd like to commit a new service : criteriaService [1]. This service, both available from java and velocity, allow to get various criteria (most of them extracted from the statistics plugin) : - Duration, a length of time - Period, a length of time defined by a min date and a max date - Range (formerly named Interval), an integer range (also allow to sublist a list according to the range) - RevisionCriteria, criteria to match document revisions (author, min date, max date, minor edits) - Scope, define an xwiki scope (page, space, wiki) Since 4 of those objects are from the statistics I've refactored the plugin and the application. Modifications in the public APIs : duration,period,range and scope factories won't be available from the statsService anymore since they have moved to criteriaService. Please shout if you're using any of those methods from velocity : - $xwiki.getStatsService().getDurationFactory() - $xwiki.getStatsService().getPeriodFactory() - $xwiki.getStatsService().getIntervalFactory() - $xwiki.getStatsService().getScopeFactory() Additions : - Document.getRevisions(RevisionCriteria), allowing to get document revisions matching the criteria - ListTool added to the rendering velocity context ($listtool) First use case, in the watchlist plugin the diffs sent by email will contain all the revisions since the last email notification (was : a diff between the last 2 revisions) [2]. [1] http://jira.xwiki.org/jira/browse/XWIKI-2159 [2] http://jira.xwiki.org/jira/browse/XPWATCHLIST-15 JV.

17 years, 6 months

5
5
0 0

[xwiki-devs] Component Based Architecture (help)

by Asiri Rathnayake

Hi Devs, Where can i find more details about the Component Based Architecture of XWiki ? I need as much information as possible. Sorry if the source of information is obvious, i couldn't do much search coz my machine is almost stuck running a neural network training algorithm (for my final year project) Thanks a lot. - Asiri

17 years, 6 months

1
1
0 0

[xwiki-devs] [VOTE] XE 1.3 release + dependent modules

by Vincent Massol

Hi, I'm planning the release 1.3 tomorrow with the following module releases: * Albatross Skin 1.4 * Toucan Skin 1.2 * Watchlist 1.3 * Core+Web+XE 1.3 Here's my +1 Thanks -Vincent

17 years, 6 months

7
6
0 0

[xwiki-devs] Why are certain Plugin classes final

by Sachin Mittal

Hi, I was in a dire need to extended on of the xwiki plugin classes MailSenderPlugin because xwiki implementation does not handle the password authentication to smtp servers that require one. I was unable to do so because the said class is declared final. My only option is to modify the xwiki code itself to make the desired change, but I certainly want to avoid this as I want to use only xwiki binaries to take advantage of future functionality implementation and bug fixes in by xwiki team. So is there any specific reason why these classes were defined as final? Is there anyway I can add such functionalities to xwki plugins without modifying the xwiki source. Thanks Sachin ----- http://www.assembla.com/wiki/show/sachin_mittal about me: -- View this message in context: http://www.nabble.com/Why-are-certain-Plugin-classes-final-tp15891099p15891… Sent from the XWiki- Dev mailing list archive at Nabble.com.

17 years, 6 months

1
0
0 0

[xwiki-devs] [ANN] DocHour day!

by Vincent Massol

Here's the new concept: as much people as possible in the XWiki community must spend 1 hour on Wednesday, 5th of March 2008 (today, sorry for the late announcement) and write documentation for 1 hour on xwiki.org. This is an effort to improve the quality and content of our documentation. Rules: * 1 hour * You choose at what time you want to work on the documentation. However most of us will be starting at 14:00 GMT+1. * On xwiki.org * You choose to document what you want. Ideas of missing documentation: - In JIRA: http://tinyurl.com/3xtn8t - Improve existing documentation - XWiki Watch documentation on http://watch.xwiki.org - XEM Documentation on http://manager.xwiki.org * Make sure you create a jira issue for the work you're doing and assign to yourself. The issue should be created in the XWiki Core project, with a "documentation" component. * If you can't do it on the 5th, then you can still do it on another day, as close as possible to the 5th of March ;) * The idea is to repeat this event every month or every 2 months. Thanks everyone, let's see what we can do with the power of the community! :) -Vincent

17 years, 6 months

2
5
0 0

[xwiki-devs] [VOTE] Move XWiki.getFlash()/flash.vm in a flash macro in macros.vm

by Vincent Massol

Hi, I've just seen that we have a XWiki.getFlash() method which just renders a flash.vm template which simply output an <object classid=...> to display a flash animation. This has nothing to do in the core proper IMO. I propose to move this in the macro.vm as a #flash macro. WDYT? Here's my +1 Thanks -Vincent

17 years, 6 months

4
3
0 0

[xwiki-devs] [vote] removing the LinkMacro

by Stéphane Laurière

Hi everyone, During the documentation hour today [1] we noticed that the LinkMacro coming from Radeox is actually not useful: it's entirely available from standard XWiki links (possibly with images additionally). Hence I propose that: 1) we disable it (and even remove it from our custom Radeox) 2) we close as "won't fix" JIRA#XWIKI-1481 Here's my +1 for both [1] http://intranet.xpertnet.biz/xwiki/bin/view/Tech/DocHour20080305 Stéphane -- Stéphane Laurière slauriere(a)xwiki.com XWiki http://www.xwiki.com http://concerto.xwiki.com http://nepomuk.semanticdesktop.org

17 years, 6 months

4
5
0 0

Re: [xwiki-devs] [xwiki-notifications] r8200 - in xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki: . web

by Vincent Massol

Hi Sergiu, First let me say this is cool! :) Some minor comments below. On Mar 4, 2008, at 10:55 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-03-04 22:55:30 +0100 (Tue, 04 Mar 2008) > New Revision: 8200 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java > Log: > XWIKI-1522: Rewrite the notification mechanism > Notifications are sent > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-04 18:33:04 UTC (rev 8199) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-04 21:55:30 UTC (rev 8200) > @@ -76,6 +76,11 @@ > import org.exoplatform.container.RootContainer; > import org.hibernate.HibernateException; > import org.securityfilter.filter.URLPatternMatcher; > +import org.xwiki.observation.ObservationManager; > +import org.xwiki.observation.event.ActionExecutionEvent; > +import org.xwiki.observation.event.DocumentDeleteEvent; > +import org.xwiki.observation.event.DocumentSaveEvent; > +import org.xwiki.observation.event.DocumentUpdateEvent; > > import com.xpn.xwiki.api.Api; > import com.xpn.xwiki.api.Document; > @@ -1070,14 +1075,37 @@ > XWikiDocument originalDocument = doc.getOriginalDocument(); > > // Notify listeners about the document change > - getNotificationManager().preverify(doc, originalDocument, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + if (originalDocument == null || > originalDocument.isNew()) { > + getNotificationManager().preverify(doc, > originalDocument, > + XWikiDocChangeNotificationInterface.EVENT_NEW, > context); > + } else { > + getNotificationManager().preverify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + } > > getStore().saveXWikiDoc(doc, context); > > - // Notify listeners about the document change > - getNotificationManager().verify(doc, originalDocument, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + try { > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + // Notify listeners about the document change > + if (originalDocument == null || > originalDocument.isNew()) { > + getNotificationManager().verify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_NEW, context); > + if (om != null) { > + om.notify(new > DocumentSaveEvent(doc.getFullName()), doc, context); > + } It seems you're using both notification mechanisms, which is fine but I think this warrants some javadoc explanations. > > + } else { > + getNotificationManager().verify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + if (om != null) { > + om.notify(new > DocumentUpdateEvent(doc.getFullName()), doc, context); > + } > + } > + } catch (Exception ex) { > + LOG.warn("Failed to send document notifications", > ex); Our rule is: no stack trace printing for warnings. Only for errors. I would consider this an error. Also I would put more information in the text like for what document it failed. > + } > } finally { > if ((server != null) && (database != null)) { > context.setDatabase(database); > @@ -3406,8 +3434,16 @@ > true); > } > getStore().deleteXWikiDoc(doc, context); > - getNotificationManager().verify(new > XWikiDocument(doc.getSpace(), doc.getName()), doc, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + try { > + getNotificationManager().verify(new > XWikiDocument(doc.getSpace(), doc.getName()), doc, > + XWikiDocChangeNotificationInterface.EVENT_DELETE, > context); > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + om.notify(new DocumentDeleteEvent(doc.getFullName()), > doc, context); > + } catch (Exception ex) { > + LOG.warn("Failed to send document notifications", ex); > + } Same comments here. > > } > > public String getDatabase() > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/web/XWikiAction.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java 2008-03-04 18:33:04 UTC (rev 8199) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java 2008-03-04 21:55:30 UTC (rev 8200) > @@ -35,6 +35,8 @@ > import org.apache.struts.action.ActionForward; > import org.apache.struts.action.ActionMapping; > import org.apache.velocity.VelocityContext; > +import org.xwiki.observation.ObservationManager; > +import org.xwiki.observation.event.ActionExecutionEvent; > > import com.xpn.xwiki.XWiki; > import com.xpn.xwiki.XWikiContext; > @@ -284,6 +286,14 @@ > } catch (Throwable e) { > e.printStackTrace(); > } > + try { > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + om.notify(new > ActionExecutionEvent(mapping.getName()), context.getDoc(), context); > + } catch (Throwable ex) { > + LOG.warn("Cannot send notifications", ex); Same here too. > > + } > > if (monitor != null) { > monitor.endTimer("notify"); Thanks -Vincent

17 years, 6 months

2
1
0 0

[xwiki-devs] bypass hasProgrammingRights()

by Raffaele Viola

Hi all, how can I bypass hasProgrammingRights() in the mathod getDocument() of the class com.xpn.xwiki.api.Document ? Thanks raffo

17 years, 6 months

2
1
0 0

[xwiki-devs] Moving to continuum 1.1

by Vincent Massol

Hi, I'm moving our CI build to continuum today. More precisely: * I've modified the TC build so that it does only "mvn clean install" instead of "mvn clean deploy". I've left the site deployment for now though. I've also removed the email notifications. * I've modified our continuum instance to do "mvn clean deploy". I'm going to work today on stabilizing the build to ensure all is ok and when this is the case I'll add the email notifications. http://continuum.xwiki.org/continuum/projectGroupSummary.action?projectGrou… Thanks -Vincent

17 years, 6 months

1
0
0 0

Re: [xwiki-devs] [xwiki-notifications] r8202 - xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/resources

by Vincent Massol

Hi Sergiu, Can you explain when the "form too large" error is happening and under what conditions? I read http://www.xwiki.org/xwiki/bin/view/FAQ/FormTooLargeError but didn't understand when it happens. Also, we must add comments in the files you've modified below to explain why we're doing this since this is not something obvious. Thanks -Vincent On Mar 5, 2008, at 1:43 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-03-05 01:43:57 +0100 (Wed, 05 Mar 2008) > New Revision: 8202 > > Modified: > xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.bat > xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh > xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.bat > xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.sh > Log: > XTJETTY-6: Increase the default maximum form content size on Jetty > Done. The new default is 1 million bytes. > > > Modified: xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/ > main/resources/start_xwiki.bat > =================================================================== > --- xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.bat 2008-03-04 23:38:30 UTC (rev 8201) > +++ xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.bat 2008-03-05 00:43:57 UTC (rev 8202) > @@ -2,7 +2,7 @@ > set LANG=fr_FR.ISO8859-1 > set JETTY_HOME=jetty > set JETTY_PORT=8080 > -set JAVA_OPTS=-Xmx300m > +set JAVA_OPTS=-Xmx300m - > Dorg.mortbay.http.HttpRequest.maxFormContentSize=1000000 > > REM Ensure the logs directory exists as otherwise Jetty reports an > error > if not exist %JETTY_HOME%\logs mkdir %JETTY_HOME%\logs > > Modified: xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/ > main/resources/start_xwiki.sh > =================================================================== > --- xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh 2008-03-04 23:38:30 UTC (rev 8201) > +++ xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki.sh 2008-03-05 00:43:57 UTC (rev 8202) > @@ -17,7 +17,7 @@ > cd "$PRGDIR" > > JETTY_HOME=jetty > -JAVA_OPTS=-Xmx300m > +JAVA_OPTS=-Xmx300m - > Dorg.mortbay.http.HttpRequest.maxFormContentSize=1000000 > > # The port on which to start Jetty can be passed to this script as > the first argument > if [ -n "$1" ]; then > > Modified: xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/ > main/resources/start_xwiki_debug.bat > =================================================================== > --- xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.bat 2008-03-04 23:38:30 UTC (rev 8201) > +++ xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.bat 2008-03-05 00:43:57 UTC (rev 8202) > @@ -2,7 +2,7 @@ > set LANG=fr_FR.ISO8859-1 > set JETTY_HOME=jetty > set JETTY_PORT=8080 > -set JAVA_OPTS=-Xmx300m -Xdebug -Xnoagent -Djava.compiler=NONE - > Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 > +set JAVA_OPTS="-Xmx300m -Xdebug -Xnoagent -Djava.compiler=NONE - > Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 - > Dorg.mortbay.http.HttpRequest.maxFormContentSize=1000000" > > # Jetty requires a logs directory to exist > if not exist %JETTY_HOME%\logs mkdir %JETTY_HOME%\logs > > Modified: xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/ > main/resources/start_xwiki_debug.sh > =================================================================== > --- xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.sh 2008-03-04 23:38:30 UTC (rev 8201) > +++ xwiki-platform/xwiki-tools/trunk/xwiki-jetty-resources/src/main/ > resources/start_xwiki_debug.sh 2008-03-05 00:43:57 UTC (rev 8202) > @@ -17,7 +17,7 @@ > cd "$PRGDIR" > > JETTY_HOME=jetty > -JAVA_OPTS="-Xmx300m -Xdebug -Xnoagent -Djava.compiler=NONE - > Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005" > +JAVA_OPTS="-Xmx300m -Xdebug -Xnoagent -Djava.compiler=NONE - > Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 - > Dorg.mortbay.http.HttpRequest.maxFormContentSize=1000000" > > # For enabling YourKit Profiling: > # JAVA_OPTS="$JAVA_OPTS -agentlib:yjpagent"

17 years, 6 months

1
0
0 0

[xwiki-devs] MetadataLuceneTutorial on xwiki.org - Where should it go?

by Vincent Massol

Hi everyone and Jean-Vivien, Jean-Vivien has done a lot of good work adding a tutorial on xwiki.org. See http://platform.xwiki.org/xwiki/bin/view/DevGuide/MetadataLuceneTutorial However I'm wondering where we should put it. Here's my current thinking: * This tutorial reflects Jean-Vivien's point of view only since it's never been discussed AFAIK and there's no general agreement about its content with the rest of the xwiki developers. As such I don't think it can be located in at the same level as the other tutorials which have been "endorsed" by the xwiki community. I see 2 solutions: 1) We move it to the draft area and Jean-Vivien submits it for review to the xwiki dev community. If the community agrees this is the right way to implement it we put it with the other tutorials/ 2) We move it to a contribution area that clearly marks the document as a contributor's view and not as endorsed by the xwiki development community. We don't have such a place today so we'll need to create it. We could create it as a subpage of the Tutorial page in the DevGuide or we could move it to the code zone to the code snippet space since what Jean-Vivien has done is basically provide code snippets to extend xwiki. It's a little bit more than a code snippet since it's also a tutorial so I'm not sure the code zone is the best place for it. WDYT? Jean-Vivien, some quick comments/questions on the content: * Jens Karmer was the original author of the Lucene plugin. Since then it's been worked on by numerous people. * You shouldn't put ":" in titles * The tutorial is missing a section at the beginning to explain what the tutorial is about * I haven't read the tutorial yet but if what you've done is useful why not consider improving xwiki's core to support what you need? For example it seems to me you're asking for a way to add custom metadata to the lucene plugin. This could easily be added as part of the lucene plugin API. Thanks -Vincent

17 years, 6 months

2
5
0 0

Re: [xwiki-devs] Building XWiki Core

by sachin mittal

Hi, JAVA_HOME points to jdk installation directory. JRE_HOME points to jre installation directory. I too have both installed and variables set. Try removing JRE_HOME for a change and see if this works. Also do the following: delete existing mvn folder. unzip mvn2.1 snapshot zip available on dev.xwiki in c folder. You can add the path to mvn bin in your system path. Then try mvn -version I have been building xwiki from source for quiet some time on windows and it works fine. If this still does not work you can connect me on sachin_mittal on skype and I would try to help you with the same. Thanks Sachin ---------------------------------------------------------------------- > > Message: 1 > Date: Tue, 4 Mar 2008 15:55:31 -0600 > From: "Kamna Jain" <kammy.scorpi(a)gmail.com> > Subject: Re: [xwiki-devs] Building XWiki Core > To: devs(a)xwiki.org > Message-ID: > <fb681d280803041355q1b3dd893uf1769a2ba41156c1(a)mail.gmail.com> > Content-Type: text/plain; charset="iso-8859-1" > > Yes, I have both JDK and JRE installed in the same location. (is that a > problem?) > Sachin, I did add the bin dir. of mvn install to the Path variable but it > does not seem to help. > mvn --version also gives the same error as mvn install: > > ERROR: JAVA_HOME not found in your environment. > Please set the JAVA_HOME variable in your environment to match the > location of your Java installation > > This is the error I get. > > Thanks >

17 years, 6 months

1
0
0 0

Re: [xwiki-devs] Building XWiki Core

by Kamna Jain

Yes, I have both JDK and JRE installed in the same location. (is that a problem?) Sachin, I did add the bin dir. of mvn install to the Path variable but it does not seem to help. mvn --version also gives the same error as mvn install: ERROR: JAVA_HOME not found in your environment. Please set the JAVA_HOME variable in your environment to match the location of your Java installation This is the error I get. Thanks On Tue, Mar 4, 2008 at 1:45 AM, <devs-request(a)xwiki.org> wrote: > Send devs mailing list submissions to > devs(a)xwiki.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.xwiki.org/mailman/listinfo/devs > or, via email, send a message with subject or body 'help' to > devs-request(a)xwiki.org > > You can reach the person managing the list at > devs-owner(a)xwiki.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of devs digest..." > > > Today's Topics: > > 1. Re: Building Xwiki core (Sergiu Dumitriu) > 2. [proposal] upgrade web-gwt to gwt 1.4 (ancapaula.luca(a)xwiki.com) > 3. Re: [proposal] upgrade web-gwt to gwt 1.4 (Sergiu Dumitriu) > 4. Re: GWT 1.4 upgrade (ancapaula.luca(a)xwiki.com) > 5. Re: [proposal] upgrade web-gwt to gwt 1.4 (Jerome Velociter) > 6. Re: Building Xwiki core (Kamna Jain) (sachin mittal) > 7. Re: [xwiki-notifications] r8181 - > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki > (Vincent Massol) > 8. Re: [xwiki-notifications] r8184 - > xwiki-platform/core/branches/xwiki-core-1.3 > /xwiki-core/src/main/java/com/xpn/xwiki > (Vincent Massol) > 9. Re: GWT 1.4 upgrade (Vincent Massol) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 03 Mar 2008 22:43:48 +0100 > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > Subject: Re: [xwiki-devs] Building Xwiki core > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <47CC7114.4040006(a)xwiki.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Kamna Jain wrote: > > Yes, > > I am setting the JAVA_HOME variable with DOS prompt > > and after I set it, I log of and then it is available in the list of > > env. variables after I log back in. > > But, when I try to run mvn install, it still gives me the same error. > > > > Also, although, I set the M2_HOMe variable, I am not able to use mvn > > command without its location! (I have to write the full path of the > > mvn.bat file and then say install after a space) > > I dont know what I am doing wrong. > > > > Thanks for your replies. > > > > > > I remember seeing this on another windows machine. It has something to > do with that crappy thing they like to call an Operating System and the > way it executes the maven script. > > Do you by any chance have installed both the JDK and the JRE? > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > > ------------------------------ > > Message: 2 > Date: Mon, 3 Mar 2008 23:31:15 +0100 (CET) > From: ancapaula.luca(a)xwiki.com > Subject: [xwiki-devs] [proposal] upgrade web-gwt to gwt 1.4 > To: devs(a)xwiki.org > Message-ID: <51105.130.79.213.35.1204583475.squirrel(a)mail.xwiki.com> > Content-Type: text/plain;charset=iso-8859-1 > > Hi developers! > > I'd like to upgrade the web-gwt module to gwt 1.4, as in the dedicated > branch > > https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/web/branches/xwiki-web-g… > . > A stable upgrade will be finalized tomorrow, although there will still > remain a couple of appearance issues to be solved until the xwiki-web 1.4 > milestone release. > > WDYT? > > > > ------------------------------ > > Message: 3 > Date: Mon, 03 Mar 2008 23:39:36 +0100 > From: Sergiu Dumitriu <sergiu(a)xwiki.com> > Subject: Re: [xwiki-devs] [proposal] upgrade web-gwt to gwt 1.4 > To: XWiki Developers <devs(a)xwiki.org> > Message-ID: <47CC7E28.90507(a)xwiki.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > ancapaula.luca(a)xwiki.com wrote: > > Hi developers! > > > > I'd like to upgrade the web-gwt module to gwt 1.4, as in the dedicated > > branch > > > https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/web/branches/xwiki-web-g… > > . > > A stable upgrade will be finalized tomorrow, although there will still > > remain a couple of appearance issues to be solved until the xwiki-web > 1.4 > > milestone release. > > > > WDYT? > > > > +1 > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > > ------------------------------ > > Message: 4 > Date: Mon, 3 Mar 2008 23:51:35 +0100 (CET) > From: ancapaula.luca(a)xwiki.com > Subject: Re: [xwiki-devs] GWT 1.4 upgrade > To: "XWiki Developers" <devs(a)xwiki.org> > Message-ID: <39500.130.79.213.35.1204584695.squirrel(a)mail.xwiki.com> > Content-Type: text/plain;charset=iso-8859-1 > > Because from the reliability point of view the native gwt solution is > better than a third-party library and produces cleaner code while the > styling drawback can easily be ameliorated, we have chosen it from the two > and applied it for the gwt 1.4 upgrade branch. > > We also didn't get any response from the gwt-tk mailing list regarding a > future release. > > > Hi devs, > > > > We have planned the GWT 1.4 upgrade for the next XWatch milestone at the > > end of march. For this, we need to make a decision regarding the web-gwt > > dependencies (for the moment, the xwiki gwt dialogs rely on the gwt-tk > > library that does not yet have a release for gwt 1.4) so we must choose > > from: > > - using another library to provide this functionality, particularly the > > MyGwt library > > pros: nice looks and good API + the possibility of using the > library > > components in including projects. > > cons: code changes required by the clean switch (updating all > involved > > classes to use library API instead of GWT API), the lack of a maven > > repository with all available MyGwt versions (only 0.5.0 rc). As well, > > while testing, I experienced a couple of rendering issues (caused, > > seemingly by the use of the strict or xhtml DTD). > > - using the native gwt modal dialogs introduced in 1.4: > > pros: not styled (we totally control the styling process and can > build an > > uniform look); widgets consistency, at least at this level. A big > > advantage is that the web-gwt module will not depend on any other > library > > anymore. > > cons: not styled, the usual GWT API (which can be poor in some > > situations); GWT also has some problems caused by the standard mode > > interpretation in browsers (caused by the doctype declaration) but in > > this situation the code seems to be stable. > > > > What do you think? > > > > _______________________________________________ > > devs mailing list > > devs(a)xwiki.org > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > > ------------------------------ > > Message: 5 > Date: Tue, 4 Mar 2008 05:34:44 +0100 (CET) > From: "Jerome Velociter" <jerome(a)xwiki.com> > Subject: Re: [xwiki-devs] [proposal] upgrade web-gwt to gwt 1.4 > To: "XWiki Developers" <devs(a)xwiki.org> > Message-ID: <57026.86.124.34.145.1204605284.squirrel(a)mail.xwiki.com> > Content-Type: text/plain;charset=iso-8859-1 > > +1, > > Jerome. > > > Hi developers! > > > > I'd like to upgrade the web-gwt module to gwt 1.4, as in the dedicated > > branch > > > https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/web/branches/xwiki-web-g… > > . > > A stable upgrade will be finalized tomorrow, although there will still > > remain a couple of appearance issues to be solved until the xwiki-web > 1.4 > > milestone release. > > > > WDYT? > > > > _______________________________________________ > > devs mailing list > > devs(a)xwiki.org > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > > ------------------------------ > > Message: 6 > Date: Tue, 4 Mar 2008 10:19:36 +0530 > From: "sachin mittal" <sjmittal(a)gmail.com> > Subject: Re: [xwiki-devs] Building Xwiki core (Kamna Jain) > To: devs(a)xwiki.org > Message-ID: > <79d89bcf0803032049r49a43339hf583a9d5f5526d5e(a)mail.gmail.com> > Content-Type: text/plain; charset="iso-8859-1" > > Hi, > Can you paste the console output. > You can add the maven bin directory to the path variable so that you dont > have to type the full path to mvn.bat every time you run the mvn scripts. > > Also what do you get when you type mvn -version in the command prompt. > > Thanks > Sachin > > > > > ---------------------------------------------------------------------- > > > > Message: 1 > > Date: Mon, 3 Mar 2008 15:32:30 -0600 > > From: "Kamna Jain" <kammy.scorpi(a)gmail.com> > > Subject: Re: [xwiki-devs] Building Xwiki core > > To: devs(a)xwiki.org > > Message-ID: > > <fb681d280803031332y756f2f66g72f65d3b687ca66(a)mail.gmail.com> > > Content-Type: text/plain; charset="iso-8859-1" > > > > Yes, > > I am setting the JAVA_HOME variable with DOS prompt > > and after I set it, I log of and then it is available in the list of > env. > > variables after I log back in. > > But, when I try to run mvn install, it still gives me the same error. > > > > Also, although, I set the M2_HOMe variable, I am not able to use mvn > > command > > without its location! (I have to write the full path of the mvn.bat file > > and > > then say install after a space) > > I dont know what I am doing wrong. > > > > Thanks for your replies. > > >

17 years, 6 months

2
1
0 0

[xwiki-devs] [VOTE] Change the attachment archive storage

by Sergiu Dumitriu

Hi devs, As detailed in another mail (http://lists.xwiki.org/pipermail/devs/2008-February/005344.html), the current attachment archive mechanism is very inefficient. We should write a new one, which stores attachment versions as plain binary data, and see if the current core is pluggable enough to allow the old mechanism to be preserved as a plugin, and possibly define other storage mechanisms, like a filesystem based one. Artem, do you think you can help, as this is something related to what you've been working on? -- Sergiu Dumitriu http://purl.org/net/sergiu/

17 years, 6 months

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs