- xwiki-devs@xwiki.org - lists.xwiki.org

[Proposal] XWiki syntax for line and strike

by Sergiu Dumitriu

We need to define the way the wiki syntax behaves, with examples and test cases. I created http://jira.xwiki.org/jira/browse/XWIKI-1206 for this purpose, as a container task. For the moment I have proposals for horizontal lines ( http://jira.xwiki.org/jira/browse/XWIKI-1242 ) and strikethrough ( http://jira.xwiki.org/jira/browse/XWIKI-1207 ). Please review the proposed [counter]examples and vote for them. Thanks, Sergiu -- http://purl.org/net/sergiu

18 years, 4 months

2
2
0 0

[ANN] XWiki 1.0 RC 5 Released

by Vincent Massol

The XWiki development team team is pleased to announce the availability of the 1.0 RC 5 release. Go grab it on http://www.xwiki.org/xwiki/bin/view/Main/Download The 1.0 RC4 release was supposed to be the last release before the 1.0 final but we've discovered some important bugs, the most important being that with RC4 you couldn't anymore copy/paste content from Word/Excel into the WYSIWYG editor. This release is a bug fix release and is planned to be promoted as the final 1.0 release on next Tuesday. Let's hope it's the last RC. * Bugs fixed: o XWIKI-1205 - Going to the Main.WebHome page on a wiki with an empty database generates a NPE o XWIKI-1210 - Nested lists are discarded by WYSIWYG editor o XWIKI-1224 - Html tags is escaped when we switch from wysiwyg editor to wiki editor o XWIKI-1225 - Entering a multiline cell content only keeps the first line when saved in WYSIWYG mode o XWIKI-1227 - Incorrect paragraph when copy and paste from other editor to WYSIWYG editor o XWIKI-1229 - Toolbar in Wysiwyg Editor cannot wrap properly under IE7 o XWIKI-1233 - Unindent button greyed out even though line is indented o XWIKI-1234 - Editor doesn't understand the 1. syntax notation for lists o XWIKI-1238 - Horizontal line breaks table * Improvement o XWIKI-1228 - Change the style sheet for select list in toolbar of WYSIWYG editor o XWIKI-1237 - Add handle button toolbar for font size and font family select in toolbar of visual editor. IMPORTANT: XWiki 1.0 RC 2 has fixed an important security issue in past releases where passwords were stored in clear in the database. Passwords are now hashed. If you are upgrading from a previous version, any new user or any password update will automatically get the password hashed. However existing users who do not change their passwords will still have their passwords in clear in the database. Thus, we are providing a tool to automatically hash all passwords from an existing database. See the full release notes on http://www.xwiki.org/xwiki/bin/view/ Main/ReleaseNotesXWiki10RC5 Enjoy -The XWiki development team

18 years, 4 months

1
0
0 0

XWiki 1.0 RC 5 is now staged for testing

by Vincent Massol

Hi everyone, I've staged the RC5 release on http://www.xwiki.org/10rc5/ It would be nice if some of you could quickly try it out (we'd like to release ASAP) and let us know if it's working as expected. Once we get a few confirmations we'll officially release it. You can check the release notes on http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWiki10RC5 Thanks a lot -Vincent (on behalf of the XWiki dev team)

18 years, 4 months

2
1
0 0

[VOTE] Release new 1.0 RC5 today

by Vincent Massol

Hi, We discovered yesterday some important issues in RC4 with the WYSIWYG editor. Namely: * [XWIKI-1205] - Going to the Main.WebHome page on a wiki with an empty database generates a NPE * [XWIKI-1224] - Html tags is escaped when we switch from wysiwyg editor to wiki editor * [XWIKI-1225] - Entering a multiline cell content only keeps the first line when saved in WYSIWYG mode * [XWIKI-1227] - Incorrect paragraph when copy and paste from other editor to WYSIWYG editor * [XWIKI-1229] - Toolbar in Wysiwyg Editor cannot wrap properly under IE7 These are too important and we can't promote RC4 as 1.0 final because of them. I'm proposing we release a quick RC5 today with these changes. Here's my +1 Thanks -Vincent

18 years, 4 months

4
5
0 0

[Proposal] Move XWiki.getService()/getPortalService() to an Exo plugin

by Vincent Massol

Hi, I'd like to move the public APIs getService() and getPortalService() in a separate Exo plugin. Advantages: 1) less cruft in XWiki classes 2) removes one dependency on Exo in XWiki core 3) better separation of concern ok with everyone? Thanks -Vincent

18 years, 4 months

4
3
0 0

xwiki on oracle 9

by yeboaher＠telkom.co.za

Hi chaps, I am prepared to fix the Oracle port. However, I cannot connect an svn client at work due to our network security policy. Can you package the latest stable source for me to work on? Many thanks. Ed

18 years, 4 months

2
1
0 0

Windows default install fails to start

by Shawn Lauzon

Hey guys -- I just grabbed the Windows .exe for rc4 to try it out quick, and noticed that it doesn't work out of the box. When I start it, I get this failure: 19:08:46.125 WARN!! [main] org.mortbay.jetty.servlet.WebApplicationContext.doStart(WebApplicationContext.java:519) >12> Configuration error on file:/C:/Program%20Files/XWiki/xwikionjetty/webapps/xwiki/ org.apache.xerces.impl.dv.DVFactoryException: DTD factory class org.apache.xerces.impl.dv.dtd.DTDDVFactoryImpl does not extend from DTDDVFactory. at org.apache.xerces.impl.dv.DTDDVFactory.getInstance(Unknown Source) at org.apache.xerces.impl.dv.DTDDVFactory.getInstance(Unknown Source) at org.apache.xerces.impl.xs.opti.SchemaParsingConfig.<init>(Unknown Source) at org.apache.xerces.impl.xs.opti.SchemaParsingConfig.<init>(Unknown Source) at org.apache.xerces.impl.xs.traversers.XSDHandler.<init>(Unknown Source) at org.apache.xerces.impl.xs.traversers.XSDHandler.<init>(Unknown Source) ... I figured out that I needed to delete the xerces jar file from our lib directory, and after I did that it worked. But this is not at all obvious, and really for something that is stated "Should be used by first-time users.", it'll leave a very bad impression. I would just add it to the Instructions, but I'm not sure if that is good enough. Would it make sense to modify the build script to delete the xerces jar file when creating the Windows exe? shawn.

18 years, 4 months

3
3
0 0

JDK1.6 and why xwiki needs XWikiJDBCConnection?

by Artem Melentyev

Hello. I would like the xwiki 1.0 release be able to compile/run on Java 1.6. Many users already use java 1.6. I see only one problem: XWikiJDBCConnection class. http://jira.xwiki.org/jira/browse/XWIKI-974 As I see, info from this class is not used in xwiki core. Main question: Why xwiki needs XWikiJDBCConnection? If it is not needed, we can easily remove it by patch http://jira.xwiki.org/jira/secure/attachment/10939/noXWikiJDBCConnection.pa… If it is needed, I can rewrite XWikiJDBCConnection using java reflections. -- Artem Melentyev, UralSU, CS401

18 years, 4 months

2
1
0 0

XWiki guide (setup, deploy & doc)

by Sanjay Jaiswar

Hi, Vincent, you asked me to discuss about this doc in the mailing list. This doc concentrates on complete setup guide for a newbie user (admin). Once setup is done, provided the help links for admin & user. I haven't created any redundant pages. Wherever required, xwiki links are re-used. Moreover, there are few additional links provided. This is the TOC of the doc. 1 Document Purpose 2 Prerequisites 2.1 Jdk 2.2 Tomcat Installation 2.3 Mysql 3 Database 3.1 Create Database 4 Xwiki Installation 4.1 Deploy Xwiki 4.2 Default Wiki Xar 4.3 Importing Xwiki Pages (Xar) 5 Xwiki Help 5.1 User's Guide 5.1.1 Video Tutorials 5.1.2 Features 5.2 Admin Guide 5.2.1 Create Groups 5.2.2 Add Users To Group Refer the attached doc. http://www.xwiki.org/xwiki/bin/view/Sandbox/InstallDevGuide Thanks, Sanjay

18 years, 4 months

2
1
0 0

compile gwt module of gelc error

by wanggsh＠gmail.com

Hi, I download the latest gelc application from repository and build with ant,get following error(JDK1.5,ANT 1.6.5 on Windows XP sp2): gelc.gwt: [gwtcompile] Compiling org.curriki.gwt.Main [gwtcompile] Output will be written into H:\SoftDeveloping\wiki\xwiki\EclipseSpa ce\gelc\build\org.curriki.gwt.Main [gwtcompile] Analyzing permutation #1 [gwtcompile] [ERROR] Unexpected internal compiler error [gwtcompile] java.lang.OutOfMemoryError: Java heap space BUILD FAILED H:\SoftDeveloping\wiki\xwiki\EclipseSpace\gelc\build.xml:76: Unable to compile G WT I can't found documents on build gelc,please help! Jackson

18 years, 4 months

2
1
0 0

[Proposal] Reorganizing JIRA projects

by Vincent Massol

Hi, We need to organize a bit better the different JIRA projects. Right now there are: - XWiki - XWiki Applications - XWiki Clients We need to clean the XWiki Applications and XWiki Clients projects. For this we need to define a strategy for where to put xwiki plugins, applications, etc. Here are some facts: * A JIRA project has the same versions for all components. This means one JIRA project per release lifecycle. And here's my proposal in term of JIRA projects: * "XWiki": - We put everything here that is tied to the XWiki Core release (1.0 RC2, 1.1 B1, etc). Right now there are several plugins that are still tied to the XWiki release (all the core plugins). So they should go in there for now. When we'll move out the plugins later on, we will then move their JIRA issues. * "XWiki Applications": - We remove this JIRA project * "XWiki Default Wiki": - We create this new JIRA project. Corresponds to xwiki- applications/wikis/default. - We move all issues from current XWiki JIRA project that have a "Default Wiki" component to it. - We define a version scheme for it. I propose to use the same versions as for XWiki core for now. But in the future it'll be possible to release the default wiki independently of XWiki Core. - We create components for the various XWiki applications that we haven't separated from the xwiki-applications/wikis/default yet (i.e. all except the Panels which has been moved out) * "XWiki Panels Application": - We create this JIRA project. Corresponds to xwiki-applications/ xarlets/panels - We define a version scheme for it. I propose to use the same versions as for XWiki core for now. But in the future it'll be possible to release the default wiki independently of XWiki Core. - We release the panels application on the forge instead of just releasing it as an attachment to http://www.xwiki.org/xwiki/bin/view/ Code/PanelsApplication. We'll continue to reference the download from that page but it'll point to OW's forge. We ensure it's also referenced from the main Download page on xwiki.org * "XWiki Selenium Application": - We create this JIRA project. Corresponds to xwiki-applications/ xarlets/selenium - We define a version scheme for it. I propose to start at 0.1 as it's still early stuff - Release it as 0.1 on the forge and, as above, modify xwiki.org to point to it (from the code zone). * "XWiki <plugin name> Plugin": - Where <plugin name> is: "Adwords", "Alexa", "Email Notification", "IP Resolver", "Laszlo", "Task Manager", "Terraserver" - The strategy is that once a plugin is moved out of the core to the xwiki-plugins/ dir, we create a JIRA project for it - We define a version scheme for them. I propose to start at 0.1 as we haven't released them yet. We shouldn't release any of them until we've tested it works with the latest version of XWiki Core. * "XWiki Clients": - We remove this JIRA project and move all current clients to the sandbox. Namely they are: "foxwiki", "anyedit", "p2pxwiki", "wiked" Others: * I'm not entirely sure what to do with these projects in xwiki- tools: build tools, package and cryptpasswords. * I think they're too small and not well-defined enough to warrant a JIRA project each. I'm proposing to create a Tools component in the main XWiki JIRA project for now to see how they develop in the future. WDYT? If you're ok I'm proposing to do the reorganization work. Thanks -Vincent

18 years, 4 months

2
3
0 0

Problem with new comment on save feature

by Vincent Massol

Hi, 1) In trunk, it's not possible to save without entering a comment. I think this should be optional. 2) When clicking on save with no comment there's a dialog box that pops up that asks for a comment but it's not possible to cancel it even though there's a cancel button Thanks -Vincent

18 years, 4 months

4
5
0 0

RE: [xwiki-dev] xwiki dev ideas

by Gurnani, Anil

Thanks to everyone. I got some great ideas for xwiki projects. I will go back and digest them and pick one that I really like (right now - I like them all - that's why it's hard to pick just one :-) Thanks again Anil *********************************************************************** Bear Stearns is not responsible for any recommendation, solicitation, offer or agreement or any information about any transaction, customer account or account activity contained in this communication. ***********************************************************************

18 years, 4 months

2
1
0 0

Save user input

by evelyne24＠gmail.com

Well, thank you for the responses on my previous posts. Another "difficult" question (for me :( )... Here is the code: #foreach($obj in $doc.getObjects("Movr.MediaHasPersonClass")) #if($context.action=='view') #set($personObj= $xwiki.getDocument($obj.getProperty('person').value).getObject("Movr.PersonClass")) ##link to person's page #set($personURL = $xwiki.getURL("$obj.getProperty('person').value")) <a href="$personURL">$personObj.firstName $personObj.lastName</a> #else ###inline ##ajax input suggest <input id="inputSuggest$velocityCount" name="inputSuggest" alt="Suggestions" type="text" /> $obj.person The question is the following one: I have an Ajax input suggest (which works just fine, it retrieves from the database the information I need), which is suppose to help me add another object of type PersonClass, by selecting from the ones that are already in the database. My class MediaHasPersonClass has a field person, of type DatabaseList, which initially had attached a Hibernate query to retrieve all the persons from the database and display them in a select. Now, I'm using this Ajax suggest so I would like to somehow tell xwiki that the person whom I selected from the suggest is the correspondent object (for instance, if I write $obj.person I get an xwiki rendered input with the name of a person from the database, and if I change the name and save it, the modifications will be kept). I would like to know how can I do that for my own input. I hope I explained somehow what I would like to know... Thanks. Evelina

18 years, 4 months

2
1
0 0

Problem

by evelyne24＠gmail.com

Hello all, I wrote a post on xwiki-users this morning, because someone told me there is where the questions about "how to" are supposed to go, but nobody answered (and I figured it out by myself, with the help of Sergiu) so I'll try my luck here, as I really need some help. In a velocity script I receive a request and I take the value with #set($input =$request.get("param")). My question is, how can I apply string transformations (i.e to lowercase, split the string etc) to this variable($input) in velocity? I looked everywhere but I guess I miss something. Please help! Thank you, Evelina Slatineanu

18 years, 4 months

4
3
0 0

[ANN] XWiki 1.0 RC 4 Released

by Vincent Massol

The XWiki development team team is pleased to announce the availability of the 1.0 RC 4 release. Go grab it on http://www.xwiki.org/xwiki/bin/view/Main/Download This release is a bug fix release and is planned to be promoted as the final 1.0 release next week if no critical bug is found till then. * Bugs fixed: o XWIKI-1023 - Probable mistake in strikethrough regular expression match o XWIKI-1151 - Wyswiyg editor has problem with lists and carriage returns o XWIKI-1152 - Wysiwyg loosing content when copy pasting and switching to list o XWIKI-1161 - Exception when manipulating class fields causes them to "disappear" o XWIKI-1163 - Remove lines space before and after the list, table o XWIKI-1164 - Editor removes line feeds o XWIKI-1165 - WYSIWYG editor doesn't understand the "-" notation for lists o XWIKI-1166 - WYSIWYG editor doesn't understand the <text> , it's ignored o XWIKI-1167 - Create 2 lists that separated by a line space then it merges both lists o XWIKI-1172 - "Indent" button generates escaped <bloquote> wiki markup o XWIKI-1180 - The blockquote is never removed o XWIKI-1182 - Empty line after list missing o XWIKI-1183 - URLs entered in wiki markup are displayed without the protocol part o XWIKI-1184 - Tooltip for Ordered List is wrong o XWIKI-1189 - Reduce the amount of space before the level 1 title o XWIKI-1190 - One empty line at the start of a document is stripped when rendered and edited again o XWIKI-1191 - Macromapping of velocity macros when there's no Velocity macro page defined fail and instead include the WebHome page of the current space o XWIKI-1192 - {skype} macro mapping to #skype velocity macro isn't working o XWIKI-1197 - exception in rename nonexistent document o XWIKI-1204 - Incorrect type of code macro when we switch from wiki => wysiwyg => wiki * Improvements o XWIKI-1039 - The albatross skin does not distinguish disabled form fields o XWIKI-1109 - XWikiRightServiceImpl.listAllLevels uses an expensive method for producing the rights list. o XWIKI-1200 - Hide actions in the menu that don't have a meaning for a non-existing document IMPORTANT: XWiki 1.0 RC 2 has fixed an important security issue in past releases where passwords were stored in clear in the database. Passwords are now hashed. If you are upgrading from a previous version, any new user or any password update will automatically get the password hashed. However existing users who do not change their passwords will still have their passwords in clear in the database. Thus, we are providing a tool to automatically hash all passwords from an existing database. See the full release notes on http://www.xwiki.org/xwiki/bin/view/ Main/ReleaseNotesXWiki10RC4 Enjoy -The XWiki development team

18 years, 4 months

1
0
0 0

RE: [xwiki-dev] xwiki dev ideas

by Gurnani, Anil

My strongest skills are in java,j2ee,and jms architecture and development - I am also pretty good at documenting stuff (I used to write articles for computer magazines explaining some high tech topic) - followed by DB and infrastructure stuff like machines, OS, networking, TCP/IP and Internet, etc. etc. (http://www.anilgurnani.com should give a pretty good idea about me) on the infrastructure front, I can provide hosting space, subversion, wikis, downloads, mirrors in US - etc. etc. through my previous venture (http://www.oncr.com) Doing some documentation may be a good starting point (as I will need to learn before I can document) - is there any particular type of documentation that is currently needed? Thanks Anil -----Original Message----- From: Sergiu Dumitriu [mailto:sergiu.dumitriu@gmail.com] Sent: Wednesday, May 09, 2007 9:52 AM To: xwiki-dev(a)objectweb.org Subject: Re: [xwiki-dev] xwiki dev ideas Hi, You probably did notice from the mailing lists that we do need developers (and testers), especially at this point, when XWiki 1.0 should be out in a few days, and when the XWiki 2.0 architecture must be finalized and implemented. So your help is very appreciated. "Not hard to implement" differs from person to person. Could you tell us what are your strong points? Java, databases, html+css, javascript, velocity, testing, documentation? On 5/9/07, Gurnani, Anil <agurnani(a)bear.com> wrote: > Ok so I have been a member of the dev mailing list for over six months > and I have been playing with the latest releases of xwiki for six months > and now I am itching to contribute :-) > > Anybody has any ideas for some cool (yet not very hard to implement > cause my understanding of the code is very minimal at this point) > feature to get my feet wet? > > Anil > > > > > Sergiu -- http://purl.org/net/sergiu *********************************************************************** Bear Stearns is not responsible for any recommendation, solicitation, offer or agreement or any information about any transaction, customer account or account activity contained in this communication. ***********************************************************************

18 years, 4 months

2
1
0 0

xwiki dev ideas

by Gurnani, Anil

Ok so I have been a member of the dev mailing list for over six months and I have been playing with the latest releases of xwiki for six months and now I am itching to contribute :-) Anybody has any ideas for some cool (yet not very hard to implement cause my understanding of the code is very minimal at this point) feature to get my feet wet? Anil *********************************************************************** Bear Stearns is not responsible for any recommendation, solicitation, offer or agreement or any information about any transaction, customer account or account activity contained in this communication. ***********************************************************************

18 years, 4 months

3
2
0 0

trunk is broken...

by Vincent Massol

FYI trunk has an issue probably due to the latest commits: when you edit a page the save/preview/etc buttons are not displayed and a velocity error is shown instead. -Vincent

18 years, 4 months

3
4
0 0

XWiki 1.0 RC 4 is now staged for testing

by Vincent Massol

Hi everyone, I've staged the RC4 release on http://www.xwiki.org/10rc4/ It would be nice if some of you could quickly try it out (we'd like to release ASAP) and let us know if it's working as expected. Once we get a few confirmations we'll officially release it. You can check the release notes on http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWiki10RC4 Thanks a lot -Vincent (on behalf of the XWiki dev team)

18 years, 4 months

1
0
0 0

Category (and hierarchical category).

by phl

Hello, 1) I have not yet understand what is a category in xWiki and how to fill it (I succeed to create mine, but I can't put anything into it). 2) In fact, I looking for a category as mediawiki. For instance, my xwiki is a presentation of books. So when I see the book main page, I will have the text and the list of the subcategories (book of mathematics, book of physics, ...). When I add a new sub category (like books on computer sciences), I would like that it will be automatically add to the book main page. And I will also that this page shows to the user the subcategory like : documentation about compiler, and documentation about wiki. And in the page about wiki, I would like to have a list of hyperlink to page that describes mediawiki, xwiki, ..... Are this kind of mechanism fully , partilly coded into xwiki ? If not how to code it ? Thanks, PHL. -- View this message in context: http://www.nabble.com/Category-%28and-hierarchical-category%29.-tf3704021.h… Sent from the XWiki- Dev mailing list archive at Nabble.com.

18 years, 4 months

2
1
0 0

Re: [xwiki-commits] r3134 - in xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api: client server

by Vincent Massol

Hi Ludovic, Do you think you could add the copyright and a short javadoc (or at least please remove the useless class javadoc generated by IDEA which makes control tools think a javadoc is there and wrongly increase our CLOC statistics :))? I noticed that you miss these whenever you add new classes... +package com.xpn.xwiki.gwt.api.client; + +import com.google.gwt.user.client.rpc.IsSerializable; + +/** + * Created by IntelliJ IDEA. + * User: ldubost + * Date: 8 mai 2007 + * Time: 16:38:24 + * To change this template use File | Settings | File Templates. + */ If I dared I would ask you to also apply our coding styles... :) It's defined in there: http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle (I have taken the time to write a nice doc about it to make it easy for everyone to apply our code style). Thanks -Vincent On May 8, 2007, at 8:39 PM, Ludovic Dubost wrote: > Author: ludovic > Date: 2007-05-08 20:39:48 +0200 (Tue, 08 May 2007) > New Revision: 3134 > > Added: > xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiGWTException.java > Removed: > xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > LoginException.java > xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > RightException.java > Modified: > xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiService.java > xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/server/ > XWikiServiceImpl.java > Log: > XWIKI-1195 Improvement of error reporting in GWT API > > Deleted: xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/LoginException.java > =================================================================== > --- xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > LoginException.java 2007-05-08 18:39:00 UTC (rev 3133) > +++ xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > LoginException.java 2007-05-08 18:39:48 UTC (rev 3134) > @@ -1,27 +0,0 @@ > -package com.xpn.xwiki.gwt.api.client; > - > -import com.google.gwt.user.client.rpc.IsSerializable; > -/* > - * Copyright 2006, XpertNet SARL, and individual contributors as > indicated > - * by the contributors.txt. > - * > - * This is free software; you can redistribute it and/or modify it > - * under the terms of the GNU Lesser General Public License as > - * published by the Free Software Foundation; either version 2.1 of > - * the License, or (at your option) any later version. > - * > - * This software is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this software; if not, write to the Free > - * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > - * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > - * > - * @author jeremi > - */ > - > -public class LoginException extends Exception implements > IsSerializable { > -} > > Deleted: xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/RightException.java > =================================================================== > --- xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > RightException.java 2007-05-08 18:39:00 UTC (rev 3133) > +++ xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > RightException.java 2007-05-08 18:39:48 UTC (rev 3134) > @@ -1,27 +0,0 @@ > -package com.xpn.xwiki.gwt.api.client; > - > -import com.google.gwt.user.client.rpc.IsSerializable; > -/* > - * Copyright 2006, XpertNet SARL, and individual contributors as > indicated > - * by the contributors.txt. > - * > - * This is free software; you can redistribute it and/or modify it > - * under the terms of the GNU Lesser General Public License as > - * published by the Free Software Foundation; either version 2.1 of > - * the License, or (at your option) any later version. > - * > - * This software is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Public License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this software; if not, write to the Free > - * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > - * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > - * > - * @author jeremi > - */ > - > -public class RightException extends Exception implements > IsSerializable { > -} > > Added: xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/XWikiGWTException.java > =================================================================== > --- xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiGWTException.java 2007-05-08 18:39:00 UTC (rev 3133) > +++ xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiGWTException.java 2007-05-08 18:39:48 UTC (rev 3134) > @@ -0,0 +1,61 @@ > +package com.xpn.xwiki.gwt.api.client; > + > +import com.google.gwt.user.client.rpc.IsSerializable; > + > +/** > + * Created by IntelliJ IDEA. > + * User: ldubost > + * Date: 8 mai 2007 > + * Time: 16:38:24 > + * To change this template use File | Settings | File Templates. > + */ > +public class XWikiGWTException extends Exception implements > IsSerializable { > + private String message; > + private String fullMessage; > + private int code; > + private int module; > + > + public XWikiGWTException() { > + super(); > + } > + > + public XWikiGWTException(String message, String fullMessage, > int code, int module) { > + super(); > + this.setMessage(message); > + this.setFullMessage(fullMessage); > + this.setCode(code); > + this.setModule(module); > + } > + > + public String getMessage() { > + return message; > + } > + > + public void setMessage(String message) { > + this.message = message; > + } > + > + public String getFullMessage() { > + return fullMessage; > + } > + > + public void setFullMessage(String fullMessage) { > + this.fullMessage = fullMessage; > + } > + > + public int getCode() { > + return code; > + } > + > + public void setCode(int code) { > + this.code = code; > + } > + > + public int getModule() { > + return module; > + } > + > + public void setModule(int module) { > + this.module = module; > + } > +} > > Modified: xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > client/XWikiService.java > =================================================================== > --- xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiService.java 2007-05-08 18:39:00 UTC (rev 3133) > +++ xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/client/ > XWikiService.java 2007-05-08 18:39:48 UTC (rev 3134) > @@ -40,64 +40,64 @@ > */ > public interface XWikiService extends RemoteService { > > - public Document getDocument(String fullName); > - public Document getDocument(String fullName, boolean > withObject, boolean withRenderedContent); > - public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers); > + public Document getDocument(String fullName) throws > XWikiGWTException; > + public Document getDocument(String fullName, boolean > withObject, boolean withRenderedContent) throws XWikiGWTException; > + public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers) throws > XWikiGWTException; > > - public Document getDocument(String fullName, boolean > withObject, boolean viewDisplayers, boolean editDisplayers, boolean > withRenderedContent); > + public Document getDocument(String fullName, boolean > withObject, boolean viewDisplayers, boolean editDisplayers, boolean > withRenderedContent) throws XWikiGWTException; > > - public String getUniquePageName(String space); > - public String getUniquePageName(String space, String pageName); > - public Document getUniqueDocument(String space, String pageName); > - public Document getUniqueDocument(String space); > + public String getUniquePageName(String space) throws > XWikiGWTException; > + public String getUniquePageName(String space, String pageName) > throws XWikiGWTException; > + public Document getUniqueDocument(String space, String > pageName) throws XWikiGWTException; > + public Document getUniqueDocument(String space) throws > XWikiGWTException; > > - public User getUser(String fullName); > - public User getUser(); > + public User getUser(String fullName) throws XWikiGWTException; > + public User getUser() throws XWikiGWTException; > > - public User[] getUserList(int nb, int start); > + public User[] getUserList(int nb, int start) throws > XWikiGWTException; > > - public boolean updateProperty(String docname, String > className, String propertyname, String value); > - public boolean updateProperty(String docname, String > className, String propertyname, int value); > - public boolean updateProperty(String docname, String > className, String propertyname, List value); > + public boolean updateProperty(String docname, String > className, String propertyname, String value) throws > XWikiGWTException; > + public boolean updateProperty(String docname, String > className, String propertyname, int value) throws XWikiGWTException; > + public boolean updateProperty(String docname, String > className, String propertyname, List value) throws XWikiGWTException; > > > - public List searchDocuments(String sql, int nb, int start); > + public List searchDocuments(String sql, int nb, int start) > throws XWikiGWTException; > > - public List getDocuments(String sql, int nb, int start); > - public List getDocuments(String sql, int nb, int start, > boolean fullName); > - public List getDocuments(String sql, int nb, int start, > boolean fullName, boolean viewDisplayers, boolean editDisplayers); > + public List getDocuments(String sql, int nb, int start) throws > XWikiGWTException; > + public List getDocuments(String sql, int nb, int start, > boolean fullName) throws XWikiGWTException; > + public List getDocuments(String sql, int nb, int start, > boolean fullName, boolean viewDisplayers, boolean editDisplayers) > throws XWikiGWTException; > > - public List getObjects(String sql, String className, int nb, > int start); > - public XObject getFirstObject(String sql, String className); > + public List getObjects(String sql, String className, int nb, > int start) throws XWikiGWTException; > + public XObject getFirstObject(String sql, String className) > throws XWikiGWTException; > > - public XObject addObject(String fullName, String className); > - public List addObject(String fullName, List classesName); > - public boolean addObject(String docname, XObject xobject); > + public XObject addObject(String fullName, String className) > throws XWikiGWTException; > + public List addObject(String fullName, List classesName) > throws XWikiGWTException; > + public boolean addObject(String docname, XObject xobject) > throws XWikiGWTException; > > - public Boolean lockDocument(String fullName, boolean force); > - public void unlockDocument(String fullName); > - public Boolean isLastDocumentVersion(String fullName, String > version); > + public Boolean lockDocument(String fullName, boolean force) > throws XWikiGWTException; > + public void unlockDocument(String fullName) throws > XWikiGWTException; > + public Boolean isLastDocumentVersion(String fullName, String > version) throws XWikiGWTException; > > - public String getLoginURL(); > + public String getLoginURL() throws XWikiGWTException; > > - public Boolean saveDocumentContent(String fullName, String > content); > - public Boolean saveObject(XObject object); > - public Boolean saveObjects(List objects); > + public Boolean saveDocumentContent(String fullName, String > content) throws XWikiGWTException; > + public Boolean saveObject(XObject object) throws > XWikiGWTException; > + public Boolean saveObjects(List objects) throws > XWikiGWTException; > > - public Boolean deleteObject(XObject object); > - public Boolean deleteObject(String docName, String className, > int number); > + public Boolean deleteObject(XObject object) throws > XWikiGWTException; > + public Boolean deleteObject(String docName, String className, > int number) throws XWikiGWTException; > > - public boolean addComment(String docname, String message); > + public boolean addComment(String docname, String message) > throws XWikiGWTException; > > - public List customQuery(String queryPage); > - public List customQuery(String queryPage, int nb, int start); > - public String getDocumentContent(String fullName); > - public String getDocumentContent(String fullName, boolean > rendered); > - public String getDocumentContent(String fullName, boolean > rendered, Map params); > + public List customQuery(String queryPage) throws > XWikiGWTException; > + public List customQuery(String queryPage, int nb, int start) > throws XWikiGWTException; > + public String getDocumentContent(String fullName) throws > XWikiGWTException; > + public String getDocumentContent(String fullName, boolean > rendered) throws XWikiGWTException; > + public String getDocumentContent(String fullName, boolean > rendered, Map params) throws XWikiGWTException; > > - public void logJSError(Map infos); > + public void logJSError(Map infos) throws XWikiGWTException; > > - public Dictionary getTranslation(String translationPage, > String local); > + public Dictionary getTranslation(String translationPage, > String local) throws XWikiGWTException; > > > /** > > Modified: xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/ > server/XWikiServiceImpl.java > =================================================================== > --- xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/server/ > XWikiServiceImpl.java 2007-05-08 18:39:00 UTC (rev 3133) > +++ xwiki/trunk/web/gwt/src/main/java/com/xpn/xwiki/gwt/api/server/ > XWikiServiceImpl.java 2007-05-08 18:39:48 UTC (rev 3134) > @@ -30,14 +30,7 @@ > import com.xpn.xwiki.doc.XWikiAttachment; > import com.xpn.xwiki.doc.XWikiDocument; > import com.xpn.xwiki.doc.XWikiLock; > -import com.xpn.xwiki.gwt.api.client.Attachment; > -import com.xpn.xwiki.gwt.api.client.Document; > -import com.xpn.xwiki.gwt.api.client.User; > -import com.xpn.xwiki.gwt.api.client.XObject; > -import com.xpn.xwiki.gwt.api.client.XWikiService; > -import com.xpn.xwiki.gwt.api.client.Dictionary; > -import com.xpn.xwiki.gwt.api.client.LoginException; > -import com.xpn.xwiki.gwt.api.client.RightException; > +import com.xpn.xwiki.gwt.api.client.*; > import com.xpn.xwiki.objects.BaseObject; > import com.xpn.xwiki.objects.BaseProperty; > import com.xpn.xwiki.objects.PropertyInterface; > @@ -110,58 +103,73 @@ > } > > > - public Document getDocument(String fullName) { > + protected XWikiGWTException getXWikiGWTException(Exception e) { > + // let's make sure we are informed > + if (log.isErrorEnabled()) { > + log.error("Unhandled exception on the server", e); > + } > + > + XWikiException exp; > + if (e instanceof XWikiException) > + exp = (XWikiException) e; > + else > + exp = new XWikiException > (XWikiException.MODULE_XWIKI_GWT_API, > XWikiException.ERROR_XWIKI_UNKNOWN, "Unknown GWT Exception", e); > + > + return new XWikiGWTException(exp.getMessage(), > exp.getFullMessage(), exp.getCode(), exp.getModule()); > + } > + > + public Document getDocument(String fullName) throws > XWikiGWTException { > return getDocument(fullName, false, false, false, false); > } > > > - public Document getDocument(String fullName, boolean full, > boolean withRenderedContent) { > + public Document getDocument(String fullName, boolean full, > boolean withRenderedContent) throws XWikiGWTException { > return getDocument(fullName, full, false, false, > withRenderedContent); > } > > - public String getUniquePageName(String space){ > + public String getUniquePageName(String space) throws > XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return context.getWiki().getUniquePageName(space, > context); > - } catch (XWikiException e) { > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public String getUniquePageName(String space, String pageName){ > + public String getUniquePageName(String space, String pageName) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return context.getWiki().getUniquePageName(space, > pageName, context); > - } catch (XWikiException e) { > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public Document getUniqueDocument(String space, String > pageName) { > + public Document getUniqueDocument(String space, String > pageName) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > String fullName = context.getWiki().getUniquePageName > (space, pageName, context); > return getDocument(fullName); > - } catch (XWikiException e) { > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public Document getUniqueDocument(String space) { > + public Document getUniqueDocument(String space) throws > XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > String fullName = context.getWiki().getUniquePageName > (space, context); > return getDocument(space + "." + fullName); > - } catch (XWikiException e) { > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers) { > + public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers) throws > XWikiGWTException { > return getDocument(fullName, full, viewDisplayers, > editDisplayers, false); > } > > - public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers, boolean > withRenderedContent) { > + public Document getDocument(String fullName, boolean full, > boolean viewDisplayers, boolean editDisplayers, boolean > withRenderedContent) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("view", context.getUser(), fullName, context) == true) { > @@ -172,21 +180,19 @@ > return null; > } > } catch (Exception e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > - return null; > + throw getXWikiGWTException(e); > } > } > > - public User getUser(){ > + public User getUser() throws XWikiGWTException { > try { > return getUser(getXWikiContext().getUser()); > - } catch (XWikiException e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > - return null; > } > > - public User getUser(String fullName) { > + public User getUser(String fullName) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("view", context.getUser(), fullName, context)==true) { > @@ -196,12 +202,11 @@ > return null; > } > } catch (Exception e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > - return null; > + throw getXWikiGWTException(e); > } > } > > - public User[] getUserList(int nb, int start) { > + public User[] getUserList(int nb, int start) throws > XWikiGWTException { > User[] users = new User[nb]; > try { > XWikiContext context = getXWikiContext(); > @@ -217,95 +222,92 @@ > > return users; > } catch (Exception e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > - return new User[0]; > + throw getXWikiGWTException(e); > } > } > > - public List searchDocuments(String sql, int nb, int start) { > + public List searchDocuments(String sql, int nb, int start) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return searchDocuments(sql, nb, start, context); > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > - public List getDocuments(String sql, int nb, int start) { > + public List getDocuments(String sql, int nb, int start) throws > XWikiGWTException { > return getDocuments(sql, nb, start, false); > } > > - public List getDocuments(String sql, int nb, int start, > boolean full) { > + public List getDocuments(String sql, int nb, int start, > boolean full) throws XWikiGWTException { > return getDocuments(sql, nb, start, full, false, false); > } > > - public List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers) { > + public List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return getDocuments(sql, nb, start, full, > viewDisplayers, editDisplayers, false, context); > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > - public boolean updateProperty(String docname, String > className, String propertyname, String value) { > + public boolean updateProperty(String docname, String > className, String propertyname, String value) throws > XWikiGWTException { > XWikiContext context = null; > try { > context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), docname, context)==true) { > XWikiDocument doc = context.getWiki().getDocument > (docname, context); > + XWikiDocument oldDoc = (XWikiDocument) doc.clone(); > doc.setStringValue(className, propertyname, value); > - context.getWiki().saveDocument(doc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.updateproperty"), context); > return true; > } else > return false; > - } catch (XWikiException e) { > - e.printStackTrace(); > - return false; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public boolean updateProperty(String docname, String > className, String propertyname, int value) { > + public boolean updateProperty(String docname, String > className, String propertyname, int value) throws XWikiGWTException { > XWikiContext context = null; > try { > context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), docname, context)==true) { > XWikiDocument doc = context.getWiki().getDocument > (docname, context); > + XWikiDocument oldDoc = (XWikiDocument) doc.clone(); > doc.setIntValue(className, propertyname, value); > - context.getWiki().saveDocument(doc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.updateproperty"), context); > return true; > } else > return false; > - } catch (XWikiException e) { > - e.printStackTrace(); > - return false; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public boolean updateProperty(String docname, String > className, String propertyname, List value) { > + public boolean updateProperty(String docname, String > className, String propertyname, List value) throws XWikiGWTException { > XWikiContext context = null; > try { > context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), docname, context)==true) { > XWikiDocument doc = context.getWiki().getDocument > (docname, context); > + XWikiDocument oldDoc = (XWikiDocument) doc.clone(); > doc.setListValue(className, propertyname, value); > - context.getWiki().saveDocument(doc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.updateproperty"), context); > return true; > } else > return false; > - } catch (XWikiException e) { > - e.printStackTrace(); > - return false; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - private List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers, > XWikiContext context) { > + private List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers, > XWikiContext context) throws XWikiGWTException { > return getDocuments(sql, nb, start, full, viewDisplayers, > editDisplayers, false, context); > } > > - private List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers, > boolean withRenderedContent, XWikiContext context) { > + private List getDocuments(String sql, int nb, int start, > boolean full, boolean viewDisplayers, boolean editDisplayers, > boolean withRenderedContent, XWikiContext context) throws > XWikiGWTException { > List newlist = new ArrayList(); > try { > List list = context.getWiki().getStore > ().searchDocumentsNames(sql, nb, start, context); > @@ -321,12 +323,11 @@ > > return newlist; > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > - private List searchDocuments(String sql, int nb, int start, > XWikiContext context) { > + private List searchDocuments(String sql, int nb, int start, > XWikiContext context) throws XWikiGWTException { > List newlist = new ArrayList(); > try { > List list = context.getWiki().getStore > ().searchDocumentsNames(sql, nb, start, context); > @@ -340,12 +341,11 @@ > > return newlist; > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > - public List getObjects(String sql, String className, int nb, > int start){ > + public List getObjects(String sql, String className, int nb, > int start) throws XWikiGWTException { > List docs = getDocuments(sql, nb, start, true); > List objects = new ArrayList(); > Iterator it = docs.iterator(); > @@ -358,26 +358,24 @@ > return objects; > } > > - public XObject getFirstObject(String sql, String className){ > + public XObject getFirstObject(String sql, String className) > throws XWikiGWTException { > List objs = getObjects(sql, className, 1, 0); > if (objs != null && objs.size() > 0) > return (XObject) objs.get(0); > return null; > } > > - public XObject addObject(XWikiDocument doc, String className){ > + public XObject addObject(XWikiDocument doc, String className) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > int index = doc.createNewObject(className, context); > return newObject(new XObject(), doc.getObject > (className, index), false, false, context); > - } catch (XWikiException e) { > - e.printStackTrace(); > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > - return null; > - > } > > - public XObject addObject(String fullName, String className) { > + public XObject addObject(String fullName, String className) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), fullName, context)) { > @@ -386,18 +384,17 @@ > > XObject obj = addObject(doc, className); > > - context.getWiki().saveDocument(doc, oldDoc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.updateproperty"), context); > > return obj; > } > return null; > - } catch (XWikiException e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > - return null; > } > > - public List addObject(String fullName, List classesName){ > + public List addObject(String fullName, List classesName) > throws XWikiGWTException { > try{ > XWikiContext context = getXWikiContext(); > XWikiDocument doc = context.getWiki().getDocument > (fullName, context); > @@ -407,31 +404,31 @@ > while(it.hasNext()){ > objs.add(addObject(doc, (String) it.next())); > } > - context.getWiki().saveDocument(doc, oldDoc, context); > + > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.addobject"), context); > return objs; > - } catch (XWikiException e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > - return null; > } > > > - public boolean addObject(String docname, XObject xobject) { > + public boolean addObject(String docname, XObject xobject) > throws XWikiGWTException { > XWikiContext context = null; > try { > context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), docname, context)==true) { > XWikiDocument doc = context.getWiki().getDocument > (docname, context); > + XWikiDocument oldDoc = (XWikiDocument) doc.clone(); > BaseObject newObject = doc.newObject > (xobject.getClassName(), context); > > mergeObject(xobject, newObject, context); > - context.getWiki().saveDocument(doc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.addobject"), context); > return true; > } else > return false; > - } catch (XWikiException e) { > - e.printStackTrace(); > - return false; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > @@ -443,7 +440,18 @@ > * @param content > * @return > */ > - public Boolean saveDocumentContent(String fullName, String > content) { > + public Boolean saveDocumentContent(String fullName, String > content) throws XWikiGWTException { > + return saveDocumentContent(fullName, content, null); > + } > + > + /** > + * save only the content of a document > + * TODO manage translations > + * @param fullName > + * @param content > + * @return > + */ > + public Boolean saveDocumentContent(String fullName, String > content, String comment) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), fullName, context)) { > @@ -453,18 +461,18 @@ > doc.setAuthor(context.getUser()); > if (doc.isNew()) > doc.setCreator(context.getUser()); > - context.getWiki().saveDocument(doc, oldDoc, context); > + context.getWiki().saveDocument(doc, oldDoc, > (comment==null) ? context.getMessageTool().get > ("core.comment.updatecontent") : comment, context); > return Boolean.valueOf(true); > + } else { > + return Boolean.valueOf(false); > } > - > } catch (Exception e) { > - e.printStackTrace(); > + throw getXWikiGWTException(e); > } > - return Boolean.valueOf(false); > } > > > - public Boolean saveObject(XObject object) { > + public Boolean saveObject(XObject object) throws > XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), object.getName(), context)) { > @@ -475,21 +483,21 @@ > doc.setAuthor(context.getUser()); > if (doc.isNew()) > doc.setCreator(context.getUser()); > - context.getWiki().saveDocument(doc, oldDoc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.updateobject"), context); > return Boolean.valueOf(true); > + } else { > + return Boolean.valueOf(false); > } > - > } catch (Exception e) { > - e.printStackTrace(); > + throw getXWikiGWTException(e); > } > - return Boolean.valueOf(false); > } > > - public Boolean deleteObject(XObject object) { > + public Boolean deleteObject(XObject object) throws > XWikiGWTException { > return deleteObject(object.getName(), object.getClassName > (), object.getNumber()); > } > > - public Boolean deleteObject(String docName, String className, > int number) { > + public Boolean deleteObject(String docName, String className, > int number) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("edit", context.getUser(), docName, context)) { > @@ -504,17 +512,18 @@ > doc.setAuthor(context.getUser()); > if (doc.isNew()) > doc.setCreator(context.getUser()); > - context.getWiki().saveDocument(doc, oldDoc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.deleteobject"), context); > return Boolean.valueOf(true); > + } else { > + return Boolean.valueOf(false); > } > } catch (Exception e) { > - e.printStackTrace(); > + throw getXWikiGWTException(e); > } > - return Boolean.valueOf(false); > } > > > - public Boolean saveObjects(List objects) { > + public Boolean saveObjects(List objects) throws > XWikiGWTException { > Iterator it = objects.iterator(); > boolean error = false; > while(it.hasNext()){ > @@ -532,7 +541,7 @@ > * @param force > * @return > */ > - public Boolean lockDocument(String fullName, boolean force) { > + public Boolean lockDocument(String fullName, boolean force) > throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > XWikiDocument doc = context.getWiki().getDocument > (fullName, context); > @@ -551,12 +560,11 @@ > else > return Boolean.valueOf(false); > } catch (Exception e) { > - e.printStackTrace(); > + throw getXWikiGWTException(e); > } > - return null; > } > > - public void unlockDocument(String fullName) { > + public void unlockDocument(String fullName) throws > XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > > @@ -564,56 +572,54 @@ > XWikiLock lock = doc.getLock(context); > if (lock != null) > doc.removeLock(context); > - } catch (XWikiException e) { > - e.printStackTrace(); > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public Boolean isLastDocumentVersion(String fullName, String > version) { > + public Boolean isLastDocumentVersion(String fullName, String > version) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return Boolean.valueOf(context.getWiki().getDocument > (fullName, context).getVersion().equals(version)); > - } catch (XWikiException e) { > - e.printStackTrace(); > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public String getLoginURL() { > + public String getLoginURL() throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > return context.getWiki().getDocument > ("XWiki.XWikiLogin", context).getExternalURL("login", context); > - } catch (XWikiException e) { > - e.printStackTrace(); > - return null; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public boolean addComment(String docname, String message) { > + public boolean addComment(String docname, String message) > throws XWikiGWTException { > XWikiContext context = null; > try { > context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("comment", context.getUser(), docname, context)==true) { > XWikiDocument doc = context.getWiki().getDocument > (docname, context); > + XWikiDocument oldDoc = (XWikiDocument) doc.clone(); > BaseObject newObject = doc.newObject > ("XWiki.XWikiComments", context); > newObject.set("author", context.getUser(), context); > newObject.set("date", new Date(), context); > newObject.set("comment", message, context); > - context.getWiki().saveDocument(doc, context); > + context.getWiki().saveDocument(doc, oldDoc, > context.getMessageTool().get("core.comment.addcomment"), context); > return true; > } else > return false; > - } catch (XWikiException e) { > - e.printStackTrace(); > - return false; > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > > - public List customQuery(String queryPage) { > + public List customQuery(String queryPage) throws > XWikiGWTException { > return customQuery(queryPage, 0, 0); > } > > - public List customQuery(String queryPage, int nb, int start) { > + public List customQuery(String queryPage, int nb, int start) > throws XWikiGWTException { > List newlist = new ArrayList(); > try { > XWikiContext context = getXWikiContext(); > @@ -632,12 +638,11 @@ > } > return null; > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > - protected User newUser(User user, XWikiDocument xdoc, > XWikiContext context) { > + protected User newUser(User user, XWikiDocument xdoc, > XWikiContext context) throws XWikiGWTException { > newDocument(user, xdoc, context); > user.setFirstName(xdoc.getStringValue("XWiki.XWikiUsers", > "first_name")); > user.setLastName(xdoc.getStringValue("XWiki.XWikiUsers", > "last_name")); > @@ -645,52 +650,51 @@ > return user; > } > > - protected Document newDocument(Document doc, XWikiDocument > xdoc, XWikiContext context) { > + protected Document newDocument(Document doc, XWikiDocument > xdoc, XWikiContext context) throws XWikiGWTException { > return newDocument(doc, xdoc, false, context); > } > > - protected Document newDocument(Document doc, XWikiDocument > xdoc, boolean withObjects, XWikiContext context) { > + protected Document newDocument(Document doc, XWikiDocument > xdoc, boolean withObjects, XWikiContext context) throws > XWikiGWTException { > return newDocument(doc, xdoc, withObjects, false, false, > false, context); > } > > - public boolean hasAccessLevel(String level, String fullName, > XWikiContext context) > - { > + public boolean hasAccessLevel(String level, String fullName, > XWikiContext context) throws XWikiGWTException { > try { > return getXWikiContext().getWiki().getRightService > ().hasAccessLevel(level, > context.getUser(), fullName, context); > } catch (Exception e) { > - return false; > + throw getXWikiGWTException(e); > } > } > > - protected void assertEditRight(XWikiDocument doc, XWikiContext > context) throws XWikiException, LoginException, RightException { > + protected void assertEditRight(XWikiDocument doc, XWikiContext > context) throws XWikiGWTException, XWikiException { > if (context.getMode() == XWikiContext.MODE_GWT_DEBUG) > return; > if (!hasAccessLevel("edit", doc.getFullName(), context)) > raiseRightException(context); > } > > - protected void assertViewRight(String fullName, XWikiContext > context) throws XWikiException, LoginException, RightException { > + protected void assertViewRight(String fullName, XWikiContext > context) throws XWikiGWTException, XWikiException { > if (context.getMode() == XWikiContext.MODE_GWT_DEBUG) > return; > if (!hasAccessLevel("view", fullName, context)) > raiseRightException(context); > } > > - protected void raiseRightException(XWikiContext context) > throws RightException, LoginException { > + protected void raiseRightException(XWikiContext context) > throws XWikiException { > if (context.getUser().equals("XWiki.XWikiGuest")){ > - throw new LoginException(); > + throw new XWikiException > (XWikiException.MODULE_XWIKI_ACCESS, > XWikiException.ERROR_XWIKI_ACCESS_TOKEN_INVALID, "User needs to be > logged-in"); > } > else > - throw new RightException(); > + throw new XWikiException > (XWikiException.MODULE_XWIKI_ACCESS, > XWikiException.ERROR_XWIKI_ACCESS_DENIED, "User needs appropriate > rights"); > } > > - protected void assertViewRight(XWikiDocument doc, XWikiContext > context) throws XWikiException, LoginException, RightException { > + protected void assertViewRight(XWikiDocument doc, XWikiContext > context) throws XWikiGWTException, XWikiException { > assertViewRight(doc.getFullName(), context); > } > > protected Document newDocument(Document doc, XWikiDocument > xdoc, boolean withObjects, boolean withViewDisplayers, > - boolean withEditDisplayers, > boolean withRenderedContent, XWikiContext context) { > + boolean withEditDisplayers, > boolean withRenderedContent, XWikiContext context) throws > XWikiGWTException { > doc.setId(xdoc.getId()); > doc.setTitle(xdoc.getTitle()); > doc.setFullName(xdoc.getFullName()); > @@ -714,18 +718,19 @@ > doc.setLanguage(xdoc.getLanguage()); > doc.setDefaultLanguage(xdoc.getDefaultLanguage()); > doc.setTranslation(xdoc.getTranslation()); > + doc.setComment(xdoc.getComment()); > doc.setUploadURL(xdoc.getExternalURL("upload", "ajax=1", > context)); // "ajax=1" > doc.setViewURL(xdoc.getExternalURL("view", context)); > try { > doc.setSaveURL(context.getWiki().getExternalURL > (xdoc.getFullName(), "save", "ajax=1", context)); //, "ajax=1" > - } catch (XWikiException e) { > - e.printStackTrace(); > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > doc.setHasElement(xdoc.getElements()); > try { > doc.setEditRight(context.getWiki().getRightService > ().hasAccessLevel("edit", context.getUser(), xdoc.getFullName(), > context)); > - } catch (XWikiException e) { > - e.printStackTrace(); > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > if (withObjects) { > Iterator it = xdoc.getxWikiObjects().values().iterator(); > @@ -752,8 +757,8 @@ > if (withRenderedContent){ > try { > doc.setRenderedContent(xdoc.getRenderedContent > (context)); > - } catch (XWikiException e) { > - e.printStackTrace(); > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > } > return doc; > @@ -826,7 +831,7 @@ > } > } > > - public String getDocumentContent(String fullName) { > + public String getDocumentContent(String fullName) throws > XWikiGWTException { > return getDocumentContent(fullName, false, null); > } > > @@ -843,11 +848,11 @@ > return baseObject; > } > > - public String getDocumentContent(String fullName, boolean > rendered) { > + public String getDocumentContent(String fullName, boolean > rendered) throws XWikiGWTException { > return getDocumentContent(fullName, rendered, null); > } > > - public String getDocumentContent(String fullName, boolean > rendered, Map params) { > + public String getDocumentContent(String fullName, boolean > rendered, Map params) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > if (context.getWiki().getRightService().hasAccessLevel > ("view", context.getUser(), fullName, context)==true) { > @@ -865,8 +870,7 @@ > return null; > } > } catch (Exception e) { > - e.printStackTrace(); > - return null; > + throw getXWikiGWTException(e); > } > } > > @@ -876,16 +880,15 @@ > // + "stacktrace" + infos.get("stacktrace")); > } > > - public Dictionary getTranslation(String translationPage, > String local){ > + public Dictionary getTranslation(String translationPage, > String local) throws XWikiGWTException { > try { > XWikiContext context = getXWikiContext(); > XWikiMessageTool msg = context.getMessageTool(); > Properties properties = msg.getDocumentBundleProperties > (translationPage, context); > return new Dictionary(properties); > - } catch (XWikiException e) { > - e.printStackTrace(); //To change body of catch > statement use File | Settings | File Templates. > + } catch (Exception e) { > + throw getXWikiGWTException(e); > } > - return null; > } > > > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

18 years, 4 months

1
0
0 0

Deleting XWIKI-1203

by Vincent Massol

For those who wonder I've deleted XWIKI-1203 because the bug fixed in it wasn't there in RC3 and has been introduced by another commit in RC4. Thus we don't want/need to have a jira issue that appears in the release notes, which would be confusing. Thanks -Vincent PS: We all need to start writing selenium tests to prevent regressions...

18 years, 4 months

1
0
0 0

Re: [xwiki-dev] OpenID, Shibboleth and other identity technologies for xwiki

by chandra sekhar

Hi, Can someone please unsubscribe me off the list please. I had mailed so many times now to xwiki-dev-unsubscribe(a)objectweb.org . But i still get the mails. Does anyone know any other procedures to unsubscribe from the xwiki group. Thank you, ----- Original Message ---- From: Bradley Beddoes <beddoes(a)intient.com> To: xwiki-dev(a)objectweb.org Sent: Tuesday, May 8, 2007 3:22:52 PM Subject: Re: [xwiki-dev] OpenID, Shibboleth and other identity technologies for xwiki Hi Vincent, Your absolutely correct there are many alternatives each with their own various positives and negatives. A review of the solutions available is always a good idea. However I am pretty confident nothing else matches the ESOE for its feature set at this stage, but of course I would be happy to be proven wrong :). regards, Bradley Vincent Brousseau wrote: > OpenSSO could also be an interesting alternative > (https://opensso.dev.java.net/). > > It started off the codebase of Sun Java System Access Manager so it's > heavy, but definitely enterprise grade. > > There are many other solutions of that kind, perhaps they should be > reviewed first before going on with an integration in XWiki. > > Vincent > > > On 5/7/07, Bradley Beddoes <beddoes(a)intient.com> wrote: >> Hi, >> Responses inline below. >> >> Sergiu Dumitriu wrote: >> > Hi, >> > >> > This looks good, congratulations! >> > >> > It would be nice if it could be integrated in XWiki (with your kindly >> > offered help), as it provides support for many authentication >> > protocols. However, this must not be done in a haste. We should >> > establish some goals, an implementation plan (including eventual >> > changes needed in the XWiki engine), and a target version. I think >> > that 1.0 is out of the question, so we need to decide if it is a >> > feature that must go into 1.1 or it can wait until the XWiki 2.0 >> > architecture is finalized. >> > >> > (@Vincent) Should we establish a developer meeting on IRC to discuss >> > this? Or are mailing lists OK? >> > >> > On another topic, how stable is the ESEO API? Can we count on a >> > future-compatible integration? >> >> The really cool part is that the integration on the application side for >> pure identity transfer is minimal, especially in java with the use of >> filters. >> >> If you'd like to take it further and integrate authorization to the >> ESOE's policy decision point (and I think it would be a god idea) that >> would take a little longer. >> >> The API itself should be pretty static from this point forward, while >> we've got it tagged at 0.1 in reality its a lot further ahead then that, >> infact we're rolling into production at some sites shortly. >> >> regards, >> Bradley >> >> >> > >> > Thanks, >> > Sergiu >> > >> > On 5/8/07, Bradley Beddoes <beddoes(a)intient.com> wrote: >> >> Hi, >> >> In later March there was a thread about openID support for xwiki, >> at the >> >> time I mentioned new project we were about to launch which could solve >> >> the openID issue as well as shibboleth, active directory and LDAP >> >> integration. >> >> >> >> That software is now available at http://esoeproject.org >> >> >> >> Have a look at what it can offer I would be happy to work with the >> xwiki >> >> community further to integrate appropriately. >> >> >> >> regards, >> >> Bradley >> >> >> >> >> >> >> > >> >> >> >> >> -- >> You receive this message as a subscriber of the >> xwiki-dev(a)objectweb.org mailing list. >> To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org >> For general help: mailto:sympa@objectweb.org?subject=help >> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws >> >> > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

18 years, 4 months

1
0
0 0

[Proposal] OpenID support in XWiki

by Artem Melentyev

Hi. I would like to propose the project: OpenID[1] support in XWiki. OpenID is an open, decentralized, free framework for user-centric digital identity. [1] 1) XWiki as openid consumer. Possibility to login into xwiki with openid. Value: major 2) XWiki as openid provider. Some users of xwiki will have openid account like username.xwiki.host or xwiki.host/openid/username For example users in xwiki.com will have openid = username.xwiki.com Value: minor User story: I have account and virtual wiki at username.xwiki.com. I wish to login with openid into xwiki.org. Standard authentication process with openid[3]: I enter to openid login form at xwiki.org my openid=username.xwiki.com, click sumbit. xwiki.org redirects me to openid authentication page in username.xwiki.com. I enter my password, click submit. username.xwiki.com redirects me back to xwiki.org. Done. I logined into xwiki.org with openid. If I already logined to username.xwiki.com, xwiki.org will not redirects me to username.xwiki.com, and I don't enter password. I may use my openid=username.xwiki.com as normal openid. For example I may write comments to livejournal.com with openid[2]. Advantages: The User needs only one login for all xwikis and openid services. User's openid will be point at homepage on xwiki (possibly). Increase popularity of xwiki project: There are not much openid providers for now. [4] XWiki users will promote xwiki their openids (*.xwiki.com) There are also bounty($5000) for openid-enabled opensource projects: http://iwantmyopenid.org/bounty There are other authorization protocols, similar to the technology openid: http://lid.netmesh.org/ http://en.wikipedia.org/wiki/Inames (inames mostly paid) http://yadis.org/ But it is not too common. Technical details: Possible openid implementations: http://code.google.com/p/openid4java/ or http://code.google.com/p/joid/ Consumer: Then user logins with openid first time, xwiki create special user like XWiki.openid_<user's openid> for a user settings storage. Provider: java servlet. WDYT? Is this project suitable for GSoC 2007? Estimated workload: 1-2 man/month References: [1] http://openid.net/ [2] http://www.livejournal.com/openid/ [3] http://openid.net/about.bml [4] http://openid.net/wiki/index.php/Public_OpenID_providers -- Artem Melentyev, UralSU, CS401

18 years, 4 months

6
14
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs