- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r31216 - in platform/xwiki-applications/trunk: administration/src/main/resources/XWiki blog/src/main/resources/Blog invitation/src/main/resources/Invitation officeimporter/src/main/resources/XWiki panels/src/main/resources/P
by Thomas Mortagne 23 Sep '10

23 Sep '10

You just broke pretty much all applications for stable branch... On Wed, Sep 22, 2010 at 03:44, abusenius <platform-notifications(a)xwiki.org> wrote: > Author: abusenius > Date: 2010-09-22 03:44:29 +0200 (Wed, 22 Sep 2010) > New Revision: 31216 > > Modified: > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > platform/xwiki-applications/trunk/blog/src/main/resources/Blog/CategoriesCode.xml > platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Migration.xml > platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Publisher.xml > platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationGuestActions.xml > platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationMemberActions.xml > platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/WebHome.xml > platform/xwiki-applications/trunk/officeimporter/src/main/resources/XWiki/OfficeImporterAdmin.xml > platform/xwiki-applications/trunk/panels/src/main/resources/Panels/DocumentInformation.xml > platform/xwiki-applications/trunk/panels/src/main/resources/Panels/PanelLayoutUpdate.xml > platform/xwiki-applications/trunk/wiki-manager/src/main/resources/XWiki/XWikiServerClassSheet.xml > Log: > XWIKI-5463: Checking for CSRF tokens in applications > > Modified: platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml > =================================================================== > --- platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/Registration.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -686,11 +686,16 @@ > * @param $doAfterRegistration code block to run after registration completes successfully. > *### > #macro(createUser, $fields, $request, $response, $doAfterRegistration) > - ## See if email verification is required and register the user. > - #if($xwiki.getXWikiPreferenceAsInt('use_email_verification', 0) == 1) > - #set($reg = $xwiki.createUser(true)) > + ## CSRF check > + #if(${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > + ## See if email verification is required and register the user. > + #if($xwiki.getXWikiPreferenceAsInt('use_email_verification', 0) == 1) > + #set($reg = $xwiki.createUser(true)) > + #else > + #set($reg = $xwiki.createUser(false)) > + #end > #else > - #set($reg = $xwiki.createUser(false)) > + $response.sendRedirect("$!{services.csrf.getResubmissionURL()}") > #end > ## > ## Handle output from the registration. > > Modified: platform/xwiki-applications/trunk/blog/src/main/resources/Blog/CategoriesCode.xml > =================================================================== > --- platform/xwiki-applications/trunk/blog/src/main/resources/Blog/CategoriesCode.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/blog/src/main/resources/Blog/CategoriesCode.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -397,7 +397,7 @@ > #end > #set($query = "${query}obj.name = doc.fullName and obj.className = '${blogCategoryClassname}' and doc.fullName <> 'Blog.CategoryTemplate' and doc.parent = ? order by doc.name") > #foreach($item in $xwiki.searchDocuments($query, $parameterValues)) > - #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item)) > + #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item) && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($subcategoryDoc = $xwiki.getDocument($item)) > $subcategoryDoc.setParent($categoryParent) > $subcategoryDoc.save($msg.get('xe.blog.manageCategories.comment.updatedParent'), true) > @@ -409,7 +409,7 @@ > #end > #set($query = "${query}obj.name = doc.fullName and obj.className = '${blogPostClassname}' and doc.fullName <> 'Blog.BlogPostTemplate' and categories.id.id = obj.id and categories.id.name = 'category' and category = ? order by doc.name") > #foreach($item in $xwiki.searchDocuments($query, $parameterValues)) > - #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item)) > + #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item) && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($blogEntryDoc = $xwiki.getDocument($item)) > #set($discard = $blogEntryDoc.getObject(${blogPostClassname}).getProperty('category').value.remove($category)) > $blogEntryDoc.save($msg.get('xe.blog.manageCategories.comment.removedDeletedCategory'), true) > @@ -433,7 +433,7 @@ > #set($query = ', BaseObject obj where ') > #set($query = "${query}obj.name = doc.fullName and obj.className = '${blogCategoryClassname}' and doc.fullName <> 'Blog.CategoryTemplate' and doc.parent = ? order by doc.name") > #foreach($item in $xwiki.searchDocuments($query, $parameterValues)) > - #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item)) > + #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item) && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($subcategoryDoc = $xwiki.getDocument($item)) > $subcategoryDoc.setParent($newCategoryDoc.fullName) > $subcategoryDoc.save($msg.get('xe.blog.manageCategories.comment.updatedParent'), true) > @@ -442,16 +442,18 @@ > #set($query = ', BaseObject obj, DBStringListProperty categories join categories.list as category where ') > #set($query = "${query}obj.name = doc.fullName and obj.className = '${blogPostClassname}' and doc.fullName <> 'Blog.BlogPostTemplate' and categories.id.id = obj.id and categories.id.name = 'category' and category = ? order by doc.name") > #foreach($item in $xwiki.searchDocuments($query, $parameterValues)) > - #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item)) > + #if($xwiki.hasAccessLevel('edit', $xcontext.user, $item) && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($blogEntryDoc = $xwiki.getDocument($item)) > #set($discard = $blogEntryDoc.getObject(${blogPostClassname}).getProperty('category').value.remove($category)) > #set($discard = $blogEntryDoc.getObject(${blogPostClassname}).getProperty('category').value.add($newCategoryDoc.fullName)) > $blogEntryDoc.save($msg.get('xe.blog.manageCategories.comment.updatedRenamedCategory'), true) > #end > #end > - $categoryDoc.getObject('Blog.CategoryClass').set('name', $newCategoryName) > - $categoryDoc.save($msg.get('xe.blog.manageCategories.comment.updatedCategory'), true) > - $categoryDoc.rename($newCategoryName) > + #if ($!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > + $categoryDoc.getObject('Blog.CategoryClass').set('name', $newCategoryName) > + $categoryDoc.save($msg.get('xe.blog.manageCategories.comment.updatedCategory'), true) > + $categoryDoc.rename($newCategoryName) > + #end > #end > {{/velocity}}</content> > </xwikidoc> > > Modified: platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Migration.xml > =================================================================== > --- platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Migration.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Migration.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -24,7 +24,7 @@ > <syntaxId>xwiki/2.0</syntaxId> > <hidden>true</hidden> > <content>{{velocity filter="none"}} > -#if($request.migrate) > +#if($request.migrate && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($newContent = '#includeForm("Blog.BlogPostSheet")') > #set($query = ", BaseObject obj where obj.name = doc.fullName and obj.className = 'XWiki.ArticleClass'") > #foreach($article in $xwiki.searchDocuments($query)) > > Modified: platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Publisher.xml > =================================================================== > --- platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Publisher.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/blog/src/main/resources/Blog/Publisher.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -32,7 +32,7 @@ > #end > #set($entryName = "$!{request.entryName}") > #if($entryName != '') > - #if($xwiki.hasAccessLevel('edit', $xcontext.user, $entryName)) > + #if($xwiki.hasAccessLevel('edit', $xcontext.user, $entryName) && $!{services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($entryDoc = $xwiki.getDocument($entryName)) > #if ($entryDoc) > #getEntryObject($entryDoc $entryObj) > > Modified: platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationGuestActions.xml > =================================================================== > --- platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationGuestActions.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationGuestActions.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -223,7 +223,7 @@ > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.accept.alreadyReportedAsSpam'){{/error}} > #elseif($status != 'pending') > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.invalidStatus', ["#messageStatusForCode($status)"]){{/error}} > - #else > + #elseif($confirm && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #if("#canGuestAcceptInvitation($doc)" != 'true') > ## > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.accept.improperConfiguration'){{/error}} > @@ -235,6 +235,9 @@ > #set($invited = true) > {{include document="XWiki.Registration"/}} > #end > + #else > + ## CSRF protection > + $response.sendRedirect("$!{services.csrf.getResubmissionURL()}") > #end > #elseif($action == 'decline') > ## Decline Invitation <------------------------------------------------------------------------ > @@ -261,7 +264,7 @@ > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.decline.alreadyReportedAsSpam'){{/error}} > #elseif($status != 'pending') > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.invalidStatus', ["#messageStatusForCode($status)"]){{/error}} > - #elseif($confirm) > + #elseif($confirm && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #setMessageStatus($message, 'declined', $memo)## > $emailContainer.saveAsAuthor($msg.get('xe.invitation.doAction.decline.saveComment')) > {{info}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.decline.success'){{/info}} > @@ -280,7 +283,7 @@ > #if("$!message" == '') > ## No message found by that id. > {{error}}(%id="invitation-action-message"%)$msg.get('xe.invitation.doAction.reportSpam.noMessageFound'){{/error}} > - #elseif($confirm) > + #elseif($confirm && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #setMessageStatus($message, 'reported', $memo)## > $emailContainer.saveAsAuthor($msg.get('xe.invitation.doAction.reportSpam.reportSaveComment')) > ## Your report has been logged, sorry for the inconvienence. > > Modified: platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationMemberActions.xml > =================================================================== > --- platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationMemberActions.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/InvitationMemberActions.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -382,7 +382,7 @@ > $msg.get('xe.invitation.doUserActionOnMultipleMessages.cancel.someMessagesNotFound', > [$mathtool.sub($messageIDs.size(), $messages.size()), $messageIDs.size()]){{error}}))) > #end > - #elseif($confirm) > + #elseif($confirm && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > ## If the user accidently selected messages to which this action cannot be done, just skip over them. > #set($changed = false) > #foreach($message in $messages) > @@ -435,7 +435,7 @@ > $msg.get('xe.invitation.doUserActionOnMultipleMessages.noMessagesFound') > #end > {{/error}}))) > - #elseif($confirm) > + #elseif($confirm && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > ## If the user accidently selected messages to which this action cannot be done, just skip over them. > #set($changed = false) > #foreach($message in $messages) > > Modified: platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/WebHome.xml > =================================================================== > --- platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/WebHome.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/invitation/src/main/resources/Invitation/WebHome.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -737,7 +737,9 @@ > #set($messageBody = '') > #end > ## > - #if("$!request.get('sendMail')" != '' && $request.getMethod().toLowerCase() == 'post') > + #if("$!request.get('sendMail')" != '' > + && $request.getMethod().toLowerCase() == 'post' > + && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #generateAndSendMail($config, > $recipients, > $subjectLine, > > Modified: platform/xwiki-applications/trunk/officeimporter/src/main/resources/XWiki/OfficeImporterAdmin.xml > =================================================================== > --- platform/xwiki-applications/trunk/officeimporter/src/main/resources/XWiki/OfficeImporterAdmin.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/officeimporter/src/main/resources/XWiki/OfficeImporterAdmin.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -281,7 +281,7 @@ > #set($msgRestart=$msg.get("xe.officeimporter.openoffice.actions.restart")) > #set($msgUpdate=$msg.get("xe.officeimporter.openoffice.update")) > #set($msgLimitedControl=$msg.get("xe.officeimporter.openoffice.limitedcontrol")) > -#if($hasAdmin) > +#if($hasAdmin && ${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($currentAction = "$!{request.action}") > #if($currentAction == "stop") > #if(!$oomanager.stopServer()) > > Modified: platform/xwiki-applications/trunk/panels/src/main/resources/Panels/DocumentInformation.xml > =================================================================== > --- platform/xwiki-applications/trunk/panels/src/main/resources/Panels/DocumentInformation.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/panels/src/main/resources/Panels/DocumentInformation.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -547,7 +547,7 @@ > #end > ## Use the syntax and content received from the client, as the user might have made some changes that are not on saved yet. > #set($void = $translatedDoc.setSyntaxId($oldSyntax)) > - #if (!$translatedDoc.convertSyntax($newSyntaxId)) > + #if (!$translatedDoc.convertSyntax($newSyntaxId) || !${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #set($error = true) > #else > #set($void = $translatedDoc.save("Document converted from syntax $oldSyntax to syntax $newSyntaxId")) > > Modified: platform/xwiki-applications/trunk/panels/src/main/resources/Panels/PanelLayoutUpdate.xml > =================================================================== > --- platform/xwiki-applications/trunk/panels/src/main/resources/Panels/PanelLayoutUpdate.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/panels/src/main/resources/Panels/PanelLayoutUpdate.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -34,7 +34,7 @@ > ## > ## Check to see if the current user has admin rights on the current preferences document. > ## > -#if(!$xwiki.hasAccessLevel("admin", $xcontext.user, $prefsdocument)) > +#if(!$xwiki.hasAccessLevel("admin", $xcontext.user, $prefsdocument) || !${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > #xwikimessageboxstart("$msg.get('panelwizard.placemanager')" "") > $msg.get("panelwizard.notadmininplace", $place) > #xwikimessageboxend() > > Modified: platform/xwiki-applications/trunk/wiki-manager/src/main/resources/XWiki/XWikiServerClassSheet.xml > =================================================================== > --- platform/xwiki-applications/trunk/wiki-manager/src/main/resources/XWiki/XWikiServerClassSheet.xml 2010-09-22 01:44:21 UTC (rev 31215) > +++ platform/xwiki-applications/trunk/wiki-manager/src/main/resources/XWiki/XWikiServerClassSheet.xml 2010-09-22 01:44:29 UTC (rev 31216) > @@ -36,7 +36,9 @@ > #set ($wiki = $WikiManager.getWikiFromDocumentName($doc.fullName)) > ## > #if ($action && ($action == "create") && $domain && ($domain.trim().length() > 0)) > - #if (!$wiki.containsWikiAlias($domain)) > + #if (!${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > + #error($msg.get("notallowed")) > + #elseif (!$wiki.containsWikiAlias($domain)) > #set ($alias = $wiki.newObject("XWiki.XWikiServerClass")) > $alias.set("server", $domain) > $alias.set("homepage", "Main.WebHome") > @@ -47,7 +49,9 @@ > #end > ## > #if ($action && ($action == "delete") && $domain && ($domain.trim().length() > 0)) > - #if ($wiki.containsWikiAlias($domain)) > + #if (!${services.csrf.isTokenValid("$!{request.getParameter('form_token')}")}) > + #error($msg.get("notallowed")) > + #elseif ($wiki.containsWikiAlias($domain)) > #set ($alias = $wiki.getWikiAlias($domain)) > #set ($removed = $wiki.removeObject($alias.objectApi)) > $wiki.save() > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 1

[xwiki-devs] [VOTE] Move extension manager as experimental application/component of the platform
by Thomas Mortagne 23 Sep '10

23 Sep '10

As planned by the XE 2.5 roadmap (http://enterprise.xwiki.org/xwiki/bin/view/Main/Roadmap) i would like to move extension manager to the platform. It's one application for the UI and one jar for the framework (plus several MB of maven/classloading dependencies). The rationale is that it makes it easier to try and play with it to have as much comments as possible. It would be "taged" as experimental which means anything in it can be changed anytime and nobody can expect a code that use this component's API to not be broken. The current state of Extension Manager is summarized in http://dev.xwiki.org/xwiki/bin/view/Design/ExtensionManagerProposal#HPlanni… and detailed in the rest of the document. I'm pretty confident it's not dangerous for the rest of XE when you don't use it and it can't slow down it or something. So WDYT ? Here is my +1. Thanks, -- Thomas Mortagne

5 5

[xwiki-devs] duplicated id generation
by Ricardo Espírito Santo 23 Sep '10

23 Sep '10

Hello there, I have been asked to develop something on top of the pdf export facilities on the xwiki. But I run into a small problem: When *generating a pdf with multiple pages*, say all the pages from one space, the ids of elements within the pages get duplicated and the *pdf exportation fails*. i.e.: *Page A* with a title *TheQuickBrownFox...* some text under it and then *page B* with the same title: *TheQuickBrownFox...* with some other text under this. Both will get an auto ID of *TheQuickBrownFox... *Now this doesn't happen for items on the same page since the ID generation mechanism counts all items of the same name and increments it if necessary. But this mechanism does not contemplate cross page duplicated items. To avoid the following error: Property ID "lipsum" (found on "fo:block") previously used; ID values must be unique within a document! (See position 12:39) We thought some changes to the ID generation mechanism could be made: We could* prefix the ID* with the space and page name and this would be a simple elegant solution. Now: Is this the best solution? Will someone point out the best place to do this? If I post a patch with this fix will it be included on the trunk? Thank you in advance, » Ricardo Espírito Santo » Linkare TI - Tecnologias de Informação, Lda

4 3

[xwiki-devs] [vote] Commit the section, column and dashboard macro in the platform macros
by Anca Luca 22 Sep '10

22 Sep '10

Hi devs, wdyt about committing the section & macro columns from the contrib (https://svn.xwiki.org/svnroot/xwiki/contrib/projects/xwiki-macro-column/) in the platform macros, along with a first, very simple implementation of the dashboard macro (which for the moment only delegates to the section macro)? This would be the first step towards the implementation of the dashboard, and the plan is to be done before 2.5M2. Here's my +1. WDYT? Anca

10 21

[xwiki-devs] [Discussion] Preview link next to Office attachments
by Marius Dumitru Florea 22 Sep '10

22 Sep '10

Hi devs, I'd like to add a preview link next to office attachments in the attachments tab (See http://jira.xwiki.org/jira/browse/XAOFFICE-11 ). I was thinking to create a new velocity template, officepreview.vm, and use it like this: $doc.getURL("view", "xpage=officepreview&attachment=$escapetool.url($attachment.filename)") Another option is to add a new action (i.e. /xwiki/bin/officepreview/Space/Page/presentation.ppt ) or reuse an existing one (i.e. /xwiki/bin/preview/Space/Page/presentation.ppt ). WDYT? Thanks, Marius

3 2

[xwiki-devs] [VOTE] XWiki Syntax 2.1: Specifying QueryString and Anchor
by Vincent Massol 22 Sep '10

22 Sep '10

Hi devs, Since this is an important public change, we need to vote on it. This is the vote for the mail thread: http://markmail.org/message/drm6jq4mosjbryew First some terminology: [[label>>target||params]] The vote is on moving query string and anchor information from the link target to link parameters. Rules: * This is for XWiki Syntax 2.1 only * The target part is there to specify what the link is targeting. QueryString and Anchors do not serve to specify the target. They're just used at render time to control the display. Hence the rationale why they are specified as link params and not as part of the target. Note that for an interwiki link, the interwiki alias is part of the target since it serves to specify the target. * We name the param "queryString" so that it's clear what it is. We can always change it later on with no backward compat issues if we want something more isolated from URLs but we don't see the need now. The user has to write a valid query string including any URL-encoding required. * Example: [[label>>doc:docReference||queryString="a=b&c=d" anchor="anchor"]] Here's my +1 Thanks -Vincent

4 3

[xwiki-devs] exporting document as pdf in landscape mode
by Ibrahim hammani 22 Sep '10

22 Sep '10

Hello all, Is there any way to export a document as a pdf and in landscape mode. Thanx. Ibrahim Hammani.

1 0

[xwiki-devs] [VOTE] Release XE 2.4.1
by Thomas Mortagne 22 Sep '10

22 Sep '10

Hi devs, I would like to release XE/XEM 2.4.1 because it contains some important bugfixes. See http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=p… Here is my +1, Thanks, -- Thomas Mortagne

10 11

[xwiki-devs] [Discussion] Failed to locate Script Service
by Marius Dumitru Florea 22 Sep '10

22 Sep '10

Hi devs, I was playing with the office preview script service when I discovered that $services throws ScriptServiceNotFoundException when there's no script service registered for the specified hint, e.g. $services.foo . I was expecting $services to return null when it fails to locate a service. I even wrote: #if($services.officepreview) {{html}} $services.officepreview.preview(...) {{/html}} #else {{error}}The office preview component has not been installed.{{/error}} #end What do you think it's best: to throw ScriptServiceNotFoundException or to return null? Anyway, I think there should be a method to check if a script service is available ( http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-script/src/mai… ). WDYT? Thanks, Marius

4 3

[xwiki-devs] Current entity reference
by Marius Dumitru Florea 21 Sep '10

21 Sep '10

Hi devs, If I write: {{groovy}} print com.xpn.xwiki.web.Utils.getComponent(org.xwiki.model.ModelContext.class).getCurrentEntityReference(); {{/groovy}} in a wiki page I get: name = [xwiki], type = [WIKI], parent = [null] I was expecting to get a reference to the current page (i.e. the page that executes the groovy script). The javadoc of ModelContext interface says: "Allows accessing Model Objects for current objects (current document, current wiki, current space, etc) placed in the Execution Context." Looks like DefaultModelContext ( http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-model/src/main… ) always returns a WikiReference. What was the rationale behind this? Thanks, Marius

2 2