- xwiki-devs@xwiki.org - lists.xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r19992 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc
by Vincent Massol 15 May '09

15 May '09

On May 15, 2009, at 2:47 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2009-05-15 02:47:38 +0200 (Fri, 15 May 2009) > New Revision: 19992 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > DefaultDocumentAccessBridge.java > Log: > XWIKI-3521: Include Macro uses same revision number for included > page as the current page > Fixed. > Patch submitted by Anamaria Stoica, applied without changes. > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > doc/DefaultDocumentAccessBridge.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > DefaultDocumentAccessBridge.java 2009-05-15 00:47:33 UTC (rev 19991) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > DefaultDocumentAccessBridge.java 2009-05-15 00:47:38 UTC (rev 19992) > @@ -123,7 +123,15 @@ > public String getDocumentContent(String documentName, String > language) throws Exception > { > XWikiContext xcontext = getContext(); > - return xcontext.getWiki().getDocument(documentName, > xcontext).getTranslatedContent(language, xcontext); > + String originalRev = (String) xcontext.get("rev"); > + try { > + xcontext.remove("rev"); > + return xcontext.getWiki().getDocument(documentName, > xcontext).getTranslatedContent(language, xcontext); > + } finally { > + if (originalRev != null) { > + xcontext.put("rev", originalRev); > + } > + } This is missing documentation. It's not obvious why 1) there's a rev value in the context and 2) why you have to remove it and set it back. Thanks -Vincent

1 0

[xwiki-devs] Access to XWiki from HttpServlet
by glenn_engel＠agilent.com 15 May '09

15 May '09

I have a servlet I am porting from another environment that only needs a few services from XWiki (mostly user authentication and group membership). Is there a recommended way of getting a handle to an XWiki instance from a servlet that derives from HttpServlet? I was looking for some sort of static method I could invoke to retrieve this but haven't come across one yet. Suggestions would be appreciated. Thanks, Glenn

2 1

Re: [xwiki-devs] [xwiki-notifications] r19942 - enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium
by Vincent Massol 14 May '09

14 May '09

On May 14, 2009, at 4:42 PM, mflorea (SVN) wrote: > Author: mflorea > Date: 2009-05-14 16:42:12 +0200 (Thu, 14 May 2009) > New Revision: 19942 > > Modified: > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/StandardFeaturesTest.java > Log: > XWIKI-3682: Trademark symbol is not displayed correctly. > > Modified: enterprise/trunk/distribution-test/wysiwyg-tests/src/test/ > it/com/xpn/xwiki/it/selenium/StandardFeaturesTest.java > =================================================================== > --- enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/StandardFeaturesTest.java 2009-05-14 14:34:42 > UTC (rev 19941) > +++ enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/StandardFeaturesTest.java 2009-05-14 14:42:12 > UTC (rev 19942) > @@ -215,6 +215,7 @@ > /** > * @see XWIKI-3012: Exception when opening a WYSIWYG dialog in > FF2.0 > * @see XWIKI-2992: Place the caret after the inserted symbol > + * @see @see XWIKI-3682: Trademark symbol is not displayed > correctly. lots of see... ;) -Vincent > > */ > public void testInsertSymbol() > { > @@ -224,7 +225,9 @@ > closeDialog(); > clickSymbolButton(); > getSelenium().click("//div[@title='registered sign']"); > - assertWiki("\u00A9\u00AE"); > + clickSymbolButton(); > + getSelenium().click("//div[@title='trade mark sign']"); > + assertWiki("\u00A9\u00AE\u2122"); > } > > /**

2 1

[xwiki-devs] [VOTE] Creating complex lists with the new WYSIWYG editor
by Marius Dumitru Florea 14 May '09

14 May '09

Hi there, Right now the new WYSIWYG editor allows us to create simple lists like the following: ----------8<---------- * plants * animals ** invertebrates ** vertebrates ---------->8---------- By pressing just Enter when the caret is inside a list item we create a new list item. This is the basic mechanism. It's simple and it should remain so. If I want to make the previous list a bit more complex: ----------8<---------- * (((= Plants = Plants are living organisms belonging to the kingdom Plantae.))) * (((= Animals = Animals are a major group of mostly multicellular, eukaryotic organisms of the kingdom Animalia or Metazoa. They are divided into:))) ** (((== Invertebrates == An invertebrate is an animal lacking a vertebral column.))) ** (((== Vertebrates == Vertebrates are members of the subphylum Vertebrata, chordates with backbones or spinal columns.))) ---------->8---------- I have to be able to insert new lines inside a list item using the Enter key but without creating a new list item. Let's consider the following state: ----------8<---------- * (((= Plants =))) ---------->8---------- We have a level 1 heading inside a list item. The caret is inside the heading, at the end. Pressing Enter can have the following three outcomes: 1. Continue editing in the heading, but on a new line: ----------8<---------- * (((= Title 1 x =))) ---------->8---------- 2. Continue editing in the same list item but after the heading, in a paragraph: ----------8<---------- * (((= Title 1 = x))) ---------->8---------- 3. Create a new list item: ----------8<---------- * (((= Title 1 =))) * x ---------->8---------- For the first outcome I think we all agree that the user has to press Shift+Enter. For the second and third outcomes I see two options: A) Enter for 2 and CTRL/META+Enter for 3 B) Enter for 3 and CTRL/META+Enter for 2 (if you see any other options please step up) I'm +1 for A) for the following reason: if the user has inserted a heading in a list item then he will surely want to add more content after that heading, thus pressing just Enter is the natural way of doing this. From a technical POV the caret is first inside a heading and then inside a list item so the heading should have the priority of handling the Enter key. NOTE: Choosing A) or B) doesn't affect the way simple lists are created, which is using just Enter. Please cast your votes and sorry for the long mail, Marius

4 9

[xwiki-devs] increasing low size-limit on XWiki.JavaScriptExtension[] data in object-editor ?
by Niels Mayer 14 May '09

14 May '09

In 1.8, if too much data is entered in a doc's ?editor=object fieldXWiki.JavaScriptExtension[] (say a big chunk of JSON on the order of 97783 bytes) you can no longer save without getting an underlying error. This appears related to the following: com.xpn.xwiki.objects.LargeStringProperty --> com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'XWL_VALUE' at row 1 How can this be changed to allow for a larger limit on entries? Fortunately, http://nielsmayer.com/xwiki/bin/view/Exhibit/Presidents3 ( src <http://nielsmayer.com/xwiki/bin/download/Exhibit/Presidents3/Exhibit.Presid…>) has entries small enough, but as you grow the amount of Javascript data you hold in a XWiki.JavaScriptExtension you eventually get a failure like this: A problem occured while trying to process your request. Please contact the > webmaster if this happens again. > > Detailed information: > > Error number 3201 in 3: Exception while saving document Exhibit.pods > Wrapped Exception: could not update: [com.xpn.xwiki.objects.LargeStringProperty#component[id,name]{id=-2025184002, name=code}] > com.xpn.xwiki.XWikiException: Error number 3201 in 3: Exception while saving document Exhibit.pods > Wrapped Exception: could not update: [com.xpn.xwiki.objects.LargeStringProperty#component[id,name]{id=-2025184002, name=code}] > at com.xpn.xwiki.store.XWikiHibernateStore.saveXWikiDoc(XWikiHibernateStore.java:595) > at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:135) > at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:128) > at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:1282) > at com.xpn.xwiki.web.SaveAction.save(SaveAction.java:176) > at com.xpn.xwiki.web.SaveAndContinueAction.action(SaveAndContinueAction.java:64) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:215) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) > at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) > at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) > at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) > at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:432) > > ... > > Wrapped Exception: > > com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'XWL_VALUE' at row 1 > at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:2983) > at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1631) > at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:1723) > at com.mysql.jdbc.Connection.execSQL(Connection.java:3256) > at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1313) > at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1585) > at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1500) > at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1485) > at org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:101) > at org.apache.commons.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedStatement.java:101) > at org.hibernate.persister.entity.AbstractEntityPersister.update(AbstractEntityPersister.java:2412) > at org.hibernate.persister.entity.AbstractEntityPersister.updateOrInsert(AbstractEntityPersister.java:2312) > at org.hibernate.persister.entity.AbstractEntityPersister.update(AbstractEntityPersister.java:2612) > at org.hibernate.action.EntityUpdateAction.execute(EntityUpdateAction.java:96) > at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:279) > at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:263) > at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:168) > at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:298) > at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27) > at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1000) > at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:338) > at org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:106) > at com.xpn.xwiki.store.XWikiHibernateBaseStore.endTransaction(XWikiHibernateBaseStore.java:866) > at com.xpn.xwiki.store.XWikiHibernateBaseStore.endTransaction(XWikiHibernateBaseStore.java:837) > at com.xpn.xwiki.store.XWikiHibernateStore.saveXWikiDoc(XWikiHibernateStore.java:585) > at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:135) > at com.xpn.xwiki.store.XWikiCacheStore.saveXWikiDoc(XWikiCacheStore.java:128) > at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:1282) > at com.xpn.xwiki.web.SaveAction.save(SaveAction.java:176) > at com.xpn.xwiki.web.SaveAndContinueAction.action(SaveAndContinueAction.java:64) > > Thanks. Niels http://nielsmayer.com

2 2

[xwiki-devs] Creating a macro component
by glenn_engel＠agilent.com 13 May '09

13 May '09

I'm having a difficult time adding a java macro and getting it to get invoked. I first found this page and created my class and created a META-INF/plexus/components.xml per the 'tutorial' here: http://dev.xwiki.org/xwiki/bin/view/Drafts/Tutorial+to+Write+a+Macro+in+the… I then found this tutorial for components (http://platform.xwiki.org/xwiki/bin/view/DevGuide/WritingComponents) and created a META-INF/components.txt file and added an @Component("mymacro") annotation to the macro implementation. However, I am unable to get my macro code to get called when pages are rendered. Is there something else I'm missing? I've verified all the relevant files are in my jar. -- Glenn

2 6

[xwiki-devs] [Proposal] Logging improvements
by Vincent Massol 13 May '09

13 May '09

Hi, I wanted to see if we could move our LogEnabled lifecycle phase to a Logging component. I think it's not going to work since this means injecting a LoggingFactory/LoggingManager component and you need to call getLogger(this.getClass()) to get access to the Logger which is awkward. What I propose: 1) Use SLF4J (drop the slf4j-log4j jar in our WEB-INF/lib so that SLF4J uses log4j by default) 2) Drop the JCL/JUL/LOG4j SLF4J legacy jars in our WEB-INF/lib too and exclude the JCL/JUL/LOG4J jars from our poms so that all third party logs go to our logging system 3) Non component code should use a SLF4J's LoggerFactory directly 4a) Keep LogEnabled and AbstractLogEnabled for our components or 4b) Automatically inject a Logger and a ComponentManager when there are fields with these types in a component class. I like 4b) for its simplicity but I'm worried by the "magical" aspect of it. WDYT? Thanks -Vincent

2 9

[xwiki-devs] Photo Album API
by Edo Beutler 13 May '09

13 May '09

Hi devs, we are working with XWiki for about three years now (I think we started using it around version 0.8). In this time we developed several plugins, which we always planed to make open source to give something back to the community. However, until now we never found the time to do it. Now we saw in your GSoC proposals the project for a new photo album application. We thought this would be a good moment to contribute our photo plugin (or parts of it). Short list of features: - unzip an attached file and attach the contained files to a document (i.e. the photo album) - resize images to a maximum width and height maintaining the aspect ratio (if you like already while unzipping) - only jpg until now. When we wrote it, the XWiki image plugin stretched the images when width and height were defined. - read meta data from images (using http://www.drewnoakes.com/code/exif/ - sadly it seems the library is not updated anymore) The plugin would be the Java part only and not directly affect the GSoC project, since it seems to focus mostly on a new front end, but we think the plugin could add some features to it. (Maybe I could create a small example page if you are interested) I hope to hear from you wether you are interested and if so, what parts you are interested in. Also don't hesitate to ask if you have questions or need further information. Edo

3 3

[xwiki-devs] xwiki-core missing from maven?
by glenn_engel＠agilent.com 12 May '09

12 May '09

Hi, I'm trying to build a plugin and am unable to resolve XwikiDefaultPlugin. In looking at the source I was expecting it to be in artifactId xwiki-core but I don't see this in the maven repository. I put the following in my pom.xml but maven still is unable to find xwiki-core but is quite happy to find and download xwiki-component. <dependency> <groupId>org.xwiki.platform</groupId> <artifactId>xwiki-core-component</artifactId> <version>${platform.core.version}</version> </dependency> <dependency> <groupId>org.xwiki.platform</groupId> <artifactId>xwiki-core</artifactId> <version>${platform.core.version}</version> </dependency> Anyone know how to resolve this? Thanks, Glenn

2 3

[xwiki-devs] [ANN] XWiki Enterprise 1.9 Milestone 2 Released
by Jean-Vincent Drean 12 May '09

12 May '09

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.9 Milestone 2. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download Second and last milestone of the XWiki Enterprise 1.9 version. Main changes: * UI improvements ** Quick Jump to any Page navigation ** Faster Save and Continue using AJAX ** Improved Full Screen editing ** New Live Table UI ** Improved comments UI and functionality ** Multiple attachment upload in one request ** New UI for the Class and Object editors ** Improved toolbar in the wiki editor ** Preliminary support for Autosave * WYSIWYG 2.0 improvements * XWiki Syntax 2.0 rendering improvements * XWiki 1.0 to 2.0 syntax converter improvements * Switched to UTF-8 as the default encoding * Mailsender improvements * PDF export improvements * JavaScript improvements * Dutch tranlsations For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise19M2 Note that general goals for XWiki Enterprise 1.9 are: * Finish/stabilize/document new rendering * Finish/stabilize/document new wysiwyg editor * Finish/stabilize/document office importer + doc splitter/management * Finish/stabilize/document webdav * Finish/stabilize/document REST support * Usability improvements Thanks, The XWiki dev team

1 0