- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [VOTE] Switch to UTF-8 by default in our distributions
by Sergiu Dumitriu 17 Mar '09

17 Mar '09

Niels Mayer wrote: > > PS: Why not just have xwiki.cfg's default be: 'xwiki.encoding=UTF-8' ; > likewise have web.xml's default for > com.xpn.xwiki.web.SetCharacterEncodingFilter's 'encoding' be UTF-8. These > encoding errors that oft go unnoticed are probably resulting in a number of > configuration errors, and perhaps other bug-reports that aren't entirely > valid, should they depend on encoding issues. Big +1 This is one of the oldest issues open (http://jira.xwiki.org/jira/browse/XWIKI-94) I guess that since we're nearing 2.0, it would be a good thing to set this on trunk, before the 1.9M1 release. WDYT? -- Sergiu Dumitriu http://purl.org/net/sergiu/

5 12

[xwiki-devs] [Proposal] Move WYSIWYG DOM API in a separate module
by Marius Dumitru Florea 17 Mar '09

17 Mar '09

Hi devs, The new WYSIWYG editor uses an enhanced DOM API to manipulate the edited document. This API extends the default DOM API found in GWT adding: * W3C Range and Selection support ( http://tinyurl.com/cvsm3a ) * Multiple-window support ( http://tinyurl.com/cphdep ) * Depth-first pre-order iterator (part of Document traversal support) * Lots of DOM utility methods I'd like to move this API in a separate build module to make it reusable inside and outside XWiki. We could name it xwiki-web-gwt-dom (or xwiki-gwt-dom?) and place it, at list for now, in platform/web/gwt-dom (or platform/web/xwiki-gwt-dom?). Also, I'd like to rename the package name from com.xpn.xwiki.wysiwyg.client.dom to org.xwiki.gwt.dom. WDYT? Marius

6 5

Re: [xwiki-devs] [xwiki-notifications] r17677 - in platform/core/trunk/xwiki-xml: . src/main/java/org/xwiki/xml/internal/html
by Vincent Massol 17 Mar '09

17 Mar '09

Hi Asiri, On Mar 16, 2009, at 6:58 PM, asiri (SVN) wrote: > Author: asiri > Date: 2009-03-16 18:58:57 +0100 (Mon, 16 Mar 2009) > New Revision: 17677 > > Modified: > platform/core/trunk/xwiki-xml/pom.xml > platform/core/trunk/xwiki-xml/src/main/java/org/xwiki/xml/internal/ > html/DefaultHTMLCleaner.java > Log: > XWIKI-3365: Get rid of jdom dependency in xwiki-xml module > > * Fixed. [snip] > + } > // Workaround HTML XML declaration bug. > - fixCleanedNodeBug(cleanedNode); > - > - // Ideally following code should be enough. But SF's HTML > Cleaner seems to omit the DocType declaration while > - // serializing. > - // See https://sourceforge.net/tracker/index.php?func=detail&aid=2062318&group_id=… > - // cleanedNode.setDocType(new DoctypeToken("html", > "PUBLIC", "-//W3C//DTD XHTML 1.0 Strict//EN", > - // "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd > ")); > - // try { > - // result = new DomSerializer(cleanerProperties, > false).createDOM(cleanedNode); > - // } catch(ParserConfigurationException ex) { } > - // As a workaround, we have go through JDOM so that we can > set the DocType manually. > - org.jdom.Document jdomDoc = null; > - jdomDoc = new JDomSerializer(cleanerProperties, > false).createJDom(cleanedNode); > - jdomDoc.setDocType(new DocType("html", "-//W3C//DTD XHTML > 1.0 Strict//EN", > - "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd")); > + fixCleanedNodeBug(cleanedNode); > + // Serialize the cleanedNode TagNode into a w3c dom. > try { > - result = new DOMOutputter().output(jdomDoc); > - } catch (JDOMException ex) { > - throw new RuntimeException("Error while transforming > jdom document into w3c document", ex); > + Document tempDoc = new DomSerializer(cleanerProperties, > false).createDOM(cleanedNode); > + DOMImplementation domImpl = > + > DocumentBuilderFactory > .newInstance().newDocumentBuilder().getDOMImplementation(); > + DocumentType docType = > + domImpl.createDocumentType(QUALIFIED_NAME_HTML, "-// > W3C//DTD XHTML 1.0 Strict//EN", > + "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd > "); > + result = domImpl.createDocument(null, > QUALIFIED_NAME_HTML, docType); > + > result.replaceChild(result.adoptNode(tempDoc.getDocumentElement()), > result.getDocumentElement()); > + } catch (ParserConfigurationException ex) { > + throw new RuntimeException("Error while serializing > TagNode into w3c dom.", ex); cool but why have you removed the comment saying that there's a SF html cleaner bug? Can you put it back and instead add that this is workaround? Thanks -Vincent

2 1

[xwiki-devs] FYI: new MIT simile widget -- itunes cover-flow image/doc selection?
by Niels Mayer 16 Mar '09

16 Mar '09

This could be an interesting way to select media (images, video/audio, documents) in xwiki: http://www.simile-widgets.org/runway/ > This widget lets you display images in a rich interactive visualization > similar to that of Apple iTunes known as Cover Flow. It is a Flash-based > implementation ... The Flash widget can fire events to update the web page's > Javascript. .... The web page's Javascript can change the Flash widget on > the fly. Documentation<http://code.google.com/p/simile-widgets/wiki/Runway> > Mailing List <http://groups.google.com/group/simile-widgets> (for > technical support, etc.) Code<http://code.google.com/p/simile-widgets/source/browse/#svn/runway/trunk>(open source, BSD license)... > I think it would be useful in the anchor/link wizard in the wysiwyg editor, lending an itunes style album-cover-flipping style interface to process of link and image. selection in xwiki. It would be great if we could render semi-readable scaled-down thumbnails of existing xwiki documents in the cover-flow browser. Yet another GSOC project... though I bet the basic interface to 'runway' is pretty trivial in xwiki ... (e.g. of similar complexity and interface-ability is the youtube chromeless player: http://nielsmayer.com/xwiki/bin/view/Todo/YoutubeChromelessPlayer then again ... I can't figure out why my example doesn't work in IE, yet fine in safari&firefox -- probably because having a menagerie-a-trois of languages to deal with by adding flash to the picture always leads to trouble...) Niels http://nielsmayer.com

3 2

[xwiki-devs] JCaptcha 2.0 integration
by Jerome Velociter 15 Mar '09

15 Mar '09

Hello Devs, I'm starting to think about the integration of JCaptcha 2.0 (http://forge.octo.com/jcaptcha/confluence/display/general/Simple+Servlet+In…) that would deprecated our current Captcha plugin. I think we need it as a component, for example xwiki-captcha We can have a CaptchaedRequestValidator component interface that declares the following method : boolean validateCaptcha(HttpServletRequest request); which would be called from the register action, comment add action, etc. (anywhere a captcha is needed - we could even expose a velocity API if we need it) WDYT ? Regards, Jerome.

4 10

Re: [xwiki-devs] [xwiki-notifications] r17624 - in platform/core/trunk/xwiki-rendering/xwiki-rendering-macros: xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/internal/macro/rss xwi
by Thomas Mortagne 14 Mar '09

14 Mar '09

The RSS macro and its RSSMAcroParameters class should extends the Box macro since it's exactly the goal of AbstractBoxMacro. The way it works currently make copy the same parameters in BoxMacroParameters and RssMacroParameters when we should have RssMacroParameters extends BoxMacroParameters. This would remove some useless code in rss macro... On Sat, Mar 14, 2009 at 11:00, SVN jvelociter <platform-notifications(a)xwiki.org> wrote: > Author: jvelociter > Date: 2009-03-14 11:00:44 +0100 (Sat, 14 Mar 2009) > New Revision: 17624 > > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/AbstractBoxMacro.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/BoxMacroParameters.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/internal/macro/rss/RssMacro.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/macro/rss/RssMacroParameters.java > Log: > XWIKI-3359 Add "width" parameter to box macro > XWIKI-3358 Add ability to control the width of the box containing the output of the RSS macro 2.0 > > Merged from branch 1.8 > > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/AbstractBoxMacro.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/AbstractBoxMacro.java 2009-03-14 09:58:04 UTC (rev 17623) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/AbstractBoxMacro.java 2009-03-14 10:00:44 UTC (rev 17624) > @@ -21,6 +21,7 @@ > > import java.io.StringReader; > import java.util.Collections; > +import java.util.HashMap; > import java.util.List; > import java.util.Map; > > @@ -123,19 +124,24 @@ > String titleParameter = parameters.getTitle(); > List< ? extends Block> titleBlockList = parameters.getBlockTitle(); > > + Map<String, String> boxParameters = new HashMap<String, String>(); > String classParameter = parameters.getCssClass(); > String cssClass = > StringUtils.isEmpty(classParameter) ? getClassProperty() : getClassProperty() + " " + classParameter; > - Map<String, String> classParameterMap = Collections.singletonMap("class", cssClass); > + boxParameters.put("class", cssClass); > > + if (!StringUtils.isEmpty(parameters.getWidth())) { > + boxParameters.put("style", "width:" + parameters.getWidth()); > + } > + > Block boxBlock; > if (context.isInline()) { > List<Block> contentBlocks = parseContent(parameters, content, context); > FormatBlock spanBlock = new FormatBlock(contentBlocks, Format.NONE); > - spanBlock.setParameters(classParameterMap); > + spanBlock.setParameters(boxParameters); > boxBlock = spanBlock; > } else { > - boxBlock = new XMLBlock(new XMLElement("div", classParameterMap)); > + boxBlock = new XMLBlock(new XMLElement("div", boxParameters)); > > // we add the image, if there is one > if (!StringUtils.isEmpty(imageParameter)) { > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/BoxMacroParameters.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/BoxMacroParameters.java 2009-03-14 09:58:04 UTC (rev 17623) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/main/java/org/xwiki/rendering/macro/box/BoxMacroParameters.java 2009-03-14 10:00:44 UTC (rev 17624) > @@ -48,6 +48,11 @@ > private String image = StringUtils.EMPTY; > > /** > + * Refer to {@link #getWidth()}. > + */ > + private String width = StringUtils.EMPTY; > + > + /** > * @return the title to be displayed in the message box. Note that it can be specified using Wiki 2.0 syntax. > */ > private List< ? extends Block> blockTitle; > @@ -117,10 +122,26 @@ > /** > * @param cssClass - refer to {@link BoxMacroParameters#getCssClass()} > */ > - @ParameterDescription("the CSS sheet used for rendering the document") > + @ParameterDescription("A CSS class to add to the box element") > public void setCssClass(String cssClass) > { > this.cssClass = cssClass; > } > > + /** > + * @return an optional width to enforce as an inline style on the DIV element the box will be formed of. > + */ > + public String getWidth() > + { > + return this.width; > + } > + > + /** > + * @param width - refer to {@link BoxMacroParameters#getWidth()} > + */ > + @ParameterDescription("An optional width for the box, expressed in px or %") > + public void setWidth(String width) > + { > + this.width = width; > + } > } > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/internal/macro/rss/RssMacro.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/internal/macro/rss/RssMacro.java 2009-03-14 09:58:04 UTC (rev 17623) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/internal/macro/rss/RssMacro.java 2009-03-14 10:00:44 UTC (rev 17624) > @@ -28,6 +28,7 @@ > import com.sun.syndication.io.SyndFeedInput; > import com.sun.syndication.io.XmlReader; > > +import org.apache.commons.lang.StringUtils; > import org.xwiki.rendering.block.Block; > import org.xwiki.rendering.block.LinkBlock; > import org.xwiki.rendering.block.MacroBlock; > @@ -178,6 +179,11 @@ > if (parameters.isCss()) { > boxParameters.setCssClass("rssfeed"); > } > + > + if (!StringUtils.isEmpty(parameters.getWidth())) { > + boxParameters.setWidth(parameters.getWidth()); > + } > + > renderFeedOrEntryTitle(boxParameters, parameters.isCss(), "rsschanneltitle", feed.getTitle(), feed.getLink()); > > List<Block> result = null; > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/macro/rss/RssMacroParameters.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/macro/rss/RssMacroParameters.java 2009-03-14 09:58:04 UTC (rev 17623) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-rss/src/main/java/org/xwiki/rendering/macro/rss/RssMacroParameters.java 2009-03-14 10:00:44 UTC (rev 17624) > @@ -22,6 +22,7 @@ > > import java.net.URL; > > +import org.apache.commons.lang.StringUtils; > import org.xwiki.rendering.macro.descriptor.ParameterDescription; > import org.xwiki.rendering.macro.descriptor.ParameterMandatory; > > @@ -55,6 +56,11 @@ > private boolean image; > > /** > + * The width of the enclosing box containing the RSS macro output. > + */ > + private String width = StringUtils.EMPTY; > + > + /** > * If "true" then adds class id elements (rssitem, rssitemtitle, rssitemdescription, rsschanneltitle, etc) which you > * can style by modifying your skin's CSS file. > */ > @@ -103,6 +109,23 @@ > } > > /** > + * @param width the width of the RSS box, that will dismiss potential CSS rules defining its default value. > + */ > + @ParameterDescription("The width, in px or %, of the box containing the RSS output (default is 30%)") > + public void setWidth(String width) > + { > + this.width = width; > + } > + > + /** > + * @return the width of the RSS box, that will dismiss potential CSS rules defining its default value. > + */ > + public String getWidth() > + { > + return this.width; > + } > + > + /** > * @param css whether to add class id elements (rssitem, rssitemtitle, rssitemdescription, rsschanneltitle, etc). > */ > @ParameterDescription("Specifies whether to add class id elements (rssitem, rssitemtitle, rssitemdescription etc).") > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r17618 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation xwiki-rendering-tests/src/test/resources/macros
by Thomas Mortagne 14 Mar '09

14 Mar '09

On Fri, Mar 13, 2009 at 16:50, SVN jvelociter <platform-notifications(a)xwiki.org> wrote: > Author: jvelociter > Date: 2009-03-13 16:50:43 +0100 (Fri, 13 Mar 2009) > New Revision: 17618 > > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/MacroTransformation.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro7.test > platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro8.test > platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro9.test > Log: > XWIKI-3352 Wrap rendering error descriptions in a <pre> tag > > Merged from branch 1.8 > > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/MacroTransformation.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/MacroTransformation.java 2009-03-13 15:43:26 UTC (rev 17617) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/MacroTransformation.java 2009-03-13 15:50:43 UTC (rev 17618) > @@ -226,15 +226,17 @@ > Map<String, String> errorDescriptionBlockParams = > Collections.singletonMap("class", "xwikirenderingerrordescription hidden"); > > + Block descriptionBlock = new XMLBlock(Arrays.asList((Block) new WordBlock(description)), new XMLElement("pre", Collections.EMPTY_MAP)); You should use VerbatimBlock instead, it's its job. > + > if (macroToReplace.isInline()) { > errorBlocks.add(new XMLBlock(Arrays.asList((Block) new WordBlock(message)), new XMLElement("span", > errorBlockParams))); > - errorBlocks.add(new XMLBlock(Arrays.asList((Block) new WordBlock(description)), new XMLElement("span", > + errorBlocks.add(new XMLBlock(Arrays.asList((Block) descriptionBlock), new XMLElement("span", > errorDescriptionBlockParams))); > } else { > errorBlocks.add(new XMLBlock(Arrays.asList((Block) new WordBlock(message)), new XMLElement("div", > errorBlockParams))); > - errorBlocks.add(new XMLBlock(Arrays.asList((Block) new WordBlock(description)), new XMLElement("div", > + errorBlocks.add(new XMLBlock(Arrays.asList((Block) descriptionBlock), new XMLElement("div", > errorDescriptionBlockParams))); > } > > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro7.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro7.test 2009-03-13 15:43:26 UTC (rev 17617) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro7.test 2009-03-13 15:50:43 UTC (rev 17618) > @@ -16,7 +16,9 @@ > onWord [Unknown macro: unknown] > endXMLNode [span] [class=xwikirenderingerror] > beginXMLNode [span] [class=xwikirenderingerrordescription hidden] > +beginXMLNode [pre] > onWord [The "unknown" macro is not in the list of registered macros. Verify the spelling or contact your administrator.] > +endXMLNode [pre] > endXMLNode [span] [class=xwikirenderingerrordescription hidden] > endMacroMarkerInline [unknown] [] [] > onSpace > @@ -26,7 +28,7 @@ > .#----------------------------------------------------- > .expect|xhtml/1.0 > .#----------------------------------------------------- > -Unknown Unknown macro: unknownThe "unknown" macro is not in the list of registered macros. Verify the spelling or contact your administrator. macro > +Unknown Unknown macro: unknown<pre>The "unknown" macro is not in the list of registered macros. Verify the spelling or contact your administrator.</pre> macro > .#----------------------------------------------------- > .expect|xwiki/2.0 > .#----------------------------------------------------- > @@ -34,4 +36,4 @@ > .#----------------------------------------------------- > .input|xhtml/1.0 > .#----------------------------------------------------- > -<html>Unknown Unknown macro: unknownThe "unknown" macro is not in the list of registered macros. Verify the spelling or contact your administrator. macro</html> > \ No newline at end of file > +<html>Unknown Unknown macro: unknown<pre>The "unknown" macro is not in the list of registered macros. Verify the spelling or contact your administrator.</pre> macro</html> > \ No newline at end of file > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro8.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro8.test 2009-03-13 15:43:26 UTC (rev 17617) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro8.test 2009-03-13 15:50:43 UTC (rev 17618) > @@ -17,7 +17,9 @@ > onWord [Not an inline macro] > endXMLNode [span] [class=xwikirenderingerror] > beginXMLNode [span] [class=xwikirenderingerrordescription hidden] > +beginXMLNode [pre] > onWord [This macro can only be used by itself on a new line] > +endXMLNode [pre] > endXMLNode [span] [class=xwikirenderingerrordescription hidden] > endMacroMarkerInline [testsimplemacro] [] [] > onSpace > @@ -27,7 +29,7 @@ > .#----------------------------------------------------- > .expect|xhtml/1.0 > .#----------------------------------------------------- > -Not inline Not an inline macroThis macro can only be used by itself on a new line macro > +Not inline Not an inline macro<pre>This macro can only be used by itself on a new line</pre> macro > .#----------------------------------------------------- > .expect|xwiki/2.0 > .#----------------------------------------------------- > @@ -35,4 +37,4 @@ > .#----------------------------------------------------- > .input|xhtml/1.0 > .#----------------------------------------------------- > -<html>Not inline Not an inline macroThis macro can only be used by itself on a new line macro</html> > \ No newline at end of file > +<html>Not inline Not an inline macro<pre>This macro can only be used by itself on a new line</pre> macro</html> > \ No newline at end of file > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro9.test > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro9.test 2009-03-13 15:43:26 UTC (rev 17617) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-tests/src/test/resources/macros/macro9.test 2009-03-13 15:50:43 UTC (rev 17618) > @@ -15,7 +15,9 @@ > onWord [Failed to execute macro: testfailingmacro] > endXMLNode [span] [class=xwikirenderingerror] > beginXMLNode [span] [class=xwikirenderingerrordescription hidden] > +beginXMLNode [pre] > onWord [stack trace here] > +endXMLNode [pre] > endXMLNode [span] [class=xwikirenderingerrordescription hidden] > endMacroMarkerInline [testfailingmacro] [] [] > onSpace > @@ -25,7 +27,7 @@ > .#----------------------------------------------------- > .expect|xhtml/1.0 > .#----------------------------------------------------- > -Execution Failed to execute macro: testfailingmacrostack trace here error > +Execution Failed to execute macro: testfailingmacro<pre>stack trace here</pre> error > .#----------------------------------------------------- > .expect|xwiki/2.0 > .#----------------------------------------------------- > @@ -33,4 +35,4 @@ > .#----------------------------------------------------- > .input|xhtml/1.0 > .#----------------------------------------------------- > -<html>Execution Failed to execute macro: testfailingmacrostack trace here error</html> > \ No newline at end of file > +<html>Execution Failed to execute macro: testfailingmacro<pre>stack trace here</pre> error</html> > \ No newline at end of file > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

2 1

Re: [xwiki-devs] [xwiki-notifications] r17602 - in platform/core/trunk: xwiki-cache/xwiki-cache-tests/src/main/java/org/xwiki/cache/tests xwiki-containers/xwiki-container-api/src/main/java/org/xwiki/container xwiki-containers/xwiki-container-portlet/src/main/java/org/xwiki/container/portlet xwiki-containers/xwiki-container-servlet/src/main/java/org/xwiki/container/servlet xwiki-core/src/test/java/com/xpn/xwiki/test
by Vincent Massol 13 Mar '09

13 Mar '09

Hi Sergiu, On Mar 13, 2009, at 12:38 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2009-03-13 00:38:08 +0100 (Fri, 13 Mar 2009) > New Revision: 17602 > > Modified: > platform/core/trunk/xwiki-cache/xwiki-cache-tests/src/main/java/ > org/xwiki/cache/tests/AbstractTestCache.java > platform/core/trunk/xwiki-containers/xwiki-container-api/src/main/ > java/org/xwiki/container/ApplicationContext.java > platform/core/trunk/xwiki-containers/xwiki-container-portlet/src/ > main/java/org/xwiki/container/portlet/PortletApplicationContext.java > platform/core/trunk/xwiki-containers/xwiki-container-servlet/src/ > main/java/org/xwiki/container/servlet/ServletApplicationContext.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/ > TestApplicationContext.java > Log: > XWIKI-3312: Add a getTemporaryDirectory() method to ApplicationContext > Done. > Patch submitted by Dan Miron, enhanced and extended. > > > Modified: platform/core/trunk/xwiki-cache/xwiki-cache-tests/src/main/ > java/org/xwiki/cache/tests/AbstractTestCache.java > =================================================================== > --- platform/core/trunk/xwiki-cache/xwiki-cache-tests/src/main/java/ > org/xwiki/cache/tests/AbstractTestCache.java 2009-03-12 23:03:56 UTC > (rev 17601) > +++ platform/core/trunk/xwiki-cache/xwiki-cache-tests/src/main/java/ > org/xwiki/cache/tests/AbstractTestCache.java 2009-03-12 23:38:08 UTC > (rev 17602) > @@ -19,6 +19,7 @@ > */ > package org.xwiki.cache.tests; > > +import java.io.File; > import java.io.InputStream; > import java.net.MalformedURLException; > import java.net.URL; > @@ -130,6 +131,21 @@ > } > > /** > + * {@inheritDoc} > + * > + * @see > org.xwiki.container.ApplicationContext#getTemporaryDirectory() > + */ > + public File getTemporaryDirectory() > + { > + try { > + // The system temporary directory is a good place for > temporary test data. > + return new File(System.getProperty("java.io.tmpdir")); > + } catch (SecurityException e) { > + return new File("."); > + } > + } I don't understand why you had to modify the cache module. > + > + /** > * @return a instance of the cache factory. > * @throws Exception error when searching for cache factory > component. > */ > > Modified: platform/core/trunk/xwiki-containers/xwiki-container-api/ > src/main/java/org/xwiki/container/ApplicationContext.java > =================================================================== > --- platform/core/trunk/xwiki-containers/xwiki-container-api/src/ > main/java/org/xwiki/container/ApplicationContext.java 2009-03-12 > 23:03:56 UTC (rev 17601) > +++ platform/core/trunk/xwiki-containers/xwiki-container-api/src/ > main/java/org/xwiki/container/ApplicationContext.java 2009-03-12 > 23:38:08 UTC (rev 17602) > @@ -20,6 +20,7 @@ > */ > package org.xwiki.container; > > +import java.io.File; > import java.io.InputStream; > import java.net.MalformedURLException; > import java.net.URL; > @@ -27,5 +28,15 @@ > public interface ApplicationContext > { > InputStream getResourceAsStream(String resourceName); > + > URL getResource(String resourceName) throws MalformedURLException; > + > + /** > + * Gets the directory which the container must provide for > storing temporary data. The contents of this directory > + * may be deleted between container restarts (temporary</ > em>, as the name implies), so it is not a safe place to > + * store permanent/important data. > + * > + * @return a {@link File} object pointing to a directory that > the application can use for storing temporary files > + */ > + File getTemporaryDirectory(); I don't like this too much but it's ok for now. However I don't think this is a good generic solution for the future. I think it would be better to implement a temporary storage that uses the same storage api as the other storages (main storage, version storage, attachment storage, etc). The pb with returning a File is that 1) it ties us to a disk storage which might not be available in all environments for various reasons and 2) it's not extensible and you cannot swap another implementation (like it you want to use a memory storage for example). For this we need the new storage/model of course which is why it's ok to have this now. WDYT? Thanks -Vincent

2 2

[xwiki-devs] support for google sitemaps and webmaster tools? (and why do xwiki RDF's give "unsupported file format"?)
by Niels Mayer 12 Mar '09

12 Mar '09

Has anybody figured out a way to get xwiki to generate a Google sitemap as an alternative to RSS feeds? (see http://www.google.com/webmasters/tools/docs/en/protocol.html ). Also, video sitemaps ( http://www.google.com/support/webmasters/bin/answer.py?answer=80472&cbid=sw…) would be useful to index xwiki attachments and media on media search engines ( http://video.google.com/ ). Video sitemaps are predicated on MRSS: *Using an mRSS feed as a Video Sitemap* back to top<http://www.google.com/support/webmasters/bin/answer.py?answer=80472&cbid=sw…> Google supports mRSS <http://search.yahoo.com/mrss>, an RSS module that supplements the element capabilities of RSS 2.0<http://cyber.law.harvard.edu/rss/rss.html>to allow for more robust media syndication. If you publish an mRSS feed for the video content on your site, you can submit the feed's URL as a Sitemap. For detailed information on creating an mRSS feed, including samples and best practices, please see the Media RSS specification<http://search.yahoo.com/mrss>. Google also supports RSS 2.0 using enclosures tags for video content and thumbnail urls. **Sitemaps seem to use their own protocol: > *XML Sitemap Format* > > The Sitemap Protocol format consists of XML tags. All data values in a > Sitemap must be entity-escaped<https://www.google.com/webmasters/tools/docs/en/protocol.html#escaped>. > The file itself must be UTF-8 encoded. > > A sample Sitemap that contains just one URL and uses all optional tags is > shown below. The optional tags are in italics. > > <?xml version="1.0" encoding="UTF-8"?> > <urlset <https://www.google.com/webmasters/tools/docs/en/protocol.html#urlsetdef> xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> > <url <https://www.google.com/webmasters/tools/docs/en/protocol.html#urldef>> > <loc <https://www.google.com/webmasters/tools/docs/en/protocol.html#locdef>>http://www.example.com/</loc> > *<lastmod <https://www.google.com/webmasters/tools/docs/en/protocol.html#lastmoddef>>2005-01-01</lastmod> > <changefreq <https://www.google.com/webmasters/tools/docs/en/protocol.html#changefreqdef>>monthly</changefreq> > <priority <https://www.google.com/webmasters/tools/docs/en/protocol.html#prioritydef>>0.8</priority>* > </url> > </urlset> > > The Sitemap must: > > - Begin with an opening <urlset> tag and end with a closing </urlset>tag. > - Include a <url> entry for each URL as a parent XML tag. > - Include a <loc> child entry for each <url> parent tag. > > Niels http://nielsmayer.com PS: google sitemap support sounds like a good entry-level GSOC project. :-) Probably just a big hack to existing code in Main.WebRss?xpage=rdf and Main.BlogRss?xpage=rdf. Probably a 1 day project for someone that knows how.... PPS: why does http://nielsmayer.com/xwiki/bin/view/Main/WebRss?xpage=rdfwork in many places, display correctly in firefox 3, but when used to generate a sitemap in google webmaster tools, it fails. (Meanwhile roller blogger's RSS feed succeeds): roller/NielsMayer/feed/entries/atom Atom Feed 5 hours ago OK 32 xwiki/bin/view/Main/BlogRss?xpage=rdf -- 5 hours ago Errors -- xwiki/bin/view/Main/WebRss?xpage=rdf -- 5 hours ago Errors The reported problem coming from xwiki's xpage=rdf feeds: *Unsupported file format* > Your Sitemap does not appear to be in a supported format. Please ensure it > meets our Sitemap guidelines and resubmit. Help<http://www.google.com/support/webmasters/bin/answer.py?answer=35738&hl=en> [image: > Help] >

2 1

[xwiki-devs] [VOTE] Java Logging configuration file
by Fabio Mancinelli 11 Mar '09

11 Mar '09

Dear all, Restlet uses as its logging system the Java Logging System provided with the JDK. So in order to vary its verbosity it's needed to configure that system by providing a logging.properties like the one located in the JRE/lib. This properties file is ether passed as a system property through a -D parameter to the JVM, or explicitly loaded and set using LogManager.getLogManager().readConfiguration(); In order load this configuration file I did the following: I placed a logging.properties file in WEB-INF and loaded it in the init() method of a subclass of the Restlet Servlet. Now there are several possibilities wrt to where to place the logging.properties and how to actually name it. 1) WEB-INF/logging.properties 2) The resources of the REST module 3) XWiki Core. I am +1 for 1 (maybe we can call it java-logging.properties) WDYT? Cheers, Fabio

2 1