- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] JSX skin extension: why not importing external JS based on URL?
by Pascal Voitot 17 Oct '08

17 Oct '08

hello, I would like to be able to import an external Javascript using its URL in the head of the HTML page using the same model as JSX extension... something like: $xwiki.jsx.use("url:http://my_url_to_my_external_js") but JSX always translates the URL into a JSX action... It would really be practical for importing external JS APIs... What do you think about this possible extension to Skin extension? Is there already another way of doing this? regards Pascal

2 2

Re: [xwiki-devs] [xwiki-notifications] r13574 - platform/core/trunk/xwiki-cache/xwiki-cache-api/src/main/java/org/xwiki/cache/internal
by Vincent Massol 17 Oct '08

17 Oct '08

Hi Thomas, Hmmm.... I think this would be best done as it's done in the DefaultRenderingConfiguration class, i.e. with a configuration component which is in charge of returning the values and in charge of setting the default values. WDYT? Thanks -Vincent On Oct 15, 2008, at 3:10 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2008-10-15 15:09:38 +0200 (Wed, 15 Oct 2008) > New Revision: 13574 > > Modified: > platform/core/trunk/xwiki-cache/xwiki-cache-api/src/main/java/org/ > xwiki/cache/internal/DefaultCacheManager.java > Log: > XWIKI-2741: Add a CacheManager component based on configuration > component to get default cache and local cache hint > * add default hints to use when configuration is not found in > xwiki.properties > > Modified: platform/core/trunk/xwiki-cache/xwiki-cache-api/src/main/ > java/org/xwiki/cache/internal/DefaultCacheManager.java > =================================================================== > --- platform/core/trunk/xwiki-cache/xwiki-cache-api/src/main/java/ > org/xwiki/cache/internal/DefaultCacheManager.java 2008-10-15 > 13:06:40 UTC (rev 13573) > +++ platform/core/trunk/xwiki-cache/xwiki-cache-api/src/main/java/ > org/xwiki/cache/internal/DefaultCacheManager.java 2008-10-15 > 13:09:38 UTC (rev 13574) > @@ -43,6 +43,16 @@ > public class DefaultCacheManager implements CacheManager, > Initializable, Composable > { > /** > + * The default cache implementation. > + */ > + private static final String DEFAULT_CACHE_HINT = "jbosscache"; > + > + /** > + * The default local cache implementation. > + */ > + private static final String DEFAULT_LOCALCACHE_HINT = > "jbosscache/local"; > + > + /** > * The component manager to use to find cache components. > */ > private ComponentManager componentManager; > @@ -60,12 +70,12 @@ > /** > * The role hint of configured default cache component. > */ > - private String cacheHint; > + private String cacheHint = DEFAULT_CACHE_HINT; > > /** > * The role hint of configured default local cache component. > */ > - private String localCacheHint; > + private String localCacheHint = DEFAULT_LOCALCACHE_HINT; > > /** > * {@inheritDoc}

1 0

Re: [xwiki-devs] [xwiki-notifications] r13481 - in enterprise/trunk/distribution-test: . wysiwyg-tests wysiwyg-tests/src wysiwyg-tests/src/test wysiwyg-tests/src/test/it wysiwyg-tests/src/test/it/com wysiwyg-tests/src/test/it/com/xpn wysiwyg-tests/src/test/it/com/xpn/xwiki wysiwyg-tests/src/test/it/com/xpn/xwiki/it wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/framework
by Sergiu Dumitriu 17 Oct '08

17 Oct '08

jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-10-10 11:53:57 +0200 (Fri, 10 Oct 2008) > New Revision: 13481 > Log: > XE-319 : Write an integration tests framework for the new wysiwyg editor > > Initial version, the XHTML assertions must be reviewed since some behaviors looks weird. Should we test the internal HTML? Or the generated wiki syntax? Marius, do all the browsers have the same markup? AFAIK, no, so this is a point against testing HTML. Testing the wiki syntax implies testing not just the editor, but also the html parser. -- Sergiu Dumitriu http://purl.org/net/sergiu/

3 5

Re: [xwiki-devs] [xwiki-notifications] r13521 - platform/core/branches/xwiki-core-1.6/xwiki-core
by Vincent Massol 16 Oct '08

16 Oct '08

Actually we should have it as a build best practice to always specify an id inside an <execution> element since this has already caused other problems in the past. Thanks -Vincent On Oct 13, 2008, at 5:23 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-10-13 05:23:01 +0200 (Mon, 13 Oct 2008) > New Revision: 13521 > > Modified: > platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml > Log: > XWIKI-2757: Empty .jar produced after build > Fixed. > Merged from trunk@13520 > > > Modified: platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml > =================================================================== > --- platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml > 2008-10-13 03:21:34 UTC (rev 13520) > +++ platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml > 2008-10-13 03:23:01 UTC (rev 13521) > @@ -626,6 +626,9 @@ > <artifactId>maven-jar-plugin</artifactId> > <executions> > <execution> > +  > + <id>build-test-jar</id> > <goals> > <goal>test-jar</goal> > </goals>

2 1

Re: [xwiki-devs] [xwiki-notifications] r13522 - in platform/core/trunk/xwiki-localization/src/main: java/org/xwiki/localization java/org/xwiki/localization/internal resources/META-INF/plexus
by Vincent Massol 16 Oct '08

16 Oct '08

On Oct 13, 2008, at 6:10 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-10-13 06:10:11 +0200 (Mon, 13 Oct 2008) > New Revision: 13522 > > Modified: > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/AbstractWikiBundle.java > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/Bundle.java > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/DefaultWikiInformation.java > platform/core/trunk/xwiki-localization/src/main/java/org/xwiki/ > localization/internal/StaticDocumentsBundle.java > platform/core/trunk/xwiki-localization/src/main/resources/META-INF/ > plexus/components.xml > Log: > XWIKI-2756: New Localization component > Fix some errors detected at runtime. [snip] > > properties.putAll(getDocumentBundle(fullDocumentName, > language)); > } catch (Exception ex) { > - getLogger().warn("Exception loading a document > bundle"); > + getLogger().warn("Exception loading a document > bundle: " + fullDocumentName); Would be good to use "[" + fullDocumentName + "]" (or MessageFormat or the new logger). Thanks -Vincent

2 1

Re: [xwiki-devs] [xwiki-notifications] r13481 - in enterprise/trunk/distribution-test: . wysiwyg-tests wysiwyg-tests/src wysiwyg-tests/src/test wysiwyg-tests/src/test/it wysiwyg-tests/src/test/it/com wysiwyg-tests/src/test/it/com/xpn wysiwyg-tests/src/test/it/com/xpn/xwiki wysiwyg-tests/src/test/it/com/xpn/xwiki/it wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/framework
by Vincent Massol 16 Oct '08

16 Oct '08

On Oct 10, 2008, at 11:53 AM, jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-10-10 11:53:57 +0200 (Fri, 10 Oct 2008) > New Revision: 13481 > > Added: > enterprise/trunk/distribution-test/wysiwyg-tests/ > enterprise/trunk/distribution-test/wysiwyg-tests/pom.xml > enterprise/trunk/distribution-test/wysiwyg-tests/src/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/xpn/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/AllTests.java > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/StandardFeaturesTest.java > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/framework/ > enterprise/trunk/distribution-test/wysiwyg-tests/src/test/it/com/ > xpn/xwiki/it/selenium/framework/AbstractWysiwygTestCase.java > Log: > XE-319 : Write an integration tests framework for the new wysiwyg > editor > > Initial version, the XHTML assertions must be reviewed since some > behaviors looks weird. [snip] > + public void testTypingAndDeletion() > + { > + typeText("foobar"); > + assertXHTML("foobar "); This is not correct. There should be no br. > + typeBackspaces("foobar".length()); > + assertXHTML(WYSIWYG_DEFAULT_CONTENT); Maybe an assertEmptyXHTML() would be better? > + public void testParagraphs() > + { > + typeTextThenEnter("a"); > + typeTextThenEnter("b"); > + typeText("c"); > + assertXHTML("abc "); The br is wrong. > + public void testBold() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); What does this mean? Select the first element in the DOM? Couldn't we have instead: selectText("foobar")? It would seems easier to write and easier to understand. > + clickBoldButton(); > + assertXHTML("foobar</ > strong> "); The second paragraph shouldn't be there. > + public void testItalics() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); > + clickItalicsButton(); > + assertXHTML("foobar "); Same > > + } > + > + public void testUnderline() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); > + clickUnderlineButton(); > + assertXHTML("<ins>foobar</ins><ins></ins> </ > p>"); same > > + } > + > + public void testStrikethrough() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); > + clickStrikethroughButton(); > + assertXHTML("<del>foobar</del><del></del> </ > p>"); same > > + } > + > + public void testSubscript() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); > + clickSubscriptButton(); > + assertXHTML("foobar "); same > > + } > + > + public void testSuperscript() > + { > + typeTextThenEnter("foobar"); > + selectElement("p", 1); > + clickSuperscriptButton(); > + assertXHTML("foobar "); same > > + } > + > + public void testUnorderedList() > + { > + // Create a list with 3 items > + typeTextThenEnter("a"); > + typeTextThenEnter("b"); > + typeText("c"); > + selectAllContent(); > + clickUnorderedListButton(); > + assertXHTML("<ul><li>a</li><li>b</li><li>c </li></ul>"); > + > + // Undo > + clickUnorderedListButton(); > + assertXHTML("abc "); br shouldn't be there > > + > + // Create a list with 1 item and delete it > + resetContent(); clearContent()? > + typeText("a"); > + selectAllContent(); > + clickUnorderedListButton(); > + typeBackspaces(2); > + assertXHTML(" "); should be empty. > + > + // Create a list with 1 item and delete the bullet > + resetContent(); > + typeText("a"); > + selectAllContent(); > + clickUnorderedListButton(); > + typeLeftArrow(); > + typeBackspace(); > + assertXHTML("a"); [snip] (other tests also need to be fixed) > + > + public static final String WYSIWYG_DEFAULT_CONTENT = " "; This is not correct. It should be empty. Thanks -Vincent

2 1

Re: [xwiki-devs] [xwiki-notifications] r13504 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc
by Vincent Massol 16 Oct '08

16 Oct '08

Hi Sergiu, On Oct 11, 2008, at 3:15 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-10-11 03:15:50 +0200 (Sat, 11 Oct 2008) > New Revision: 13504 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > XWikiDocument.java > Log: > XWIKI-2587: Saving a blank wiki page throws exception in Oracle > Fixed. > > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > doc/XWikiDocument.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > XWikiDocument.java 2008-10-10 23:36:43 UTC (rev 13503) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/ > XWikiDocument.java 2008-10-11 01:15:50 UTC (rev 13504) > @@ -420,6 +420,9 @@ > > public void setContent(String content) > { > + if (content == null) { > + content = ""; > + } I think this requires some comment explanations (explaining that with an Oracel DB the content can be null whereas in other DBs it's never null) since normally content cannot be null (we don't check for null as a general practice). Thanks -Vincent > > if (!content.equals(this.content)) { > setContentDirty(true); > setWikiNode(null);

1 0

[xwiki-devs] [ANN] XWiki Enterprise 1.6.1 released
by Thomas Mortagne 16 Oct '08

16 Oct '08

The XWiki development team is pleased to announce the release of XWiki Enterprise 1.6.1. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is a bug fix release. It fix an important regression of LDAP authenticator. Changes from 1.6: Bugs fixed * XWIKI-2747 - LDAP search is sometime done without the base dn * XWIKI-2753 - Display bug in konqueror for class editor * XWIKI-2757 - Empty .jar produced after build Improvements * XAPANELS-59 - Inconsistent redirects in the Panel Wizard Task * XWIKI-2752 - Remove the "code" formatting style from the old WYSIWYG editor For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise161 Thanks -The XWiki dev team

1 0

[xwiki-devs] Error deploying xwiki enterprise 1.6
by Vivian Richard 16 Oct '08

16 Oct '08

Hi, I am trying to deploy xwiki enterprise in my Fedora 3, JBoss 4.0.5 server and using jdk1.5.0_01. I am getting the following error: javax.servlet.ServletException: Error number 3 in 0: Could not initialize main XWiki context Wrapped Exception: Unable to build interceptor chain org.apache.struts.action.RequestProcessor.processException(RequestProcessor.java:535) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:433) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:697) javax.servlet.http.HttpServlet.service(HttpServlet.java:810) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:94) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96) root cause com.xpn.xwiki.XWikiException: Error number 3 in 0: Could not initialize main XWiki context Wrapped Exception: Unable to build interceptor chain com.xpn.xwiki.XWiki.getMainXWiki(XWiki.java:325) com.xpn.xwiki.XWiki.getXWiki(XWiki.java:386) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:135) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:697) javax.servlet.http.HttpServlet.service(HttpServlet.java:810) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:94) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:287) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96) Please suggest

3 5

[xwiki-devs] [VOTE] Release XE 1.6.1
by Thomas Mortagne 16 Oct '08

16 Oct '08

Hi devs, XE 1.6 contains an important LDAP bug, it's now fixed and I would like to release a 1.6.1 version as soon as possible. Here is my +1 -- Thomas Mortagne

4 5