- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [GSoC][officeimporter]generate formatblock for del
by Wang Ning 15 Aug '08

15 Aug '08

Hi Vincent, I run a test case for <del> and it does not work. In XDOMGeneratorListener#endFormat(WikiFormat format) you use (format.hasStyle(IWemConstants.STRIKE)) to handle the strickout, but both <s> and <strike> are deprecated in xhtml. Why not use (format.hasStyle(IWemConstants.DEL))? WDYT? Thanks Wang Ning

2 1

[xwiki-devs] Problems with SyndEntryDocumentSourceTest
by Vincent Massol 15 Aug '08

15 Aug '08

Hi, I've reviewed SyndEntryDocumentSourceTest and I've found some problems: 1) In testSourceAccessRights() 253 1 try { 254 1 source.source(new SyndEntryImpl(), doc, Collections.EMPTY_MAP, getContext()); 255 0 assertTrue(ACCESS_RIGHTS_VIOLATED, false); 256 } catch (XWikiException e) { 257 // we should get an exception 258 } This is not the correct way: * the assertTrue is never executed since the test expects an exception to be thrown * instead the assertTrue should be replaced by a fail("Should have thrown an exception here") * the catch should have an exception name of "expected" instead of "e" to signify that this is expected * the exception should be checked in the catch to verify it's the correct one we get 259 // even user name length implies all access rights 260 1 getContext().setUser("Condor"); 261 1 try { 262 1 source.source(new SyndEntryImpl(), doc, Collections.EMPTY_MAP, getContext()); 263 // we shouldn't get an exception 264 } catch (XWikiException e) { 265 0 assertTrue(ACCESS_RIGHTS_VIOLATED, false); 266 } Same here 2) In initArticleClass() 167 7 XWikiDocument doc; 168 7 boolean needsUpdate = false; 169 170 7 try { 171 7 doc = getContext().getWiki().getDocument(ARTICLE_CLASS_NAME, getContext()); 172 } catch (Exception e) { 173 0 doc = new XWikiDocument(); 174 0 doc.setFullName(ARTICLE_CLASS_NAME); 175 0 needsUpdate = true; 176 } 177 178 7 BaseClass bclass = doc.getxWikiClass(); 179 7 bclass.setName(ARTICLE_CLASS_NAME); 180 181 7 needsUpdate |= bclass.addTextField("title", "Title", 64); 182 7 needsUpdate |= bclass.addTextAreaField("content", "Content", 45, 4); 183 7 needsUpdate |= bclass.addTextField("category", "Category", 64); 184 185 7 String content = doc.getContent(); 186 7 if ((content == null) || (content.equals(""))) { 187 0 needsUpdate = true; 188 0 doc.setContent("1 XWiki.ArticleClass"); 189 } 190 191 7 if (needsUpdate) { 192 7 getContext().getWiki().saveDocument(doc, getContext()); 193 } 194 7 return bclass; 195 } * Lines 173-175 are never called. * Lines 187-188 are never called too. Could the writer of this test please fix this? Thanks -Vincent

2 1

[xwiki-devs] Problems with PeriodFactoryTest
by Vincent Massol 15 Aug '08

15 Aug '08

Hi, There are some pb with PeriodFactoryTest. For example: public void testDayPeriodStartEndCode()... 40 { 41 1 Period day = PeriodFactory.createDayPeriod(System.currentTimeMillis()); 42 1 SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd"); 43 1 try { 44 1 long start = sdf.parse(String.valueOf(day.getStartCode())).getTime(); 45 1 long end = sdf.parse(String.valueOf(day.getEndCode())).getTime(); 46 1 assertTrue("Start code must be less than end code", start < end); 47 } catch (ParseException e) { 48 0 assertTrue(e.getMessage(), false); 49 } 50 } 51 This test isn't expecting an exception to be raised and thus it should: * throw an Exception in its signature * remove the try/catch block The other test methods should also be fixed similarly. Could the writer of this test please fix this? Thanks -Vincent

2 1

[xwiki-devs] New WYSIWYG integration issue
by Marius Dumitru Florea 15 Aug '08

15 Aug '08

Hi devs, I'm trying to integrate the new WYSIWYG editor into XWiki's page editing mechanism and I'm having an issue regarding how the edited content is being submitted. Right now (correct me if I'm wrong) when the user clicks "Save & View" the edit form is submitted having a "content" field filled with the result of converting editor's HTML output to XWiki syntax. Two things should be noted: * the conversion takes place on the client side, in JavaScript code; * the save action, on the server side, expects XWiki code, not (X)HTML. In the case of the new WYSIWYG editor, converting the (X)HTML to XWiki on the client side is out of discussion. I must use the new rendering module, which is written in Java. In order to smoothly integrate the new editor I have to make sure the save action gets the XWiki code it expects. Asynchronously retrieving the result of the conversion before submitting the edit form is tricky due to the fact that the user can click "Save & View" before the response arrives. In light of this, Sergiu suggested me the following 2 solutions: A) Retrieve the conversion synchronously This would be easy if GWT would allow it. Instead I'd have to write error-prone code using timeout to wait for the response and then release the form submit. B) Use a servlet filter I'd have to write a servlet filter that detects the save action, determines the editor (wysiwyg, new_wysiwyg, wiki etc.) and the syntax of the submitted content (XWiki by default, XHTML for the new editor) and makes the conversion, if needed. I prefer the second solution. WDYT? Regards, Marius

4 7

Re: [xwiki-devs] [xwiki-notifications] r11850 - in platform/core/trunk: xwiki-patchservice xwiki-rendering/src/main/java/org/xwiki/rendering/renderer/xhtml
by Vincent Massol 15 Aug '08

15 Aug '08

On Aug 15, 2008, at 11:16 AM, vmassol (SVN) wrote: > Author: vmassol > Date: 2008-08-15 11:16:30 +0200 (Fri, 15 Aug 2008) > New Revision: 11850 > > Modified: > platform/core/trunk/xwiki-patchservice/pom.xml This shouldn't have been committed, sorry. Anyway it shouldn't do any harm so leaving it for now. -Vincent > platform/core/trunk/xwiki-rendering/src/main/java/org/xwiki/ > rendering/renderer/xhtml/XHTMLRenderer.java > Log: > XWIKI-2568: Continue implementing the new Rendering Architecture > > * Fixed XHTML output for underline since is deprecated. We use a > class='underline' instead. > > Modified: platform/core/trunk/xwiki-patchservice/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-patchservice/pom.xml 2008-08-14 > 20:20:58 UTC (rev 11849) > +++ platform/core/trunk/xwiki-patchservice/pom.xml 2008-08-15 > 09:16:30 UTC (rev 11850) > @@ -95,15 +95,7 @@ > <version>2.8.1</version> > <scope>test</scope> > </dependency> > - > - <dependency> >  > <groupId>javax.servlet</groupId> > <artifactId>servlet-api</artifactId> > @@ -124,19 +116,4 @@ > <scope>test</scope> > </dependency> > </dependencies> > -</project> > +</project>

1 0

[xwiki-devs] [GSoC][officeimporter]test WikiModelXHTMLParser and TestEventsListener
by Wang Ning 15 Aug '08

15 Aug '08

Hi, Vincent I test the xhtml parser. There is the focus: 1. base text format underline. I think you can fix it. 2. List both number and bulleted. The problem is in wikimodel xhtmlparser. It don't parser nested list correctly. I think it hard to fix but I will try my best. 3. Link For input <html><body><a href=\"http://xwiki.org\">xwiki</a></body></html>, the xhtmlparser generate beginDocument() beginParagraph([]) beginFormat([]) xwiki<http://xwiki.org> endFormat([]) endParagraph([]) endDocument() I use XhtmlParser and EventDumpListener. But the WikiModelXHTMLParser don't handle the event. Maybe XDOMGeneratorListener have some problem to generate link block. Any suggestion about this? Thanks. 4. table Xhtmlparser can generate table event, but XDOMGeneratorListener don't handle the event correctly. Is it not finished? 5. img Xhtmlparser just ignore the <img> tag. But it's OK since I use imagetagfilter to handle the <img> 6. param of text like text. how to handle the algin parameter? I think, if the problem above can be fixed, xhtmlparser will work for conversion from xhtml to xwiki syntax. Thanks. Wang Ning

2 5

[xwiki-devs] Stylesheet for just some pages
by Markus Lanthaler 14 Aug '08

14 Aug '08

Hi, I'm currently adding some stylesheets to Albatross to style the new OpenID login and registration form (http://jira.xwiki.org/jira/browse/XSALBATROSS-34) Since those OpenID styles are used only there I wanted to ask how it is possible to include the stylesheet just on the login and registration page!? Is there some special mechanisms? Thanks, Markus

2 6

[xwiki-devs] [GSoC][officeimporter]quick question about new rending block
by Wang Ning 14 Aug '08

14 Aug '08

Hi Vincent, 1. I found the rendering of boldblock is **bold**, which should be *bold*, right? The related class is XWikiSyntaxRenderer. 2. I can't find a underline block. Is it missing or just no needed. How to rendering underline or __underline__ Thanks. Wang Ning

2 1

[xwiki-devs] [GSOC] Deadline approaching soon: 18 August
by Vincent Massol 14 Aug '08

14 Aug '08

Hi GSOCers and mentors, See http://code.google.com/opensource/gsoc/2008/faqs.html#0.1_timeline Make sure everything is committed, cleaned, documented, integrated. Thanks -Vincent

1 0

[xwiki-devs] Monitoring and Export Application
by Ludovic Dubost 13 Aug '08

13 Aug '08

Hi, I've fixed the Monitoring application on http://code.xwiki.org (the package was corrupted) and published an Import/Export Application. The Monitoring application includes scripts to check the running requests, view the memory consumption and flush the cache. The Import/Export application includes a selective export, an export by date, a single page export and import. The Applications are available on xwiki.org: http://code.xwiki.org/xwiki/bin/view/Applications/MonitoringApplication http://code.xwiki.org/xwiki/bin/view/Applications/ImportExportApplication Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

1 0