25 Feb
2010
25 Feb
'10
11:35 a.m.
Hi,
I created the JIRA issue: http://jira.xwiki.org/jira/browse/XWIKI-4939
related to this proposal
and attached a patch to it.
Who would have some time to look at it?
Thanks,
Anamaria
On Thu, Feb 25, 2010 at 11:52 AM, Marius Dumitru Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
Anamaria Stoica wrote:
Hi Marius,
On Thu, Feb 25, 2010 at 9:59 AM, Marius Dumitru Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
Currently wiki macros are defined as objects attached to wiki pages. I
don't think this will be changed too soon so IMO returning a
DocumentReference is fine.
Thanks,
Marius
Hi Anamaria,
Anamaria Stoica wrote:
Good observation, thanks!
I put the return type as DocumentReference because this is what it got
in the constructor of
DefaultWikiMacro, but as DocumentReference extends EntityReference, we
could make the
new method return an EntityReference, thus have:
EntityReference getEntityReference();
Question is now, does it make sense to have any Entity Reference as
return type, or
it must to be a document type? Hi devs,
I'm proposing we add the following method:
DocumentReference getEntityReference();
Why not getDocumentReference()?
considering the returned type.
Thanks,
Anamaria
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
+1 otherwise.
Thanks,
Marius
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs to
org.xwiki.rendering.macro.wikibridge.WikiMacro.
This way we'll have a simple way to retrieve the wiki Document having
the corresponding
XWiki.WikiMacroClass xObject attached.
Thanks,
Anamaria
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs