20 Mar
2009
20 Mar
'09
2:20 p.m.
On Fri, Mar 20, 2009 at 12:37, Dan Miron <dan.miron(a)xwiki.com> wrote:
Hi guys! I'd like to know what you think about
this matter, which has
been raised on http://jira.xwiki.org/jira/browse/XWIKI-3375.
As I posted there, this is what I think:
-the parameters for the two macros are completely different, so i see no
point for having the box specific parameters (cssClass, title, image,
width and blockTitle) among the rss macro's ones, this will lead to
confusion for the user. The box parameters are deduced from the rss
feed's properties and then passed to the box macro. No need for them to
be exposed in the Rss Macro. Therefore, extending the RssMacroParameters
from the BoxMacroParameters is unreliable.
Since rss macro is a box and should support all box macro parameters,
if some parameters of box macro break the rss macro then box macro is
not generic enough.
-extending the RssMacro from the AbstractBoxMacro<RssMacroParameters>
doesn't mean simply implementing AbstractBoxMacro.parseContent instead
of Macro.execute. Currently, most of the code about the box around the
css macro is placed in the box macro's implementation, which is
DefaultBoxMacro, so we do make use of the existing implementations.
Giving up using the box macro internally means giving up using most of
the features already presented in the box macro and rewriting them
All the box macro feature are supposed to be implemented in
AbstractBoxMacro and DefaultBoxMacro is just as its name say it: a
default implementation for the content of the box. If it's more then
it's totally wrong.
-and finally, the most time costing disadvantage is that extending the
rss macro from the box basically means rewriting this macro from
scratch, because it involves redesigning it, task that will cost us time.
I'm just speaking about the box around the whole rss, making rss macro
extends box macro is more about removing code, I can imagine how it
could be possible that it make "rewriting this macro from scratch".
So, therefore, I'm -1 for this.
Tnx,
Dan
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne