For the record, this change breaks the links in the Watch List live
table from the user profile. XWiki.XWikiUserWatchListLiveTableResults,
which feeds the live table, uses:
$services.model.createDocumentReference($wiki, '', '')
and
$services.model.createDocumentReference($wiki, $spaceName, '')
to get the reference to the wiki/space home page. I'm going to update this page.
Thanks,
Marius
On Wed, Feb 20, 2013 at 1:23 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
No one against, applied on master.
I'm -0 (behaviour change) to apply it on 4.5 branch but will apply it
if there is other people who agree with Denis on this part.
On Tue, Feb 19, 2013 at 2:38 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Right now the model script service use "currentmixed" as default
resolver and it should use "current" one IMO:
1) it's behavior is not very clear for a newcomer
2) it's pretty much unusable for attachments
The difference between the two resolver is that "currentmixed" resolve
document name beased on default (WebHome) instead of current document.
AFAIK this resolver as been introduced for retro compatibility purpose
because in some old APIs like XWikiDocument contructors the document
name was resolver as WebHome and not based on the current document.
So I propose to change the default resolver to "current".
Here is my +1.
This script service is not much used yet, I doubt anybody is using it
expecting to get WebHome when resolving the document name but since
it's a behaviour change 5.0 is the right time for it.
--
Thomas Mortagne
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs