Re: [xwiki-devs] [UX][Proposal] Improvements for WYSIWYG macros

On Tue, Jun 12, 2012 at 9:03 PM, Ecaterina Moraru (Valica) <valicac(a)gmail.com> wrote: It's an interesting proposal and it's good you bring this subject up, but.. :) I'm not sure about putting Collapse/Expand Macros on the tool bar because: * The tool bar is a place for features that don't have a menu or that are frequently used. * The argument that this feature needs to be more visible applies to any entry from the menu that is not on the tool bar. This feature is certainly less important than creating a link or inserting an image. I don't think crowding the tool bar is a good idea. * Why text buttons and not icons? * The tool bar is generic. If the macro plugin can put some buttons on the right end of the tool bar then any WYSIWYG editor plugin should be able to do it. We end up with a tool bar split in two. What would be the rule (for a plugin) to put buttons on the left side versus right side of the tool bar? * I don't think it looks nice when the tool bar has multiple lines (which can happen if you activate all the plugins and feaures and reduce the browser window size or use the editor in a form that doesn't take the full page width, e.g. class="xform half" or with both left and right panels). I'm fine with displaying the macro header for block macros (including macro parameters) but I don't think it changes anything for macros with large output. If the macro output spans across multiple 'pages' and you scroll then the macro header is hidden. Also, in-line macros can't have the header. I'm not fond of displaying the background for the macro output. The dashed border and the highlight are enough IMO. Displaying a context tool bar when clicking on the macro should work with both in-line and block macros. This can be made generic and reused for links, images, etc. Same as Sergiu, I'd like to see how you handle in-line macro, i.e. macros inside the text (across multiple lines). A single macro in a table cell is still a block macro. Same as Vincent, we can't really display nested macros. Thanks, Marius