Re: [xwiki-devs] [PROPOSAL] Add support for the reference locale in XWiki#getDocument/exist

Hi devs, While working on XWIKI-9200 (which is done expect for that little question ;)) I found that there is no API to check if a document exist in specific language. You have to do a custom query. Since I would like to make my code as readable as possible and considering that we will have to do it eventually anyway here it is: two choices: 1) add support for reference locale in XWiki#exist and XWiki#getDocument as well as XWikiHibernateStore#exists. Both XWikiHibernateStore#loadXWikiDoc and XWikiCacheStore are already taking into account the locale since they are based on the id (so this would also be about consistency) 2) introduce new methods like XWiki#existsWithLocale, XWiki#getDocumentWithLocale and XWikiStoreInterface#existsWithLocale (and the corresponding implementations) WDYT ? 2) is obviously the safest but I can't find method names I like. I would be OK with 1) if everyone is strongly for it but it's probably a bit dangerous so my vote goes to 2) for now. -- Thomas Mortagne