26 Oct
2010
26 Oct
'10
7:19 p.m.
On 10/26/2010 06:48 PM, Vincent Massol wrote:
We need to decide where to put events but I think
it's wrong to put them in the observation-api package.
Yes, I thought about that, too. Normally, each one should be in its
target module: xwiki-comments, xwiki-attachments, xwiki-annotations.
Unfortunately, we don't have something like that for comments and
attachments. Plus, document events should be moved as well, since they
are not part of the observation core API.
One option would be to move annotation events to an annotation module,
and the others to the a new submodule, xwiki-observation-modelEvents, or
xwiki-model-events.
On Oct 26, 2010, at 6:01 PM, sdumitriu (SVN) wrote:
> Author: sdumitriu
> Date: 2010-10-26 18:01:34 +0200 (Tue, 26 Oct 2010)
> New Revision: 32192
>
> Added:
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractAnnotationEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractAttachmentEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractCommentEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationAddEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationDeleteEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AnnotationUpdateEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentAddEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentDeleteEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AttachmentUpdateEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentAddEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentDeleteEvent.java
>
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/CommentUpdateEvent.java
> Log:
> XWIKI-5622: New event types: add/update/delete comment/annotation/attachment
> Done.
> Patch from Stefan Abageru applied with a bit of changes.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/