16 Oct
2008
16 Oct
'08
10:37 p.m.
Vincent Massol wrote:
Actually we should have it as a build best practice to
always specify
an id inside an <execution> element since this has already caused
other problems in the past.
I started writing a .pom practice document, but didn't have much content
to put in it, so I dropped the idea for a later moment.
By the way, I spent several hours until I found the problem, so
requiring IDs is a very good idea.
Thanks
-Vincent
On Oct 13, 2008, at 5:23 AM, sdumitriu (SVN) wrote:
> Author: sdumitriu
> Date: 2008-10-13 05:23:01 +0200 (Mon, 13 Oct 2008)
> New Revision: 13521
>
> Modified:
> platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml
> Log:
> XWIKI-2757: Empty .jar produced after build
> Fixed.
> Merged from trunk@13520
>
>
> Modified: platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml
> ===================================================================
> --- platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml
> 2008-10-13 03:21:34 UTC (rev 13520)
> +++ platform/core/branches/xwiki-core-1.6/xwiki-core/pom.xml
> 2008-10-13 03:23:01 UTC (rev 13521)
> @@ -626,6 +626,9 @@
> <artifactId>maven-jar-plugin</artifactId>
> <executions>
> <execution>
> + <!-- We must have an ID here, as otherwise the
> configuration is used for generating the normal jar, too.
> + See XWIKI-2757 -->
> + <id>build-test-jar</id>
> <goals>
> <goal>test-jar</goal>
> </goals>
--
Sergiu Dumitriu
http://purl.org/net/sergiu/