Hi devs/Anca,
On Nov 14, 2011, at 3:24 PM, Anca Luca wrote:
On 11/14/2011 02:32 PM, Vincent Massol wrote:
> On Nov 14, 2011, at 2:28 PM, Anca Luca wrote:
>
>> On 11/14/2011 01:51 PM, Vincent Massol wrote:
>>> On Nov 14, 2011, at 1:41 PM, Eduard Moraru wrote:
>>>
>>>> +1,
>>>>
>>>> Also, what about the Dashboard macro itself? Can it be moved inside
>>>> something like
>>>>
xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro?
>>> It's a wiki macro. I wouldn't create a new app just for it. IMO
it's very fine in the Dashboard app and would be overkill to create a new app just for
1 page (I also don't see what it would bring more).
>> ?
>>
>> dashboard macro is not a 'wiki macro' as in it's not in a wiki page,
it's in a java module. It would make a bit sense to move it in it's own module
since it's a bit of a rebel macro: it uses and depends on the platform-oldcore which
is not really what rendering macros do…
> My bad. I mixed it with the activity macro.
>
> Indeed it's not a wiki macro and I completely agree with Eddy's suggestion
:)
>
>> Otherwise I have nothing against putting all that in a dashboard application ( 0
), as long as it's preserving the behaviour.
>>
>> Just as an experience to share: upgrading Main.WebHome is really really annoying,
on multiwikis, we need to make a script or so everytime we make changes in the default
main.webhome, so in this case too. I gained this experience when i changed the
main.webhome in order to introduce dashboards on it, and everybody that upgraded farms
complained about having to upgrade each main.webhome manually. We should avoid this.
> Actually someone upgrading will see have its Main.Dashboard page present unless we
removes it. So it should be fine.
I don't understand. What does Main.Dashboard have to do with Main.WebHome? since some
version (3.2-m-something), Main.WebHome is a standalone dashboard, it's not using
Main.Dashboard, it has and uses its own dashboard (gadgets are stored in the page itself).
It only uses Main.Welcome to grab the welcome text which needs to be translated in all
languages so we put it in a separate page.
My idea is the following:
* Have a Dashboard.WebHome page which displays the "main" dashboard which could
be either the wiki dashboard or the user dashboard
* Have Quick Links Panel 's Dashboard link to point to Dashboard.WebHome
* Have Main.WebHome's content to be {{include document="Dashboard.WebHome"
context="new"/}}
My rationale is that:
* we should have a place in the wiki to display the "main" dashboard and have a
link to it from the UI (this is the Quick Links Panel + The Dashboard space which would
now appear in the list of spaces)
* it just happens that we want by default the Main.WebHome to display the
"main" dashboard but an admin/user might want to display something else and
having a single include with no gadgets in it makes it easy to do
* If users want to create a space dashboard they'd simply use {{dashboard/}} for
their space (and later on they'd use a space template for example)
* I find it a bit strange right now that we have 2 "official" dashboards: the
Main.WebHome one and the Main.Dashboard one
it's the same rationale:
Main.Dashboard is the official wiki dashboard, Main.WebHome just happens to be a dashboard
(it could be anything else). I think we chose this approach (a different dashboard instead
of an include) for the same reason, to allow the main.webhome to be changed while the
official wiki dashboard still stays as a dashboard. And an include was sort of technically
hard to do because we wanted to keep Main.Dashboard as a something that can be used by the
space dashboards, if we decide to break this behaviour (and I think we could since
creating a dashboard in the space webhome is not that hard + we should provide a template
rather than a page to include) it will be easier to have an unique wiki db which is used
on main.webhome.