20 Feb
2013
20 Feb
'13
10:10 a.m.
On Feb 19, 2013, at 2:38 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote:
Hi devs,
Right now the model script service use "currentmixed" as default
resolver and it should use "current" one IMO:
1) it's behavior is not very clear for a newcomer
2) it's pretty much unusable for attachments
The difference between the two resolver is that "currentmixed" resolve
document name beased on default (WebHome) instead of current document.
AFAIK this resolver as been introduced for retro compatibility purpose
because in some old APIs like XWikiDocument contructors the document
name was resolver as WebHome and not based on the current document.
So I propose to change the default resolver to "current".
Here is my +1.
This script service is not much used yet,
I don't think this is fully true. I've seen it used in quite a few extensions and
I know XWiki SAS is using it a bit everywhere too on their client projects.
I doubt anybody is using it
expecting to get WebHome when resolving the document name but since
it's a behaviour change 5.0 is the right time for it.
It's going to break a few places for sure but I'd say it's acceptable.
I think we should:
1) Do a quick review of places where we use it in *.vm and *.xml files in xwiki-platform
to ensure it's ok
2) Make sure it's mentioned in the RN of 5.0 in the backward compat section
3) Update the "currentmixed" resolver javadoc to mention to not use it except
for blah blah…
So here's my +1 to do this in 5.0 provided we do these 3 points.
Thanks
-Vincent