Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc)
* one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For
the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and
one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out
which is the app and which is the event.
I think I would prefer the following:
* On the left, avatar in big + app in smaller on top of it
* On the right, icon for the event. Actually the icon could be in addition to the “text”
(i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the
icon for the event and only keep the text.
In your variations I don’t see one where the app icon is on the left.
Thanks
-Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica)
<valicac(a)gmail.com> wrote:
Hi,
So these are some more iterations for the notifications layout
http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x…
I've played with User centered vs. Event centered and variants for
displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if
you want to make some small changes.
Thanks,
Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent(a)massol.net> wrote:
>
>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau <
> guillaume.delhumeau(a)xwiki.com> wrote:
>>
>> Hello
>>
>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent(a)massol.net>et>:
>>
>>> Hi Guillaume,
>>>
>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau <
>>> guillaume.delhumeau(a)xwiki.com> wrote:
>>>>
>>>> Any news on this? I'd like to implement this quickly because 9.10 is
>>> coming
>>>> :)
>>>
>>> This the current status:
>>> * Caty proposed some improved layout for displaying notifications
>>> * I commented about the need to display event + type, and about the need
>>> to have a link to see the diff. I also mentioned that we need to work on
>>> the mail template display
>>> * Caty replied and updated her proposal to take into account those
>>> comments.
>>> * I kind of like Caty’s proposal focused on the user. We want to favor
>>> contributions and I think it helps. It also makes the UI more appealing
>>> visually.
>>> * You mentioned that you’d prefer a proposal more focused on the event
>>> rather than the user
>>> * Thomas agrees with you
>>> * Edy mentioned some extra points
>>>
>>
>> I have also mentioned that the diff we propose is too technical for many
>> users.
>
> Yes and we have 4 solutions:
>
> * Solution 1: make it simpler to understand for everyone
> * Solution 2: have a wiki admin UI level option to select whether to
> include diff or not in the default template + user-level profile UI option
> (ie. per user)
> * Solution 3: have a singe button in the mail, that, when clicked,
> displays the diff (which is hidden by default)
> * Solution 4: implement 2 mail templates (one for simple users and one for
> advanced users) and let the users choose in their profile which one they
> want to receive + have a wiki admin UI level option to decide which is the
> default when not overridden by the user.
>
> Thanks
> -Vincent
>
>>
>>> So I guess we need to decide about whether we show the avatar as in
> Caty’s
>>> proposal or not, right? Is that what you’re asking about Guillaume?
>>>
>>> On my side, I don’t see the issue in displaying the user avatar large vs
>>> small. The events are still ordered by page events.
>>>
>>> Thanks
>>> -Vincent
>>>
>>
>> Thanks
>>
>>
>>>
>>>>
>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau <
>>>> guillaume.delhumeau(a)xwiki.com>gt;:
>>>>
>>>>> Note that you have a mail template for the notifications too.
It's
>>>>>
https://github.com/xwiki/xwiki-platform/blob/
>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform-
>>>>> core/xwiki-platform-notifications/xwiki-platform-
>>>>> notifications-ui/src/main/resources/XWiki/Notifications/
>>>>> MailTemplate.xml#L23 but it's not documented yet.
>>>>>
>>>>> This mail template allows you to customize the header and the footer
> of
>>>>> the email, but not the actual content.
>>>>>
>>>>> To be precise, each *event type* can have its own template or
failback
>>> to
>>>>> the default one (
https://github.com/xwiki/xwiki-platform/blob/
>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform-
>>>>> core/xwiki-platform-web/src/main/webapp/templates/
>>>>> notification/email/default.html.vm)
>>>>>
>>>>> So it's a template *per event type* and it's not linked to
any user
>>>>> choice. But we could add some options in the default template for
>>> example.
>>>>>
>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol
<vincent(a)massol.net>et>:
>>>>>
>>>>>> Hi Guillaume,
>>>>>>
>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau <
>>>>>> guillaume.delhumeau(a)xwiki.com> wrote:
>>>>>>>
>>>>>>> Some ideas.
>>>>>>>
>>>>>>> I have feedback about the fact the diff is way too technical
for
>>> users.
>>>>>>>
>>>>>>> Example: "What does it means???"
https://img15.hostingpics.net/
>>>>>>> pics/670307example1.png
>>>>>>>
>>>>>>> So we could hide this in a "technical details"
link.
>>>>>>
>>>>>> That’s one option but there’s another which is to provide the
ability
>>> to
>>>>>> choose which mail template to use in the Admin and provide
several
>>>>>> templates for different needs.
>>>>>>
>>>>>> For example for the
xwiki.org watchlist we absolutely need to be
> able
>>> to
>>>>>> see the diffs without clicking a “technical details” link for
each
>>>>>> notification. It could be ok if there’s a single “technical
details”
>>> link
>>>>>> for ALL notifications that shows all diffs at once.
>>>>>>
>>>>>> Thanks
>>>>>> -Vincent
>>>>>>
>>>>>>>
>>>>>>> The "details" link could be replaced by a
"more" link, with a very
>>>>>>> simplified diff (the complete diff would go the the
technical
> details
>>>>>> view).
>>>>>>>
>>>>>>> In the body of the event, in addition with the title of the
> document,
>>> we
>>>>>>> could add some extracts of the diff.
>>>>>>>
>>>>>>> Example taken on gmail:
>>>>>>>
https://img15.hostingpics.net/pics/763456example2.png
>>>>>>>
>>>>>>> I hope it helps,
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol
<vincent(a)massol.net>et>:
>>>>>>>
>>>>>>>> Looks nice. Does it work in all mail clients that support
HTML?
>>>>>>>>
>>>>>>>> I'd like an option to show the details for all events
as otherwise
>>> it's
>>>>>>>> too painful to have to open all one by one (for the use
case when
> you
>>>>>> want
>>>>>>>> to check everything).
>>>>>>>>
>>>>>>>> Same as Guillaume: not all events are page-related
events. So we
> need
>>>>>> to
>>>>>>>> handle those too.
>>>>>>>>
>>>>>>>> Thanks!
>>>>>>>> -Vincent
>>>>>>>>
>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau <
>>>>>>>> guillaume.delhumeau(a)xwiki.com> wrote:
>>>>>>>>>
>>>>>>>>> First of all, it looks very nice.
>>>>>>>>>
>>>>>>>>> Now, you said the events are displayed like in the
notifications,
>>> but
>>>>>> in
>>>>>>>>> the notifications they are ordered by dates, not by
pages. Does
> your
>>>>>>>>> proposal imply to change the ordering? What about
events that do
> not
>>>>>>>>> concern any page (like: "a new wiki has been
created" or "a new
>>> XWiki
>>>>>>>>> version is available")? We don't have such
events for now but we
>>> plan
>>>>>> to
>>>>>>>>> have some soon. We could display them last for
example.
>>>>>>>>>
>>>>>>>>> Nice CSS expand!
>>>>>>>>>
>>>>>>>>> Thanks you,
>>>>>>>>>
>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica)
<
>>>>>> valicac(a)gmail.com
>>>>>>>>> :
>>>>>>>>>
>>>>>>>>>> This is a proposal for the Notifications mail:
>>>>>>>>>>
http://design.xwiki.org/xwiki/bin/view/Proposal/
>>>>>>>>>> NotificationsImprovements9xEmail
>>>>>>>>>>
>>>>>>>>>> I've continued with the 'user' avatar
focused proposal, since
> I've
>>>>>>>>>> currently focused on the email template. If we
drop the user
> avatar
>>>>>>>> (since
>>>>>>>>>> we group multiple users) then we can have the
event/app icon
>>> instead
>>>>>> of
>>>>>>>> the
>>>>>>>>>> avatar.
>>>>>>>>>>
>>>>>>>>>> What I want to have feedback on is the email
layout,
> functionality
>>>>>> (tree
>>>>>>>>>> navigation, details expanding) and styling.
>>>>>>>>>>
>>>>>>>>>> You can play with the Prototype
>>>>>>>>>>
http://jsfiddle.net/risherry/cj25759w/embedded/#Result
>>>>>>>>>>
>>>>>>>>>> If we were to translate to the mail template,
there are still
> some
>>>>>>>> things
>>>>>>>>>> to be tested (like translating the CSS selectors
into inline,
>>> decide
>>>>>>>> what
>>>>>>>>>> email clients we support, etc.)
>>>>>>>>>>
>>>>>>>>>> Let me know,
>>>>>>>>>> Caty
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume
Delhumeau <
>>>>>>>>>> guillaume.delhumeau(a)xwiki.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru
(Valica) <
>>>>>>>> valicac(a)gmail.com
>>>>>>>>>>> :
>>>>>>>>>>>
>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM,
Guillaume Delhumeau <
>>>>>>>>>>>> guillaume.delhumeau(a)xwiki.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent
Massol <vincent(a)massol.net
>> :
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08,
Vincent Massol <vincent(a)massol.net
>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05,
Vincent Massol <
> vincent(a)massol.net>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Another
feedback/questions:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> * Is the avatar icon
clickable and leading to the user
>>> profile?
>>>>>>>>>>>>>>>> * We need a way to link
directly to the diff, at least for
>>> page
>>>>>>>>>>>> events
>>>>>>>>>>>>>> so that the user can see what was
modified (as we have
>>> currently
>>>>>> in
>>>>>>>>>>> the
>>>>>>>>>>>>> AS)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not
precise enough. In your
> example I
>>>>>>>>>> see
>>>>>>>>>>> I
>>>>>>>>>>>>>> created and modified the Roadmap
page but they both say “2
>>> hours
>>>>>>>>>>> ago”.
>>>>>>>>>>>>>> Shouldn’t I be able to see how
far away both events were
> done?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> My understanding is that events
are grouped by app+type but
> not
>>>>>> by
>>>>>>>>>>>> entity
>>>>>>>>>>>>>> anymore (for page events) and
thus you can have 3 events
>>>>>> displayed
>>>>>>>>>>> for
>>>>>>>>>>>>> the
>>>>>>>>>>>>>> same page, f.ex: Creation,
Modification, Deletion.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> And you could also have different
users grouped in the same
>>>>>> composite
>>>>>>>>>>>>> event. So when you display the
details, it would be nice to
> show
>>>>>>>>>> which
>>>>>>>>>>>> user
>>>>>>>>>>>>> made each event, and I see you have
removed this info.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> The focus of this proposal is on user,
compared to the old one,
>>>>>> when
>>>>>>>> it
>>>>>>>>>>> was
>>>>>>>>>>>> on the app/doc.
>>>>>>>>>>>> Close to what we have on Facebool. So it
didn't made sense that
>>> we
>>>>>> say
>>>>>>>>>>> that
>>>>>>>>>>>> a page has been edited by vmassol, and
that the details
> showcase
>>>>>> that
>>>>>>>>>>>> multiple user actually did the edit.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> In Facebook, you have it actually:
>>>>>>>>>>>
https://pasteboard.co/GOioRAT.png
>>>>>>>>>>>
>>>>>>>>>>> On XWiki, we have the following (already
implemented):
>>>>>>>>>>>
https://pasteboard.co/GOiqgYf.png
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> -Vincent
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>> -Vincent
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>> -Vincent
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On 2 Oct 2017, at
18:01, Vincent Massol <
> vincent(a)massol.net
>>>>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at
17:54, Ecaterina Moraru (Valica) <
>>>>>>>>>>>>> valicac(a)gmail.com>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Event Type:
BlogPostPublishedEvent
>>>>>>>>>>>>>>>>>> from
>>>>>>>>>>>>>>>>>>
http://design.xwiki.org/xwiki/bin/view/Proposal/
>>>>>>>>>>>>>>
NotificationsImprovements9x#HEventTypes
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> ok thanks, had missed
this since I was reading from top to
>>>>>>>>>> bottom
>>>>>>>>>>>> and
>>>>>>>>>>>>>> stopped at the overview :)
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> However I don’t think
it scales since it means one unique
>>> icon
>>>>>>>>>>> per
>>>>>>>>>>>>>> combination of app type + event
type.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> What would scale
better is two icons: one for the app type
>>> and
>>>>>>>>>>> one
>>>>>>>>>>>>> for
>>>>>>>>>>>>>> the event type.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> For example imagine
that the Blog app had the following
>>>>>> events:
>>>>>>>>>>>>>>>>> * When a blog post is
published
>>>>>>>>>>>>>>>>> * When a blog post is
created
>>>>>>>>>>>>>>>>> * When a blog post is
removed
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> You wouldn’t be able
to use the RSS icon to represent the
> 3
>>>>>>>>>>> events.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> BTW the RSS icon
isn’t necessarily representative of the
>>> Blog
>>>>>>>>>>> app.
>>>>>>>>>>>> A
>>>>>>>>>>>>>> lot of apps can have a RSS feed.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> That’s the main
remark I have: it’s going to be harder and
>>>>>>>>>> harder
>>>>>>>>>>>> to
>>>>>>>>>>>>>> find unique icons as we had more
events to apps, especially
> if
>>>>>>>>>>> there’s
>>>>>>>>>>>>> only
>>>>>>>>>>>>>> 1 icon that is supposed to
combine both app type + event
> type.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> WDYT?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>>> -Vincent
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>>>>> Caty
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Mon, Oct 2,
2017 at 6:52 PM, Vincent Massol <
>>>>>>>>>>>> vincent(a)massol.net>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Hi Caty,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On 2 Oct
2017, at 17:21, Ecaterina Moraru (Valica) <
>>>>>>>>>>>>>> valicac(a)gmail.com>
>>>>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I've
created some improvements suggestions for our
>>>>>>>>>>> Notifications
>>>>>>>>>>>>>> UI, see
>>>>>>>>>>>>>>>>>>>>
http://design.xwiki.org/xwiki/bin/view/Proposal/
>>>>>>>>>>>>>>>>>>>
NotificationsImprovements9x
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Let me
know what you think.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Re the
overview, I don’t see where you mention the app?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> For example,
could you show how a new Blog post would be
>>>>>>>>>>>> displayed
>>>>>>>>>>>>>> and you
>>>>>>>>>>>>>>>>>>> differentiate
that for example from a Page creation or
>>>>>>>>>>>>> modification?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>>>>> -Vincent
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>>>>>>> Caty
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Guillaume Delhumeau
(guillaume.delhumeau(a)xwiki.com)
>>>>>>>>>>>>> Research & Development Engineer
at XWiki SAS
>>>>>>>>>>>>> Committer on the
XWiki.org project
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Guillaume Delhumeau
(guillaume.delhumeau(a)xwiki.com)
>>>>>>>>>>> Research & Development Engineer at XWiki
SAS
>>>>>>>>>>> Committer on the
XWiki.org project
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
>>>>>>>>> Research & Development Engineer at XWiki SAS
>>>>>>>>> Committer on the
XWiki.org project
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
>>>>>>> Research & Development Engineer at XWiki SAS
>>>>>>> Committer on the
XWiki.org project
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
>>>>> Research & Development Engineer at XWiki SAS
>>>>> Committer on the
XWiki.org project
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
>>>> Research & Development Engineer at XWiki SAS
>>>> Committer on the
XWiki.org project
>>>
>>>
>>
>>
>> --
>> Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
>> Research & Development Engineer at XWiki SAS
>> Committer on the
XWiki.org project
>
>