26 Feb
2011
26 Feb
'11
8:58 a.m.
Hi Sergiu,
On Feb 26, 2011, at 12:00 AM, sdumitriu (SVN) wrote:
Author: sdumitriu
Date: 2011-02-26 00:00:44 +0100 (Sat, 26 Feb 2011)
New Revision: 34960
Added:
platform/core/trunk/xwiki-eventstream/
platform/core/trunk/xwiki-eventstream/pom.xml
platform/core/trunk/xwiki-eventstream/src/
platform/core/trunk/xwiki-eventstream/src/main/
platform/core/trunk/xwiki-eventstream/src/main/java/
platform/core/trunk/xwiki-eventstream/src/main/java/org/
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/Event.java
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventFactory.java
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventGroup.java
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/EventStream.java
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/DefaultEvent.java
platform/core/trunk/xwiki-eventstream/src/main/java/org/xwiki/eventstream/internal/DefaultEventFactory.java
platform/core/trunk/xwiki-eventstream/src/main/resources/
platform/core/trunk/xwiki-eventstream/src/main/resources/META-INF/
platform/core/trunk/xwiki-eventstream/src/main/resources/META-INF/components.txt
platform/core/trunk/xwiki-eventstream/src/test/
platform/core/trunk/xwiki-eventstream/src/test/java/
platform/core/trunk/xwiki-eventstream/src/test/java/org/
platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/
platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/
platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/EventAndFactoryTest.java
platform/core/trunk/xwiki-eventstream/src/test/java/org/xwiki/eventstream/EventGroupTest.java
Modified:
platform/core/trunk/pom.xml
Log:
XWIKI-6047: New EventStream component
That was new to me. Was this discussed (it's possible I missed a mail on the list)?
From the jira it seems this module is meant to be a replacement of the ActivityStream
plugin, right? If so what's the strategy to replace it (timing, backward compat,
etc)?
There seems to be a notion of Event similar to that of the Observation module.
Maybe Event is not the right term here seems the javadoc says "A recorded event that
happened at some point in the wiki". Maybe something like ArchiveEvent, PastEvent,
SavedEvent, etc And maybe these events should extend the Observation Event and add new
fields (date, etc)? Or maybe it's better to not extend but have a field that is the
original Observation Event object? Or maybe not and it's better to have no
relationship to the Observation module to be independent? In any case this should probably
be discussed/explained.
Maybe the Obervation module should be split in one more submodule called
xwiki-observation-store or xwiki-observation-history? It seems to me this could be about
historizing the events sent by the Observation managed.
To be honest, I haven't really thought about it enough (would need to load the code in
my IDE).
I find that this commit happens quite late in the release cycle (3 days before end of
milestone) and would have warranted some earlier discussion.
It's ok, I'm not asking to rollback, just saying that something this important
from an architecture point of view should rather be done earlier and discussed.
Thanks
-Vincent