JIRA XWIKI-283 - patch posted 5 mo ago for {rss} macro works with RSS but not RSS2

I just read that that JIRA entries should be emailed to the list??? This is a trivial fix for a serious problem with {rss}. -- RSS2 is a new version of RSS. The {rss} macro works only with RSS feeds that are not labelled RSS2. (This issue was raised in the forum and I was asked to post this bug by Ludovic 12/2005.) This problem was originally found in 0.9.743 and still exists in the subversion repository as of June 20, 2006 (i.e. 1.0B1). I tried upgrading to the latest version of rome.jar, 0.7, but that didn't help. A Google search showed that many XWiki users are having the same problem I am. When I use {rss... |full=true} I see the following text. The "SyndContent" text is coming from the ROME code (not directly from the RSS source). SyndContentImpl.value=*Be sure to check out my November Newsletter for important tips for Buyers! Click on the Newsletter tab on my Home Page and read about 6 questions a Buyer should ask before making an offer. Read More <http://----.com/ViewBlog/14/&gt;* SyndContentImpl.type=text/plain SyndContentImpl.interface=interface com.sun.syndication.feed.synd.SyndContent Description RSS2 is a new version of RSS. The {rss} macro works only with RSS feeds that are not labelled RSS2. (This issue was raised in the forum and I was asked to post this bug by Ludovic 12/2005.) This problem was originally found in 0.9.743 and still exists in the subversion repository as of June 20, 2006 (i.e. 1.0B1). I tried upgrading to the latest version of rome.jar, 0.7, but that didn't help. A Google search showed that many XWiki users are having the same problem I am. When I use {rss... |full=true} I see the following text. The "SyndContent" text is coming from the ROME code (not directly from the RSS source). SyndContentImpl.value=*Be sure to check out my November Newsletter for important tips for Buyers! Click on the Newsletter tab on my Home Page and read about 6 questions a Buyer should ask before making an offer. Read More <http://----.com/ViewBlog/14/&gt;* SyndContentImpl.type=text/plain SyndContentImpl.interface=interface com.sun.syndication.feed.synd.SyndContent Show » All Comments Work Log Change History Sort Order: [Ascending order - Click to sort in descending order] [ Permlink | « Hide ] Trevor Cox [22/Jun/06 11:00 PM] Here's the fix. It applies to xwiki 0.9.743 through subversion June 20, 2006. and to rome 0.6 through 0.8. 185c184 < .append(NEWLINE).append(entry.getDescription()) --- 218c217 < .append(NEWLINE).append(entry.getDescription()) --- Explanation: The following code appends the result of com.sun.syndication.feed.synd.SyndEntry.getDescription(). That would be fine if getDescription returned a String, but in fact it returns a feed.synd.SyndContent object. buf.append(NEWLINE).append("<div class='rssitemdescription'>") .append(NEWLINE).append(entry.getDescription().getValue()) .append(NEWLINE).append("</div>"); [ Show » ] Trevor Cox [22/Jun/06 11:00 PM] Here's the fix. It applies to xwiki 0.9.743 through subversion June 20, 2006. and to rome 0.6 through 0.8. 185c184 < .append(NEWLINE).append(entry.getDescription()) --- > .append(NEWLINE).append(entry.getDescription().getValue()) 218c217 < .append(NEWLINE).append(entry.getDescription()) --- > .append(NEWLINE).append(entry.getDescription().getValue()) Explanation: The following code appends the result of com.sun.syndication.feed.synd.SyndEntry.getDescription(). That would be fine if getDescription returned a String, but in fact it returns a feed.synd.SyndContent object. buf.append(NEWLINE).append("<div class='rssitemdescription'>") .append(NEWLINE).append(entry.getDescription().getValue()) .append(NEWLINE).append("</div>"); [ Permlink | « Hide ] Trevor Cox [22/Jun/06 11:05 PM] Sorry, forgot to mention the file is: com/xpn/xwiki/render/macro/rss/RSSMacro.java