Re: [xwiki-dev] [Proposal] build-tools module and Checkstyle

Hi, I'd like to propose creating a build-tools/ module in xwiki/trunk. This module will contain tools/files for the build. Right now it'll contain our licenses and our checkstyle config files. In the future it can contain other things like PMD, findbugs configs, plugins that we need for our build, etc. This is the structure recommended by Maven2. It's the one I've used on Cargo. You can check it out here if you want: http://fisheye.codehaus.org/browse/cargo/cargo/trunk/build-tools M2: The idea is to create a build-tools JAR containing all the verification tools configs. This jar is then used by the other build module which need to check for compliance. This is described here: http://tinyurl.com/yjlgnx Once we have this we can start defining one by one the checkstyle rules that we want to apply. I'm proposing that we DON'T turn on build failure on checkstyle for the whole project or it'll never build. What I'm suggesting instead for now (so that everyone can get used to this - say for the coming month or so and then we can review the strategy) is that everyone voluntarily turn on checkstyle verification on whatever new class he writes or on existing code that he cleans up to match the conventions. This that once we get a clean class, anyone causing a violation on that class will result in a build failure. Right now I have excluded all files. I have this ready and working on my local computer. Let me know if it's ok and I'll commit it (right now it's only bound to the Maven2 build anyway). Once I have this committed, the next step is to agree on the checkstyle conventions to use. I'll post another mail on that later on after we've agreed on this one. Thanks -Vincent ___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com -- You receive this message as a subscriber of the xwiki-dev(a)objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws