Re: [xwiki-devs] [Proposal] Customized Less Variables on the color editor

Hi Yacine. Thanks for publishing your idea. I don't understand the need for the "Customized Variables" panel. We can already create new variables in the "lessCode" field without declaring it before in the theme editor. The only benefit I can see is that these variables would be taken into account in the live preview, which is currently not the case. It's a good benefit, but limited to the variables that the skin already uses but without being exposed in the editor. About the ability to add some JavaScript code in the theme, I have mixed feelings. Why do you need this ability in the theme? It should be more useful in the skin actually, don't you think? During the last seminar, we had a discussion about what should be a skin and what should be a theme. Both notions are not clearly separated right now. The conclusion was that we should put our modifications in the skin, and use the themes only when it's simple variation of the user interface (colors, fonts). I am pretty sure that a JavaScript field would not be used for these simple variations, but to add new behaviours, to create a new user experience. In that case, it's more the role of a skin. What do you think about this? Thanks, 2015-07-27 18:55 GMT+02:00 Yacine Kebir <yacine.kebir(a)xwiki.com>om>: -- Guillaume Delhumeau (gdelhumeau(a)xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project