Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

Hi Simon, Ok cool so it seems you have it implemented at both the job level and the listener level. This is what happens in the AntiSpam app when the event is cancelled (ie when it finds some spam in the doc): https://extensions.xwiki.org/xwiki/bin/download/Extension/AntiSpam%20Tool%2… As you can see it’s not really user-friendly. Maybe you don’t get this because you’re running inside a job? But in this case I don’t understand why you need a listener since you check for XClass before you start the move/rename. I must be missing something.

This listener is registered only during rename/move? What happens if I write a script that moves/renames pages with XClass?

I still think we should handle it with a warning to explain this. It’s easy for me, we just need to check for XClass and warn that any copied pages having a link to this XClass will no longer point to it but will keep pointing to the original XClass. Easy to do.

Thanks -Vincent > > Simon >> Thanks >> -Vincent >>> >>> Simon >>> >>> >>> On 9/26/18 10:27 AM, Simon Urli wrote: >>>> Hi everyone, >>>> ok trying to sum-up (I'm only talking about cases with XClass below, to simplify): >>>> - according to Vincent, we should completely prevent simple users to copy/move/rename and only allow advanced users to do it after a warning >>>> - according to Adel & Clément: preventing simple users will be useless as they can easily switch the advanced feature in their account >>>> - according to Marius copying a page/app is not necessarily harmful compared to moving/renaming and we should manage it differently. >>>> I really don't know the practice of users on the field, but it looks to me that preventing simple users to do the action and telling them to ask an advanced user is actually a good trade-off: >>>> 1. it will warn users that they might be doing something wrong >>>> 2. it's not something completely blocking: either they ask for the admin/advanced user, or they know they can switch the advanced features by themselves, at their own risks >>>> Now maybe we can only do the warning for the "copy" action. >>>> WDYT? >>>> Simon >>>> On 9/25/18 11:36 AM, Vincent Massol wrote: >>>>> Hi Marius, >>>>> >>>>>> On 25 Sep 2018, at 11:34, Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com> wrote: >>>>>> >>>>>> On Sun, Sep 23, 2018 at 11:12 AM Vincent Massol <vincent(a)massol.net> wrote: >>>>>> >>>>>>> Hi Simon, >>>>>>> >>>>>>>> On 21 Sep 2018, at 16:58, Simon Urli <simon.urli(a)xwiki.com> wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 9/21/18 4:53 PM, Adel Atallah wrote: >>>>>>>>> +1 for the warning, but I would not forbid simple users from renaming >>>>>>>>> or moving pages but instead just hide the action (from the page menu). >>>>>>>> >>>>>>>> OK I should have written it: by "forbid" I meant: >>>>>>>> >>>>>>>> 1. Hide the action from the menu >>>>>>>> 2. Return an error message if the user try to access the >>>>>>> renaming/moving page (using forged URL) >>>>>>>> >>>>>>>> So you suggest we shouldn't do 2? >>>>>>> >>>>>>> So +1 to prevent/warn the user when doing a move/renaming >>>>>> >>>>>> >>>>>> >>>>>>> AND copy pages containing XClass definitions >>>>>> >>>>>> >>>>>> FTR, copying a single page having an XClass definition is not dangerous (it >>>>>> won't break the application that owns the page), as it only creates a new >>>>>> class definition. Copying an entire application is not dangerous either. >>>>>> The copy won't work like the original application (this justifies a warning >>>>>> as it may fail the user expectations), but the original application will >>>>>> still work. Renaming or moving an application is dangerous as it breaks the >>>>>> application. >>>>> >>>>> Yes you’re correct. Unless the user does a copy + delete ;) >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>>> (the message should list all such pages). >>>>>>> >>>>>>> -1 to hide the action from the menu (if you’re talking about the >>>>>>> “Move/Rename” and “Copy" actions) because: >>>>>>> 1) you get to choose whether you move/rename/copy children after you click >>>>>>> the action >>>>>>> 2) even when the current page has an XClass, the user wouldn't understand >>>>>>> why he cannot see/click on the action. It’s better that he can do it but >>>>>>> get an error message, explaining why and telling him that to contact an >>>>>>> advanced users if he really needs to do it. >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>>> On Fri, Sep 21, 2018 at 4:44 PM Simon Urli <simon.urli(a)xwiki.com> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> users might currently break their AWM application by renaming/moving >>>>>>>>>> pages containing XClass definition. >>>>>>>>>> >>>>>>>>>> We need a proper refactoring operation to be able to properly do such >>>>>>>>>> move/rename. But this feature might take a while to be completely >>>>>>>>>> available. >>>>>>>>>> >>>>>>>>>> In the meantime I propose that we prevent users from renaming/moving >>>>>>>>>> pages containing XClass. >>>>>>>>>> >>>>>>>>>> What I propose is the following: >>>>>>>>>> - Forbid completely *simple users* to rename/move pages containing >>>>>>> XClass >>>>>>>>>> - Display a warning to *advanced users* when they perform such >>>>>>>>>> operation: the same kind of warning we already have when performing >>>>>>> edit >>>>>>>>>> on XWiki pages >>>>>>>>>> >>>>>>>>>> WDYT? >>>>>>>>>> >>>>>>>>>> Simon >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Simon Urli >>>>>>>>>> Software Engineer at XWiki SAS >>>>>>>>>> simon.urli(a)xwiki.com >>>>>>>>>> More about us at http://www.xwiki.com >>>>>>>> >>>>>>>> -- >>>>>>>> Simon Urli >>>>>>>> Software Engineer at XWiki SAS >>>>>>>> simon.urli(a)xwiki.com >>>>>>>> More about us at http://www.xwiki.com >>>>> >>> >>> -- >>> Simon Urli >>> Software Engineer at XWiki SAS >>> simon.urli(a)xwiki.com >>> More about us at http://www.xwiki.com > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.urli(a)xwiki.com > More about us at http://www.xwiki.com