Re: [xwiki-devs] Proposal "Auto Completion in Content Editors" has been refined

Hi James, A few remarks: (1) It's not clear what page suggestions you show initially before the user types any text. Recently modified? (2) It's not clear what happens when the user types after the suggest panel is displayed. Do you filter the visible list or retrieve new suggestions based on the typed text? Search makes more sense. (3) Then if typing = search, the user has to know where each suggested attachment and images is located. Images with the same name could be attached to different pages. Note that the location is displayed for suggested pages. (4) Attachment suggestions should be triggered by Space.Page@ in the context of a link as it happens for images. (5) You generate [[Space.Page]] when the user selects a page. Wouldn't make much sense to generate [[Page Title>>Space.Page]] ? (6) It's not clear what macro suggestions you show initially, before the user types any text. (7) The category icon and the category name are a bit redundant. I prefer only a graphic icon. Also, wouldn't be useful to display a substring of macro description below the macro name? (8) "required" takes too much space, a better way to mark required parameters is needed (9) I'm afraid you can't bypass required parameters or required content when you insert a macro. You can skip the edit macro parameters dialog only if the macro doesn't have required parameters nor required content. (10) If you don't implement the server side as GWT-RPC services (using XWiki components), then you need to propose something else. There are a few options: REST resources, XWiki actions, wiki page, separate servlet. You don't have many details about the server side part. (11) Using !! to trigger image suggestions is problematic. The issue is that XWiki 2.0 syntax is not very auto-complete friendly because [[ is used for both links and images. It's confusing to write !! and then get [[ in the end after you select the image. You need to thing of a better solution. One would be to merge link with image but I'm not sure it's better. Regarding the planning, I noticed that you placed the testing after the implementation. It's best to write tests as early as possible, both unit and functional (Selenium). Hope this helps, Marius On 04/07/2011 10:34 AM, 许凌志(Jamesxu) wrote: