14 May
2012
14 May
'12
5:38 p.m.
On 05/14/2012 11:12 AM, Vincent Massol wrote:
On May 14, 2012, at 4:58 PM, Sergiu Dumitriu wrote:
OK, I see, you meant "standard" as in "standard for other projects as
well", not as in "doing dodgy stuff and undocumented tricks that might
break at any moment".
I agree that we should use maven as much as possible, and I tried to do
that. There are a few things that aren't yet possible, and for which I
had to rely on external tools like sed, xsltproc, grep...
On 05/14/2012 04:27 AM, Vincent Massol wrote:
Maven is a standard.
This script isn't and is only there to add stuff that Maven cannot or will not do.
So all I'm saying is that we must put the maximum of stuff in our Maven setup and the
minimum in this script.
And if Maven improves in the future and adds stuff that are done by our custom script we
should move those outside of the script in our Maven setup.
More precisely here, Maven supports defining release repositories and we should use that.
It's a standard, documented feature.
On May 14, 2012, at 10:26 AM, Vincent Massol wrote:
What do you mean by that? The script calls maven intensively, so it is almost as standard
as maven is.
On May 14, 2012, at 10:07 AM, Marius Dumitru Florea wrote:
> On Mon, May 14, 2012 at 10:29 AM, Vincent Massol<vincent(a)massol.net> wrote:
>> Hi,
>>
>> On May 14, 2012, at 8:56 AM, Vincent Massol wrote:
>>
>>> Hi Caleb,
>>>
>>> On May 13, 2012, at 12:17 PM, Caleb James DeLisle wrote:
>>>
>>>> Hi,
>>>>
>>>> I'd like to change the<repository> in each top level pom to
nexus so that on release, all releases will go directly to staging by default.
>>>> Agent1 already has an account in the staging repository from my last
release so this should just work.
>>>>
>>>> WDYT?
>>>
>>> +1 for using staging but not to change the target repo. We need to be able to
go from staging to target.
>>> The canonical way is to use mvn release:stage.
>>
>
>> There's one reason we might not want to use mvn release:stage though: safety.
It means RM could run mvn release:perform by error instead of mvn release:stage and I
don't think maven will refuse to run mvn release:perform even when there's a
staging repo defined… (strange design BTW).
>
> It shouldn't be a problem if the release script uses release:stage .
>
>>
>> Thus I'm changing to +1 to replace the target repo by the staging one to
reduce likelihood of mistakes.
>
> -0. The commons root POM is inherited by projects that are released
> independently, e.g. from contrib, and I don't think they should be
> forced to go through staging. I'm fine with staging but I think it
> should be put in the release script, not in the POM.
-0 to put that in the release script :)
The reason is that this release script shouldn't even exist and we need to keep it
minimal and use the Maven standard best practices. This script has nothing standard.
Thanks
-Vincent
>
>> Thanks
>> -Vincent
>>
>>> This POM is NOT made to be inherited by projects other than the XWiki Dev
Team projects.
>>>
>>> What we could do is create a pom that can be inherited by contrib projects
but this is really a different issue than the one at hand since even right now it's
not ok for contrib projects.
>>> Thanks
>>> -Vincent
>>>
>>>> Thanks,
>>>> Marius
>>>>
>>>>>
>>>>> Thanks
>>>>> -Vincent
>>>>>
>>>>> PS: Also +1 to upgrade to Release plugin 2.3:
http://jira.xwiki.org/jira/browse/XCOMMONS-168 ;)
--
Sergiu Dumitriu
http://purl.org/net/sergiu/