9 Feb
2011
9 Feb
'11
2:24 p.m.
On 02/09/2011 08:06 AM, Sergiu Dumitriu wrote:
On 02/02/2011 01:51 PM, Caleb James DeLisle wrote:
Done in r34414.
injectCustomMappingsInSessionFactory was not altered because I FORGOT to annotate it
@Deprecated.
injectInSessionFactory and isValidCustomMapping were made private and I realized these can
still be
accessed from groovy without warning. We cannot support private methods as API but still
it will not
be fun when a script stops working because of some internal refactoring. Perhaps we need
to modify
groovy to log warnings when it accesses private methods.
Caleb
According to my records (fool I was I didn't
use @since)
r30719 [misc.] Deprecated XWikiHibernateStore functions which should be internal.
was prior to 2.5M1 which means that they have been deprecated for 2.5, 2.6, and 2.7.
The original mail:
http://lists.xwiki.org/pipermail/devs/2010-August/019620.html
I propose removing:
saveXWikiClassProperty
used nowhere.
deleteXWikiClass
used nowhere.
getBatcherStats
used nowhere.
resetBatcherStats
used nowhere.
and making private:
loadXWikiProperty
used nowhere (outside of XWikiHibernateStore).
saveXWikiClass
used nowhere (outside of XWikiHibernateStore).
loadXWikiClass
used nowhere (outside of XWikiHibernateStore).
loadAttachmentList
used nowhere (outside of XWikiHibernateStore).
saveAttachmentList
used nowhere (outside of XWikiHibernateStore).
saveAttachment
used nowhere (outside of XWikiHibernateStore).
injectCustomMappingsInSessionFactory
used nowhere (outside of XWikiHibernateStore).
injectInSessionFactory
used nowhere (outside of XWikiHibernateStore).
isValidCustomMapping
used nowhere (outside of XWikiHibernateStore).
Others may be made private or removed as dependencies in the platform are retired or
refactored.
I'm not sure about the custom mapping methods, they might be used,
better ask Ludovic about this.
+1 for the rest.