[xwiki-devs] XEM review

Hi Thomas and everyone, I've started reviewing the XEM code in SVN in preparation for the 1.0M1 release for the 17th and I have the following questions/remarks (before putting them in JIRA): 1) Search.WebHome: This looks empty. Should it be removed or will there be something before 1.0M1 is released? 2) The XE XAR overwrites the XEM XAR in the build. I think it should be the other way around. 3) The XEM home page should be different than the XE one. It should mention things specific to XEM. 4) The Quick Links panel should be specific to XEM. 5) I think several XE pages should be removed from the default XEM. For example Photo Album is not something I'd think belongs to the XEM Administrator page by default. It would be belong to a subwiki for sure but not to the Admin one or at least not by default. This raises the question: what is the XEM administrator wiki for? Only for administrating subwikis or is it meant for other things too? 6) UserDirectory.WebHome is empty too 7) Utils space. Is that the right name for this space? From its content it look like some Admin space. 8) UserDirectory space. Wouldn't it be shorter and nicer to name this space: "Users" , and to name "Wikis" the space listing wikis instead of "WikiDirectory"? 9) The WikiDirectory.WebHome page shows the following which doesn't look very nice (especially the "listwikiempty" text): Wikis totalnumberofwiki : 0 createwiki Search listwikiempty 10) XEMAdmin.WebHome is empty 11) In XEMCode there's a XEMSkin document. Is it ready? If not we shouldn't keep pages that are not going to be released in 1.0M1 12) XWiki.SearchResults is not used/ + some other comments. Generally speaking it seems to me the default XEM wiki is not ready yet to be released. Also it would be nice if XEM had a different visual identity than XE. Do we have a skin in progress for it? Will it be ready for 1.0M1? I'm pretty sure I must be missing something (maybe there's a patch that hasn't been applied about XEM's XAR pages?)... :) These are just a few questions to get us started towards the 1.0M1 release of XEM. Thanks -Vincent