Re: [xwiki-devs] XWiki tags specification

Hi, On Mon, Apr 18, 2011 at 09:30, Marius Dumitru Florea < mariusdumitru.florea(a)xwiki.com&gt; wrote: I also think that trailing / leading spaces are useless in tags. They're more often a mistake than an intentional choice. Thus I'm +1 to automatically remove them and say they're not allowed as part of the tags specifications.

Guillaume >> BTW you haven't defined what the separator is. Is the separator the one > defined in the Tag class property? If so it can be anything and there needs > to be a way to enter it IMO. Imagine I choose space as the separator and I > want to enter "word of mouth". I should be allowed to, either by using > quotes or by escaping. > > I see your point. I thought the separator was fixed because the UI says > "Comma separated tags". I just tested and it seems pipe character | is > also used as separator. If I enter "foo|bar,end" the UI displays 2 tags > but the value of the XWiki.TagClass object is "foo|bar|end" (so actually > I entered 3 tags). > > IMO the fact that you can change the separator is an implementation > detail. We now use a Static List to store the list of tags but this can > change. The way we store the tags shouldn't influence the way we define > tags. The separator is *not* part of the tags specification because we > could have an UI that allows you to input tags only one by one and we > could store tags in separate fields. > > So IMO the specification should only say: > > * tags' case is used only for display > * tags don't have leading or trailing spaces > > And in our implementation, *because* we input and store tags using a > single field, we can define a separator and a way to escape that > separator. I prefer comma as separator and backslash as escaping. > >> >>> I just wanted to fix the current way of inputting tags which is not >>> consistent: >>> >>> * regarding leading and trailing spaces: >>> " foo, bar" -> " foo" and "bar" >>> >>> * regarding case: >>> "foo,bar,fOo" -> removing "fOo" removes "foo" also. >> > >> Fixing is a different topic. This is not what you asked. You asked for a > spec. Once we have defined it, then you can restrict yourself to > implementing only part of it if you don't have time/will to implement it > fully. My point is that the spec has to be known and since you started the > spec thread we might as well brainstorm on it, no? > > Sure. Let's see what others have to say about this. > > Thanks, > Marius > >> >> Thanks >> -Vincent >> >>> Thanks, >>> Marius >>> >>>> >>>> Some questions: >>>> * Can the user uses quotes to enter any character, for ex " word ". > Alternatively the space could be escaped with a char, for ex \ >>>> * How can the user use quotes, is there an escape char, for ex: my tag > with a \" >>>> * Same question for entering the tag separator character. For ex if > comma is the separator, can I enter: tag with \, in the name >>>> >>>> Thanks >>>> -Vincent >>>> >>>>>>> * tags' case is saved but case is ignored when comparing two tags > (once >>>>>>> you defined a tag "news" you can't define a new tag "News"; the > existing >>>>>>> tag is reused; tag's case is used only for display) >>>>>> >>>>> >>>>>> If we don't consider case I'm not sure we should use display using > the first tag entered. For example someone entered "http". Someone else > wants to add HTTP. Should we display http or HTTP? >>>>>> I'm fine with displaying http provided the UI allows to renamed the > tag case. >>>>> >>>>> If you click on the tag you go to Main.Tags page where you have an >>>>> option to rename the tag (that is specified in the query string). >>>>> >>>>> Thanks, >>>>> Marius >>>>> >>>>>> >>>>>> Otherwise ok for me. >>>>>> >>>>>>> Optionally, we could enforce that tags can't contain white spaces. >>>>>> >>>>>> See above. >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> If no one is against it then I'd like to change the UI to apply > these >>>>>>> constraints. >>>>>>> >>>>>>> Thanks, >>>>>>> Marius