6 Aug
2015
6 Aug
'15
4:32 p.m.
On 6 Aug 2015 at 16:22:56, Eduard Moraru
(enygma2002@gmail.com(mailto:enygma2002@gmail.com)) wrote:
On Thu, Aug 6, 2015 at 4:01 PM, vincent(a)massol.net
wrote:
yes I know, I mentioned this in my mais before you started replying. See below.
On 6 Aug 2015 at 14:57:37, Eduard Moraru (enygma2002(a)gmail.com(mailto:
enygma2002(a)gmail.com)) wrote:
Please note that create.vm and createinline.vm are not brought by the
flamingo skin, but are actually part of the shared platform-web templates. Hi,
While I understand the logic, this proposal sounds like we want to move
towards skin-level tests (and supporting multiple skins), i.e. with the
addition of a new XWiki skin, we will need a complete set of new UI tests
for the new skin, since all our existing UI tests will be associated with
the previous skin.
AFAIK, we agreed (mainly due to low man-power) to only support 1 XWiki
skin
and, as skins come and go, we only update the
tests, not replace them.
Take
the colibri to flamingo transition for example:
we just updated some
tests
instead of rewriting a complete new set of tests
+ pageObjects.
IMO, if we are looking for a replacement of xwiki-enterprise-test-ui, we
could try what Marius suggested and use an xwiki-platform-web-test module
so that we move the tests to platform and still don`t tie them to a
particular skin (such as flamingo).
Basically what you’d like is to have the -web module depend on the -skin
module. However it’s the other way around.
So it wouldn’t be normal to test in web something that is brought by a
skin.
Also, the flamingo skin does not override so many
templates (compared to
platform-web) and around a third of its files are about LESS (so ultimately
styling/CSS). I feel we would also be giving it too much importance by
moving all our UI tests (and PageObjects) under the flamingo skin and tying
all our UI tests to this particular skin's modules.
Right now we have a problem in that Flaming overrides a *lot* of VMs. AFAIK this was
supposed to be temporary and was done to continue having colibri work while we were
working on Flamingo. Now that Flamingo is the default and Colibri is being retired (we
need to decide when exactly BTW, will depend how much work there’s to not make it fail
with Nested Spaces I guess), we could move back the vms currently in flamingo into -web
and make them the default so that the next skin is based on them.
So to summarize what I wrote in my initial mail: functional tests should go in the module
having the code they’re testing. So since create.vm is in -web ATM and not overridden by
the flamingo skin, CreatePageAndSpaceTest should go there. I didn’t do it initially
because I wanted to have all “skin” level functional tests in one place for now and I was
focused on the hard part of the work which was moving the tests out of enterprise.
I’ll move CreatePageAndSpaceTest during 7.2M3 if nobody beats me to it.
Thanks
-Vincent
Thanks,
Eduard
> Thanks
> -Vincent
>
> > Thanks,
> > Eduard
> >
> > On Mon, Aug 3, 2015 at 5:14 PM, vincent(a)massol.net
> > wrote:
> >
> > > Note that we could also move the base PageObjects currently located in
> > > xwiki-platform-test into xwiki-platform-flamingo-skin-test-pageobjects…
> > >
> > > -Vincent
> > >
> > >
> > > On 3 Aug 2015 at 14:55:22, vincent(a)massol.net (vincent(a)massol.net
> (mailto:
> > > vincent(a)massol.net)) wrote:
> > >
> > > >
> > > >
> > > > On 3 Aug 2015 at 14:53:50, Marius Dumitru Florea (
> > > mariusdumitru.florea@xwiki.com(mailto:mariusdumitru.florea@xwiki.com))
> > > wrote:
> > > >
> > > > > +1. I guess we'll have to add a xwiki-platofrm-web-test
module at
> some
> > > > > point for testing the Velocity templates that are shared
between
> > > > > skins.
> > > >
> > > > yes, I didn’t mention this but I agree. For now since we have only 1
> > > skin (or will soon since we’re removing colibri) it seems simpler to
> have
> > > the tests in Flamingo.
> > > >
> > > > Thanks
> > > > -Vincent
> > > >
> > > > > Thanks,
> > > > > Marius
> > > > >
> > > > > On Mon, Aug 3, 2015 at 3:41 PM, vincent(a)massol.net wrote:
> > > > > > Hi devs,
> > > > > >
> > > > > > I’ve brainstormed with Thomas and we’ve discussed where to
put
> > > functional tests such as test that verify that page creation from the
> UI
> > > works (i.e. that test the create vm and the oldcore java action in this
> > > case).
> > > > > >
> > > > > > We’re proposing to put those tests (which are currently
located
> in
> > > enterprise tests) under xwiki-platform-flamingo-skin, i.e. to
> assimilate
> > > those tests as functional skin tests.
> > > > > >
> > > > > > In order to do this I’ll create:
> > > > > >
> > > > > > xwiki-platform-flamingo
> > > > > > |_ xwiki-platform-flamingo-skin
> > > > > > |_ xwiki-platform-flamingo-skin-resources (—> zip)
> > > > > > |_ xwiki-platform-flamingo-skin-test (functional tests)
> > > > > > |_ xwiki-platform-flamingo-theme
> > > > > > |_ xwiki-platform-flamingo-theme-bootswatch (XAR)
> > > > > > |_ xwiki-platform-flamingo-theme-ui (XAR)
> > > > > > |_ xwiki-platform-flamingo-theme-test (functional tests
for
> Theme UI)
> > > > > >
> > > > > > WDYT?
> > > > > >
> > > > > > I’m going to start moving and splitting the current
> CreatePageTest
> > > into 2:
> > > > > > * the tests that use Template Provider will go in
> > > platform-administration-tests
> > > > > > * the tests that verify simple page/space creation will go
in
> > > xwiki-platform-flamingo-skin-test
> > > > > >
> > > > > > Thanks
> > > > > > -Vincent