On Feb 19, 2009, at 5:45 PM, Anca Paula Luca wrote:
Vincent Massol wrote:
On Feb 18, 2009, at 8:03 PM, Anca Paula Luca
wrote:
Dan Miron wrote:
Hi,
Regarding the
http://jira.xwiki.org/jira/browse/XWIKI-2964 issue,
this
is how I see it:
- Grabbing the icons from the silk iconset
- Creating a macro called 'icon' with the following parameters:
- fileName (required) the name of the file which holds
the
icon; here I see two possible approaches:
- with (optional)
- height (optional)
An example of usage would be the following:
{{icon fileName="arrow_out.gif" with="20" height="20" /}}
WDYT?
Would it be any difference between this macro and the image markup
([[image:reference]] or image:reference), besides the way the image
file
resolution (image: looks it up as an attachment whereas the {{icon}}
macro would
getit from the silk icon set) ?
This is possible but we would need a different uri. So yes we could
introduce:
icon:arrow_out
I was referring to
image: arrow_out.gif, or just image: arrow_out (although this second
one would
be even more complicated).
But you can't do that... :)
How would the rendering know that this is not an attachment?
See XWikiImageParserDefaultAttachmentParser in the code.
Thanks
-Vincent
Of course is not core, but I don't see why two,
and, as a user, I
think I'd find
it hard to grasp when {{icon}} and when image: and why not only one
of them.
This shouldn't be a stopper anyway, it's not that that important...
Happy coding,
Anca Luca
>
> But I don't like it too much because it means changing the rendering
> engine code for something that is not core IMO.
>
> Thanks
> -Vincent
>
>> Any way we could make these icons accessible as image: references
>> instead of
>> building a whole new macro for it, for syntax simplicity?
>>
>> Happy coding,
>> Anca Luca