25 Apr
2018
25 Apr
'18
12:08 p.m.
To give my opinion, I’m hesitating about 2 approaches:
Approach 1: “standard"
==================
* We should have “Default Color Theme” be a copy from the Iceberg color theme page. I
think I’d prefer the copy to be done at runtime; for example if the currently defined
color theme page doesn’t exist when going to the L&F > Themes admin page, create it
by copying Iceberg. This provides a self healing feature if the color theme page has been
removed/doesn’t exist/etc.
* Predefined color theme pages should be considered “standard” and a warning message
displayed if a user wants to edit them. BTW would be nice to have a feature to have a
customized message per “type”. For example for color theme pages we would display a
message saying that the user should copy the page to customize it instead of editing it.
* The Color Theme UI should also be improved a bit to have a “Customize” button on color
theme pages that would perform a copy to let the user customize a theme.
Approach 2: “demo"
================
* Consider all color themes to be demo content and once the user starts modifying them
don’t merge them anymore
* When we want to provide modified color themes, introduce new theme pages
* Don’t provide a “Default Color Theme” page. Directly set “Iceberg” to be the default
CT.
Analysis
=======
Approach 2 is more wiki style and simpler for sure. Users can use the diff feature and the
rollback feature if they want to go back to the original versions.
I think I’m leaning more towards 2 ATM.
Thanks
-Vincent
On 25 Apr 2018, at 11:35, Vincent Massol
<vincent(a)massol.net> wrote:
Is this a VOTE or a proposal or a brainstorming? I’m asking since nobody has voted yet,
not even Thomas (except if we consider that “prefer” means +1 and “OK” means +0 ;)).
From the answer it seems we might need a new VOTE since several new points have been
added to the discussion. I’m not able to VOTE right now.
Thanks
-Vincent
On 23 Apr 2018, at 12:29, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi xwikiers,
Following new XAR entry type mail here is a question about color
themes we provide in standard XWiki (Cerulean, Charcoal, etc.).
1) Standard stuff, if you want a custom color theme create a new one
(would be nice to be able to copy a standard one and propose it when
you try to edit a standard one).
2) Demo content, edit and delete it all you want and upgrade won't
touch a customized theme to avoid surprises (background color changed
a bit in the standard version which now collide with your logo)
3) Same as 2 but delete is bad (same as home page)
WDYT ?
I'm think I prefer 1) but I'm OK with 3) if other think it's more
example than standard material. Let's say -0 for 2).
Thanks,
--
Thomas Mortagne