10 May
2011
10 May
'11
5:42 p.m.
On 05/10/2011 05:03 PM, Vincent Massol wrote:
Hi,
I'd like to commit @Inject injection of Loggers at the same time as I do the switch
to SLF4J/Logback (I have it mostly done on my machine).
The idea is to move from:
public MyComponent implements LogEnabled, MyComponentRole
{
...
}
to:
public MyComponent implements MyComponentRole
{
@Inject
private Logger logger;
...
}
Rationale:
* More consistent with how we inject dependencies
* Makes it easier to move to another DI framework later on (CDI, Guice, etc) since the
way to implement this with them is to use the JSR299 @Producer annotation on a class that
produces Loggers.
* Allows to keep the current logging behavior unchanged for backward compatibility (we
juste deprecate it).
WDYT?
+1 if it works. I didn't like LogEnabled from the start.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/