Re: [xwiki-devs] [VOTE] Adding notions of Locale and Version in EntityReference

Hi Devs, The implementation of the immutable version of reference is almost ready now. It introduce the parameters on reference as suggested, but we now have a discussion on how the constructors of "typed" entity reference should be. My initial dev was to provide constructor like: But Vincent have different vision of this, here its comment extracted from GitHub ( https://github.com/xwiki/xwiki-platform/commit/cea424914f40ce924afbc49b3159…) : My proposal was: I am myself not really happy with that since I dislike the idea that parameter are generic on "typed" references. Do not like either the idea to provide keys for creating a Map or Pairs, since the implementation details that use Map should not be so exposed IMO. There should not be so much parameter on a single "typed" reference, and these should be easy to provide. Creating Maps in java is not fun in syntax for that IMO, and is far too open. I had propose using overloaded constructor like public DocumentReference(String wikiName, List<String> spaceNames, String pageName, Locale locale) or if something more flexible should be used public DocumentReference(String wikiName, List<String> spaceNames, String pageName, Object... parameters) where parameters is later interpreted based on object type and limited to those used for a given typed reference. Here Vincent comments on this: Maybe some of you have an even better idea ? Denis