1 Jun
2009
1 Jun
'09
12:29 p.m.
Hi!
Thank you very much for your code review.
public interface IConstants {
Why do you need an interface for this?
This looks like a .net interface naming convention, but I did not see it
in the java world. The XWiki convention is documented here:
-
http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle#HClass2FInterfacena…
I thought this kind of interface might be useful, because I will have a lot
of constants ( the URL of every dialog box etc). Another reason for using
this kind of interface is the localization. If you don't like it, I can
remove it.
Settings.java
I this a generic settings class or will it store just
authentication
settings?
I would like to store here all the settings, established by the user.I can
make it more generic, using a dictionary structure which will have the keys
the name of the properties and the value = the value itself.
XwikiAddIn.java
Can you explain a bit what is the role of this class?
I hope this
doesn't become a massive singleton that will be used everywhere across
the sources.
Yes, it is a singleton which stores the XMLRPC client and XWikiStructure. I
promise that it won't become massive, but I think this two objects will be
used in many classes and I would like to avoid sending them as parameters.
I will add the proper documentation and change some class names.
I've wrote also a post about what I've done to be more clear :
http://gsoc.myxwiki.org/xwiki/bin/view/XWiki+Integration+With+Open+Office/C…
Now I work on the navigation panel. I have a problem .. it is not clear for
me how can I integrate the panel in the OpenOffice environment in order to
look as a component of it (like the custom control from the XWord). Is
anybody who knows? (I will ask today alsa the OOo API deveopers).
Let me know if there are any other changes that I should do at the written
classes.
Best regards,
Cristina