On Jun 18, 2013, at 9:03 AM, Vincent Massol <vincent(a)massol.net> wrote:
Hi Ludovic,
On Jun 18, 2013, at 8:24 AM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
Hi,
I have ported the ratings plugin to a component architecture and also to
4.5.x.
Could some devs review the pom and apis before I make a release of it ?
I've reviewed the pom and fixed the issues I could see:
https://github.com/xwiki-contrib/application-ratings/commit/b92244985049fdd…
One note: you have 1.3-SNAPSHOT so it means it's the continuation of some previous
versions… Where are they released?
I've checked on e.x.o and I see:
* org.xwiki.contrib:xwiki-ratings-application (this is a different id from the new
org.xwiki.contrib.ratings:application-ratings-ui.
Thus I've just added an alias:
https://github.com/xwiki-contrib/application-ratings/commit/e3217574da230f7…
Thanks
-Vincent
Thanks
-Vincent
PS: I haven't review the API part
I mostly interested if the pom are correct for
releasing.
On the code itself, I don't think we can change the storage classes unless
we are ready to loose compatibility with the previous plugin. But we could
change the script service API if there are better choices.
https://github.com/xwiki-contrib/application-ratings
Thanks
Ludovic