11 Oct
2012
11 Oct
'12
midnight
On 10/10/2012 12:03 PM, Jerome Velociter wrote:
On 10/10/2012 04:30 PM, Vincent Massol wrote:
Totally agree.
One other thing that bugs me is that a component that implements two
roles will have two instances, and this makes it harder to have a class
that implements both ScriptService and a specific role for that component.
Hi Ludovic,
On Oct 10, 2012, at 3:39 PM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
Wouln't it be good to start distinguish between API and SPI, and have a
different set of CLIRR rules for each type ?
For instance, I don't see a big benefit in not allowing new methods in
such script services interfaces. In my opinion those are not designed or
intended to be extended or implemented by third parties anyway.
So IMO going through a VOTE everytime one adds a new method to a script
service is too constraining for little value.
My 2 cents
Jerome Why would script services be internal ? They
should have a stable API
shouldn't they ?
Yes, I agree, each Script Service should define an interface
and
implement it in addition to implementing ScriptService.
We've been lazy and we should fix this as otherwise CLIRR won't let us
know when we break scripting APIs. >
>> Ludovic
>>
>> 2012/10/10 Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com>
>>
>>> On Wed, Oct 10, 2012 at 3:28 PM, Ludovic Dubost <ludovic(a)xwiki.com>
>>> wrote:
>>>> Hi,
>>>>
>>>> I found an issue with the maven project to generate the javadocs for
>>>> SRD. Apparently all the internal packages are ignored.
> This is normal and good. We don't want to show these to the user.
>
> Thanks
> -Vincent
>
>>>> This is no necessarly a problem unless we want them in the javadocs.
>>>> Now there is a problem as some APIs are in internal, which does not
>>>> seem normal.
>>>>
>>>> This is the case of:
>>>>
>>>> org.xwiki.officeimporter.internal.script.OfficeImporterScriptService
>>>>
>>>
org.xwiki.officeimporter.internal.openoffice.script.OpenOfficeManagerScriptService
>>>
>>>> org.xwiki.office.viewer.internal.DefaultOfficeViewerScriptService
>>> Most of our script services are internal. For the office module I need
>>> to create a single script service (hint=office) with 3 methods
>>> getImporter(), getManager() and getViewer().
>>>
>>> Thanks,
>>> Marius
>>>
>>>> Until we find a solution i've reverted to the javadocs manually
>>>> generated (without the maven project).
>>>>
>>>> Ludovic
--
Sergiu Dumitriu
http://purl.org/net/sergiu/