Hi Thomas,
On May 2, 2012, at 6:48 PM, GitHub wrote:
Branch: refs/heads/master
Home:
https://github.com/xwiki/xwiki-commons
Commit: 6ecb131081233764ed773eb84f9be34e23edb888
https://github.com/xwiki/xwiki-commons/commit/6ecb131081233764ed773eb84f9be…
Author: tmortagne <thomas.mortagne(a)gmail.com>
Date: 2012-05-02 (Wed, 02 May 2012)
Changed paths:
M xwiki-commons-core/pom.xml
M xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/AbstractJob.java
M xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/Job.java
M xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/JobManager.java
M
xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/event/status/JobStatus.java
M
xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/internal/DefaultJobManager.java
M
xwiki-commons-core/xwiki-commons-job/src/main/java/org/xwiki/job/internal/DefaultJobStatus.java
Log Message:
-----------
XCOMMONS-162: Add start and end data to job status
XCOMMONS-163: Add join method to Job
diff --git a/xwiki-commons-core/pom.xml b/xwiki-commons-core/pom.xml
index 799f042..2251f94 100644
--- a/xwiki-commons-core/pom.xml
+++ b/xwiki-commons-core/pom.xml
@@ -115,6 +115,8 @@
<exclude>**/internal/**</exclude>
<exclude>**/test/**</exclude>
<!-- Remove the following excludes after we release the current version as
final -->
+ <exclude>org/xwiki/job/Job</exclude> <!-- New methods -->
+ <exclude>org/xwiki/job/event/status/JobStatus</exclude> <!--
New methods -->
This goes against the deprecation/legacy strategy we have voted since we said we will not
add *any* breakage. It's not allowed anymore to have any exceptions in CLIRR.
(See
http://markmail.org/message/tino4ngttflc5i3s).
So you need to go through a deprecation strategy and move this to legacy.
Alternatively you should make a new proposal to amend our backward-compatibility strategy
for "young" apis. I'll start the thread for you but in the meantime all
Release Manager need to be very careful to not perform new releases when there are CLIRR
excludes since it means we have broken backward compatibility.
Thanks
-Vincent