10 Oct
2012
10 Oct
'12
4:30 p.m.
Hi Ludovic,
On Oct 10, 2012, at 3:39 PM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
Why would script services be internal ? They should
have a stable API
shouldn't they ?
Yes, I agree, each Script Service should define an interface and implement it in addition
to implementing ScriptService.
We've been lazy and we should fix this as otherwise CLIRR won't let us know when
we break scripting APIs.
Ludovic
2012/10/10 Marius Dumitru Florea <mariusdumitru.florea(a)xwiki.com>
> On Wed, Oct 10, 2012 at 3:28 PM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
>> Hi,
>>
>> I found an issue with the maven project to generate the javadocs for
>> SRD. Apparently all the internal packages are ignored.
This is normal and good. We don't want to show these to the user.
Thanks
-Vincent
>> This is no necessarly a problem unless we want
them in the javadocs.
>> Now there is a problem as some APIs are in internal, which does not
>> seem normal.
>>
>> This is the case of:
>>
>> org.xwiki.officeimporter.internal.script.OfficeImporterScriptService
>>
> org.xwiki.officeimporter.internal.openoffice.script.OpenOfficeManagerScriptService
>> org.xwiki.office.viewer.internal.DefaultOfficeViewerScriptService
>
> Most of our script services are internal. For the office module I need
> to create a single script service (hint=office) with 3 methods
> getImporter(), getManager() and getViewer().
>
> Thanks,
> Marius
>
>>
>> Until we find a solution i've reverted to the javadocs manually
>> generated (without the maven project).
>>
>> Ludovic